From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E29C433F5 for ; Fri, 4 Mar 2022 18:33:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF24F8D0003; Fri, 4 Mar 2022 13:33:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA2668D0001; Fri, 4 Mar 2022 13:33:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D91B08D0003; Fri, 4 Mar 2022 13:33:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id CBA388D0001 for ; Fri, 4 Mar 2022 13:33:12 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9CE0762B06 for ; Fri, 4 Mar 2022 18:33:12 +0000 (UTC) X-FDA: 79207551024.15.EC348FA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf28.hostedemail.com (Postfix) with ESMTP id E05FDC001D for ; Fri, 4 Mar 2022 18:33:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AAD6B21136; Fri, 4 Mar 2022 18:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646418790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gJnCxkBq7SDkx56n/I8CCu4Rod5CPYjuSp+zNXS2bSA=; b=t3fzROUoQfIORgMlNQfrmE24E4i5w4V9gbKbCg0gPcmdp3VuViPQc4JNMG+bVKLDiTBB7n 9XoCWe+WZcoAhWSfiaLr9mUJNiDILJMTiuGI70n3vGmP8/9WRQgc22s2eiaby99v+9Q8pB lNEKjwVp7zaK8Ni8JfC7mm4qrnuEPMk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646418790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gJnCxkBq7SDkx56n/I8CCu4Rod5CPYjuSp+zNXS2bSA=; b=xarTsfu/8RTPI5FgQc2k8FfN4wFIS5J8JYlLKVqYVeXyhHwx2vz5Zdu77qvw2XIv1lLYZU Fvbpw/mxnngYHoDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7C7C313B70; Fri, 4 Mar 2022 18:33:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RPkmHWZbImLdBAAAMHmgww (envelope-from ); Fri, 04 Mar 2022 18:33:10 +0000 Message-ID: Date: Fri, 4 Mar 2022 19:33:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 4/5] mm/slub: limit number of node partial slabs only in cache creation Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Marco Elver , Matthew WilCox , Roman Gushchin , linux-kernel@vger.kernel.org References: <20220304063427.372145-1-42.hyeyoo@gmail.com> <20220304063427.372145-5-42.hyeyoo@gmail.com> From: Vlastimil Babka In-Reply-To: <20220304063427.372145-5-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: cwgq6su78paiz3gidjkxycd385nrxph8 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t3fzROUo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="xarTsfu/"; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Queue-Id: E05FDC001D X-HE-Tag: 1646418791-736220 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/4/22 07:34, Hyeonggon Yoo wrote: > SLUB sets number of minimum partial slabs for node (min_partial) > using set_min_partial(). SLUB holds at least min_partial slabs even if > they're empty to avoid excessive use of page allocator. > > set_min_partial() limits value of min_partial limits value of > min_partial MIN_PARTIAL and MAX_PARTIAL. As set_min_partial() can be > called by min_partial_store() too, Only limit value of min_partial > in kmem_cache_open() so that it can be changed to value that a user wants. > > [ rientjes@google.com: Fold set_min_partial() into its callers ] > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 6f0ebadd8f30..f9ae983a3dc6 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3981,15 +3981,6 @@ static int init_kmem_cache_nodes(struct kmem_cache *s) > return 1; > } > > -static void set_min_partial(struct kmem_cache *s, unsigned long min) > -{ > - if (min < MIN_PARTIAL) > - min = MIN_PARTIAL; > - else if (min > MAX_PARTIAL) > - min = MAX_PARTIAL; > - s->min_partial = min; > -} > - > static void set_cpu_partial(struct kmem_cache *s) > { > #ifdef CONFIG_SLUB_CPU_PARTIAL > @@ -4196,7 +4187,8 @@ static int kmem_cache_open(struct kmem_cache *s, slab_flags_t flags) > * The larger the object size is, the more slabs we want on the partial > * list to avoid pounding the page allocator excessively. > */ > - set_min_partial(s, ilog2(s->size) / 2); > + s->min_partial = min_t(unsigned long, MAX_PARTIAL, ilog2(s->size) / 2); > + s->min_partial = max_t(unsigned long, MIN_PARTIAL, s->min_partial); > > set_cpu_partial(s); > > @@ -5361,7 +5353,7 @@ static ssize_t min_partial_store(struct kmem_cache *s, const char *buf, > if (err) > return err; > > - set_min_partial(s, min); > + s->min_partial = min; > return length; > } > SLAB_ATTR(min_partial);