From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 365B9D68BE5 for ; Sat, 16 Nov 2024 10:27:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3CAB6B00A9; Sat, 16 Nov 2024 05:27:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C59A6B00AC; Sat, 16 Nov 2024 05:27:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 817526B00CA; Sat, 16 Nov 2024 05:27:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 60E2D6B00A9 for ; Sat, 16 Nov 2024 05:27:00 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E47731C793B for ; Sat, 16 Nov 2024 10:26:59 +0000 (UTC) X-FDA: 82791578688.21.68323D0 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf26.hostedemail.com (Postfix) with ESMTP id 8009E140016 for ; Sat, 16 Nov 2024 10:26:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf26.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731752728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bvRxnmu+yCK710/wiQawhwot1julMAdZRZ7PalkopIA=; b=u9rwZGvxBAU9Kgv7A2h05GnPcmqRFXLlAJmTA1M+txSWbcphwfHW8aBOWYByHZQ5yfYBjn HSQldWniMNa6EgoWJ2K5WAzKnBB3KI/VxkPWi4mXNu38+YVPuCSAPBIL7Toawnsnlmmb3N lUJHq7om6Agi7Ax1FDXqmEXgQRh9pj4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf26.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731752728; a=rsa-sha256; cv=none; b=F6a3yYHJWa9NRMjtBNJ8wOsEpX108VJlpbFiLA3BfjAQIT4k5xuwM6swdr2MA48i7BEDGa Zfr9HvVxA/4shqNoQhZ9h1pg2VxXt+0u2AyRtzgc96BAXCN6IwHJHRrp6fUX3xrwTBKES4 BUndO2bgXCwmVVw1oUCJnPujux8/2q4= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Xr96m167Wz9sSL; Sat, 16 Nov 2024 11:26:56 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IieXZuAi8N-1; Sat, 16 Nov 2024 11:26:56 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Xr96l3Rvbz9sSN; Sat, 16 Nov 2024 11:26:55 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 51FF68B7A7; Sat, 16 Nov 2024 11:26:55 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id BlevLl1v9xVh; Sat, 16 Nov 2024 11:26:55 +0100 (CET) Received: from [192.168.232.159] (POS169858.IDSI0.si.c-s.fr [192.168.232.159]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B911A8B763; Sat, 16 Nov 2024 11:26:51 +0100 (CET) Message-ID: Date: Sat, 16 Nov 2024 11:26:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/21] arm: pxa: Convert timeouts to use secs_to_jiffies() To: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-3-911fb7595e79@linux.microsoft.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20241115-converge-secs-to-jiffies-v2-3-911fb7595e79@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8009E140016 X-Stat-Signature: rpcfbepruwyqcohwkc4xbh8ngtue6zok X-HE-Tag: 1731752782-459415 X-HE-Meta: U2FsdGVkX1/8OvI1HC77lwgDJaJusPgBn+vVI2Y9eJWFDlx5qSypeUWGYxQbu/0tL2o9M0+i1BBH0uhcMzBfDy8hAt4KvjsKS4HTenulSKSgf+nM2MUSSnG74lnf2npcgQuAtZE8KApwrdhVJ1azhxw2kr3LSDslq+SYmYYK7Jr0xDxWFj04IS735afhphNpaksE4+1wnNqeq+KHl9hHFyP3Hrety7asr5DCmai5yoM1EjhbS83NAqzvv6d/eVgzIvbNfY5L/Kvz81kMe68iigsFNGl6mV2L056nnOu+YDrwuT1wVZupuSAWRI18OmS+FhHWFQeZ0UK0XKx21qgv9+8lX9C+/Zji6m3RMYSl6bw4/2nfo07XmNslut8kJgcMRAWSD6QJDAoNUV7kEpbBBC81V8qCcnGQ1KZTLbtxr0Uk1KBwABIJbX7QtCo8896A0HeQubiJO9h27Oeu+XY26vqHMykyPOora82VR9wmCfz+9AOCb9KnxSzGMgUducO7maF/NUzF6khtHt2R7QdfVeaOe9F8U6RdyOgnhDMmnFeJYnrAND2fErEHyZMAOY30Md5taLNEGjLmangTFlF+xxuLgK3adjEvn4VTrUZjUQbl+wL6VnnqN8OtNpxNIJVyo5NfUttHb97E7Sjqv1BmfK3n51JF7mR4jt69vmhErcAykYuHlcUzU2xieeKxVkeEPybd73kXxDuOx34CnwBiJOFLAkM+IJCS4Wm/oQkTQIp7Zh4hOsnZrarm+03YHK75jcpkkV3cyU3PXMrwzktrOLoaNlOqw6Azd9oTU1FMY+i6M5RSDVnTRo9nof0HULedCLbdWjTZXSi25iBFQeew0j40ljwK6f1QD/DFbw8qGHJESGfWf0bewm6cdfxvYKCcM5QbomXaM/AGC1fafs0c/Yh/GM/a/UVHel26UZ2Ie2zy4TL6C3wKXPs+HDbVLlqoh7N7JGNQ7Vf8DVsBnBR AY0jLmi1 iZF/ttw8vX/R3r9ECBYuy4UBXwQLBehD5wganzCOC9e+H2ZooG9xIAOcCb8OKARWU588oo8legq41alSpn+SX9P+Y9UiWGXIpwERGyz0srnjz66ng0J/7qlJ/L1WiBADIkOvi6NPkKws4eZvRhw+xNDfCdya62Cx5G4bmLNxykEx0vLSpwf4Hg9aPXcC9vAiax5ezOOPGANZ7mCdqfm41z/WUkCURBlhV0t0x6lApqOqZYJphwk7G5YYGORY9m31o1uAZuyIrNz3OD6ZDXH6M99pZrjTT1cKSIzVtnIPP32zVI3E65hp+19Yhzarv811poiHFSeUSxmCDdyzFnwb4Zc0ie2vAVCPkv3Gk5ZUuwqkG3J1L9z7kekjWmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan > --- > arch/arm/mach-pxa/sharpsl_pm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-pxa/sharpsl_pm.c b/arch/arm/mach-pxa/sharpsl_pm.c > index 72fa2e3fd35318e5a63c121ed7990a56a56b134c..bbbd06bc79bbb94fb258562e5a382acaf3c277b3 100644 > --- a/arch/arm/mach-pxa/sharpsl_pm.c > +++ b/arch/arm/mach-pxa/sharpsl_pm.c > @@ -31,9 +31,9 @@ > /* > * Constants > */ > -#define SHARPSL_CHARGE_ON_TIME_INTERVAL (msecs_to_jiffies(1*60*1000)) /* 1 min */ > -#define SHARPSL_CHARGE_FINISH_TIME (msecs_to_jiffies(10*60*1000)) /* 10 min */ > -#define SHARPSL_BATCHK_TIME (msecs_to_jiffies(15*1000)) /* 15 sec */ > +#define SHARPSL_CHARGE_ON_TIME_INTERVAL (secs_to_jiffies(60)) /* 1 min */ > +#define SHARPSL_CHARGE_FINISH_TIME (secs_to_jiffies(10*60)) /* 10 min */ > +#define SHARPSL_BATCHK_TIME (secs_to_jiffies(15)) /* 15 sec */ This comment is completely useless now. The other ones are probably also kind of useless, everybody knows 1 min = 60 sec. See https://docs.kernel.org/process/coding-style.html#commenting > #define SHARPSL_BATCHK_TIME_SUSPEND (60*10) /* 10 min */ > > #define SHARPSL_WAIT_CO_TIME 15 /* 15 sec */ > > -- > 2.34.1 >