From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D209CC7EE26 for ; Tue, 23 May 2023 08:00:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 530A86B0074; Tue, 23 May 2023 04:00:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E1C1900003; Tue, 23 May 2023 04:00:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A8C9900002; Tue, 23 May 2023 04:00:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2B4BB6B0074 for ; Tue, 23 May 2023 04:00:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BE4C1A06C1 for ; Tue, 23 May 2023 08:00:01 +0000 (UTC) X-FDA: 80820771402.13.05EE4E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id E830A10000A for ; Tue, 23 May 2023 07:59:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uc24tH+V; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684828799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c/I/wqsAUZDwVaD1e7Awdsb6/q2Rvw3zvRXvMlz6NW0=; b=x5vraNnvdaSzSIosLmt7Dscw6hhL0Z+LpPu0SUaGroWkRiCQL41oRkb/l/RADdGrCXeHM4 YIdgHeOKq+4spwEux+VEGfvrhXgJ8oG8r39efB0flFJkXQse+T3R7cJvDQzFb73hOYuCal TjLbfqcxU2s3XUvfkcG/63pdwHHVsiU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684828799; a=rsa-sha256; cv=none; b=xtLDQbPN9A0Ia3TbF7nsLBXyUr0BMdpNHbPCwnyBHogeX7wmgv94nDcg/aS+0DzDPiYByW O88aY8uwNdD83uGESy9ySmkPxKRWSDUBAgtgQ+7uJPa2d/6kncYjfwjVZdGCsVbh+VaxGu Cmr5aBBtAXz8+lq+5ukoNknwV+ZOpgU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uc24tH+V; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684828798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c/I/wqsAUZDwVaD1e7Awdsb6/q2Rvw3zvRXvMlz6NW0=; b=Uc24tH+V5jJMRRb9hD3Wkqq6dEKB3Xyh3mhR/p+IPMwFpJ4YVXuHMTcEC/gbxQgXaMF/jm onq6EqTNJtZzLy3qnFUQ2s7bUZmBi/Sa78IYhlfSz/sEnMesUZ/a8mKCNBeaiV0gn/Fsjf jG9L7E70+R3N7VASbY0pqhEZumEwkBc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-ISvrEQPpMNKl6FruTi43ug-1; Tue, 23 May 2023 03:59:56 -0400 X-MC-Unique: ISvrEQPpMNKl6FruTi43ug-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-30a5d4e5731so1068944f8f.1 for ; Tue, 23 May 2023 00:59:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684828795; x=1687420795; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c/I/wqsAUZDwVaD1e7Awdsb6/q2Rvw3zvRXvMlz6NW0=; b=XEvk9uqtPQFBMWW/7C608qhyIdXnSB5TBC5TR4QuRRzWk/UCdEcCiD3c5PhyDGOg2v syCHrt2kJ9ywBxPOAHbc6VQmoVJs4mgmqFxXkpgKDGLRyo+uDjduoKB+0pNM/N/Q55vq lWftjVQrfdAVG2qSQXQszUmnJO28285u9lXVuIdHPI0Zka4MD2lbjOJDOVj0QC9QAQtZ XPmLvFzQf8hzcMD6po/eaoV38gxp9YKO9AO2KKvKFMqEZK8QlPS9cbjonEUVDCBYUNip Sq6UDdEaYNzrbo1xO4uovUACpJuCajQJS0NyAZ3UxeWzgbZwq8BlJ5NKSdYi66MvHzE+ LiDg== X-Gm-Message-State: AC+VfDzfvJ5NDXQ0wI8DElc5cWBPayiA0lgmnwexu95yuChUC1J72Xl4 KeoBIkrvFnGCG+i9FLaSDd6wabUPgEJGgx4yELg+0VCe7N/9EGzU4YccXqpZSD/xch9san/VAJ6 rx4FG5+k6qqedL5FqF2s= X-Received: by 2002:adf:e401:0:b0:309:4176:702 with SMTP id g1-20020adfe401000000b0030941760702mr9786028wrm.37.1684828795458; Tue, 23 May 2023 00:59:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ63Bb25pawnjsloN5gp3/r6DIpPxmC+hDZy27hfHmyipn66Vb2ESk2diwsR0KgQ5gEy6CPgrA== X-Received: by 2002:adf:e401:0:b0:309:4176:702 with SMTP id g1-20020adfe401000000b0030941760702mr9786013wrm.37.1684828795083; Tue, 23 May 2023 00:59:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd? (p200300cbc74cb4005c8ba0b2f57ee1cd.dip0.t-ipconnect.de. [2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd]) by smtp.gmail.com with ESMTPSA id c10-20020a5d414a000000b00304ae802f02sm10148229wrq.66.2023.05.23.00.59.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 00:59:54 -0700 (PDT) Message-ID: Date: Tue, 23 May 2023 09:59:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH -V2 4/5] swap: remove get/put_swap_device() in __swap_duplicate() To: "Huang, Ying" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Minchan Kim , Tim Chen , Yang Shi , Yu Zhao References: <20230522070905.16773-1-ying.huang@intel.com> <20230522070905.16773-5-ying.huang@intel.com> <9cbd93e0-721a-01c2-14dd-87f89363a830@redhat.com> <87o7mbyifo.fsf@yhuang6-desk2.ccr.corp.intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <87o7mbyifo.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E830A10000A X-Rspam-User: X-Stat-Signature: zzubsn3pewz1pn7fmdy7wtokc1jqe8mb X-Rspamd-Server: rspam03 X-HE-Tag: 1684828798-860633 X-HE-Meta: U2FsdGVkX190sClAYiXa462aR/fkqg8quFnOF8Rq6yjPpvfDznJwtS5FdZ25JI8LOkIG9oG+jWMvh956ocQ2T5zYcAOP3BUUFmN+eAJPcQnaFLfi+70a0SLWhuwp5FvJ35zlLcc5GkW59xIGjGy59z8wG7sLI/ufqEXWjnz1y14tePMdcJLqVYCUyVX5YwJNYcZeIU6e4Se8TxY9nsg1epaY3m0zpMsBXELA8w/vEmFatpZy0FrL/1JVfcVgsLDwQ8euIXwbpTjLHuD0a+rp+/GLOKS2ToooGAo9+yATBA8asOetmwzL5OtBvo/xc0JgvrnnRk9GBE9HlUkHcoo98iLpjH1LmwOHUGfHzIpgDGnA778BIE6sCA4cwhm4/1Aq392gXfdfXw+f4+8QG1kEkhSsKU7SoAJJJAu/32GdB5f268lWv6SjbpLOb2KqpNosTpyszi6i6PsZPaCSQOeN126frdpJ1RBmERJiBPgEMrRqVS2/1IEGX/NKoSPL8hFDPft8aiTdgfHwcD3bQGgODUW7ZbYf5JWohn/j0hkCs657PSSKCB9Ul5hNVbI8+hi3ctFJf3HG/8w7H1AuLEm8UBB3lwrkm1Pf9mxgewUolb/DN7bq8c0d0EoMEwoLYMmesl7bSASVXv5m29doi2mSuGQTlyzuUOJqzy95qBwPwFActkLIzsPmV/tCiAVVyND/36UtehG5iY4KKr5XgLpnypOTNdpFegIO/WRE7EI6ZUXqzAmKr2/R+Dt2x5X1ai/bFryi9M4YteqLJV6utUT3E5sJ0fyisuzx5ZKZFzX3kbPICi7Fjo/eqWZZgob/yie/Zb2s8CPSPCU3J4wdrj1N/2qCPKToWYYqoL/PJ0HBoaQKT5+4irfY8dEulCTk4RJU3QKJwK10+DSwZenrWKRrAOCce2mRHwL25HKThplUT09MCJrPXt3ivdRnz1Kk4e9yTP0L+mgWt6Enea7ckKn nRYvhXV9 tos1nay9eKsMOOinJF+WqcIKeM73bVqmt7oMDuX9CZRNuKtxb4qQwOWPdx/p+Hxm5ehWjIkmJCYDo6kw43Pe2IpGhlmMdRxFfKbfeBqlgGynYTPE3ITelQEBs/bXMX06VpF6hwAIlAYR5fkVDMx4z9LGmfa/bo60k7u8MfM5HLmueOfbrQj549FIoZp6sKLUFnSnvUz31AVAM2Q9ZTAvsW3nl95dQSoVWMjAbRwF66UL9LV9wCEBW/W83tQrEUbaF7RrVqViqcLrn2cFXTQm0Ux594531EPjmRnsayMarPIognuPz6Ulm56dgscV3rfKTH5QgFymHaaQuQ8/PMwVneCJQfhRbDPDcx1SugzR/lqamZ9+5Q0ViwPkzr0a5TNiotHpnRayaCADWt+UFl4DW4NGlTzdFP1cyQzVbaC81+ojwqh3s6BImR08mdQuoriXbiZmRZykz1L3E4+I/jU7BIOIhNopmKd/bzVav X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.05.23 02:56, Huang, Ying wrote: > David Hildenbrand writes: > >> On 22.05.23 09:09, Huang Ying wrote: >>> __swap_duplicate() is called by >>> - swap_shmem_alloc(): the page lock of the swap cache is held. >> >> page lock of the swap cache? Did you really mean to say that or am I >> confused? >> >> "Page lock of the page that is in the swap cache?" > > Sorry for my poor English. Or make it shorter? > > "the folio in the swap cache is locked" Much clearer, thanks. -- Thanks, David / dhildenb