From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96887C6FD1F for ; Tue, 26 Mar 2024 17:02:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25AA56B0089; Tue, 26 Mar 2024 13:02:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20AA46B008A; Tue, 26 Mar 2024 13:02:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 084E76B008C; Tue, 26 Mar 2024 13:02:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ED3F96B0089 for ; Tue, 26 Mar 2024 13:02:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BE3BE1609E1 for ; Tue, 26 Mar 2024 17:02:34 +0000 (UTC) X-FDA: 81939809028.17.4F8B39C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 94673A0032 for ; Tue, 26 Mar 2024 17:02:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eWS/89xw"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711472548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1uw+Pse+hEjqp2IInnIpkApQjiMh/+MIWQ0lKJPzHCg=; b=Dz2NNDwcPaFC4ralMPQSCM3iTWj+jydvgPpUOsnBl+zQfTBOPUSv4QiGW5yiDyOJFr3TBm zZfvce6GOWDsNWh+Dgsw0I5Zqjo58dl/Xf2MkauiZ5RgaU4KUp2H0i4KS4qEbCUhp1Ibwb riScBrwkG+Nkq/470qc9so6D3zA5es8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eWS/89xw"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711472548; a=rsa-sha256; cv=none; b=5wswbFD17xsH4EIW16tnErGbdbofrbRPX++HavoXcWrDzcPCAKOijwnAB7Jh35gTXWCDNX mo+cl2snOeSbOI5Kw+OZ7frr91CuboQyDI1KdZ3yoqFwQlLpidUKZYG+GxEgKASR1y/Nsl JszI+Q/V19yVvxZBMkZWhojHPSN6mdo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711472547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1uw+Pse+hEjqp2IInnIpkApQjiMh/+MIWQ0lKJPzHCg=; b=eWS/89xwqngtbHXxWMWKkPaiXVzi5RjI5yKKJBReDLKsLBJjoo1f5u1vWbo8IpecCsckCm EqHkbxJp1dFNEYfM2115YZVvIT/pu8AZ+KFkXGPrbgSMkem9mOnAYIB76USlTifLjuigll 5Xx488QvTvHJ8Z12XrWAGD0o3fmux7w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452--sBo87i7MKyMSNa6kmKv8A-1; Tue, 26 Mar 2024 13:02:26 -0400 X-MC-Unique: -sBo87i7MKyMSNa6kmKv8A-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-414105984aeso31670145e9.0 for ; Tue, 26 Mar 2024 10:02:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711472545; x=1712077345; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1uw+Pse+hEjqp2IInnIpkApQjiMh/+MIWQ0lKJPzHCg=; b=cOcD9TDLf7NOYESmWYaWfLocpoifOiQevcYi1723o07BYFuwt6aBowoGKsODDyDAB0 wk/N3JoEj7bxbiOQ/V/cUnV9U2OI820jSSqc9Ck/h9l59+f//8VO+An8ar/GEf3N5cNU 7OKrBQPVMbr8hnljXI41J9R38aYeIxoxuFgRlL4Axz8j5GSbyAmgy7kNFo8nI4MPI/Rl kNAj9la50dfjGpJKD8HZeg4qhlBKwTPL3Ib0iKq68pjdQMjV0PuvICuhqT9rG3HT9+rr umP01rc70Smreo3qVgYxq4gIDq+2nIkGPYyyy1VXjCO9DSLNDaq7YzDufUCPdr7Cyb7M +27w== X-Forwarded-Encrypted: i=1; AJvYcCWKV8DmJJ/lISztiGKjf6Pn/btfcZ3CTU1rBH4Cmr1iy8sKmzxWIctfPVWNWFUCEFZW7+TyooxHIVH9KtMTQKOpw8k= X-Gm-Message-State: AOJu0YyH1wkKgpVV/tsKedQoTCmdMxvxwyztoi6ox/udSYcuKj4zD16K Igfx754WmrGyGcCUEZ2cxvmY4hQpEBn7gseHXy0bLpy78u09qLmz6Q1TOB/HaNZc90uCJL/xBsM z6w8tZ/yqvyH5dx0sm6ZKX1QRsZ92rGzc0S8hRCl0/MtZoVUf X-Received: by 2002:a5d:58d9:0:b0:341:b4bf:f0bc with SMTP id o25-20020a5d58d9000000b00341b4bff0bcmr6939838wrf.71.1711472544869; Tue, 26 Mar 2024 10:02:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7MtWaB4IMdU0Fs6kw5+r/J58scc0bGrfuwmJ/itc54CTilbkBjvYCyAJI81RCPhAft7ZJQA== X-Received: by 2002:a5d:58d9:0:b0:341:b4bf:f0bc with SMTP id o25-20020a5d58d9000000b00341b4bff0bcmr6939812wrf.71.1711472544333; Tue, 26 Mar 2024 10:02:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c741:c700:3db9:94c9:28b0:34f2? (p200300cbc741c7003db994c928b034f2.dip0.t-ipconnect.de. [2003:cb:c741:c700:3db9:94c9:28b0:34f2]) by smtp.gmail.com with ESMTPSA id bn22-20020a056000061600b00341d2604a35sm4164872wrb.98.2024.03.26.10.02.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 10:02:23 -0700 (PDT) Message-ID: Date: Tue, 26 Mar 2024 18:02:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 3/4] mm/memory: Use ptep_get_lockless_norecency() for orig_pte To: Ryan Roberts , Mark Rutland , Catalin Marinas , Will Deacon , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Andrew Morton , Muchun Song Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240215121756.2734131-1-ryan.roberts@arm.com> <20240215121756.2734131-4-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240215121756.2734131-4-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 94673A0032 X-Rspam-User: X-Stat-Signature: zhdtks5g8wfqmzr5h9iscb6y7nqwdxf9 X-Rspamd-Server: rspam01 X-HE-Tag: 1711472548-947437 X-HE-Meta: U2FsdGVkX190lZ0sIQO0+8RFXmKvv1KTTsAeYGZDrhpyeOVgAR7BSuambcKZVP0IRc5gMrUrnk0AbC+ziymG5QGVF2nV2yRiI290/QYAU5CtSbYkdW0hK/SI1T86E/Lopjls1OFnWx7KMOFSXUWd+JcmAEY77SHd18ew19OHgeX7zcpXNVUVu3pXRb/mYJEFLOr9qejz3t9Ub3sdGQEd4d1QQjcJMOiSoTbOpJ8bvrtQG+XQJs8/ijoc4qZvWhaINHCVwogdAaxty7QHNiQbhpF3HRZ96Q6JQrg8MAJwW0jLkUlP5eg76TjuP0PjGZJhfW8RK5WLORZLdC6g6C1EAVpxHrlZPpgeXbUCe00oU63Xs9jwzY9I5fuN2tg3sHUIKnWhOLjJV+Xe4kYByla7FJqJ79Yi4LJ6U6aAkrr+gnBboDZNGWs0NhPJZPBeh28Ku9GDRW5/H6iLtCO7Z2cco1ihFmGhGgo78TzqqJ8eRxz+0YUx6GG92Wzsz/AE1xmWzmxooajkW6ybFbqRb9eklXAuVEg0+Hyj+2Ru9QMGcsCt7Z0JLCVoYqAqo+RO2wNKeIcCIDsXybQndynE5D8inM6uUVXjd4GMOJOdPrKbHovQUKkIonS08h4xQAkllGGvsJSB5tZnEuI0ClOaByQy7+rqXcesIrqelF6j+UguXiKNB1FYNWb+SSPRpLGGRUbeHhnHNPfHWQOVFceTb49YN+kK/XySSHF1+fr+aZtW3rXvCG74x9A5vF+QOC+v16xxrSimjpePJ5a3HWbrTnEUj8m11WxFIj8NIvucEZuBZzcK2lXHT06kHMYbTVDRIVN7QPLFpaMXvHD5S2u4/DCCn5PYrAlTNTWcGlO2XwUtVML9NDg5cr9K3S/uI1NyKjHR1QlDgO/x5+B0oOR/nQOz78R/5sKBFykCtzQfWU2agFu762BdUhGrCeEplZXIW+RxIAS0xs/9ZqeZQ4Urgn0 InCVEztm 3l/TfbG3ePrQLGjoDVHiOC7dEMFZLqrhO0hhjy7tCJb8BwNBJHfy9XoSBESeHUD+hAXSekFf1lt/O9Uk1I3xGM2lBsvyulQNTgbA8CbfQ/2/h5WQrcNNEfOI9u7RZNgGEIVQH5Z43UQubqv9bwK7NlamkCv4QAFXNCFUI06SAfbbocsbUWvmbbk4+cT6FgpqO/vRVit//nobBX+Hr19o5M4IQkCaw1ji4PmwW6g3/FASWPIO3NG7R084VkbTuOGykThN+YxjbeFbj8J39MxzgjMM+xnk7NIOHdGbzkWyixpP3NOoiZhTshy/EvffWL7/yaVuqv1fLLfMQPc3nl0LNsqEr+0lXdKbgF/AO5/Xa5pRS4HJ5c3/xkJscXoPG/RKD5oemWuXYTo7Qo8z6OW1o2o3LCsaRgbE61EjlknUuqdclEsJW7Plf/LXDZL3G5XKwfrky/LaqV4TkjC2fclxa713ZLQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.02.24 13:17, Ryan Roberts wrote: > Let's convert handle_pte_fault()'s use of ptep_get_lockless() to > ptep_get_lockless_norecency() to save orig_pte. > > There are a number of places that follow this model: > > orig_pte = ptep_get_lockless(ptep) > ... > > if (!pte_same(orig_pte, ptep_get(ptep))) > // RACE! > ... > > > So we need to be careful to convert all of those to use > pte_same_norecency() so that the access and dirty bits are excluded from > the comparison. > > Additionally there are a couple of places that genuinely rely on the > access and dirty bits of orig_pte, but with some careful refactoring, we > can use ptep_get() once we are holding the lock to achieve equivalent > logic. We really should document that changed behavior somewhere where it can be easily found: that orig_pte might have incomplete/stale accessed/dirty information. > @@ -5343,7 +5356,7 @@ static vm_fault_t handle_pte_fault(struct vm_fault *vmf) > vmf->address, &vmf->ptl); > if (unlikely(!vmf->pte)) > return 0; > - vmf->orig_pte = ptep_get_lockless(vmf->pte); > + vmf->orig_pte = ptep_get_lockless_norecency(vmf->pte); > vmf->flags |= FAULT_FLAG_ORIG_PTE_VALID; > > if (pte_none(vmf->orig_pte)) { > @@ -5363,7 +5376,7 @@ static vm_fault_t handle_pte_fault(struct vm_fault *vmf) > > spin_lock(vmf->ptl); > entry = vmf->orig_pte; > - if (unlikely(!pte_same(ptep_get(vmf->pte), entry))) { > + if (unlikely(!pte_same_norecency(ptep_get(vmf->pte), entry))) { > update_mmu_tlb(vmf->vma, vmf->address, vmf->pte); > goto unlock; I was wondering about the following: Assume the PTE is not dirty. Thread 1 does vmf->orig_pte = ptep_get_lockless_norecency(vmf->pte) /* not dirty */ /* Now, thread 2 ends up setting the PTE dirty under PT lock. */ spin_lock(vmf->ptl); entry = vmf->orig_pte; if (unlikely(!pte_same(ptep_get(vmf->pte), entry))) { ... } ... entry = pte_mkyoung(entry); if (ptep_set_access_flags(vmf->vma, ...) ... pte_unmap_unlock(vmf->pte, vmf->ptl); Generic ptep_set_access_flags() will do another pte_same() check and realize "hey, there was a change!" let's update the PTE! set_pte_at(vma->vm_mm, address, ptep, entry); would overwrite the dirty bit set by thread 2. -- Cheers, David / dhildenb