From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ABDAC6FD1F for ; Tue, 26 Mar 2024 17:07:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1EE76B0095; Tue, 26 Mar 2024 13:06:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA8246B0098; Tue, 26 Mar 2024 13:06:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FA3C6B0099; Tue, 26 Mar 2024 13:06:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 89AF86B0095 for ; Tue, 26 Mar 2024 13:06:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2A35A140D0B for ; Tue, 26 Mar 2024 17:06:59 +0000 (UTC) X-FDA: 81939820158.23.7897B27 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id AB89A160004 for ; Tue, 26 Mar 2024 17:06:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fKGg2ISN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711472816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JPlyj3/CwacwsRZeB51P6wmxNjfcbT5PqkU2WxATGYc=; b=N7sRpFS8DaWhUTNIQ+scxBjXQtX5OgRFWmJj7K9eIqH8M0urKE9TQK+Zeu4RWMBMxlD3CQ fiiuDM0NI1klKkn+M8DIHWtilVX6v04HTHGno9uy2x6gB0VO3Ysm9qFoudj7QreOQkBMfZ 7Tvrltz1VbSK2dOkQojLYdXHdde4QqA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fKGg2ISN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711472816; a=rsa-sha256; cv=none; b=ZQ4Ir6GC5M2/EnipLk0bLWCruEZNm2NFl338R1I93T/WRJll/ccMSQFtNp0DkebzXec0CH KpyAjUII9JUxq0GF8mQfPeUYWUWWZy4zmENZ29HHp4ZcNjiEJ3bCZVieiZBxwLT1rvKs7h h+i0sF+8OpRemf59HuMPWyBtV23nfQY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711472815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JPlyj3/CwacwsRZeB51P6wmxNjfcbT5PqkU2WxATGYc=; b=fKGg2ISNl347vbsSMKz8flr82ecrrfeMsBDvjbsez7q1o1aKqOqGey1GcnA+cjTES0xS0+ 9HSYabLbHzIsMfbYtS2NikF4wmMfq4r7zF33zHHQWyIYUHrPMgJuxp4NQ0HaDyAXkGs6Uo +kbbiLSzbQdnko8tNFRb+Igl36UoTZ4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-P_yvrolDOCunat4ZOF2hTQ-1; Tue, 26 Mar 2024 13:06:54 -0400 X-MC-Unique: P_yvrolDOCunat4ZOF2hTQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-41489c04f8cso9860095e9.3 for ; Tue, 26 Mar 2024 10:06:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711472813; x=1712077613; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JPlyj3/CwacwsRZeB51P6wmxNjfcbT5PqkU2WxATGYc=; b=wpX959Ht/HPtwUyroAYXXz547I2oe6vEdwjV8o93xbGiL4uHJmcIiAU0VEhxgSrFZQ gcmOitXZ81bf+pQ8n0IP9dfmxVFrQCqYxG6EBfkmMfUyZylGooXwSf6kP4OQu1SumNIc /L60MFLgSLwIN6NVxPdIfomqP6V92woeWA1kljzGKq5tjN3AGy1RwjuisjQiZRhB+KmC GOwXooZ8HrWWi4FkysmBRxtzdKPNXSfm7JTt3ukS9gZR2Ot50XC1I8kQY7y+kYmzgGPV Hel2EuMKI0z+G3trCNzyHFBIZNh9UNe+UoQcoff8154HyiTydkJkN1UitvVPewdZuF4w 9lFQ== X-Forwarded-Encrypted: i=1; AJvYcCXt6Btrc7wXpIYO2556XeRtbtsPz/acWD6iKTEIOlz+VYc9mJ3W2O03EuohFbySIRNbXHCPaccK4qEPkBp3Yj7r4Dg= X-Gm-Message-State: AOJu0YzJ4wFtZh2CbZW/bQFE8AvQICKbjhPZdiI8L57WwaRcTR4qNP8+ vEAKzoAeoeQKmnblIGPVRRWQCe+ispoHysMyuexHMPe/RpR+qg4u6cYuDz21JJ+GOMLEhGWXcg9 LS1DXV9nysbBFbpWzIk6IuPSr1sg9r6mgzAbNIG+lCeDiuL2mLpdJl5Aa X-Received: by 2002:a05:600c:474c:b0:414:9242:e249 with SMTP id w12-20020a05600c474c00b004149242e249mr517545wmo.3.1711472812813; Tue, 26 Mar 2024 10:06:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGVWxJ/Chl2KE2yk9iFpxvNAel1tHxXsTN/HzdeJ9LFGV5GYS0hUjUFkZ3bEIaz8tvGgQFvVA== X-Received: by 2002:a05:600c:474c:b0:414:9242:e249 with SMTP id w12-20020a05600c474c00b004149242e249mr517518wmo.3.1711472812318; Tue, 26 Mar 2024 10:06:52 -0700 (PDT) Received: from ?IPV6:2003:cb:c741:c700:3db9:94c9:28b0:34f2? (p200300cbc741c7003db994c928b034f2.dip0.t-ipconnect.de. [2003:cb:c741:c700:3db9:94c9:28b0:34f2]) by smtp.gmail.com with ESMTPSA id iv16-20020a05600c549000b0041409d4841dsm12091942wmb.33.2024.03.26.10.06.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 10:06:51 -0700 (PDT) Message-ID: Date: Tue, 26 Mar 2024 18:06:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] virt: acrn: stop using follow_pfn To: Christoph Hellwig Cc: Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Fei Li , x86@kernel.org, linux-mm@kvack.org References: <20240324234542.2038726-1-hch@lst.de> <20240324234542.2038726-2-hch@lst.de> <7d151430-c296-44de-8998-a20a0b526aab@redhat.com> <20240326060447.GA7108@lst.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240326060447.GA7108@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AB89A160004 X-Stat-Signature: qida7jhxg3aj9izok65j1eabd3sp49z7 X-Rspam-User: X-HE-Tag: 1711472816-60173 X-HE-Meta: U2FsdGVkX1++rt425MR1Ky5CuO6n5wwzQNOZiuJwoEWvA9i6ns1RGZW9HHqKl0dM0zJgvJqXonfyz6IpY5tjul2y1lK5mhUAZ+y+872NR+z6BCoylgw+Yp5jzfODcbPYBGIvW+y0cCDVxZhsWsrnUr3NBJHzA57D0ZfMyN9hzZ4L6stTxkdFUNOkukajwirtT8FJkYByl6VliNrTToN4h3/bY9y33eQDyr5fbmj35A61al2AquKiLyktEERBjQUXViO4uYMpfE9J1tRJKut26pYoT3K8mlBiBYl/IKmCPZOH0KWQM9d+AICs3CtE+1/cECjO0t1HkgXr/LrafaVU1AbFUwqDIsAWeSJsfVoxVKuDU0kqz3J6YuxioBHXIvrtXYXZpl7VNT83E2faVU0u6Qd0f8GLwRR51jzQidp2RNyF0KItn7gEFRiSSD448hefLYTCeLQNctT2fMytk1SofvQqfKyRrcMCI3exiovhPq8TozFue1bp0R4S15Ls0BqNE/HCejTo5rl/iwLkrRq6MgxRq+RWRrL7/4JjUy131iT5LEX6BBa5m1/CBr2E7aQBBUx7h8LN5o4RkdglWqh3TqYoZT6SJlrTtQlQDFiBQY6BgvzznBHdSlv/4cJhzLnEru5XXDrn/JuIOu3ZGqDkRom6ukuo/zw3nQFvJd68QhswtRdaDOZUIp7vj5gX7VoZODGBwANSKmIECWm0jbriO+xuDnZUWpvM4c5cChRT1tfiFny7gpo+RRmbf8R5aSDux0jDSk2RCScziCudKCkMSkVOCZAZn5O18COF4gmHtWaWc9wg6dffvCBhAO0rAgCfuvdJ6j9Eq+nBpuLwwIgBRurqMAAWyVX3eC/vuhe6c/5ZiMIkRJJCrvF1FB/WvdyG/AXSkYxa2HjoWY5VnzGwPEWCGOBSSwJxj/U+g9uAj8gGmJpkVmMCE6gmS7pgAXVMQJtv80LnV4JFt/TQp08 h7yyZ7Fp Yp/7s4vM/iAh6x2m+oBMLBUFe3XtrgGfuK3go+oWrpMl/eQHeSuvqM4BpSo5lrakWyiaOPUn5IutzFU0klhs9TTrgEvnPFpSXI7iTF9NboSfNxg+2ERoXKd8U9buL+pUs59tGIw9rpnPfNhFtLJXMgr+UaTmBql9OvLbzS/ORypA4Hb//IKO5OdYb3K71a15Ci3LSn6pMlG9I786d5CMmp+FSl9nfN1SniItqSFTyA9OLltfugd1CyACId2avTSz0zXoZv34JXJj9dhb3HAcyTXNFivvvIjLRLi7WCjW6zbz8xzsnNstOkYqoN1pnnCcyO6DA6G1MuHji2KGC0O3lWOTicN5PUrsClFWvPPq+jYJykCQgR+ZadeTv4tVblGzQ/tY4vNovINJ9NPBo8e+bL6W9fhDaLwYmos8wjsILA+EWwTQjWxwFS82PogGZ/PVydJ4LBG18mC6x09MW5XPqHQDOzV0FxXSyYAfXF1obBzyQl0DpqhzNRrN5Tg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.03.24 07:04, Christoph Hellwig wrote: > On Mon, Mar 25, 2024 at 11:33:31AM +0100, David Hildenbrand wrote: >> ... I have similar patches lying around here (see bwlow). I added some >> actual access permission checks. >> >> (I also realized, that if we get an anon folio in a COW mapping via follow_pte() >> here, I suspect one might be able to do some nasty things. Just imagine if we >> munmap(), free the anon folio, and then it gets used in other context ... At >> least KVM/vfio handle that using references+MMU notifiers.) > > How about you just send out your series that seems to go further and > I retract mine? Let's go with yours first and I'll rebase. Regarding above issue, I still have not made up my mind: likely we should reject any PFN in acrn that has a valid "struct page", and that page does not have PG_reserved set. That's what VFIO effectively does IIRC. -- Cheers, David / dhildenb