From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31757C433ED for ; Fri, 14 May 2021 10:36:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA547611BF for ; Fri, 14 May 2021 10:36:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA547611BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 62F0F6B0036; Fri, 14 May 2021 06:36:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B8806B006E; Fri, 14 May 2021 06:36:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 431B96B0070; Fri, 14 May 2021 06:36:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id 0888B6B0036 for ; Fri, 14 May 2021 06:36:52 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A1380AF78 for ; Fri, 14 May 2021 10:36:52 +0000 (UTC) X-FDA: 78139483464.06.6F86B32 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf04.hostedemail.com (Postfix) with ESMTP id 915AE3CD for ; Fri, 14 May 2021 10:36:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0CE1BAF59; Fri, 14 May 2021 10:36:51 +0000 (UTC) Subject: Re: [PATCH v10 03/33] mm/vmstat: Add functions to account folio statistics To: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Layton References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-4-willy@infradead.org> From: Vlastimil Babka Message-ID: Date: Fri, 14 May 2021 12:36:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210511214735.1836149-4-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 915AE3CD Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam04 X-Stat-Signature: 1bbmigasf9xbb7ny34jmzrt9yggdzo1m X-HE-Tag: 1620988611-85990 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/11/21 11:47 PM, Matthew Wilcox (Oracle) wrote: > Allow page counters to be more readily modified by callers which have > a folio. Name these wrappers with 'stat' instead of 'state' as requested > by Linus here: > https://lore.kernel.org/linux-mm/CAHk-=wj847SudR-kt+46fT3+xFFgiwpgThvm7DJWGdi4cVrbnQ@mail.gmail.com/ > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton Acked-by: Vlastimil Babka > --- > include/linux/vmstat.h | 107 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 107 insertions(+) > > diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > index 3299cd69e4ca..d287d7c31b8f 100644 > --- a/include/linux/vmstat.h > +++ b/include/linux/vmstat.h > @@ -402,6 +402,78 @@ static inline void drain_zonestat(struct zone *zone, > struct per_cpu_pageset *pset) { } > #endif /* CONFIG_SMP */ > > +static inline void __zone_stat_mod_folio(struct folio *folio, > + enum zone_stat_item item, long nr) > +{ > + __mod_zone_page_state(folio_zone(folio), item, nr); > +} > + > +static inline void __zone_stat_add_folio(struct folio *folio, > + enum zone_stat_item item) > +{ > + __mod_zone_page_state(folio_zone(folio), item, folio_nr_pages(folio)); > +} > + > +static inline void __zone_stat_sub_folio(struct folio *folio, > + enum zone_stat_item item) > +{ > + __mod_zone_page_state(folio_zone(folio), item, -folio_nr_pages(folio)); > +} > + > +static inline void zone_stat_mod_folio(struct folio *folio, > + enum zone_stat_item item, long nr) > +{ > + mod_zone_page_state(folio_zone(folio), item, nr); > +} > + > +static inline void zone_stat_add_folio(struct folio *folio, > + enum zone_stat_item item) > +{ > + mod_zone_page_state(folio_zone(folio), item, folio_nr_pages(folio)); > +} > + > +static inline void zone_stat_sub_folio(struct folio *folio, > + enum zone_stat_item item) > +{ > + mod_zone_page_state(folio_zone(folio), item, -folio_nr_pages(folio)); > +} > + > +static inline void __node_stat_mod_folio(struct folio *folio, > + enum node_stat_item item, long nr) > +{ > + __mod_node_page_state(folio_pgdat(folio), item, nr); > +} > + > +static inline void __node_stat_add_folio(struct folio *folio, > + enum node_stat_item item) > +{ > + __mod_node_page_state(folio_pgdat(folio), item, folio_nr_pages(folio)); > +} > + > +static inline void __node_stat_sub_folio(struct folio *folio, > + enum node_stat_item item) > +{ > + __mod_node_page_state(folio_pgdat(folio), item, -folio_nr_pages(folio)); > +} > + > +static inline void node_stat_mod_folio(struct folio *folio, > + enum node_stat_item item, long nr) > +{ > + mod_node_page_state(folio_pgdat(folio), item, nr); > +} > + > +static inline void node_stat_add_folio(struct folio *folio, > + enum node_stat_item item) > +{ > + mod_node_page_state(folio_pgdat(folio), item, folio_nr_pages(folio)); > +} > + > +static inline void node_stat_sub_folio(struct folio *folio, > + enum node_stat_item item) > +{ > + mod_node_page_state(folio_pgdat(folio), item, -folio_nr_pages(folio)); > +} > + > static inline void __mod_zone_freepage_state(struct zone *zone, int nr_pages, > int migratetype) > { > @@ -530,6 +602,24 @@ static inline void __dec_lruvec_page_state(struct page *page, > __mod_lruvec_page_state(page, idx, -1); > } > > +static inline void __lruvec_stat_mod_folio(struct folio *folio, > + enum node_stat_item idx, int val) > +{ > + __mod_lruvec_page_state(&folio->page, idx, val); > +} > + > +static inline void __lruvec_stat_add_folio(struct folio *folio, > + enum node_stat_item idx) > +{ > + __lruvec_stat_mod_folio(folio, idx, folio_nr_pages(folio)); > +} > + > +static inline void __lruvec_stat_sub_folio(struct folio *folio, > + enum node_stat_item idx) > +{ > + __lruvec_stat_mod_folio(folio, idx, -folio_nr_pages(folio)); > +} > + > static inline void inc_lruvec_page_state(struct page *page, > enum node_stat_item idx) > { > @@ -542,4 +632,21 @@ static inline void dec_lruvec_page_state(struct page *page, > mod_lruvec_page_state(page, idx, -1); > } > > +static inline void lruvec_stat_mod_folio(struct folio *folio, > + enum node_stat_item idx, int val) > +{ > + mod_lruvec_page_state(&folio->page, idx, val); > +} > + > +static inline void lruvec_stat_add_folio(struct folio *folio, > + enum node_stat_item idx) > +{ > + lruvec_stat_mod_folio(folio, idx, folio_nr_pages(folio)); > +} > + > +static inline void lruvec_stat_sub_folio(struct folio *folio, > + enum node_stat_item idx) > +{ > + lruvec_stat_mod_folio(folio, idx, -folio_nr_pages(folio)); > +} > #endif /* _LINUX_VMSTAT_H */ >