From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87130D3C524 for ; Thu, 17 Oct 2024 16:33:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE82B6B007B; Thu, 17 Oct 2024 12:33:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E99D66B0082; Thu, 17 Oct 2024 12:33:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D600A6B0083; Thu, 17 Oct 2024 12:33:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B64BF6B007B for ; Thu, 17 Oct 2024 12:33:43 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2A278ACA3D for ; Thu, 17 Oct 2024 16:33:21 +0000 (UTC) X-FDA: 82683640032.10.76388B1 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf15.hostedemail.com (Postfix) with ESMTP id E25FEA0023 for ; Thu, 17 Oct 2024 16:33:30 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=aZjVzsw1; spf=pass (imf15.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.175 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729182676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W0ti0XsvTZ/XzR+pwVr3tLSQQ+95HGH92FNh0wKLCeg=; b=hwrXdTpH5VETrw5/1tomgYUdKoepeVRyWADDmcYFwiT9ohjksxUq32xcsGZ7OgykCgbMfZ Wkvvv+5+MRIPLkYRewGibt/h/NAnAQg+CqU2Nuw0RA59eJwfMoK49YEaalEXUObf2abb7M mWtioQCbdrmBXW/+Ys96zr0JE92K+pg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729182676; a=rsa-sha256; cv=none; b=YzUxGX1cWZdKXjc831G4NqKMcUpcntwaaIssdcLmmaRaApbRXHuIxWVLVeX8rghdOP7XLz q5B4oA15j8R8+2AChS7nmMSyPwk/PtQoD5/nS6UzZKuBvW/rNMMWYe1F36F3TkN9K08KQ/ zbh2iYImQwDYaZpWETZ9TZPJd/ZpMDQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=aZjVzsw1; spf=pass (imf15.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.175 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-3a39f73a2c7so5490305ab.0 for ; Thu, 17 Oct 2024 09:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1729182820; x=1729787620; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W0ti0XsvTZ/XzR+pwVr3tLSQQ+95HGH92FNh0wKLCeg=; b=aZjVzsw15a/4xRFcCxYLJymV8lK9lZ4OpMmQWZ5CkZKLt4vVSJq4YFaY5CPvdMOKUZ Vzfo0sIEWNr2PYbSzLEmZJKn8ssYBN5+GjRQLw2mGXPBeQ0vqwnqm3j6Lydxijh5/0Cz bhLoFjZ8w/IfYWVlwzikZH5/37pvt0Wptv8Jg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729182820; x=1729787620; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W0ti0XsvTZ/XzR+pwVr3tLSQQ+95HGH92FNh0wKLCeg=; b=A1lFzRgkNzfpJpKLm/nbzXMZTP0X4rqLDCiD1SRBJZ+hT2cbukdxGyZ8k9MJmfyMbU 5TRaueVDUaHzqaZAt/RQaAbO73CMaKC9gX6IEA2vPNP7GnV6q2Nrbkjn7h6vX082i8W/ 81eadOyMAhA+I0CJON0yI0KPSjYA/1w33N7DYJFROu5bNPsr6mmnz8VgyLPf1utl9Xm9 KGaF8M7JDwxsaBxoqt5Bc3ptyDJik6JaRlyZL1XiuSWsIW0crTlTILzXl5DZzWR/Cgyg sRcz5OwdVTE/g0+Nowl7u3ZrtIXC6NuHsuv16vxNUhPs7+jgsN4k1C1hNcqUWbUbSDkh LSuQ== X-Forwarded-Encrypted: i=1; AJvYcCVkFeeXAl86Wq2SDGt1rjn/sTIZ+HfdPxt+nR9PeFKAdVGtEZnm+cxk0WV6+9+CovKbGD/6C1xQ2w==@kvack.org X-Gm-Message-State: AOJu0YxWafByJZ967YYLmZB3MdR7hTQPWgCG4KrTkGDTTuI+lafFxzcB I0DvgpRJ+Fzo2z9JsRA45qfgcOKLvjcvyBW2GraB1U23xsOkrrrpZZVWNSdSnEQ= X-Google-Smtp-Source: AGHT+IGZj5VTEGoyvHrGcQoBTDUL1ECuKHmy2uuHvPmgVMAluVOKOTXVY2rCJ8eR0erFZ+BzRAd48w== X-Received: by 2002:a92:b701:0:b0:3a3:dadc:12d9 with SMTP id e9e14a558f8ab-3a3dadc1780mr74371115ab.25.1729182819840; Thu, 17 Oct 2024 09:33:39 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dbec9b252bsm1417359173.57.2024.10.17.09.33.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 09:33:39 -0700 (PDT) Message-ID: Date: Thu, 17 Oct 2024 10:33:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: The "make headers" requirement, revisited: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* To: John Hubbard , Lorenzo Stoakes , Christian Brauner , Peter Zijlstra Cc: Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , Vlastimil Babka , pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Sang , Shuah Khan References: <6dd57f0e-34b4-4456-854b-a8abdba9163b@nvidia.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <6dd57f0e-34b4-4456-854b-a8abdba9163b@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E25FEA0023 X-Stat-Signature: 8e6csdkfh8fnscnqxc7tdfbcb7qmrdgw X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729182810-85383 X-HE-Meta: U2FsdGVkX18mqC2TajS2T4Z9+rQBmv9T9Ud6nOqonK7hyZy0nirvCrqhrglW0oEXViDgpVJCSqXD/ut2eneAOB2PBp2a/cvtoBXFK/1qlcA7AosNtvl6JHz0EtvIC5G215Qusziw4HQ7EMlSeJCtHQPco33+bI1oVYKSrionHP2D+l1zne4LdsADSgYEH187aumc3Lmm+tvSaocK00QqrJBYMOlVLHdxqojCrxxnIwedrcQyZyS+hQKCtxLIEzKn3VJ9UzIaj7EOdJuo9KpCjlft4VojbVPxoJ2hvIx/o0Vj70s8rbdXIskVBuGBu2E1iN/ohpl/In2OB+cJXw1/im62e0zKnzbsMskNq2Q+PA1JfG7PL8Q4WE7ryKnLXQ9PYcOHM52a8r8i2Ifh0/Eqn+rgTCZTQZ0mw0cy3lW09J+B8t8y3tok+oWxiPPU0fYaGZxa++5qYejjnOMBebjuEL54K1Xn4PD85AgKg2yxqzL1VXpYNT2/sHnO0omhUC9xB0wsNd4kCQxRGhyuFqj4FP0WMaBFeRmVqfqAFmk2AS0AizRT9vJj3SQZycy+SB+JEVTfu5z5KR0IqkE4b07+m7r9EVnXSSvZRdRo1VGyp0O/oysPNqUrWNS6wHwtWcHURED62o8EPNpQOOOAXh3EQkFHt+XqxWfjfmov/gzlxAqgfS0NmGeNOYHcpJHNCWyUJyVVtb8o8tNakIRn3dQPsGYu8bexgZE5mggH1gGSMZzNCuyycTQxqkuCwyngnlg+iWA2oPP77S7NrdZT2D6zGsuGWIuYT+8ejK7oiWBhJOxp6BzIFRAwybvTskQqp5xhbaVJbaIQ8GkIQKH9onJgzB8Fv69E8yuOQsyPjin3JuOpn5zcDQlOq5Fk98LteKSCdgJ/W0FxPvasxh3gIFZceHjNXXQvIM1tZdnvIJRqNP/9c0lZaCm4FnjSEdQAbX+zW6NImGEVk4ewoLLTK/J 5DoG4uNW bOmi2U+/AixyJq8tcC761btDacxw0DLDkOjmg8IKL2rbz8HbbYJDKukyXauGXq6ixzWlmZoxYad/GFmCBR98n9ywoDy+YM3jX+uaUYo3WQTpkZFs+2Iq7yvI5jSn4NIKLnhuMXJcVQa5uKpet3qRzaPoGrwLWR3iYlwDNKpC5i1LaZ32Onh9EV21P3oUu57DA3ScQr6chzcYw/+SUTFN6ChUPeEn05KAo6nZUriTuf8K0tQlqMyiTYmZMI2BlYvfKeTRPvWugHq2M2/1CnASPMZv11HT6UXRlyhkm6XbSRZtJY5QnyBekb1lOAhyhBEejBFJGAnqajQZ2qNw+d2NdDH8ceAr06Ai+U1N65WGIOwRvDf+AjQ69UbrEetcNmJUVieboB0rqNqhlJFF8u0x2vzi8Z9zDMMYL2uQf42MOYR3u6CpufgyLUykj2cDtEE6W9LtsEwvioOu68PH5K5ouYKx+m7A2C1sX/T9Y53j0kX37BnjNqEaPsFS53Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/16/24 20:01, John Hubbard wrote: > On 10/16/24 1:00 PM, Shuah Khan wrote: >> On 10/16/24 04:20, Lorenzo Stoakes wrote: > ... >>> diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h >>> index 88d6830ee004..1640b711889b 100644 >>> --- a/tools/testing/selftests/pidfd/pidfd.h >>> +++ b/tools/testing/selftests/pidfd/pidfd.h >>> @@ -50,6 +50,14 @@ >>>   #define PIDFD_NONBLOCK O_NONBLOCK >>>   #endif >>> +/* System header file may not have this available. */ >>> +#ifndef PIDFD_SELF_THREAD >>> +#define PIDFD_SELF_THREAD -100 >>> +#endif >>> +#ifndef PIDFD_SELF_THREAD_GROUP >>> +#define PIDFD_SELF_THREAD_GROUP -200 >>> +#endif >>> + >> >> As mentioned in my response to v1 patch: >> >> kselftest has dependency on "make headers" and tests include >> headers from linux/ directory > > Wait, what?! Noooo! > > Hi, Shuah! :) > > We have had this conversation before. And there were fireworks coming from > various core kernel developers who found that requirement to be unacceptable. > > And in response, I made at selftests/mm tests buildable *without* requiring > a "make headers" first, in [1]. > > I haven't followed up with other subsystems, but...maybe I should. Because > otherwise we're just going to keep having this discussion. > > The requirement to do "make headers" is not a keeper. Really. The reason we added the requirement to avoid duplicate defines such as this one added to kselftest source files. These are error prone and hard to resolve. In some cases, these don't become uapi and don't make it into system headers. selftests are in a category of depending on kernel headers to be able to test some features. Getting rid of this dependency mean, tests will be full of local defines such as this one which will become unmanageable overtime. The discussion should be: "How do we get rid of the dependency without introducing local defines?" not just "Let's get rid of the dependency" thanks, -- Shuah