From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B608C48BC3 for ; Tue, 20 Feb 2024 14:07:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E7656B0078; Tue, 20 Feb 2024 09:07:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8978B6B007D; Tue, 20 Feb 2024 09:07:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7118D6B007E; Tue, 20 Feb 2024 09:07:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6187E6B0078 for ; Tue, 20 Feb 2024 09:07:32 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 236321C06B0 for ; Tue, 20 Feb 2024 14:07:32 +0000 (UTC) X-FDA: 81812359944.30.0A3D0C7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id A0B07A001B for ; Tue, 20 Feb 2024 14:07:29 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NE+N1woU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708438049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TfSiB4xU3Pf2ASAqrc35eYDgyfR8LdcSqcXXHY4DB94=; b=fkxu6Pm9JUx9raVSkwQK/K5PWxB/jaBZu4DeykkyPzvEeNtK51QXQTnzx+fTbFoATnC8si 9zqMWWp1jg8qZZhWREEIkrY4DnBb7Ny4NESLssYhW3RoihO+ltfedU4u6tVIPlAzXeIAHt 4YQS8rLymyyFaSj5ny96Vmm7E/HNAko= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NE+N1woU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708438049; a=rsa-sha256; cv=none; b=KBkt/Q8ESH7Yl1zVoSK5w3yVidyxit5Q61Ei66Zvw3FuqN23WvmEbE6k6vVC91cofgdcm0 dtOtARg+VG2smmQ/MGZb6sbZcJNbaqbvL3csre0cvpVQXNDfs9S3VtRsv1RN+Rtt3VGrYC y5+AQ1vX8z6rEovDNmIM0EnC1CrLsk8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708438048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TfSiB4xU3Pf2ASAqrc35eYDgyfR8LdcSqcXXHY4DB94=; b=NE+N1woU0YOqGDxPUyELP5uLQA8e/3/hF3YFMCBUhxrZdJtQW1cf2BXiHRQWfig1H3hD5u 8nbmrRf9xoev2FK9wxr/XB6ahirz+iFD7evm74cf0Oir0gFeNoj+UQ4li6GpN8hFdscK9O mjk9QRhCWmv45p4/Fg9GaTybxpZhvFk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-_jmt0O8cPa6MpylJydiDQQ-1; Tue, 20 Feb 2024 09:07:26 -0500 X-MC-Unique: _jmt0O8cPa6MpylJydiDQQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-410d0660929so27033135e9.0 for ; Tue, 20 Feb 2024 06:07:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708438045; x=1709042845; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TfSiB4xU3Pf2ASAqrc35eYDgyfR8LdcSqcXXHY4DB94=; b=FxeQst/JntJ2YUNLw9idz8ffknKko6wAdo8V2AWZbA+a0qUx8P8xD2ac9uoKYmvuaj Ab1BT1Y8DNaulres1sxdpkOSJBnJd/vWQWhwBtUy9VuexaCbbUtmVSiRF6mSy0B4aRGD WHCsBMNhjuslUcn7+rBHNZ/XI8ClMouybCERy9ha73+a8ywC0WDGYmf3UgwLEfcFKiXs hCLAnBfGQ9Y+95NklPSxqfcIDxzRfHbTwUBc4PjPXL+cp7M7Zmzcnb0rD+yjbT51djv3 jE2U51oJ+jhPDxIQ5qGrYvlxGW1fut1e1NAWwTD8+pMCjNmvQtXJKNKYq07w1XGJHF1d hjMg== X-Forwarded-Encrypted: i=1; AJvYcCUgQ4SUsIHuMWN+0w4ADerbxrEejSeh5RXjQLKG/l0BrCnheMls1dfODCK27DwXt8foTknhVNTFRDGCDruordvtCHk= X-Gm-Message-State: AOJu0YyDnXMVf8YQ6RHmiYYYeCr5sp8LBfnUY9I9h5jp7muCV2IU46MO mAuUJs0t2EQkqWDNs+c7Xi0whjMEJrwgVkljYWJU4R87xMPKY5MPnXioULHYitCSbNOXuFHxdNz vJ8QdTqQxm4yIEARCqQjrqw5tOanblC6GZl6m9uR3SDF5ZFqu X-Received: by 2002:a05:600c:1d1a:b0:411:db41:687c with SMTP id l26-20020a05600c1d1a00b00411db41687cmr15038544wms.13.1708438044747; Tue, 20 Feb 2024 06:07:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlgR4p8fQNVJMnd6Ba7hnMrikj+Cav2h5yCFAosFZH5KGSXqMEspMFvnQvfnQxH3EKo9l5vg== X-Received: by 2002:a05:600c:1d1a:b0:411:db41:687c with SMTP id l26-20020a05600c1d1a00b00411db41687cmr15038492wms.13.1708438044298; Tue, 20 Feb 2024 06:07:24 -0800 (PST) Received: from ?IPV6:2003:cb:c72a:bc00:9a2d:8a48:ef51:96fb? (p200300cbc72abc009a2d8a48ef5196fb.dip0.t-ipconnect.de. [2003:cb:c72a:bc00:9a2d:8a48:ef51:96fb]) by smtp.gmail.com with ESMTPSA id js21-20020a05600c565500b0040fdb244485sm14558144wmb.40.2024.02.20.06.07.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Feb 2024 06:07:23 -0800 (PST) Message-ID: Date: Tue, 20 Feb 2024 15:07:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: arm64 MTE tag storage reuse - alternatives to MIGRATE_CMA To: Alexandru Elisei Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, rppt@kernel.org, akpm@linux-foundation.org, peterz@infradead.org, konrad.wilk@oracle.com, willy@infradead.org, jgross@suse.com, hch@lst.de, geert@linux-m68k.org, vitaly.wool@konsulko.com, ddstreet@ieee.org, sjenning@redhat.com, hughd@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org References: <70d77490-9036-48ac-afc9-4b976433070d@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: gd65x697ongux1zshygqdnxuc1qipw51 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A0B07A001B X-HE-Tag: 1708438049-221894 X-HE-Meta: U2FsdGVkX1875jt8wrk13Yyp9rk6SYYfoyoPuLKmzbPBdoU4wGis99ONV3GZKJA6zU9hlzTuiIA58eb68xkezKhrTVsaN5vYkeMe4jVv7wvbIDEo8MjyQDRKpjrLIqNZFMb7++j0ZQnjSjmwZo2BgPrl+Twbk18acUCDK9pZXFHv38ZS6pBW+JdAISinunMDqy9T1JyFD++3eoT5bh38G4mPbGUAe0TYXEax/lCShbpC5VYoZuLMYBzTFO2vltgcb/zzwA1uxVzlYvXkjCwPP4aDQLULgka9CgsGihbUX1LKq27GavAJRfTic4zvuNFqHThwloGbKjweTX3beem1FKXFH3QxMn6rRqR88g0uw6g6t3RRHr9enybadv4o8iStYB/HxNuwqtmtdK5Diwx5VYQc/3vm8qXfuydL4bhRjOFDpggYduKzmE439KMYosS5sWGSbHHhTBC58TbaVE3jpGEZYHQaMAvjO2FcXYGOitLZ9jn7vumTutBXD6qi70vsaRrE6+Tfspk/SBN9JhDvhkbYMSoNaXTEFiWFCYBBhl7LXe67HpHStjj17qPJmRDU2UHy0Azjz9hq4hHTNVKTuqLbayszmOAKAozzW+1nM5OSrerp5m1OS3TtaOexhYsp0A/8c+gpnG1Maoi/S7zSbBIoVZVtsBa+gi+JR7kCIgFnrdA9CwuOF4FZtdLFX5IUyHfUnq3s3O6a5m5kPs6M6MfTOBxfRPFJpsWK0bLkvZ3qLzgxcKtgC85U0kwGpR/SRs+u90VNSjOjJTGUehvlB/tF5ZkDa1QDM9akIe1uAi+7qSbpILjtNhaYAKQqA8F4Xw8s1SbzvmcPkHs0Znf6ocMoDEGGT0f7U07R19H1rHD8TEXhotrRY2CA+nOEYkhRccAMDsOhxthDXTBoUE3Mw8XuOf0wiQPg53+iSkXtcRg2YHmiWtZdsfjcsK4sJlbd2bJZU1OYX+t56Pt9hkg 2FP/IHPA plgFupLGV8Sc+toBQ3RiMtyXjRElNYTj8x6SUA2Q1gieCmkd++vCV64/XwCHSTYjZ2LeRyldL+mO6lbEdsqQEHgWP3QxbK9/Yh3LXnuGEVOYYo61jccCDS0MUTYKk00c4WrVELzX86j9imcjY2WYvUk0W0RChDhyC93Q2LRVfzg8ylR2BGUuKEDH1AAcsMR7rasFEJ4DY4IPtseQ7j+h4TGzqMKlveJ29su4JC9yXdpSuH6Ro4ZYDYBA7j4c+qKH6mRp8Bmh69gC+0tlxc91vOZ/q0Iz6gpicED2u1YdOt/nhm/xcVYXlqOKgrJIwCTWM3DfxUClnQiNnpVCsQizIateFevx3lnzh4kLgOkzN0JSOv+fIylHXe1mzZilMlC52IdbsTEClpdXTnrex4kQ4NQ4z41NIWG+9pnANnDV1j4Puft1oEn9wMj1DTY9b5occzyYteFjgNZaWjH7qGX8saT/4TQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> With large folios in place, we'd likely want to investigate not working on >> individual pages, but on (possibly large) folios instead. > > Yes, that would be interesting. Since the backend has no way of controlling > what tag storage page will be needed for tags, and subsequently dropped > from the cache, we would have to figure out what to do if one of the pages > that is part of a large folio is dropped. The easiest solution that I can > see is to remove the entire folio from the cleancache, but that would mean > also dropping the rest of the pages from the folio unnecessarily. Right, but likely that won't be an issue. Things get interesting when thinking about an efficient allocation approach. > >> >>> >>> I believe this is a very good fit for tag storage reuse, because it allows >>> tag storage to be allocated even in atomic contexts, which enables MTE in >>> the kernel. As a bonus, all of the changes to MM from the current approach >>> wouldn't be needed, as tag storage allocation can be handled entirely in >>> set_ptes_at(), copy_*highpage() or arch_swap_restore(). >>> >>> Is this a viable approach that would be upstreamable? Are there other >>> solutions that I haven't considered? I'm very much open to any alternatives >>> that would make tag storage reuse viable. >> >> As raised recently, I had similar ideas with something like virtio-mem in >> the past (wanted to call it virtio-tmem back then), but didn't have time to >> look into it yet. >> >> I considered both, using special device memory as "cleancache" backend, and >> using it as backend storage for something similar to zswap. We would not >> need a memmap/"struct page" for that special device memory, which reduces >> memory overhead and makes "adding more memory" a more reliable operation. > > Hm... this might not work with tag storage memory, the kernel needs to > perform cache maintenance on the memory when it transitions to and from > storing tags and storing data, so the memory must be mapped by the kernel. The direct map will definitely be required I think (copy in/out data). But memmap for tag memory will likely not be required. Of course, it depends how to manage tag storage. Likely we have to store some metadata, hopefully we can avoid the full memmap and just use something else. [...] >> Similar to virtio-mem, there are ways for the hypervisor to request changes >> to the memory consumption of a device (setting the requested size). So when >> requested to consume less, clean pagecache pages can be dropped and the >> memory can be handed back to the hypervisor. >> >> Of course, likely we would want to consider using "slower" memory in the >> hypervisor to back such a device. > > I'm not sure how useful that will be with tag storage reuse. KVM must > assume that **all** the memory that the guest uses is tagged and it needs > tag storage allocated (it's a known architectural limitation), so that will > leave even less tag storage memory to distribute between the host and the > guest(s). Yes, I don't think this applies to tag storage. > > Adding to that, at the moment Android is going to be the major (only?) user > of tag storage reuse, and as far as I know pKVM is more restrictive with > regards to the emulated devices and the memory that is shared between > guests and the host. Right, what I described here does not have overlap with tag storage besides requiring similar (cleancache) hooks. -- Cheers, David / dhildenb