From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67116C35FFC for ; Tue, 25 Mar 2025 06:45:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D36F2280003; Tue, 25 Mar 2025 02:45:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE58D280001; Tue, 25 Mar 2025 02:45:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAFC1280003; Tue, 25 Mar 2025 02:45:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8F525280001 for ; Tue, 25 Mar 2025 02:45:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 49625B7A4F for ; Tue, 25 Mar 2025 06:45:41 +0000 (UTC) X-FDA: 83259137682.19.55E0882 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf10.hostedemail.com (Postfix) with ESMTP id 24495C0003 for ; Tue, 25 Mar 2025 06:45:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742885139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WNwenqdY0v0ABTCMh14oYlXIOAu7TSYqWqZIH7y1zzQ=; b=WmbbIb/X+GbNqaKnEg/N9ClGXkLedtlevE55Wb9OgmA0ukDxoTJG4K+40RX0vpTOPGIe0C 2y5mPzwN6W4pyt4YLjOMJQcPzvVeOUmF5FdzryLUsyndeGC6scjaVe2UMJ0uVosljGAK+O 1WZnaqn/75bPMcz8k/TymDQ1MomxOBk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742885139; a=rsa-sha256; cv=none; b=Q0qSuWDuQOAXn1vxNrmbwG+JgGI8h3SvVxMV855BK7K2dp65h1iUtayWD26ltk+Rb64lc/ 1CoZAMBBmQK9hyZFrOKqr0117SD4MN1vicYaCsI+TfDLah45WSrNd85N/guGlMNR9JqbD5 qcwMhDv4QyYoefbDokDGyFUbJrqwmBk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4ZML5G60wrz4f3lgR for ; Tue, 25 Mar 2025 14:45:06 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 385F21A084D for ; Tue, 25 Mar 2025 14:45:31 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP4 (Coremail) with SMTP id gCh0CgAniFwJUeJnLJAFHg--.7441S2; Tue, 25 Mar 2025 14:45:31 +0800 (CST) Subject: Re: [PATCH v3 0/8] Minor cleanups and improvements to swap freeing code To: Baoquan He Cc: akpm@linux-foundation.org, kasong@tencent.com, tim.c.chen@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250320114829.25751-1-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: Date: Tue, 25 Mar 2025 14:45:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgAniFwJUeJnLJAFHg--.7441S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtry7KF17JF1fWr13Zry8AFb_yoW3urb_Z3 yruwn7KF42qwnrCayfKFyYvrs5GFWUGFyYvryrWw1furn5XryDXFWDCryrX3W7GaykJrZF 9wnYvry7AwnrujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4AYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AK xVWUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1l IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j 6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU80fO7 UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 24495C0003 X-Stat-Signature: 87cdyoud6oj5i9zqajirtrqk4y3okttb X-Rspam-User: X-HE-Tag: 1742885136-71092 X-HE-Meta: U2FsdGVkX18RJ/IieTDGIDY3bb+bMpxdxEVmVTl7E2UeVEprQUC+xxSM8lyOb9KiI2ixrTwJ6adPa4vpepFypPKwKgabkgkx6nv2+Gbr8Ec3jcXP4mNIcWLUjYj7TE3cP+f7OR1upTOAp9C9rhhLIW4a98NIQSVtapBIBi6i4eNTExwas1JQm5GZ4o3bNAwXi5ljvu8+wEENnEgdHkjCJXi7m7FLXb4se93nzLLS7ZobdTQ24NPal4o0bAkc7Hr1uIYU2IB2wELE1ufTgus6LRIJK0o3mAzBpyw+9aMB/CAIdqPP01mQrMy+8l9jxqm44Q40AWRBVY/dCpT8wiTCnp2shf3tEH2h20bAhWxzQuVa3pqkljZxM9puMMXACKtrefgSlO5BLfaldTBWI6nE3gwJ5wXhYZzs/sPqoyfC7RZ5rVd6ST83cULrwBN1+mNktB221GkrRF+CstJHBjNoc1EG8c38LPCkMoMeTiF3FRANRcjBwQ26Z58JaZKpVWNVqgE1vUC8gzfqwRnkzIom8aBOmye77f9zHkdC6oJPUiwdguocTbPF6IKumU1c0xrDmLTuEaTm53COP2G97iFyTFGDn60/M94eTAvn2VSMmni2eMVsqb7mMovTkxT9qh0Wk8BGD4JobHaldyu1ImnEufdlH0OZY5a8z/7CvHGs81qNtxQ47NdWTZv5JeNJGa0biQhZa7+nQO0Ts6WBVA6vrS6VCo4d9OP1DS7jL5uyumAo+ASMD9RAAOf/7ElD8tcrqGCtX+nSAhcRvm30gW0RP8NLvfJ+nvordmh61XIkRaMRMPYc3OSe5yfx/2JJyHMd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 3/24/2025 5:43 PM, Baoquan He wrote: > On 03/20/25 at 07:48pm, Kemeng Shi wrote: >> v2->v3: >> -Extent VM_BUG_ON instead of remove it >> -Keep bracket for more readability >> -Collect RVG from Tim for rest part >> >> v1->v2: >> -Collect RVB from Tim >> -Drop patch to factor out __swap_entry_free() >> -Improve changelog and add more comment. >> -Avoid unneeded lock re-aquire >> >> Hi All, >> This series contains some cleanups and improvements which are made >> during learning swapfile. Here is a summary of the changes: > > Nice improvements about swapfile.c. Those kinds of swap_free_xxx > confused me, I planned to clean up them. Thanks for great work. > > Reviewed-by: Baoquan He > Thank you for reviewing and pointing out the typo. We will fix it in the next version Thanks, Kemeng