From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CDB5C3271F for ; Fri, 5 Jul 2024 05:47:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B7AB6B009A; Fri, 5 Jul 2024 01:47:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 068126B009B; Fri, 5 Jul 2024 01:47:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E98936B009C; Fri, 5 Jul 2024 01:47:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CC8626B009A for ; Fri, 5 Jul 2024 01:47:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4CF8981675 for ; Fri, 5 Jul 2024 05:47:46 +0000 (UTC) X-FDA: 82304617332.20.3C0331C Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf08.hostedemail.com (Postfix) with ESMTP id 04F9616001F for ; Fri, 5 Jul 2024 05:47:42 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=VmvVsvFH; spf=pass (imf08.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720158444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aTMIFrktR6P6sKfiFco3hO79I2IAEdcVXmBy69Wcmgk=; b=qlgdRTKa02woew/yhaJG4gGDeQz7HqB+cXe0TJcVeHg78S/ZLc0rlJ0ygCqxa3MACbqpXs r998BAQA8vkHDGPC8YN3YoAxO8jyvLIQSx/RZ4WKT1+QfK4wZjjw0Wiu5XUPMf2Z/aWW+8 4VLz9JQ3L5NYmlTRWufEFkgXvLbUheA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=VmvVsvFH; spf=pass (imf08.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720158444; a=rsa-sha256; cv=none; b=bwm7Q9P2n82lpgMQc4Tdf5DaZ2dq12IZ/pwBVAuzL1BVBNNF+XCYcjaFevWPqlZmkBgS2c sOewJCkIMJbm1d6n2zZ+cIHtqzL/Q25veyXmWXCFK70YQNjGLNRzdcNFIJ7M9mbJx8SCUd pXmKAdQ2V03v+zECBvHmfiUl0RgAoTk= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1720158460; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=aTMIFrktR6P6sKfiFco3hO79I2IAEdcVXmBy69Wcmgk=; b=VmvVsvFHFK3fz3lFcs3RWcLKgoYFloz+yiRMxTUxDG4VRJEylxhxcH1ArV5btAXzrR6mGfctb2xV+b3oGIM4zEBCGAckWkij2lAOx2xZTaZU80lmaPIx9FzR3Iz9EKOPi7R3/HrK6iGqmm7eoRbqiRBCQJRn1Ej68B8e7N48M84= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067112;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---0W9tt65s_1720158457; Received: from 30.97.56.65(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W9tt65s_1720158457) by smtp.aliyun-inc.com; Fri, 05 Jul 2024 13:47:38 +0800 Message-ID: Date: Fri, 5 Jul 2024 13:47:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/6] add mTHP support for anonymous shmem To: Matthew Wilcox , David Hildenbrand Cc: akpm@linux-foundation.org, hughd@google.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <27beaa0e-697e-4e30-9ac6-5de22228aec1@redhat.com> <6d4c0191-18a9-4c8f-8814-d4775557383e@redhat.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 3p46oiji8i8m3s54sutzmk5e88x3zott X-Rspam-User: X-Rspamd-Queue-Id: 04F9616001F X-Rspamd-Server: rspam02 X-HE-Tag: 1720158462-149857 X-HE-Meta: U2FsdGVkX1/oxni6tC9jPP11F5rxQq1O5nsQVs9eVrmH4RF4q7YWZG8muSNzkwyli7qFxdmkE920yay7L9E/qmki00cowXxE4hUKwQ9gLMI8cdVYAgJKdDBXmNpAhyZG0hEY0U5j1OcFbG8C0EjOFHB0dnrgza30j7xpjfBgif4rhNZLy+oDl9bhlKbPi4bH+ifvbxupJxWTyQifqjd7bzHgxHOW7hRmzZ1xROSVyehGSd7m9CF6DEOTwwRlSaizjQqyO1QaPfWCOqsP9PYhoXm/U3MKrJ+/BlYMNZIgye3HM1W6pCMkp3BEWxHQd4Gw31HIfVGkQTAu7jFV+9Ve+/qCDJjgWx9bMSf/r++GtKXSeuM/qVSvEHzXs7ZA3uKJf5rnmC7//+9st/wpH3267eqojF3RNqcHibux8buGSEjconPuI35cbndjcVmiF511aI9li1JRSpYUcNfLnjdr6sWdYFlHAr44idzHbkYBGjkRmbMKVFqc9Bz1GnAPPUaQKgd5Fk64g7IiqasWWa/N7sflDjotVB9wZap474iVTGg2XgwXsuABbV7mvJlqI0MU3Wcz1mKSx+yMLFmSKBONubI5TLGVopCNL2c8SFBCQe8u6LUEPsA6H/wzPdWE6QJ4K5CGUtX5ICYobn5rryc+00R1i1IXs+3kZwXbfZfbRkhkU6zyQznB4uyTLBOCeBv2sz4HIfO4Vpo2F+9YDnWGwvC+x5Y122JHfR9VZA5bLWlsFtwDCImSyPP0Q26luuTuojChVMdTtZtMZF+s0A7vPsy1lr6sF6paZC6608ANykuBM7/Ts5ql/+XdXWO1u+QpUVGGYNFZYGGfB7qqCCXTF6rw8eNX90WV1/x5tLVjaKbd6qVPKhSUVJtqmGHPbflAC/Grk5Hg9nPGxSMySzO76cGwJqapwnQ3YwjJgklzt3lShanX/CCx0lyDdgQjFALH1ekJAxxaUSlJiU0GwHT 5O/Z/DE3 /ss6dIV5KyZFHLyh+d3Ed1ROI42jGf7wFGenR7x9huT94oiJNhBiVvquqHAQZbP3muhIUXWA9XIknCqUDWOTKSuJTYULtE0jQHMLVfKpUnlFzGzxZWMmx3RN5wolx/0ol/9qVxSkea+M9cWOvxaelS6W7YEP6oiy0O3XyPradcrEVpNYq3Ylx3nDtZXBGoyrcGnhbyqu10TbJY7WrXBizFKrEjN3PXV10fUY+AGYgxLF7yTWZwai6ugDGl7o6bkadNuIuE2Di6m2fBZFD72jC+Wg2P9koNfpsSxjL8AuJzIsi+a+8Oc+5aLkjlQ+LBOzWkJ/zCP/O438H/kK3keiT6hjkvfZ0NScV3j0kErwIm3s1lDmsVsQ39Zw1PjqjQ27TGJv9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/5 03:49, Matthew Wilcox wrote: > On Thu, Jul 04, 2024 at 09:19:10PM +0200, David Hildenbrand wrote: >> On 04.07.24 21:03, David Hildenbrand wrote: >>>> shmem has two uses: >>>> >>>> - MAP_ANONYMOUS | MAP_SHARED (this patch set) >>>> - tmpfs >>>> >>>> For the second use case we don't want controls *at all*, we want the >>>> same heiristics used for all other filesystems to apply to tmpfs. >>> >>> As discussed in the MM meeting, Hugh had a different opinion on that. >> >> FWIW, I just recalled that I wrote a quick summary: >> >> https://lkml.kernel.org/r/f1783ff0-65bd-4b2b-8952-52b6822a0835@redhat.com >> >> I believe the meetings are recorded as well, but never looked at recordings. > > That's not what I understood Hugh to mean. To me, it seemed that Hugh > was expressing an opinion on using shmem as shmem, not as using it as > tmpfs. > > If I misunderstood Hugh, well, I still disagree. We should not have > separate controls for this. tmpfs is just not that special. But now we already have a PMD-mapped THP control for tmpfs, and mTHP simply extends this control to per-size. IIUC, as David mentioned before, for tmpfs, mTHP should act like a huge order filter which should be respected by the expected huge orders in the write() and fallocate() paths. This would also solve the issue of allocating huge orders in writable mmap() path for tmpfs, as well as unifying the interface. Anyway, I will try to provide an RFC to discuss the mTHP for tmpfs approach.