From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 799FAC4332F for ; Wed, 23 Nov 2022 13:18:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C877E6B0071; Wed, 23 Nov 2022 08:18:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0FF16B0073; Wed, 23 Nov 2022 08:18:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB1326B0074; Wed, 23 Nov 2022 08:18:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A3826B0071 for ; Wed, 23 Nov 2022 08:18:42 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6347D120F44 for ; Wed, 23 Nov 2022 13:18:42 +0000 (UTC) X-FDA: 80164761684.15.68067B7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id EDF03180012 for ; Wed, 23 Nov 2022 13:18:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B64861C4E; Wed, 23 Nov 2022 13:18:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74BDEC433C1; Wed, 23 Nov 2022 13:18:32 +0000 (UTC) Message-ID: Date: Wed, 23 Nov 2022 14:18:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 15/20] media: pci/ivtv: remove FOLL_FORCE usage Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Andy Walls , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-16-david@redhat.com> From: Hans Verkuil In-Reply-To: <20221116102659.70287-16-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669209521; a=rsa-sha256; cv=none; b=f9l8cdilgah2eE6q1Llo72NT/P9DrbylslLzPFMFDJl7SlJCaB1kSIOsabJQpFnGsYYzqT TmD7ROzDbQCTeqwPcYLEjd5t3HyYwIMCcnyZkN3aGY2d7DS9fSR4VQPXHKwURGzcDtbUaH w0B77/jXc1d8lvY3u0t8fGCu/ufiioA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=xs4all.nl (policy=none); spf=pass (imf06.hostedemail.com: domain of "SRS0=+b1z=3X=xs4all.nl=hverkuil@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=+b1z=3X=xs4all.nl=hverkuil@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669209521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pC/2tdNxaEAjhUPRQAqGLeeUE7Qkmv/m9MW3HIaTBGg=; b=W6RfkpDolWss7DAKzXSbAEv3SAHoJ48aw7wMJ06JMxOaoMevqzLfQCfijs+lsjdBWg1coN 4vk7rYyToJLsp/GbkXHZkPVFIXy7gbLzJThuIFxDKv3tDO0BP4L70fKjL50KntVToHPrQ7 xWixsQd+zdmRNDzSU0qd3PUGClXvkHM= X-Rspam-User: X-Rspamd-Queue-Id: EDF03180012 Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=xs4all.nl (policy=none); spf=pass (imf06.hostedemail.com: domain of "SRS0=+b1z=3X=xs4all.nl=hverkuil@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=+b1z=3X=xs4all.nl=hverkuil@kernel.org" X-Stat-Signature: 7bmppmwic93uzx8ed15bn57tczfynomm X-Rspamd-Server: rspam10 X-HE-Tag: 1669209520-99322 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16/11/2022 11:26, David Hildenbrand wrote: > FOLL_FORCE is really only for ptrace access. R/O pinning a page is > supposed to fail if the VMA misses proper access permissions (no VM_READ). > > Let's just remove FOLL_FORCE usage here; there would have to be a pretty > good reason to allow arbitrary drivers to R/O pin pages in a PROT_NONE > VMA. Most probably, FOLL_FORCE usage is just some legacy leftover. I'm pretty sure about that as well, so: Acked-by: Hans Verkuil Regards, Hans > > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Signed-off-by: David Hildenbrand > --- > drivers/media/pci/ivtv/ivtv-udma.c | 2 +- > drivers/media/pci/ivtv/ivtv-yuv.c | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/pci/ivtv/ivtv-udma.c b/drivers/media/pci/ivtv/ivtv-udma.c > index 210be8290f24..99b9f55ca829 100644 > --- a/drivers/media/pci/ivtv/ivtv-udma.c > +++ b/drivers/media/pci/ivtv/ivtv-udma.c > @@ -115,7 +115,7 @@ int ivtv_udma_setup(struct ivtv *itv, unsigned long ivtv_dest_addr, > > /* Pin user pages for DMA Xfer */ > err = pin_user_pages_unlocked(user_dma.uaddr, user_dma.page_count, > - dma->map, FOLL_FORCE); > + dma->map, 0); > > if (user_dma.page_count != err) { > IVTV_DEBUG_WARN("failed to map user pages, returned %d instead of %d\n", > diff --git a/drivers/media/pci/ivtv/ivtv-yuv.c b/drivers/media/pci/ivtv/ivtv-yuv.c > index 4ba10c34a16a..582146f8d70d 100644 > --- a/drivers/media/pci/ivtv/ivtv-yuv.c > +++ b/drivers/media/pci/ivtv/ivtv-yuv.c > @@ -63,12 +63,11 @@ static int ivtv_yuv_prep_user_dma(struct ivtv *itv, struct ivtv_user_dma *dma, > > /* Pin user pages for DMA Xfer */ > y_pages = pin_user_pages_unlocked(y_dma.uaddr, > - y_dma.page_count, &dma->map[0], FOLL_FORCE); > + y_dma.page_count, &dma->map[0], 0); > uv_pages = 0; /* silence gcc. value is set and consumed only if: */ > if (y_pages == y_dma.page_count) { > uv_pages = pin_user_pages_unlocked(uv_dma.uaddr, > - uv_dma.page_count, &dma->map[y_pages], > - FOLL_FORCE); > + uv_dma.page_count, &dma->map[y_pages], 0); > } > > if (y_pages != y_dma.page_count || uv_pages != uv_dma.page_count) {