From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18BE8C4332F for ; Tue, 31 Oct 2023 12:04:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DCD76B02EA; Tue, 31 Oct 2023 08:04:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78D8F6B02EB; Tue, 31 Oct 2023 08:04:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62D2F6B02EC; Tue, 31 Oct 2023 08:04:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4EAD56B02EA for ; Tue, 31 Oct 2023 08:04:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 11155C0C22 for ; Tue, 31 Oct 2023 12:04:03 +0000 (UTC) X-FDA: 81405623166.07.96616EE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 9DC1B120015 for ; Tue, 31 Oct 2023 12:04:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SdA3SOCW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698753840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tizFFarlRzwye9RcySbWtnsOMYZ5mRgBH68nH0EPV+s=; b=OCPCQzY3MQZXYRwqtY2aSNbAe/Y3ZWDolB/wNNWOj1wVHB1JxKPkZovWTmUE2kefnZIopM UXyW3JKykOheJaBEUJSvgGp+sPZJqMRpzE0hH/gmmg99wDBWhOnhnUsFfWtjSAnFmpXBOd NKPRN/iARcQSJxYqK2Qhx8dGgIBDt1k= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SdA3SOCW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698753840; a=rsa-sha256; cv=none; b=vw0/V8Pr+OdynAP6lJDA6N18rc1EA+iF3k2bQ5FX4eIz7/JzIqXgaVilR5BgQp8uygGndG XLcb7tX3SiiGsEfYe9Wbb7JbMgOhQ45MWuqC2oYkyaRahu2ZQiPtq0Yc1BAu4jsGRNldQf 343u9fufl6hzSXOGIPdlgBppvdORuHo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698753839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tizFFarlRzwye9RcySbWtnsOMYZ5mRgBH68nH0EPV+s=; b=SdA3SOCWNQ3Bf3kDs3uyAar2A4xtRsGd0nqdy+GN7Z1BRkY7VX0TFnikWyfu++Th0pdfUf Kw8x0ZEj4uQ7CYmPXfL3GuZWK+WXvuzp20MkAPV/86d5lzuAowDRzoaWX8u7Z7qflDmEqo XQKcEKLO30yJ8oNsRGx9ZnTfCW0SpGs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-YnJlpysJNtmCsY6dkxngvQ-1; Tue, 31 Oct 2023 08:03:56 -0400 X-MC-Unique: YnJlpysJNtmCsY6dkxngvQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-32db6a28e24so2545268f8f.0 for ; Tue, 31 Oct 2023 05:03:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698753835; x=1699358635; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tizFFarlRzwye9RcySbWtnsOMYZ5mRgBH68nH0EPV+s=; b=w0uAiACca/7fVytrCwCKofgHyG7DkNggxXDTZ9nkOO5XguHJr6s5fdWzMQ3m9mmxqD 1M6xF7xSmecf9xKbmp9EVJhinD8Wo9WIgeZyu1YSTCP5EO3GRpnvry59R+4HKp0+4Frw +RhDS0B8v4nFtOz1sSmk0K3v07+dGg1XHuo1imMGmgLWlw5Xnt0t34LQyMG3HdifTuB+ ZdqLGWIMcJ+c5WuKDDmA8TT2hNiquenXJz+q20dsJfCvOaz6QgH5TIG6uRMuubaFYu/B Ol14WPNndJk0697vevq53qd/XuiAdpAboXxHdXVUvwRMtc/M6f6un+0vYFIcKG/sHebS mriw== X-Gm-Message-State: AOJu0YzKGyzGWgBOJ/KNVPkliA9CIsW6i18l7lD3DbZVqurSyN3bKZSk dutPl0D7twklGUTTBCbIgcvy0GQPiXpv4/oMnKYWViIKcP8htsgfbuPNKkjIdkiK34Bu/2pikfi XbJcCr+ZQguA= X-Received: by 2002:a5d:5229:0:b0:32d:9ed0:c31a with SMTP id i9-20020a5d5229000000b0032d9ed0c31amr8203292wra.64.1698753835523; Tue, 31 Oct 2023 05:03:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPNnFt3Jl6HWNbWTOKBc66lgc1Kkuj+K6c2d8a6zYk8NL7hLTmlGJwMGgFR1ELWi8GJQC6FA== X-Received: by 2002:a5d:5229:0:b0:32d:9ed0:c31a with SMTP id i9-20020a5d5229000000b0032d9ed0c31amr8203257wra.64.1698753835063; Tue, 31 Oct 2023 05:03:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:8f00:43b0:1107:57d2:28ee? (p200300cbc7078f0043b0110757d228ee.dip0.t-ipconnect.de. [2003:cb:c707:8f00:43b0:1107:57d2:28ee]) by smtp.gmail.com with ESMTPSA id v6-20020a5d4b06000000b0031f82743e25sm1344399wrq.67.2023.10.31.05.03.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Oct 2023 05:03:54 -0700 (PDT) Message-ID: Date: Tue, 31 Oct 2023 13:03:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/9] variable-order, large folios for anonymous memory To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230929114421.3761121-1-ryan.roberts@arm.com> <6d89fdc9-ef55-d44e-bf12-fafff318aef8@redhat.com> <7a3a2d49-528d-4297-ae19-56aa9e6c59c6@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: cremcfytab7qa49myoo7nxud4twbitj5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9DC1B120015 X-HE-Tag: 1698753840-527912 X-HE-Meta: U2FsdGVkX19FEntBo4JNSMIHvJUuiknyt48S1yYTx8bmlJhpoH2JmJ73yDAFMfTRYzdlYyYCUs/1jt0dqK4Oj4CmGG94firxtEOGO/DE4dPYinf6KthSjp5EOHXIiVLtXILc2vUMnsGw48nY5/0Ckp8+xIgM8bpO1EHnFHiwUSY93Yub00zptjPNQiJaU0hIO4ZpuWQGrKzohzs5zsBUQOQb/3MZ5mgnhiJdXxzPNURRwUnE5L5B/iWfbn2hXGMBdN+N7aNU2kJFcl22k+5StDQulQkpxK6C32mlpMWrt2i/djgA+66MQULn6byKx8RlCC+/AszOAfdwL+1Uja6eCh8TSdElUdbrJvxLVhwSQx/GDQeEemNGGfyo7nmMX7RR+05kWMwFEaHrinUU4t9pjQlhdUvUIOGBNQgpqugVEqjc54FHT1becfoCVkMMrV7YH90p7q58lC43QFXpT70X6yDH1qet90AOTlIxy5Kf4yAfk3nOvGEf7x/gs3qmGnXXl/FkDoIgXNwSX1Y2nzKCXfIX0T7Gw1hCi11ipwcsG/V2CU8yg7YJ7ysWebgTSizrdeYoI154fjeAMG8mTuQA6aBqtedg9exNRG6oQYZ9xUhc20X/Z1U3qQDULw4ptUnf4eOxH4ENLsNmZCQl4IjF4lTR5Fj25klBX+ZU1x5/FgJYD5TkCiXORbnv91omG8BC2PXNNl3Wb79NpalkfwjRm0hrV0VdBjUVJ+bdsyENrSCJpKQYvuLjm1AALMPrJwIYOP9MnqYBj6EuSaUcsRwaj/VrzmroHO7J/jwaPwwQ8Vw0UMlWM1KCxiwFF+ClWupHiY3vdsApifruZXKoLqQnNT2SgPX8Q7cS/g9nGcyT1OBCb8ssCA7/PrTU7bBzJAdnA9RT1zWmBByfRPUwUltG7pnJwEHbc2TE8G6yNsHbORY+fjneAaCGJzPPxR/hwwwW3Jt0lBZUszBPs4uJQhK 0Eu5OtPi FMrtkQ7dhl84e6bjZVngeb7wFqco6kMBxf2rkPgJtOx0C4ZobEnpz3u9kf1WSLewF+UF68SKPPYVk01cZWP/We1RvNy6OrujtMrD9xqgF+RI7YL4JBPDjF20CqVMF/TztWiCXhcE7zw4rQ+jpvpmPIG7eLVPyl/tEl5Yvj57J8slvuIiCs3+VAvrjJFt1K+2UGQzUGDqlXr68e7NSmAs5T0BRbnxVDiCqFGEmbJyoWocBQ5qn0VD2tjoZnHmMp37qKxD3OP4XL8/0lnULZa+7l87JJEkCTc6NTGifKOwYqB3pK7C9wkcrPGPeIH8DGsg5c1KxHfbULBqMyrIf1ESkDKmyhR7zHeZsOM8MU8NPb7Vn9IRgk3k/yomqwSibObLLvRDYrX2d5O8SXG8VsmtgLpfsfaD1GzS8Gctq7jPAWM3XK2XbV7sXVXdVpteFTZ3yTGGYiPwnDtR4sAAxG13/BL3rYskkCwjeTLZ/1jae9vSFRIAtmiBprnJ4zw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.10.23 12:55, Ryan Roberts wrote: > On 31/10/2023 11:50, Ryan Roberts wrote: >> On 06/10/2023 21:06, David Hildenbrand wrote: >> [...] >>> >>> Change 2: sysfs interface. >>> >>> If we call it THP, it shall go under "/sys/kernel/mm/transparent_hugepage/", I >>> agree. >>> >>> What we expose there and how, is TBD. Again, not a friend of "orders" and >>> bitmaps at all. We can do better if we want to go down that path. >>> >>> Maybe we should take a look at hugetlb, and how they added support for multiple >>> sizes. What *might* make sense could be (depending on which values we actually >>> support!) >>> >>> >>> /sys/kernel/mm/transparent_hugepage/hugepages-64kB/ >>> /sys/kernel/mm/transparent_hugepage/hugepages-128kB/ >>> /sys/kernel/mm/transparent_hugepage/hugepages-256kB/ >>> /sys/kernel/mm/transparent_hugepage/hugepages-512kB/ >>> /sys/kernel/mm/transparent_hugepage/hugepages-1024kB/ >>> /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/ >>> >>> Each one would contain an "enabled" and "defrag" file. We want something minimal >>> first? Start with the "enabled" option. >>> >>> >>> enabled: always [global] madvise never >>> >>> Initially, we would set it for PMD-sized THP to "global" and for everything else >>> to "never". >> >> Hi David, >> >> I've just started coding this, and it occurs to me that I might need a small >> clarification here; the existing global "enabled" control is used to drive >> decisions for both anonymous memory and (non-shmem) file-backed memory. But the >> proposed new per-size "enabled" is implicitly only controlling anon memory (for >> now). >> >> 1) Is this potentially confusing for the user? Should we rename the per-size >> controls to "anon_enabled"? Or is it preferable to jsut keep it vague for now so >> we can reuse the same control for file-backed memory in future? >> >> 2) The global control will continue to drive the file-backed memory decision >> (for now), even when hugepages-2048kB/enabled != "global"; agreed? >> >> Thanks, >> Ryan >> > > Also, an implementation question: > > hugepage_vma_check() doesn't currently care whether enabled="never" for DAX VMAs > (although it does honour MADV_NOHUGEPAGE and the prctl); It will return true > regardless. Is that by design? It couldn't fathom any reasoning from the commit log: The whole DAX "hugepage" and THP mixup is just plain confusing. We're simply using PUD/PMD mappings of DAX memory, and PMD/PTE- remap when required (VMA split I assume, COW). It doesn't result in any memory waste, so who really cares how it's mapped? Apparently we want individual processes to just disable PMD/PUD mappings of DAX using the prctl and madvise. Maybe there are good reasons. Looks like a design decision, probably some legacy leftovers. -- Cheers, David / dhildenb