From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF7EEC4829A for ; Mon, 12 Feb 2024 02:00:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B50666B006E; Sun, 11 Feb 2024 21:00:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B001A6B0072; Sun, 11 Feb 2024 21:00:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A166D6B0074; Sun, 11 Feb 2024 21:00:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 931AA6B006E for ; Sun, 11 Feb 2024 21:00:50 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 64EE0A0938 for ; Mon, 12 Feb 2024 02:00:49 +0000 (UTC) X-FDA: 81781498218.27.3488CF9 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP id B991A4000A for ; Mon, 12 Feb 2024 02:00:46 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707703247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ky0Zs4VZOUMFAlfL9lg8Xsh6o3CkG3kYccx+L1xGrlQ=; b=tIolfqb2MwaTMgCb+Xi3ZFKdDCFjPwxhrmOL7mmPy1YXsR6kPBjt0A+3zP2JaylBE4g0iW qWMg9jkun5IzfMQ06/CY0GNifcInngBbd2jqNC74vZLd/dyQCUleYRYsxsgcVLJ8WuKTgx vAP77ijCyfkPAJguTBcZuxJhBpSPcNk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707703247; a=rsa-sha256; cv=none; b=qmRZoO2vgYAEAm9+6lzzw6Td5yPdf2GfgDVqm+S5+AselBEUK5s5c8lMBWHNj+qh891hEH iRQ4ypR+KxBgf+eR90xafHCsuVN+11YAVS32BOfAbGhwRlSGuea8w0YEWh4Pv9zS91n6Qk kneh5uz2/iJVQ1fypR4GkglY7AKlPes= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22A1BDA7; Sun, 11 Feb 2024 18:01:27 -0800 (PST) Received: from [10.162.40.23] (unknown [10.162.40.23]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0AA2A3F762; Sun, 11 Feb 2024 18:00:43 -0800 (PST) Message-ID: Date: Mon, 12 Feb 2024 07:30:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Anshuman Khandual Subject: Re: [PATCH] fs/proc/task_mmu: Add display flag for VM_MAYOVERLAY To: David Hildenbrand , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20240208084805.1252337-1-anshuman.khandual@arm.com> <20240208124035.1c96c256d6e8c65f70b18675@linux-foundation.org> <2e7496af-0988-49fb-9582-bf6a94f08198@redhat.com> Content-Language: en-US In-Reply-To: <2e7496af-0988-49fb-9582-bf6a94f08198@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B991A4000A X-Stat-Signature: ipreksxfo7j7qobrjyoiwu76tmod49db X-HE-Tag: 1707703246-295377 X-HE-Meta: U2FsdGVkX18WXkecjxv/D5FsX7AkH6GeF5tzpQUS3dCRJIEwsBXhvJq2rkSnLFyTuxlUsTZVH0NAcH8hdKXD/0GHFh6vgcuXcXct2ubYTN2AzSz+9NHG9/2rn2D8Kx7Hb9Zhy1B/JCaBBU5v9GpAXc24cxR2IaUnUAGlmwhSDEBF6YY4wT5jEIC8dLc5qIYl4hTVPfcPG62sbHqbdCSU2qQaoINChcxHhF7Y77crkSA0edk3qHcx7j6mTGChuCcc2CFh5Lm4MMw1iS2n78o7AjWgdAVC7CKPFKoErzYQjCAgGijTIUfC6Z37UgA2S7xG8LEFszGwSGdnHQQaqYro1e9QCrReURAsgeLIjkW+y10eEaQjjSmYqnmIj3eQXPpfx/rYWu8Qr/d+JgvJvfKWZ9bM3JwDrRErpp6L0/qHPNds/ScgzFq0eJ9xLSNFCBg2Mep2yvvm1WQMGyA+HGjn8V0BLAWiHpL6g1Egcg+ZFT9xrJYWT/B5rLI/BmVNXWzUsckZf+b7jwxpVVIu5KYfsqw3ooh05PLwZa4Wx2aFRKCOTpm3IQW9vpi2/amPyzwNgzsUuBQMe6TRE+vzA5IbNcPlC3dfOYXRYPLqmzPl+4kM1yfMF29uxY36YR8IIfE9PEy72zq4qLJZ7Q++ErYIj/lohTtSXyx5BZkDV6YZnbQagsHXdU3NizF1iVrMo+fY5y2lWo955BSKcwCGLza8b1Ym2JEvdIT8p2Nu/MJbC3dDlQ+s0gHju2kyyd0PBjdTy7sI/QUIy84h2vAcGAWrKkJT5GYprGMQ57W+3ZSmvTeX9gEjcdbnlNSFCrj10rhAB486WLdDWWA/y7jLq0U204eKib2Z0nWJOMLY1kr6YpVv8jcJVbVzK4z3N6bwX9+c3Sup+BG5ilI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/10/24 04:01, David Hildenbrand wrote: > On 08.02.24 21:40, Andrew Morton wrote: >> On Thu, 8 Feb 2024 17:48:26 +0100 David Hildenbrand wrote: >> >>> On 08.02.24 09:48, Anshuman Khandual wrote: >>>> VM_UFFD_MISSING flag is mutually exclussive with VM_MAYOVERLAY flag as they >>>> both use the same bit position i.e 0x00000200 in the vm_flags. Let's update >>>> show_smap_vma_flags() to display the correct flags depending on CONFIG_MMU. >>>> >>>> Cc: Andrew Morton >>>> Cc: David Hildenbrand >>>> Cc: linux-kernel@vger.kernel.org >>>> Cc: linux-fsdevel@vger.kernel.org >>>> Signed-off-by: Anshuman Khandual >>>> --- >>>> This applies on v6.8-rc3 >>>> >>>>    fs/proc/task_mmu.c | 4 ++++ >>>>    1 file changed, 4 insertions(+) >>>> >>>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >>>> index 3f78ebbb795f..1c4eb25cfc17 100644 >>>> --- a/fs/proc/task_mmu.c >>>> +++ b/fs/proc/task_mmu.c >>>> @@ -681,7 +681,11 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) >>>>            [ilog2(VM_HUGEPAGE)]    = "hg", >>>>            [ilog2(VM_NOHUGEPAGE)]    = "nh", >>>>            [ilog2(VM_MERGEABLE)]    = "mg", >>>> +#ifdef CONFIG_MMU >>>>            [ilog2(VM_UFFD_MISSING)]= "um", >>>> +#else >>>> +        [ilog2(VM_MAYOVERLAY)]    = "ov", >>>> +#endif /* CONFIG_MMU */ >>>>            [ilog2(VM_UFFD_WP)]    = "uw", >>>>    #ifdef CONFIG_ARM64_MTE >>>>            [ilog2(VM_MTE)]        = "mt", >>> >>> Reviewed-by: David Hildenbrand >> >> I'm thinking >> >> Fixes: b6b7a8faf05c ("mm/nommu: don't use VM_MAYSHARE for MAP_PRIVATE mappings") >> Cc: > > I'm having a hard time believing that anybody that runs a !MMU kernel would actually care about this bit being exposed as "ov" instead of "uw". > > So in my thinking, one could even update Documentation/filesystems/proc.rst to just mention that "uw" on !MMU is only used for internal purposes. > > But now, I actually read what that structure says: > > "Don't forget to update Documentation/ on changes." > > So, let's look there: Documentation/filesystems/proc.rst > > "Note that there is no guarantee that every flag and associated mnemonic will be present in all further kernel releases. Things get changed, the flags may be vanished or the reverse -- new added. Interpretation of their meaning might change in future as well. So each consumer of these flags has to follow each specific kernel version for the exact semantic. > > This file is only present if the CONFIG_MMU kernel configuration option is enabled." > > And in fact > > $ git grep MMU fs/proc/Makefile > fs/proc/Makefile:proc-$(CONFIG_MMU)     := task_mmu.o Ahh! you are right, completely missed that. > > > So I rewoke my RB, this patch should be dropped and was never even tested unless I am missing something important. Fair enough, let's drop this patch. I found this via code inspection while looking into VM_UFFD_MISSING definition, booted with default configs which has CONFIG_MMU enabled. But this was an oversight, my bad.