From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82877CD11DF for ; Tue, 26 Mar 2024 23:03:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F03296B0083; Tue, 26 Mar 2024 19:03:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8C6F6B0085; Tue, 26 Mar 2024 19:03:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2C6F6B0087; Tue, 26 Mar 2024 19:03:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C05BA6B0083 for ; Tue, 26 Mar 2024 19:03:10 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8F688A05B0 for ; Tue, 26 Mar 2024 23:03:10 +0000 (UTC) X-FDA: 81940717740.02.C1CE12D Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) by imf02.hostedemail.com (Postfix) with ESMTP id 8F8CE80019 for ; Tue, 26 Mar 2024 23:03:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=codeconstruct.com.au header.s=2022a header.b=eIfMHGsP; spf=pass (imf02.hostedemail.com: domain of andrew@codeconstruct.com.au designates 203.29.241.158 as permitted sender) smtp.mailfrom=andrew@codeconstruct.com.au; dmarc=pass (policy=none) header.from=codeconstruct.com.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711494187; a=rsa-sha256; cv=none; b=Xql4AdLEuj/6pGFvwTqzPcE0JKMKQMQ0hW87xo+ZmhaCmpXa01wos+y/EIZkYCakK5YJDH WaogbKWoTYtKFEGcFIkW5cWEJI71kI3k+AiWxDsW2+zq6nbxRiraudfNAf4eJ3ivdWRmL1 0AVWPKuyKUxxvGFivcddjpv3zaHxTfA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=codeconstruct.com.au header.s=2022a header.b=eIfMHGsP; spf=pass (imf02.hostedemail.com: domain of andrew@codeconstruct.com.au designates 203.29.241.158 as permitted sender) smtp.mailfrom=andrew@codeconstruct.com.au; dmarc=pass (policy=none) header.from=codeconstruct.com.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711494187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tz3fNHh1K/JnaN3rWzXOsduTzNNjTpy00qDhmUkVo8k=; b=5RMpBEjD4zxTQBDX11C2sTYueRWxk1uV0imDccSXTOWOg+5J3scBtqwiPdSoe2qvCbgo7g 20J/KNtSdpgVTnEP2W1KjOA1hfioZdfCYKQ5hl24FBWZxENWwpnuft8Sz+O4BXlluKwwXY EfH/HYF3SmUEpMn8NQBwHdrvw9817C4= Received: from [192.168.68.112] (ppp118-210-177-226.adl-adc-lon-bras34.tpg.internode.on.net [118.210.177.226]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id DC391200DB; Wed, 27 Mar 2024 07:02:56 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1711494183; bh=tz3fNHh1K/JnaN3rWzXOsduTzNNjTpy00qDhmUkVo8k=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=eIfMHGsPNwHmXwNNstH9IMj4w2lyPGURp6LMbwLrjHmlPyWfu99sWNZIhMk2gO6uz RgeTjJOiQM0pv47zQxIswraW0rFx3ZPiwJSHKORRHDpqe3US9RXTYofm+LfhboiiTX 0/2nDinsXDMjMsSQxs2l6/VHxtwFkD9IKm5EvxniqkwLV0JMXkRE5RjbJG83+NbtCN qcam/A+94EU+rkbVi8UIoPMWSMl+z844LZNWJnywiVy85Sxc2rC3fDh+0d1MeyeTmc pAYFOzZm0LtzVIwBEgEJ5JYODCCsjCp/BnFptrq5B4iieSj8Tq3llCMFTW9l5/tOpw Z5xqzSAoUof7Q== Message-ID: Subject: Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent From: Andrew Jeffery To: Arnd Bergmann , linux-kbuild@vger.kernel.org, Masahiro Yamada , Harry Wentland , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= , Jani Nikula , Lucas De Marchi , Oded Gabbay , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jakub Kicinski , Paolo Abeni , Linus Walleij , Joel Stanley , Alexei Starovoitov , Daniel Borkmann , Andrew Morton , Nathan Chancellor Cc: Nicolas Schier , Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev Date: Wed, 27 Mar 2024 09:32:36 +1030 In-Reply-To: <20240326144741.3094687-2-arnd@kernel.org> References: <20240326144741.3094687-1-arnd@kernel.org> <20240326144741.3094687-2-arnd@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8F8CE80019 X-Stat-Signature: sx4yocabsgmw5i6qz8c87yfn4juy8esp X-Rspam-User: X-HE-Tag: 1711494186-299325 X-HE-Meta: U2FsdGVkX19fwtqTWqbvFhk3iOgaMErEPd0phmXK2ucDfjmxJ1N8Q/yl7QUzV5SkgDBOzBSGnh6KhJBHoJmTydJfXxfkI1UJgZVw3azwKSFTV86LNhPO5zvl9qcG1ofQY2ir1jbcVeelyZF6yyaYw8ZAgcoq8nROYPmfm5TsB/OLrJ4T3aKSiaioQ3YpmhE6uNIbutzdlHuw+7Y0E6B3uyHwrVnSrfe9XD8xvNIJZhedg/nK4GIGV503X+u9YNQYGqAmAwrqblR4ItgTBv9A4sglQCVyow2lZMJTa/chCfzSFvnJ3wG1Gx9I6Jaf4ipdh65JJodzL7tUrD5N7TLLWgxUDa+Q/BWYOzUq80OBfq6lbLfI3+kFO4Ix6q938ntU4irgRzXFDhClh7p6wIuUkoNcizfkwBo0ZWePi5BgaF4NuTs7Q9N1Eh6K1FvoEUOkBFxn8MSNc1ZXhujvRmryaPgbwlsLdcT0J8JbS1hAZOi5LWD5psAs4A606Ey4nF+EF7/TFmWqmjDIs7e+dRBPQzgvhLw7Fb7KcM0eHD6h1ZnqGx/5WFuiY4BX9CBwThFldojMpXgqPB6j/AqHgavHODWAMh8CaL3p2hO4A5D16fko4jqBOq0Gn3G05sV8kCcSRXlBUBqepkLJvzIBhmUvN//km/CXiGJ1mHzKlZcFGiiszcNJRcjjHb56fnWc/Z12b9pwRp1IeTh7ptZQdJjDreekyqKrBGnaNVJUhllfJzU2bmBWSJ/y6Fxn3r0bv8ZukXbVJ4ZFKhPfJTXMgfY7zH+9Xcf8czzgWACItF9nFUkSjUfZy2IEnnYsIYRAHQFnpKqWRFdpEjYG4CsRgJG1RSkVvWwM/73Llt4/FtLrvYKHkp5k6ee1T0rh5HvfMaPr5mTawDxokte09khtYMTgVW+okawp5fQWUm5ElvB6+0GJs5b6bSBR1UCPAdShbQRM6fP4HW3WwSrSPIIUCmh B9nzLCtI 99khnsQD8QZDQZRKxt46GEr6+a9cG0+hiK6mNJZgIjtbK1WJppkCzr8C27NXgBJgdb5tmwgbluDhW2Sp5QCsf8U/gOrQLZaBOSgrEyq6xvneSrefZQoK3SOWrMHZztnmH1iumbRaL9ufl0/KbfCo/rKD7Gbe7NYwrsV5kkN51xGl+BWxnhJYnQ+ze7sLUEAxorWOvthVFF401o+RhVPDSAU2qtKeUsPEnwIvhBr0RSKjKr8FNVkhm9q50+xmcm620EM/1Ldvksata104x96qriTY2WEG62NRmwFGN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2024-03-26 at 15:47 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann >=20 > The -Woverride-init warn about code that may be intentional or not, > but the inintentional ones tend to be real bugs, so there is a bit of > disagreement on whether this warning option should be enabled by default > and we have multiple settings in scripts/Makefile.extrawarn as well as > individual subsystems. >=20 > Older versions of clang only supported -Wno-initializer-overrides with > the same meaning as gcc's -Woverride-init, though all supported versions > now work with both. Because of this difference, an earlier cleanup of > mine accidentally turned the clang warning off for W=3D1 builds and only > left it on for W=3D2, while it's still enabled for gcc with W=3D1. >=20 > There is also one driver that only turns the warning off for newer > versions of gcc but not other compilers, and some but not all the > Makefiles still use a cc-disable-warning conditional that is no > longer needed with supported compilers here. >=20 > Address all of the above by removing the special cases for clang > and always turning the warning off unconditionally where it got > in the way, using the syntax that is supported by both compilers. >=20 > Fixes: 2cd3271b7a31 ("kbuild: avoid duplicate warning options") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/amd/display/dc/dce110/Makefile | 2 +- > drivers/gpu/drm/amd/display/dc/dce112/Makefile | 2 +- > drivers/gpu/drm/amd/display/dc/dce120/Makefile | 2 +- > drivers/gpu/drm/amd/display/dc/dce60/Makefile | 2 +- > drivers/gpu/drm/amd/display/dc/dce80/Makefile | 2 +- > drivers/gpu/drm/i915/Makefile | 6 +++--- > drivers/gpu/drm/xe/Makefile | 4 ++-- > drivers/net/ethernet/renesas/sh_eth.c | 2 +- > drivers/pinctrl/aspeed/Makefile | 2 +- For the Aspeed change: Acked-by: Andrew Jeffery Thanks!