From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B73F3C6FA81 for ; Fri, 2 Sep 2022 08:42:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 070CF8D0015; Fri, 2 Sep 2022 04:42:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 020468D0014; Fri, 2 Sep 2022 04:42:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2A5B8D0015; Fri, 2 Sep 2022 04:42:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D39328D0014 for ; Fri, 2 Sep 2022 04:42:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E9651C66DB for ; Fri, 2 Sep 2022 08:42:53 +0000 (UTC) X-FDA: 79866505026.09.F078990 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 3865BC004C for ; Fri, 2 Sep 2022 08:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662108172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1zJot1sbctL/r1rOpAyGprgdV7lZzSxC7o857qrNS3g=; b=R+dAHjorODAFSBqEfqhBEI+M2bsRy9ikX04ifbJmDip8KVebiVA5nDVtA6B2Ok/0IY040a NVeY2VV4v8hqTa/huKUvMfnwfNQxowK95YDdVlhJv/ooaUK+KE4yesBw5oRpjo0YVA/FGc rOs5z9R+WTDLztGMFnK4Kk8hOWcDqK8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-588-inA9qq-VOYaC_-GMda_aog-1; Fri, 02 Sep 2022 04:42:51 -0400 X-MC-Unique: inA9qq-VOYaC_-GMda_aog-1 Received: by mail-wm1-f71.google.com with SMTP id q16-20020a1cf310000000b003a626026ed1so394498wmq.4 for ; Fri, 02 Sep 2022 01:42:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=1zJot1sbctL/r1rOpAyGprgdV7lZzSxC7o857qrNS3g=; b=5wkC/QrDYD/MnSu2yXByBt2N132lITQh3XRtDav7Q4MDVQDMiOJAejKLi86SRPFX0A mHNMf8SGINCllM0TF/FhoBJY/xU1wDPmptgilBCKvY+r/kBxSxr70K9+r+HlevYROa/U yrWNjJ2ME/GDyOFYxM1bT5eVP+hHW2+ywtNNEdCuxuRrp7IcIGMkWNooJoRK72NrvNhz 8TWoJNN0nQIhYbzvmT3rOEpzqNuIIavkqhyJTGaWikNn9FhCaksw9FrWIGFaJYVQsp0D Mc35TgGsH/aNBQQtLDAXdhIW9XzzJXi/ZYHCJSKAB1vPS4373w8YZaMp6mzvkL9wP3Lo WXog== X-Gm-Message-State: ACgBeo0CD7ad/xX0pCQqDyWy5h5WKv+J/bjTwqjgdvib+uYkQcd3s/8R ubULyGwAlpf3lwc+7xIlmIE7lnv+wJl9+pOW0SvsZdJA59W3+T7jM9PbkUhNMqJ6KdP4hLBQh1Q 9no/7xuYX5cQ= X-Received: by 2002:a5d:6248:0:b0:222:cd3b:94c8 with SMTP id m8-20020a5d6248000000b00222cd3b94c8mr16997915wrv.97.1662108170132; Fri, 02 Sep 2022 01:42:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR6eEem5pJpyAX8xVTLKir5GJuvqD1/WeFXYRXR9FWghtwikjyK7S9Pxai2VdDN3dVZg35rw1g== X-Received: by 2002:a5d:6248:0:b0:222:cd3b:94c8 with SMTP id m8-20020a5d6248000000b00222cd3b94c8mr16997905wrv.97.1662108169923; Fri, 02 Sep 2022 01:42:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c714:4800:2077:1bf6:40e7:2833? (p200300cbc714480020771bf640e72833.dip0.t-ipconnect.de. [2003:cb:c714:4800:2077:1bf6:40e7:2833]) by smtp.gmail.com with ESMTPSA id l20-20020a05600c089400b003a30fbde91dsm7315866wmp.20.2022.09.02.01.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Sep 2022 01:42:49 -0700 (PDT) Message-ID: Date: Fri, 2 Sep 2022 10:42:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Kefeng Wang , Andrew Morton , linux-mm@kvack.org Cc: Mike Rapoport , Oscar Salvador , linux-kernel@vger.kernel.org, Vlastimil Babka References: <20220902064751.17890-1-wangkefeng.wang@huawei.com> <20220902064751.17890-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 2/2] mm: add pageblock_aligned() macro In-Reply-To: <20220902064751.17890-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662108173; a=rsa-sha256; cv=none; b=U95lEOY03JTbzv8Gyp7ktdB3nAbd5vu+pUbSGvNigcYJbLCnhjTZYhgjZvgFJmu7OcM8iB a0zoVkyM/mXeMAoZZzY6xJIPWlrpxwX7QwKN2ytAmM/wjCD205U3hVR8MRnHJGrrEngHDq CYhU4H3BecuCeHoCnwXnTeWJOHBQafs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R+dAHjor; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662108173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1zJot1sbctL/r1rOpAyGprgdV7lZzSxC7o857qrNS3g=; b=pSNMT1RBdKXmgdw23T60TxxMhTw3av7f+VyiwS1ThjTcefcmCtjAleAJ7Iq3wvxufY/6K0 D86+sgSBK+mKnChRvUUL68OOY3CHa826gjMLmu+6SnryjNKT3bUcghutCyP32+D88OCmsh iNqJcrhxxEhCXZtdIEFV8agBIT8/NxM= Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R+dAHjor; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3865BC004C X-Stat-Signature: wnke89zq4jmuakdu43adidoy9ycxpa53 X-HE-Tag: 1662108173-967189 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.09.22 08:47, Kefeng Wang wrote: > Add pageblock_aligned() and use it to simplify code. > > Signed-off-by: Kefeng Wang > --- [...] > - unsigned long nr_pgmask = pageblock_nr_pages - 1; > int nid = zone_to_nid(zone); > unsigned long nr_pages = 0; > int zid = zone_idx(zone); > @@ -1977,7 +1974,7 @@ static unsigned long __init deferred_init_pages(struct zone *zone, > if (!deferred_pfn_valid(pfn)) { > page = NULL; > continue; > - } else if (!page || !(pfn & nr_pgmask)) { I didn't sleep too well this night and am tired, please tell me why I'm wrong :) "pfn & (pageblock_nr_pages - 1)" is true if the pageblock is not aligned E.g., pfn = 1, pageblock_nr_pages = 512 pfn & (pageblock_nr_pages - 1) -> 1 & (512 - 1) -> 1 & 511 -> true "!(pfn & (pageblock_nr_pages - 1))" is true if the pageblock is aligned -> !(true) -> false However, "!pageblock_aligned(1)" = true > + } else if (!page || !pageblock_aligned(pfn)) { So shouldn't this be "pageblock_aligned(pfn)" ? > page = pfn_to_page(pfn); > } else { > page++; -- Thanks, David / dhildenb