From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B94C7618E for ; Fri, 21 Apr 2023 14:41:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 938CB6B0071; Fri, 21 Apr 2023 10:41:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E9526B0072; Fri, 21 Apr 2023 10:41:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B1D76B0075; Fri, 21 Apr 2023 10:41:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6D10A6B0071 for ; Fri, 21 Apr 2023 10:41:24 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 99CC21A043A for ; Fri, 21 Apr 2023 14:41:23 +0000 (UTC) X-FDA: 80705661246.25.3650DB0 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf02.hostedemail.com (Postfix) with ESMTP id 7986080009 for ; Fri, 21 Apr 2023 14:41:21 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=akb4FBXO; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=G6XCCAdL; spf=pass (imf02.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.28 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682088081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cqrMn8PsCijMPIlumhaZUxmJD7Z0ZbjGhB78P+4Vmns=; b=PuIDGXEOcnPZzCfuF42aHEbybq51N31lb50GUWVgnaC7Zh7Odi4UxIzSl2Uv2PyDgZymay DSQpTS0OWtFEoKSh3IgL50Lh/89nodD6aI33bJdKoVKGZnpL7ZFX4DBBIsCMEFxgAkvKCX OwE95AZh+c+cAaAOF2A0YjrC3pX+Ipo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=akb4FBXO; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=G6XCCAdL; spf=pass (imf02.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.28 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682088081; a=rsa-sha256; cv=none; b=pY+dZrQfoZuEnmyQwHO/al1ADYDrI1At/bFD+7xJRBMaD8H6DftS9N5u9CYcBBUOBBn1wj eRdklwh9ngFg7T+nj03xeOpVOE8LS2GOAQrUWWWExCz1NCZV4QMR4x2gqyotUdahgSTqjw iucnfRpQmz2V0cpgqAK0h0f83ZWGDFo= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 960845C00EF; Fri, 21 Apr 2023 10:41:20 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 21 Apr 2023 10:41:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1682088080; x=1682174480; bh=cq rMn8PsCijMPIlumhaZUxmJD7Z0ZbjGhB78P+4Vmns=; b=akb4FBXOUltQS9C51W CAlL5PsoRAwGkhiHte9fOEElovSGT9cbvRFp3vnXtWH6toqNPKegFa+DL4ae6xc7 de4ceYIUYA9KoiAOmbC3o87Mh7yalbrMrbL/ZpRjzChbbrowalzd+DNh5OntyEml lP/cm4Sk7AlX7jbJPoy8thnkm9qtGaQHxBNWS0CK7vAE76M1y7tLkiCDiX++oOja Z4QIq+P1kzvG/BzKVvl+0JtYTL+tJhdnDvrMqS8nynDJMRDhsEpt66sNIDwNClH8 r1e373iYsd0DdrnLle+5dpGLgR43H3Lk0n1PVj+2KfvFRJEs/zhr3c2ig+Zi5vSh 0oLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682088080; x=1682174480; bh=cqrMn8PsCijMP IlumhaZUxmJD7Z0ZbjGhB78P+4Vmns=; b=G6XCCAdLgtdkZkw7orITZX0IzE9GZ WcH8E1cj85JZpv5HyffbFT1ON/uxV6PMvapLE40KV+r/6SB0w9qFMff6V6fVBbqu KiXoyWcK/+Fvrisn79tl1/ufzgk5wWE8XR71LCH/5swWZ22IaqLD77BO2HILlb7+ AMKrz+GuwKUF/ae1doH722b5YaqQmQ14WKKKEoBNFQxlB9Ju8686KTzGH/lkrQfy /M3fheBSMdjikXG1FtmlAI/PiEU8gGmE9qGY2w4/DF/H2fm1hZciRnlg3sgRw4l5 QIk1KGGqowWiyLOmOmhImVI2gCRKTagrDXlprRd8SxllwkgMUyZwkhY5Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtgedgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id C7BB7B60086; Fri, 21 Apr 2023 10:41:19 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20230421082026.2115712-1-arnd@kernel.org> Date: Fri, 21 Apr 2023 16:40:33 +0200 From: "Arnd Bergmann" To: "Marco Elver" , "Arnd Bergmann" Cc: "Andrey Ryabinin" , "Andrew Morton" , "Catalin Marinas" , "Will Deacon" , "Alexander Potapenko" , "Andrey Konovalov" , "Dmitry Vyukov" , "Vincenzo Frascino" , "Mark Rutland" , "Kees Cook" , "Ard Biesheuvel" , "Marc Zyngier" , "Matthew Wilcox" , "Vlastimil Babka" , "Peter Zijlstra" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: Re: [PATCH] kasan: use internal prototypes matching gcc-13 builtins Content-Type: text/plain X-Stat-Signature: ytoaieaenm4tpcuzy1ohky1n39agw7us X-Rspam-User: X-Rspamd-Queue-Id: 7986080009 X-Rspamd-Server: rspam06 X-HE-Tag: 1682088081-662931 X-HE-Meta: U2FsdGVkX19+qBkOD4vFZP6SEGIkXqS2tDfnI1ymne1KD1UvMBcduzPVgMkYc2vMaxwDKP10vj6JzLcmhAPIxIuvgnwPVuo/30PflcIXwT7kpMRYCBNKYNzStgrTmko1mEeZAztlQvnhDropW9zR4mv++uMxY5mkgBt3ONiHtMA5EhQrnzAX2k2o89sqBNDnpG0ElBeof5kH/zDQPanAAIfVSmSE2RaSVdP43WMQb/5dC7xBrx+bl2DhUw2q/fVmYkY4AVwKEp4NrWy+9sEZBpXzaPzl6jXgKNEDjcKKnaSvmZ9052IsDHYWsYFjy7YNJPFvtTP324ZDK2GTFhiNSsByBkyfjxIY0vaReycIodDlOWq5dq3gME/S5rSAHuYVednL7GlBVYEoZKFja+VEcx6KhnHLAb8vTgyDUz5dfc5718npBq+YTOcLSQYe84bCwodlxK4gc5Rc99yDG94acpaLmms/m6BG92LTIRbC2i0DVc5iEd7f6NLe9U4YUkpyFpscw21OeE6quBsulOX93WbfNZvc/r+qJktDr868j9P/ykPZiSaeaUkTGHYtaXHKtZI0715ssWzHHGsvRDxQ2N1cG9ww/0zyx6xSXm75UZ1axOoDasF0PzCNAbFKOFoshGLw1Kzwn6hlmZ1YxiPEyS+3dQNcxl5cq21T0lXjqNhb2YPO7RzVaS8Lk9UJAESIdE/QUNp0zyPcuLTVWDYja5AoTVKmCxM3HLkaG/sDis6iEsSMfFm+YO6ZjUrJ3+NO9ts8J2gvQDBXS6oZNM1jSNSikwC5QAaiPE92ReoIjgbYG5tUR5b6Z/DP7NY4ND3ef0jF4pAsounXB/XVGslb2/CjXQuqwoi1cDhbfeTK901ca5pOt/h52FWYo3NdsN37xRzKcm38GUykJo4SwhvwefeWSFFpHvLi6xN9d6hMpUboqchYE8d77luUvE4QqUTymd8Z0axXWaHvX9/jDgQ qJ0mzThb YVB7fVbCsNECAEU+E7G7LnlLQMGPtqh1g+jkrlNYgtRb3Jh5BDf6/9Ar2il92/zF7T8Hh11DDSk9+BZhMxwMc9ehaH+AEP0Gp1gdPLKviJmcn8VQPvYQ+gbpE76BvGbAjLEWSE8pHznNs/yztu+U0a83MDvzqDYujXpCInpVSQI22BGFfCxnA6PXybvbBE0txgmhPSW8gEdXvwhw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023, at 11:19, Marco Elver wrote: > > Does it work with Clang? I tested successfully with clang-16, but did not try other versions so far. > I don't mind either way, but the custom kasan_size_t change seems to > just be needed to workaround the subtle inconsistency in type > definition, but in reality there should never be a problem. I'd rather > the KASAN code just uses normal kernel types and we just make the > compiler be quiet about it. Let me double-check, I think I may have made a mistake here, and using the normal ssize_t (but not size_t) just works right. It looks like I confused the size_t definition with something else, so this hack may not be needed after all. I've changed it again now and will give it another overnight test run on the randconfig setup. > To do that, another option is -Wno-builtin-declaration-mismatch for > mm/kasan/ which just shuts up the compiler, and allows us to keep the > code as-is. Does it have any downsides? I think the warning is useful in principle, at least it makes it more likely to catch bugs if the prototypes ever change, and to validate that things like __asan_allocas_unpoison() that I mentioned are actually intentional. Arnd