From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1345DE95A9F for ; Mon, 9 Oct 2023 16:04:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F6FD8D0084; Mon, 9 Oct 2023 12:04:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A6FE8D0031; Mon, 9 Oct 2023 12:04:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76EA78D0084; Mon, 9 Oct 2023 12:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 675768D0031 for ; Mon, 9 Oct 2023 12:04:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 17DBB1A031C for ; Mon, 9 Oct 2023 16:04:53 +0000 (UTC) X-FDA: 81326396466.09.2852CAA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf09.hostedemail.com (Postfix) with ESMTP id A741A140004 for ; Mon, 9 Oct 2023 16:04:50 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Mr38JGJF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lrC8CBCc; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696867490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DLrtq61I2S0cToZBib/cJSy8l48RNzXOA1hvvbyOcVw=; b=HsC1OKDlSmT2rGlh3D3DS6L2mc9XQdKo0zOB+j308KWnMiICKuPdumf9mCsKVQVNaNNFq3 u5EVn9tZ25Bff+BTwsc3CKeB/diYjf+DRR854HXJE9UcmnA8DIB686cvZrGa+OhE6hvUFf ARtVgtnXmUSkZ+e736EhLWM1y9bOgXs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696867490; a=rsa-sha256; cv=none; b=HAizQlVs7fXpmqvHkpBUxWK0NFwc5crkM/3UyPbPDXzEDY60ZN6hyWfJL5t7plNKm/hWbO CE7HXS0ix4GR35nCMBMJlfNlVivGfsZWmeeKQhOhIJ5cxuraMnFYcq7nd0AvsVAEahCYHo ArF8VxSFto2DBFR64HFayOz/2JbYkiQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Mr38JGJF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lrC8CBCc; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 47AB621885; Mon, 9 Oct 2023 16:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696867488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DLrtq61I2S0cToZBib/cJSy8l48RNzXOA1hvvbyOcVw=; b=Mr38JGJFjkHEHogb8j2ImpDNRltdr68BiPqMf/56ruc2lWi2zb7p4/qD+DxY5DI3VKAhLg UKqSbvdcMd0DjO83e8Em15CdLmueOm8+cfCej5Zl0N/uZhyJYw+wKXfqwXoLcq/OYtpWSE eSlEetIPSwvdOKEb8S41Ns1jgqo185g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696867488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DLrtq61I2S0cToZBib/cJSy8l48RNzXOA1hvvbyOcVw=; b=lrC8CBCcgX71SDRJDSQYJ7pPeh0XnW9UNEjzqMOx9LBdlz26yoCQpqPMba2ZTipx5K91Qh b1AOepPg3X22PCAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2531F13586; Mon, 9 Oct 2023 16:04:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8GpbCKAkJGXkRAAAMHmgww (envelope-from ); Mon, 09 Oct 2023 16:04:48 +0000 Message-ID: Date: Mon, 9 Oct 2023 18:04:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 3/4] mm: abstract merge for new VMAs into vma_merge_new_vma() Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Alexander Viro , Christian Brauner Cc: "=Liam R . Howlett" , linux-fsdevel@vger.kernel.org References: From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: kj8nxmmoxc6uqz4bbihj8pgn5i8xhptm X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A741A140004 X-Rspam-User: X-HE-Tag: 1696867490-144156 X-HE-Meta: U2FsdGVkX1+5TFJmYUFxDatIDPtHQalnW28i8rnDc4Ds6UzrvvayCTsjKzFkM/C7ckI2j6gLtmwUBcvQDkeYvMn+pDSNdV1YNkf3OhsNxLnJzMA9dYat5Gd70VFqeW0Vqk4SOnVn3wargUc2oEWwwrmleNCZKzhNl/oJO2LRayzd3HBQ7AmY4wDj+2FjzZsikDFjTh+huBAa+fWIQ131JRCCBJ6DMqNx/YoHJoSjYHu8O8fX/ZxfLGQMV2esa/DXktRfmpHF3DK82cNk4IYb5OSJyOwMTfuoF1UmQWzc7z0J5buPzL9cmrGYPZUkM+OE/lnxfnqLoLOyM1qIE+IaLMUBTW3nAPhksCZa01j+qUAcIilX/iVZY2mMqMQmZWyVf3poRnLnRY7nRJqf0e8JcglwgfRXPlpTA96uQrpr/6COwxmQ1/Tfh4kzLBNOf0hGFSTF+blwQyMYkyGwr40S+jbzz6tD2WbT03qTtQo/iS3Hjsvt9ldf7Mtql2/HSpgBiyVzOY18vg1LPXagvuoRU4eUhPJhF552Uf2Fi0cBPWObrDe1OyEqWU2bCkYoRZ6zNVQPRuDC7W+JXUvD9BlrGgIXS1OfXdtm7TE1fsnnrgkTuck525RhHfBrizDdexbwKMAES/li8P7LXlv26LJCHrZW+v5vikPGOcUdIzdvbu25AVsOlplohZinlxMaWb7aRwqjG1p8smfMiE2dodtpb+5s36bvWZpUk0/8Tzm3/1h3ZGOhQc121YCtLhOqA//z30ffEJQrLNJPLbFlE7KV+sTIdvvUPuIAGGSTfSV57mx0Ey46JuOTqWohoNHNaemA4bvYuemQ0bP9NLt+nRg58XxH2l4D89Qbd0qfUhMU8SMZEV+WkCzbUOqAkmgZC9R1WMD2ORjTVy3mKRY86QDgHzI9QumtLSeklsRjc+02OkpF4M8D8sMwzMEkjeFTpEvdk1j5bw6pHZ2DVKXdOxD nzoIacwV eM4zTiGenLqwvEV/pkR/G2LJqddBSJxA2bTr1K5K9pxzlDzkWBG4HR+rqZKstUCBvYXpA8oCLgDl79FsrfEm1u2FT1gD4S4ox99QiYmJS+N1elTo0DlzihZOTMgsqDd0BLHKOqeiknoaCFnBH+OYDixfvTFOMUoY55S7xXdwC3K1zbQoQek/q+HDgOcjsih6UKwUiChkxhippvvP0Jhge/Bc2q0koJQUMEri2EV0mNT/i6RF0zGH8FugVBgu47a/Faq3JbDeeiPtFFb4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/8/23 22:23, Lorenzo Stoakes wrote: > Only in mmap_region() and copy_vma() do we add VMAs which occupy entirely > new regions of virtual memory. > > We can share the logic between these invocations and make it absolutely > explici to reduce confusion around the rather inscrutible parameters explicit ... inscrutable > possessed by vma_merge(). > > This also paves the way for a simplification of the core vma_merge() > implementation, as we seek to make the function entirely an implementation > detail. > > Note that on mmap_region(), vma fields are initialised to zero, so we can > simply reference these rather than explicitly specifying NULL. Right, if they were different from NULL, the code would be broken already. > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka