From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02ED2E8784C for ; Tue, 3 Feb 2026 17:23:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CA556B00AA; Tue, 3 Feb 2026 12:23:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 682656B00D7; Tue, 3 Feb 2026 12:23:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 577906B00D9; Tue, 3 Feb 2026 12:23:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 39A786B00AA for ; Tue, 3 Feb 2026 12:23:53 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D646A13B12F for ; Tue, 3 Feb 2026 17:23:52 +0000 (UTC) X-FDA: 84403817904.13.804C488 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf28.hostedemail.com (Postfix) with ESMTP id 1B72DC0010 for ; Tue, 3 Feb 2026 17:23:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bG8ykAp2; spf=pass (imf28.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1770139430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2gqtPihjuX/XM6FNJdgDuZvJBw/sKRlJWVeSPr7iTbo=; b=dgmmLvlWph1eOimDak/WDsrQkjGbJ4aYdf9AZOWH2aPsRIjv7aGMyIN8COGW/sobfwy5gd HZsdfv8YQIiol1uc1EOFs/rpmeGzpjMwr6tayBFgBqgP/rA8N02or4nFd6d6Jt367iCZRz jtSKLQ/jdOt7rmntvlQbtda5DsExdaE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bG8ykAp2; spf=pass (imf28.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1770139430; a=rsa-sha256; cv=none; b=Uq+xT6PlJ3ysw0V8xhDGwVVfZ59BzS9ag9vxbyjOmlqMkyQCfR108QWn6M2QP/ypVxnK00 EhXMuorznEPChcwCqFLjjUTt9EUknv+0tbpjg0S0xjYKg3x9YzozIe/9Oubg9KlW6cvRkX mkMd7pcRiNbmD18WDCrqTBenSReoxSo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770139430; x=1801675430; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=J1w16axMFsOQYxllHsypOcSm33mJbwB6ajTl5ntTt1o=; b=bG8ykAp2v1umMTapFkSECWzIHzmfFwWh5S5l+RNUmMvNsKqRO7kfoJVM 35TjEA41qLkj7SAbBSOQbYDdfRu8zn26GSSnj83KrupUGTioQyDSU3hfN znZB9foypAAkxUdauszNL2T43q64cWYB/U5uxA99ds/6wHQkGRkm6gtCv YsUQ39YkgP5CdCbkLTVxMneSLAy9jAyJtCzQNyQ/Ofx2uHK4rFdT3CmPM E5XiS/S9cF3RsMubGrehf3hoqFV86ZCb0nbSZxic3nlmDODpqPBs3d+KJ nBUk4T6/UJNkSNVaBn17dcQ6NmTyoaFdB3UWqycFFj26RUke39IkUNxkK g==; X-CSE-ConnectionGUID: Aw+N5Z1YRBaSLNsYP9NIUg== X-CSE-MsgGUID: O51not2DRMadUClJXyoTTA== X-IronPort-AV: E=McAfee;i="6800,10657,11691"; a="82427809" X-IronPort-AV: E=Sophos;i="6.21,271,1763452800"; d="scan'208";a="82427809" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 09:23:48 -0800 X-CSE-ConnectionGUID: kGTu9zFWRbeIBuSpKoHtmA== X-CSE-MsgGUID: MFQpLX83TsKMGlma5QVdRQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,271,1763452800"; d="scan'208";a="210012973" Received: from dwoodwor-mobl2.amr.corp.intel.com (HELO [10.125.110.207]) ([10.125.110.207]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 09:23:48 -0800 Message-ID: Date: Tue, 3 Feb 2026 09:23:47 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] x86/mm/pat: Convert pte code to use ptdescs To: "Vishal Moola (Oracle)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" Cc: akpm@linux-foundation.org, "Matthew Wilcox (Oracle)" , Dave Hansen , Andy Lutomirski , Peter Zijlstra References: <20260202172005.683870-1-vishal.moola@gmail.com> <20260202172005.683870-2-vishal.moola@gmail.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20260202172005.683870-2-vishal.moola@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1B72DC0010 X-Stat-Signature: gztkhmrgkcy9sr3tkhmr8mx51bppc18e X-Rspam-User: X-HE-Tag: 1770139429-533098 X-HE-Meta: U2FsdGVkX19gVSVVjRfLPCsXH9U9GIAm+N/9K9hNs743ZpDoVQjsmuCy5wKVXT9oPwT3reih6/YcyRQ/MgcGblBLhmAvFWFsfJ541KAcfRJoLHHvwJfZYHn//tTbprECVEq0kEoiMaP2IfWrt85Ltr1kp/yLdEgjfPR+R/XxCp68pJnPZjAa/kTABxm04pIOoyNhz270B1MLW76CamfjXLLOcV0VkBWQz1Q3sFpVrS30kHy/DTiiBNVr/Tt7/cCqRjPoQe3Tdd451RUsmI1vf5QQwye0KzOzTMXhYTXdt6TLeySoBOVE212cso9eIJaXgesNuhcss1D9IjevWDfY1rGOmU3TNkHpZjLj3+MAsCPWKuU1usWB094wfcFuBW5SwsO2ukkf/Nb98vp+JxufGv1L6PgDd23MWAZ9/2xbQR9/ja/0aQFYEcbfMljuab/3uf7yWVLrn5uO1cqN4hGL/8/m+cJcSkkmHREcSmRDQJ2nORgGJIaZgVulKzY1UZOcYTEXsYoWuLRzNkhrPU2x+EIijzEtvk4Dqbz3rGhfXfFRgWeSCFFE7Ua4smwQpRAd/mgGN1dCtB4RtQWtrEzCvSmwMEbmzuTIyJXS3q2qW0hxM31JLG+RgC41RanC2OY+lK8Unc63zxSJkVSG8vnrjoWeG/heaa4Jak1dmrhiqPCI3pgEm9WRNing3G0VhjyqXKFRrhVOCZwgZJDvsk6371R3ZnPc1rNNyMTPUKWCMYpmtUqMps0YmeuY+Ndbz8vkoafThf+5XGMgvAD8z3IonaRTnfLNfMq2K9/RD/AlAd2vS57zDKrMMvNNqYVRWIvgSkmQdVhFZI96KFDzo+st5HpA10Ry1szOj2ve6dYmJLryi5BlLNo2jeZA+o4j7V6kqxMjycilMZzpZQwq6TQmKPWLr5rPfkVG76PjPTtQ44O1/c2f9hyqIIpsnCclP1p8oUblpAcAKgZXEd1T14E zPPyBczX mQSgWgKPQjOSvr6Pz/Vv7oR5Gv/t+skx4tXgtxvy4G6bw98/bpCNetZac1YyELyoup5TZreodTBiXFQJYDTMvywc4wznPJklEdqmdExESPmftbU+opqKKVX5njsYnMaGIbcrt6CN24H2E6h+m50SFw8VGJznrfhTazFJl9wc/IcurrlbD0RiEG38nJ6hsoR9ZF0p0lckII/yx61A5gxtohIgiGakwQEM//Azzu9EDAGhVDLDJKDdaX6EAgtkWjPCmrEWr69s+Sfvp+f067UUoJiCACA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/2/26 09:20, Vishal Moola (Oracle) wrote: > In order to separately allocate ptdescs from pages, we need all allocation > and free sites to use the appropriate functions. Convert these pte > allocation/free sites to use ptdescs. Imperative voice, please. > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > index 6c6eb486f7a6..f9f9d4ca8e71 100644 > --- a/arch/x86/mm/pat/set_memory.c > +++ b/arch/x86/mm/pat/set_memory.c > @@ -1408,7 +1408,7 @@ static bool try_to_free_pte_page(pte_t *pte) > if (!pte_none(pte[i])) > return false; > > - free_page((unsigned long)pte); > + pagetable_free(virt_to_ptdesc((void *)pte)); > return true; > } This looks wrong to me, or at least that the API needs improvement. Most callers are going to have a pointer that they've been modifying. They're not going to have a ptdesc handy. So I think this needs to look like: pagetable_free(pte); You can convert to ptdescs internally or do whatever you want with ptdesc sanity checks, but the API needs to be on writeable pointers. If the API takes a const pointer that requires callers to cast it, I think the API is broken. > @@ -1537,12 +1537,15 @@ static void unmap_pud_range(p4d_t *p4d, unsigned long start, unsigned long end) > */ > } > > -static int alloc_pte_page(pmd_t *pmd) > +static int alloc_pte_ptdesc(pmd_t *pmd) Why change the name? Nobody cares what this is doing internally. > { > - pte_t *pte = (pte_t *)get_zeroed_page(GFP_KERNEL); > - if (!pte) > + pte_t *pte; > + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL | __GFP_ZERO, 0); > + > + if (!ptdesc) > return -1; This also looks wrong. What kind of maniac is ever going to allocate page tables without __GFP_ZERO? __GFP_ZERO really should be a part of pagetable_alloc(), don't you think? > + pte = (pte_t *) ptdesc_address(ptdesc); > set_pmd(pmd, __pmd(__pa(pte) | _KERNPG_TABLE)); > return 0; > } Why is there a cast here? ptdesc_address() returns void*, no? Also, if there a ptdesc_pa(), this could be: static int alloc_pte_ptdesc(pmd_t *pmd) { struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL, 0); if (!ptdesc) return -1; set_pmd(pmd, __pmd(ptdesc_pa(ptdesc) | _KERNPG_TABLE)); return 0; } This *should* be a very common pattern. After you allocate a page table page, you almost always need its physical address because it's going to get pointed to by other page table or hardware register. To me, it doesn't look like the ptdesc API is very mature yet, or at least hasn't been expanded for ease for actual users. I don't want to grow its use in arch/x86 until it's a wee bit more mature.