From: Yang Shi <yang.shi@linux.alibaba.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
songliubraving@fb.com, kirill.shutemov@linux.intel.com,
akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE
Date: Tue, 26 Nov 2019 09:38:06 -0800 [thread overview]
Message-ID: <e0244439-88f2-6f9b-a64e-3454951c6d32@linux.alibaba.com> (raw)
In-Reply-To: <729623eb-df56-c436-2ca3-8f73772f539c@arm.com>
On 11/26/19 12:57 AM, Anshuman Khandual wrote:
>
> On 11/25/2019 11:57 PM, Yang Shi wrote:
>> The commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 ("mm,thp: add
> Reduce the commit SHA ID here to just 12 digits instead ?
Yes, sure.
>
>> read-only THP support for (non-shmem) FS") instroduced a new khugepaged
> s/instroduced/introduced/
Will fix.
>
>> scan result: SCAN_PAGE_HAS_PRIVATE, but the corresponding description
>> for trance events were not added.
> s/trance/trace/
My fat finger :-(
>
>> Cc: Song Liu <songliubraving@fb.com>
>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
>> ---
>> include/trace/events/huge_memory.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
>> index dd4db33..d49fbce 100644
>> --- a/include/trace/events/huge_memory.h
>> +++ b/include/trace/events/huge_memory.h
>> @@ -31,7 +31,8 @@
>> EM( SCAN_ALLOC_HUGE_PAGE_FAIL, "alloc_huge_page_failed") \
>> EM( SCAN_CGROUP_CHARGE_FAIL, "ccgroup_charge_failed") \
>> EM( SCAN_EXCEED_SWAP_PTE, "exceed_swap_pte") \
>> - EMe(SCAN_TRUNCATED, "truncated") \
>> + EM( SCAN_TRUNCATED, "truncated") \
>> + EMe(SCAN_PAGE_HAS_PRIVATE, "has_private") \
> Majority of the SCAN_PAGE_* scan results have page_ in the front. Hence we
> should just follow same pattern here and make it 'page_has_private' instead.
Some do start with "page_", anyway either is fine to me.
>
>>
>> #undef EM
>> #undef EMe
>>
prev parent reply other threads:[~2019-11-26 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 18:27 Yang Shi
2019-11-26 8:57 ` Anshuman Khandual
2019-11-26 17:38 ` Yang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0244439-88f2-6f9b-a64e-3454951c6d32@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox