From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF84ED46617 for ; Thu, 15 Jan 2026 20:05:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 540976B00F4; Thu, 15 Jan 2026 15:05:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EE386B00F6; Thu, 15 Jan 2026 15:05:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A59A6B00F8; Thu, 15 Jan 2026 15:05:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 26D536B00F4 for ; Thu, 15 Jan 2026 15:05:20 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ECB3BB9A6E for ; Thu, 15 Jan 2026 20:05:19 +0000 (UTC) X-FDA: 84335277558.13.871746A Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf05.hostedemail.com (Postfix) with ESMTP id 11D60100004 for ; Thu, 15 Jan 2026 20:05:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZTa8MIJd; spf=pass (imf05.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1768507518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kfSKNyz3xqAjIF1ki0fwiUUCENKT9VvGXQQbY+rUZVo=; b=5V4QCN9Xoc3n6/lP1CPMZbqHgiwjmvK2Mk/dfDayeVm+OtNJ5AJkJOZFN+2r4VP5i8XdRg Ayi8+NNTc4kWXADrIGi3EnEdlJUcDxQeCxSVEUSGkpC3ujbikS0rITA2xaPcAOo0WXRM/P Y/BA4unhT6WxAN8AmTrT62xtnkm0fb8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1768507518; a=rsa-sha256; cv=none; b=VlBpdv3zZYp4ACK+aMU9veDbzcKClIIejlYBrgp7eXQP4h0gXV5BENjac4B7ZFI8tD067J bD9haVMlkBq3vjKBbd1L2SFj3SCsWIqlCb8UGK72S9sxelHqLdB7AZVLPAG0N1j7TrjF9X sn1SJCNR8zveF6I02E7TsR6nF7dlNXY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZTa8MIJd; spf=pass (imf05.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E324742A52; Thu, 15 Jan 2026 20:05:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E28F2C116D0; Thu, 15 Jan 2026 20:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768507516; bh=lQjunlFmWyMO2lfyt6MHYKOuxFN86jW9uoYrdok36A8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZTa8MIJdGFVQHgLEluZ/7czewla0UppxdIHdajnxQJ86ydTVGfwKSu4XthtERI+Vz S7jrcXlBas27eS2MD4ilzRDMMXPl6T6E9jYdkN/V3bG/5qyCeBpbvRRFaNhMqR87Hm yrOWl7tr7bFwfCbSmttXaEGvHuYhAhBIYs9iTNdkypXcZ/3ehKbdUJ5MQS1tZScIOZ Lz9G5U6aHuy7cuX5bsreQjYhVzcGgutkYcdoBCPkgmmWwt3c+xpapY6koSIGNeH02C QufrTuCkot6ZMrQ56wj3oSRSVREgueyuJyGpm1FzrzpV7YI01LIlEB9EnK1pBzpzlg IStbdOwUJqRaA== Message-ID: Date: Thu, 15 Jan 2026 21:04:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 02/13] mm/gup: drop secretmem optimization from gup_fast_folio_allowed To: "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" Cc: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "maobibo@loongson.cn" , "prsampat@amd.com" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "Jonathan.Cameron@huawei.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , "Cali, Marco" References: <20260114134510.1835-1-kalyazin@amazon.com> <20260114134510.1835-3-kalyazin@amazon.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAa2VybmVsLm9yZz7CwY0EEwEIADcWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaKYhwAIbAwUJJlgIpAILCQQVCgkIAhYCAh4FAheAAAoJEE3eEPcA/4Naa5EP/3a1 9sgS9m7oiR0uenlj+C6kkIKlpWKRfGH/WvtFaHr/y06TKnWn6cMOZzJQ+8S39GOteyCCGADh 6ceBx1KPf6/AvMktnGETDTqZ0N9roR4/aEPSMt8kHu/GKR3gtPwzfosX2NgqXNmA7ErU4puf zica1DAmTvx44LOYjvBV24JQG99bZ5Bm2gTDjGXV15/X159CpS6Tc2e3KvYfnfRvezD+alhF XIym8OvvGMeo97BCHpX88pHVIfBg2g2JogR6f0PAJtHGYz6M/9YMxyUShJfo0Df1SOMAbU1Q Op0Ij4PlFCC64rovjH38ly0xfRZH37DZs6kP0jOj4QdExdaXcTILKJFIB3wWXWsqLbtJVgjR YhOrPokd6mDA3gAque7481KkpKM4JraOEELg8pF6eRb3KcAwPRekvf/nYVIbOVyT9lXD5mJn IZUY0LwZsFN0YhGhQJ8xronZy0A59faGBMuVnVb3oy2S0fO1y/r53IeUDTF1wCYF+fM5zo14 5L8mE1GsDJ7FNLj5eSDu/qdZIKqzfY0/l0SAUAAt5yYYejKuii4kfTyLDF/j4LyYZD1QzxLC MjQl36IEcmDTMznLf0/JvCHlxTYZsF0OjWWj1ATRMk41/Q+PX07XQlRCRcE13a8neEz3F6we 08oWh2DnC4AXKbP+kuD9ZP6+5+x1H1zEzsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCgh Cj/CA/lc/LMthqQ773gauB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseB fDXHA6m4B3mUTWo13nid0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts 6TZ+IrPOwT1hfB4WNC+X2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiu Qmt3yqrmN63V9wzaPhC+xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKB Tccu2AXJXWAE1Xjh6GOC8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvF FFyAS0Nk1q/7EChPcbRbhJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh 2YmnmLRTro6eZ/qYwWkCu8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRk F3TwgucpyPtcpmQtTkWSgDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0L LH63+BrrHasfJzxKXzqgrW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4v q7oFCPsOgwARAQABwsF8BBgBCAAmAhsMFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmic2qsF CSZYCKEACgkQTd4Q9wD/g1oq0xAAsAnw/OmsERdtdwRfAMpC74/++2wh9RvVQ0x8xXvoGJwZ rk0Jmck1ABIM//5sWDo7eDHk1uEcc95pbP9XGU6ZgeiQeh06+0vRYILwDk8Q/y06TrTb1n4n 7FRwyskKU1UWnNW86lvWUJuGPABXjrkfL41RJttSJHF3M1C0u2BnM5VnDuPFQKzhRRktBMK4 GkWBvXlsHFhn8Ev0xvPE/G99RAg9ufNAxyq2lSzbUIwrY918KHlziBKwNyLoPn9kgHD3hRBa Yakz87WKUZd17ZnPMZiXriCWZxwPx7zs6cSAqcfcVucmdPiIlyG1K/HIk2LX63T6oO2Libzz 7/0i4+oIpvpK2X6zZ2cu0k2uNcEYm2xAb+xGmqwnPnHX/ac8lJEyzH3lh+pt2slI4VcPNnz+ vzYeBAS1S+VJc1pcJr3l7PRSQ4bv5sObZvezRdqEFB4tUIfSbDdEBCCvvEMBgoisDB8ceYxO cFAM8nBWrEmNU2vvIGJzjJ/NVYYIY0TgOc5bS9wh6jKHL2+chrfDW5neLJjY2x3snF8q7U9G EIbBfNHDlOV8SyhEjtX0DyKxQKioTYPOHcW9gdV5fhSz5tEv+ipqt4kIgWqBgzK8ePtDTqRM qZq457g1/SXSoSQi4jN+gsneqvlTJdzaEu1bJP0iv6ViVf15+qHuY5iojCz8fa0= In-Reply-To: <20260114134510.1835-3-kalyazin@amazon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 11D60100004 X-Rspam-User: X-Stat-Signature: eakt1hh4y3pj1713mmtufusgqfpxardr X-HE-Tag: 1768507517-121699 X-HE-Meta: U2FsdGVkX19GXUmKoPK4U7O+cWgzmJVs8he4LVsaIUJenePdBYOsUQk+FWxTN7sPo2iEdcKgbQhWuZxfQ2jkawG0ddgWR6wfHWDtjEhJBF1duEY531JVWvNbhiAe6ZA74URY//kILh4pqdW5Z18aix0AlI4b/sHGwbIG/nJt3QDP2D36QspOhU0XK1nknWXpNdv4M71glZiHs/d3u/C+nAcrKE0NxUWU9Jl4Ou76eB9PVgZ4ca9eEFH4Y2Z3iNA82Z0UOG3DilHSt0fnHEvE1JbA7w/ZM206cRC/uxi8xd7LuEnRtq6MZNzW8faITuwPGotMNAsHMd58VMFnjV+0ZyJsNGIilKfmi7ub6U/c3S2W4HYOJnBGdMPStNKEeGkXz+vIrnqaka1xfcWp54SV5DWu2HRueJHWFBVr9f7O/IoSEuJdL/qDHwzdvT4kldq3tsbLDICzMstyiXTZ/L9OB7L6TNgGnpIJFKLKVK1KM9wY4RO8V1aXnzntOjJfy0+d4gsnqIFoPy2w9DqUCaZUnxAZ0gD4R9hE1mVuIeoontNC3xKhmu7vppY6KBl19HhEVVXXx1WOKSwCgdJk4Nq+3Z4jXB/8bRrJWliAn+TO+fqxYCSlQg5AlJCtRQA/1DkU1R+QHZyGpadjqQ4HmQusL0IfnDdeVWolFkayC7JXDRPTiI2FD1zbDm3+gP4OG20OYDdsOm9d+5Ok0Z34Q6Wu23N9DAnc4k8F2HyS0Nepdpw0A9HS6ugORd/WPTtQcAxsuVxPXhXwjcuxK/Fr82tU7z9wpcGktp67X4jyQP5H4ePGuxQDcpAf+6XCJIt9cogI8Ft68t9g+sLiE+TrPVnfeT+215C0OJL1KUD74POpLqb3Pcx/l6pXNbLtOqRlp5u7D4rixfji33IBvCc26VGLeKdeZY7yXGxyYxCgf8wOnIoKbDmL9kDwdTWoA83TIeLMQ9JkJOZBDBSkK+uoqhy MjCQqXm8 oitsQ3iziPuPj/x0uv5bZL3/DoqalZgaXliQ945Hy/H4oWn3GEd7y24SJPwv/FpL1d8XsCf63P64q7wyi1riJQZr6vU9zXAGJ2cFwjcLCDd/ZbjUU2MLGpdn4V3mjbc0PnWnI+zz3LKStJzANO4SewVbFHx+qdwdtxid8PoUEOfhj6UwrssI0y83br2LzYkQE1PWcDrNU1k2VvqJV3324AzCurwGRLZMPqX54EkiVZgzHlu18Q0Axop5D2G/7v6lzn3lrIylOKxZQyJzChPgu1+ta9kd0+7mX+tN1srHYB6iUej3cgtohknrlzR45/XsNIFhKIdBnZVH0nrLmIjVBSuraNSOIe5t58diBAXeJXIs0dCj2rS4wGLm6MbQp7tJJpr2sJdoFwaqEt38rItYvJsaq3wOBbgLo0sEE9VBWpfQgdSjM5cwPDRJ9xXLGmzm2/gC2YgzJyZlpmC4oaaVn+R31Gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/14/26 14:45, Kalyazin, Nikita wrote: > From: Patrick Roy > > This drops an optimization in gup_fast_folio_allowed() where > secretmem_mapping() was only called if CONFIG_SECRETMEM=y. secretmem is > enabled by default since commit b758fe6df50d ("mm/secretmem: make it on > by default"), so the secretmem check did not actually end up elided in > most cases anymore anyway. > > This is in preparation of the generalization of handling mappings where > direct map entries of folios are set to not present. Currently, > mappings that match this description are secretmem mappings > (memfd_secret()). Later, some guest_memfd configurations will also fall > into this category. > > Signed-off-by: Patrick Roy > Acked-by: Vlastimil Babka > Signed-off-by: Nikita Kalyazin Acked-by: David Hildenbrand (Red Hat) -- Cheers David