From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80B58C02185 for ; Sat, 18 Jan 2025 08:04:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7097A6B0082; Sat, 18 Jan 2025 03:04:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 691C16B0083; Sat, 18 Jan 2025 03:04:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50B386B0085; Sat, 18 Jan 2025 03:04:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2FFE36B0082 for ; Sat, 18 Jan 2025 03:04:16 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 82636B1745 for ; Sat, 18 Jan 2025 08:04:15 +0000 (UTC) X-FDA: 83019834870.13.C108D93 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id C403D140009 for ; Sat, 18 Jan 2025 08:04:13 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Jwwr4yFv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of hawk@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=hawk@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737187453; a=rsa-sha256; cv=none; b=lNO0CORvE8j1igReaM/1iGzTVmyQ3sQ9gWOf+ciboMF1EZLa7iRnpvVUIqqMKywUeS4yov qRD1RcZxxiZ0sf3G8Rm63aPesQ4z1B1MYhDD+tFdgxV9XY1xE5t8GGTO+sPu4V7pqWavLD hRawqY3Y5sQlMJ5y5aGZadRuN96VD9c= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Jwwr4yFv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of hawk@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=hawk@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737187453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4FOLWoiBdOZIbz+rGO7a7GwSxpk27LE1qCoksXK33CE=; b=arGwMrDFbOhe9Yh2M9ECao+d/k33Cnl6wnDY9v/yAScGG8tAXsHUzmH6JeAQdF89nLN4Od sWiyZuAw3850kLmB5F4WS5tl8xZ+gaftIG75Y7Am5S6xP6u93AKze8W4v4jaHWQzVCz23H LD6j7HwfoBRUAD0JG1fmT6XT4JZsWRo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E6CCBA4043E; Sat, 18 Jan 2025 08:02:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B24DC4CED1; Sat, 18 Jan 2025 08:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737187452; bh=X8xl+FikvEsefyJsKMCnT/zbfddcbexbuTDnIId5TZQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Jwwr4yFvVLsCkvAYidGgHqdk1SqnXor04i9X94Db2qJ0QhORGpQHZOZkOPmZ0GQtJ 97no8YhrF+z3OTjQ1lxCNFIVYAjcGr8mU7o6rOF0vKBZ4er/XmYA+kcxB1nNqYB5xi I4C2VEEVFterxQ3SKCBXurdH9MFkI3wJEd4w52mAp4+2zxpjHpAqcxGouwiJC8tXqr cAmuba8ya9Vapi35c8+kl1peNietydCSD5VpLFVteL1O30Vd+ZhbSsCzExQc5RQRQH zyCh1DkSlCRZ1x9ehDtdukIbZ4w4vxBXMukSP8LJ8AQkZHSGVcSYl5qh1n/eyyJkBJ PJtjuFWuoRbIw== Message-ID: Date: Sat, 18 Jan 2025 09:04:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 0/8] fix two bugs related to page_pool To: Yunsheng Lin , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: zhangkun09@huawei.com, liuyonglong@huawei.com, fanghaiqing@huawei.com, Alexander Lobakin , Robin Murphy , Alexander Duyck , Andrew Morton , IOMMU , MM , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20250110130703.3814407-1-linyunsheng@huawei.com> <3c8e4f86-87e2-470d-84d8-86c70b3e2fcc@kernel.org> <3a853e1b-b5bf-4709-b8f6-e466e3e7375e@kernel.org> <1bef4a35-efaa-4083-8ed5-8818fe285db5@huawei.com> <304b542d-514d-4269-ae11-b2e214659483@huawei.com> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: <304b542d-514d-4269-ae11-b2e214659483@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C403D140009 X-Stat-Signature: h4zjeu9jwrnf66ed5wcs1uoa6f7pwspk X-Rspam-User: X-HE-Tag: 1737187453-765264 X-HE-Meta: U2FsdGVkX1/gD6LcrlQAG3Goq1aQvLP9HyuAO24YDNuPgC2Va+CKUNbAb4fwlsl6tOUPHEvDtrk/CuWH3y4A+eLnI/vadFUMG5hybqZeyTHw+lPnRjUGAZ0vKaBU3/fJQEN4QIGQjyN83EMlAoIL+QX6EOMY0CEL+EOx4NDjKTfpFpLK59dcW3QhJ1yE+HozCZjJVMINmdR5KGMZJrTtyU/BJdwZFQcwy/0tZpxbedG/FA3atifaxrYO/7iEhQaPMlWGx92EWYJqPWHGsrkTAMHztY2yZsOUkNJpGGcLzlT7T3DXlZW4vwpIZOIrhE7JDC6JlXKSOrpXrF2I/WYMjqv+rFL0UNw9rn4Kbh7D8g6JVdbX0sx2w4nu2/aWA4Zt+MY/FJsUZmVVCLN7bddjWe9WCSmCTBSfW9oL3WjhYq32k16mdTP5A2vYncEng1YthQ0l5JDCi9q1OUxCzEu3nvl3CkCboM7VE7tamO9HGNmFB+rjBb5RHnC/TKfJ8GJkLY0tjE51X+lSpvgPyFQh3qC9fRC1wK8CceIYVdAW6qyLMriI5hMzEhgCA/JZqaqODHDgYJkJWQQ7ckAgC8A+gilEvtuwctEIhy9Td0QX1oieL4uTpVTQcickfhtb0HTTtyOXUW/3AnXkFuQrbKx2uTX8FubYLFwO4n47BzXi43WTXMFboEFoWoco3Rgw/MUpi7dtZyG6wlhpbeoAr0wtbIN+vLVWrLwIvd8lsxoKnfAcHIlzvPDThZKtu2buEYMIuNlBHnH6C/JSWz8rCSrMiIt1g+rTNMuC+o7FVrM77r2+f6WlxJP881s/+ZSz8xVNZ40SwtZhgm5+EjppaOwzKHQwu0b3OFeUbIjcoZ/1Avq8qfIayVA2t2M7K2nOCi5+I+2xGFXoU2/SgtxRPIHu5d07pvp357UsmNO7TeicKr6GLG5n7/qvXSY3OijaYw+AgmqMFjZfNEWcoPiFcCx fGTvSwn6 S3Vk24bqsQB2dAOJB8qePhMQmj3qKWc0JE7/AH2Xvxye58caHsdLZoJI0iykhrEYEYCkwbLNNDQ6r+Dyo38U4sKo+Vty5iGKNK7/jUA5kmJSdm9A0yCUfyQ5WxInfnoGWur8v3GqO/ChOpUSxGPid6ATOIrlrvoqClq8QXGa+tAV+JRvkZuDn7WGsI6i6hb0SINYypi+VLc5/0tFaLSZA7T+Vrw7LmCKtp7BDnqPuYyVv2zud1a0DeS4XTzgHoM5LRHBBwAJG1u73CoU2JetOw7YXyb+Pfm8xToScqWYQmZhdNy5+BttvPLuNh+155BSudCjBIBKqK0bXr/loBOQcbZCfRQfifYGwk3VDZXUtoce9GOne2tJjn5/A2rnJmajZXUbQD5bz7N+c2GKSJuAyggZ3ILXlFVEPce28sH2oFBO0amtLYX82lmTfkx+pTC9QHuFtlC8Y0K4Qw/edNJlO2XqgC7QE+ndoyPe1h/wFJDudY18= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17/01/2025 12.35, Yunsheng Lin wrote: > On 2025/1/17 2:02, Jesper Dangaard Brouer wrote: > >> >> Benchmark (bench_page_pool_simple) results from before and after >> patchset with patches 1-5m and rcu lock removal as requested. >> >> | Test name  |Cycles |   1-5 |    | Nanosec |    1-5 |        |      % | >> | (tasklet_*)|Before | After |diff|  Before |  After |   diff | change | >> |------------+-------+-------+----+---------+--------+--------+--------| >> | fast_path  |    19 |    19 |   0|   5.399 |  5.492 |  0.093 |    1.7 | >> | ptr_ring   |    54 |    57 |   3|  15.090 | 15.849 |  0.759 |    5.0 | >> | slow       |   238 |   284 |  46|  66.134 | 78.909 | 12.775 |   19.3 | >> #+TBLFM: $4=$3-$2::$7=$6-$5::$8=(($7/$5)*100);%.1f >> >> This test with patches 1-5 looks much better regarding performance. > > Thanks for the testing. > > Is there any notiable performance variation during different test running > for the same built kernel in your machine? > My machine have quite stable performance for this benchmark. >> https://github.com/xdp-project/xdp-project/blob/main/areas/mem/page_pool07_bench_DMA_fix.org#e5-1650-pp01-dma-fix-v7-p1-5 Like documented in above link. I have also increased the loops count for the test to get it more stable, given this will be measured over a longer period. modprobe bench_page_pool_simple loops=100000000 >> Kernel: >>  - 6.13.0-rc6-pp01-DMA-fix-v7-p1-5+ #5 SMP PREEMPT_DYNAMIC Thu Jan 16 18:06:53 CET 2025 x86_64 GNU/Linux >> >> Machine: Intel(R) Xeon(R) CPU E5-1650 v4 @ 3.60GHz >> >> modprobe bench_page_pool_simple loops=100000000 >> >> Raw data: >> [  187.309423] bench_page_pool_simple: time_bench_page_pool01_fast_path(): Cannot use page_pool fast-path >> [  187.872849] time_bench: Type:no-softirq-page_pool01 Per elem: 19 cycles(tsc) 5.539 ns (step:0) - (measurement period time:0.553906443 sec time_interval:553906443) - (invoke count:100000000 tsc_interval:1994123064) >> [  187.892023] bench_page_pool_simple: time_bench_page_pool02_ptr_ring(): Cannot use page_pool fast-path >> [  189.611070] time_bench: Type:no-softirq-page_pool02 Per elem: 61 cycles(tsc) 17.095 ns (step:0) - (measurement period time:1.709580367 sec time_interval:1709580367) - (invoke count:100000000 tsc_interval:6154679394) >> [  189.630414] bench_page_pool_simple: time_bench_page_pool03_slow(): Cannot use page_pool fast-path >> [  197.222387] time_bench: Type:no-softirq-page_pool03 Per elem: 272 cycles(tsc) 75.826 ns (step:0) - (measurement period time:7.582681388 sec time_interval:7582681388) - (invoke count:100000000 tsc_interval:27298499214) >> [  197.241926] bench_page_pool_simple: pp_tasklet_handler(): in_serving_softirq fast-path >> [  197.249968] bench_page_pool_simple: time_bench_page_pool01_fast_path(): in_serving_softirq fast-path >> [  197.808470] time_bench: Type:tasklet_page_pool01_fast_path Per elem: 19 cycles(tsc) 5.492 ns (step:0) - (measurement period time:0.549225541 sec time_interval:549225541) - (invoke count:100000000 tsc_interval:1977272238) >> [  197.828174] bench_page_pool_simple: time_bench_page_pool02_ptr_ring(): in_serving_softirq fast-path >> [  199.422305] time_bench: Type:tasklet_page_pool02_ptr_ring Per elem: 57 cycles(tsc) 15.849 ns (step:0) - (measurement period time:1.584920736 sec time_interval:1584920736) - (invoke count:100000000 tsc_interval:5705890830) >> [  199.442087] bench_page_pool_simple: time_bench_page_pool03_slow(): in_serving_softirq fast-path >> [  207.342120] time_bench: Type:tasklet_page_pool03_slow Per elem: 284 cycles(tsc) 78.909 ns (step:0) - (measurement period time:7.890955151 sec time_interval:7890955151) - (invoke count:100000000 tsc_interval:28408319289) >>