From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F68C3DA49 for ; Thu, 18 Jul 2024 23:19:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE05E6B0082; Thu, 18 Jul 2024 19:19:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E90AF6B0083; Thu, 18 Jul 2024 19:19:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D58656B0085; Thu, 18 Jul 2024 19:19:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B5B986B0082 for ; Thu, 18 Jul 2024 19:19:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5777EC02CF for ; Thu, 18 Jul 2024 23:19:58 +0000 (UTC) X-FDA: 82354443276.24.F696957 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf29.hostedemail.com (Postfix) with ESMTP id C240512000D for ; Thu, 18 Jul 2024 23:19:55 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MtDJgCeA; spf=pass (imf29.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721344776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dOtxshDQKvEp2cqRUuCoshYKYABr2QosoOtr17LvFVU=; b=YOjTN4kwUsQE8lDOyFWa11phw78v+uBf2DNOS4m7cWJ6Aysfb362FKomOhqzZEsJQlyhmB 0yVLJZzdduEguqVgm3vMW40FT+aTiphb3jm8EV1Gkxbfz/qWEF2IoGbA116PHNSaImKnsu 6y3N//7nf/x6/6Bc1P+qpsWxE5Ngq2U= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MtDJgCeA; spf=pass (imf29.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721344776; a=rsa-sha256; cv=none; b=o+l8MmOJr8IGuBu8XdxEzf/pU+RzlEtpfnehxi7pnrLGtRsh0jVctxYNVWLXMk68thKNIT I9TjOq4o33ugPBScYA8xK0M3o7desKMvAAKR4D4HI8tga8+BTz9d9mQAtAGANv0DTPkd8C Z0PPeZjKFE0VvtAHPcBSVvwbiVyDmIc= X-Envelope-To: pasha.tatashin@soleen.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721344793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dOtxshDQKvEp2cqRUuCoshYKYABr2QosoOtr17LvFVU=; b=MtDJgCeAW0oSsSYJNnn4q4Gf1asfEn1tIFvjuIol1BkJT74qI6ix1bkMpy3bmOistNC1pn oMFryEg1mlkEOgmFBnQ0sD0GawsTJDfiCJDlZzju81Edly7s15Xce/QfWYubCc8TFuirUz xaJTBxmJKD2Ul0eRNS250pUKYSJePMM= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: jpoimboe@kernel.org X-Envelope-To: kent.overstreet@linux.dev X-Envelope-To: peterz@infradead.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: cerasuolodomenico@gmail.com X-Envelope-To: surenb@google.com X-Envelope-To: lizhijian@fujitsu.com X-Envelope-To: willy@infradead.org X-Envelope-To: vbabka@suse.cz X-Envelope-To: ziy@nvidia.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linux-mm@kvack.org Date: Thu, 18 Jul 2024 16:19:44 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Pasha Tatashin Cc: akpm@linux-foundation.org, jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram Message-ID: References: <20240530170259.852088-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C240512000D X-Stat-Signature: axkmrz6zfyydknbeaeae6sa114feh4fc X-HE-Tag: 1721344795-306887 X-HE-Meta: U2FsdGVkX1+tL5t/nJyMJajreuzatLHvf6JBpHCRVESx9qJUaONV7geMA2QMZsPiDvKTObxeJP8rEVzW4UyExZq5D+XgjzRL5oJ851DCqZvAFiV3s8O/GBleFbP1hx21gDTq0sbc71ZS+pFuX4FDP0MQMGOktIYGtPyeXwXDN96BEpliv59e5VnAhTUpA7ANEs4OIf82PokuvUHnUuKaCH2x/lKA72bLPK0QBDHUJDOX+NxLp/MAQML6IPkCaCSL+jS+o1Gj09C5lqTRNGDRxXajrwJPbu8kU9aJww+kM3ztHmt5omZLuU5ITJbBO+mUSah/JcngficVniiFLqHiP+5jeveiLuDQtNLYNL3/Y1HiOUT1MH+ZKvh5dS7fKDTWuFqwKbFexWc4C4Vak/bUqj38K5qX5vI1iyzvtmkB+LwtHTqAYQm8k8tWSTbXMOV1WsP07WQlatI+FJ8/ajlO5vazn9FAwXmg3P50H4pabEIWjzP9I2baBemnCLAx6aU7bYyAL09WlQG/LuzMZxIKCOGgQTyO/hmiNAp4d3HC5C36I8NSI0r4nOkjdMKFLig8DzrPtYzCaRaSmNzw4NU2rfl4hSi3GFCRRtsrdEyPd/E6k4Zqd5Ce6g38WJqVMCppESkN+FGR12Q8LPGPb005M75NUOVf7sP/89rr/wTjFeMnodK0ysToZckrsKri8eZm6OH98VphcqrcmZL3pEtnIZl0yNEcitPRTBwJetLoqX7WgK1negRfpq+fmIPy1KNBUDQm/QSI1HuXoZQlCWCfvBj+c5GZRS+R1amWsnDBisUwtfxkcz2qHMIuls+vAlVYJlSGBoRWdjLFuW2FtS1sPUqpLzEJUSoEy4JigJMfgfKNIrHo1w11KqhpzSY+jxUtuu/cpt/2brhynxaCqNE5clrD2pxqbQdKGpnp0y9qg5J5ymySY8tdvgakbQ98Ka9Zoqo4Oz8NV6j5AdFEu9X EfyaHEn3 EikrGJINxckkiWQGTUsbm1hWUWsJ1voM3b/sET8MJg8jvloc1pqqkhxGfUjiQ9kC66mKYjTDnvS3f6lOhGHnfzkeqfWgpmCCPB6pGxhM3sjxRA6Dx69oOo3hBIeGz9dAii0jn+BJBqBxBgC4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Pasha, On Wed, Jul 17, 2024 at 12:50:00PM GMT, Pasha Tatashin wrote: > On Wed, Jun 12, 2024 at 2:50 PM Shakeel Butt wrote: > > [...] > > > > > > One more question: Is there any concern in making > > > CONFIG_DEBUG_STACK_USAGE not a debug feature i.e. enable in default > > > kernels instead of just debug kernels? > > We enabled it in Google ProdKernel. There is some overhead when > threads are exiting, because we are looking for the first non-zero > byte, but that is minimal. We haven't observed any performance impact > on our fleet. > So, you would support making CONFIG_DEBUG_STACK_USAGE enabled by default, right?