From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B48BBC282CD for ; Mon, 3 Mar 2025 18:18:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43669280037; Mon, 3 Mar 2025 13:18:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E4EB280036; Mon, 3 Mar 2025 13:18:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2103C280037; Mon, 3 Mar 2025 13:18:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 04AB2280036 for ; Mon, 3 Mar 2025 13:18:42 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 72B8751C83 for ; Mon, 3 Mar 2025 18:18:42 +0000 (UTC) X-FDA: 83181050484.26.75AAB82 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf07.hostedemail.com (Postfix) with ESMTP id 81FFF4000A for ; Mon, 3 Mar 2025 18:18:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="l95/pFGx"; spf=pass (imf07.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741025920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m21XiXDRbYhaCVEZyslTuWSdbjFHYn+/oFGQbkqyFGc=; b=ExDl9VY2XgkgT7G4s/B7mxkd+kMA6nTvmmkAzlnh8IvolxH9yxwGH9SrG2MuHKRcSBM9V+ qTHUOaTJZCcE9D4rtzylUf8Q/9qVpyYFbbIOAbMqeunJbB+7PtRk0RS0LsJqkXYKfMdcRP 2QWXphKT0a1sWbBanYQQbaSmb4zbCvc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741025920; a=rsa-sha256; cv=none; b=iJ4SwG5JUMyLLvcijZ0KyVKKY0VljFCjJBt1dH4hNz9Bd39zN70wSi64DfCTFYAfqyrVis b0IA5UFeoT5xPxu95d2YT53nm79KRate0xUSlKlK5hPtsUTMzVHEVUz+Mcj687JHr8P2p/ JDt8Cre8xFDT7aJM21q2/Sz5Y5aoEm0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="l95/pFGx"; spf=pass (imf07.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 3 Mar 2025 10:18:33 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741025918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m21XiXDRbYhaCVEZyslTuWSdbjFHYn+/oFGQbkqyFGc=; b=l95/pFGxkxbLDqIZ2cVIX4HU/3uSV7rt8YP649hRQD0vB7O72eS8QKuNkb5UHQMBZhyGx8 +1lnrWl3hkPnKy6pAkNjO2+RP6MThqTFM5nLvy0FMZi8QF1bdCD9/q1BcgJGlk2PZcAdss KlkDxF1xZ8ttUBD5pKECffcn5m4ksak= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Yosry Ahmed Cc: JP Kobryn , tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 1/4 v2] cgroup: move cgroup_rstat from cgroup to cgroup_subsys_state Message-ID: References: <20250227215543.49928-1-inwardvessel@gmail.com> <20250227215543.49928-2-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: daxyj3m1afwef73g8373ob5cg4gwx7x7 X-Rspamd-Queue-Id: 81FFF4000A X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741025920-200212 X-HE-Meta: U2FsdGVkX19HVxzp4XGyfCqwtmsZOp1/gi6A8xUp9Qk28zwR2kG/rfH5mV6JuXTV+WRqNJwK1fdSuY57vgRHQ1RTkbNALWP+1R8RTY81sF4E/JMVNksCBYLytnqzoW9TbHYoYI+Nzh6dMI0HhRj0VLXDQu/coHAvkO+PuhaAzR3WzKBQJ6UQxbE4Ub6vtFHI1DTlq2kJSx4zMck9DqGEdXly3cyOgABHUlZp0PdduVFNqgHytAiH0oTZh59sh7bwJxXqTnoEe/jyPb1rd6isxtndZL/VR3kc7KsBRKZNJp70AQYuW94Ht5ey7jqmMmxBG5lrkVjeOw9/sRxlzV4DxIp/d9iGc7UqGqKHpTD6VRFobauBUPuphwI8nc9s/Ob0tZ0DmedPLJ+iQtFIKHL6p/N36uEz/ryvV1z6UwdUFpp7MKeB1HMfFItlS8aL24rCnKKYs9fejb+BSH346HX3h4pDN3XWzGxTOxSaqljir6Nxgmt2O03kkurWAGuGAYxPEubMEMb/VU/Xa0WuhAkK0e3W8JPQs9AZJcAivFaixrNLqcCY3secFqDfqaTPm9NCMmsWN0kB80H0hJqUqxbWwQ449qv34pwqclnkC8JBQZtogye3ojIrLtTYjPrlU3nwj60s2NEK/sOSrtbfQTl42BigJjj0mP7Z55RIr+gDC5Tpar7zB5Vu3lrK61swUVzTu6lbj8wUhEndEkV9jRwod0vUpVnR+WxoBLqh7uaZTG9BQYAzdlwlbzv9piL/0uwUqs0rKMWTB9a06aN18xsUm7clXBCFwB+YgKsb96jUZ4ukPRSCd+Yleo3zktoV+paQmsNTCNCN6zM4T1xygPAAoT1nb2YPvgLH+MohR9xyXNsG6V5eSLLSY8nAzDt0VSU0u/Xewhwm8fAPkZrqZS3KvjsxxaFk8ZHw/9L1hI/+iMbfSckphkd+WU6u2vjcgNyKiSaiIl2VroMtpM1XzNA o1fhT2KU uujQ4mO1rcR+MEAvOssjoqJtxHuKeAHgRo2yMIki/9G0LpeSWfGgBBV8eW0o+CweUH0JsEE20+HHhAms3CiWEFwGCGJEY0v1BL85KOb4sLKUsS1iLrRtz6bLZdvVxk5xqMghDBY/68Ra0GNKFkp9XVrEdTsgmiaQMKGbgKgBcp07i+NDL/ywm7M4a7VFrI8H/wa21rZRJuX9SxzT+XeMDnwkVFAQhiwwz94KA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 01, 2025 at 01:25:03AM +0000, Yosry Ahmed wrote: > On Fri, Feb 28, 2025 at 05:06:23PM -0800, JP Kobryn wrote: [...] > > > > > > We should call bpf_rstat_flush() only if (!pos->ss) as well, right? > > > Otherwise we will call BPF rstat flush whenever any subsystem is > > > flushed. > > > > > > I guess it's because BPF can now pass any subsystem to > > > cgroup_rstat_flush(), and we don't keep track. I think it would be > > > better if we do not allow BPF programs to select a css and always make > > > them flush the self css. > > > > > > We can perhaps introduce a bpf_cgroup_rstat_flush() wrapper that takes > > > in a cgroup and passes cgroup->self internally to cgroup_rstat_flush(). > > > > I'm fine with this if others are in agreement. A similar concept was > > done in v1. > > Let's wait for Shakeel to chime in here since he suggested removing this > hook, but I am not sure if he intended to actually do it or not. Better > not to waste effort if this will be gone soon anyway. > Yes, let's remove this unused hook. JP, can you please followup after this series with the removal/deprecation of this? One thing we might want to careful about is if in future someone to add this functionality again, that would not be a clean revert but what Yosry is asking for.