From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38358D4335C for ; Fri, 8 Nov 2024 02:49:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8A776B008A; Thu, 7 Nov 2024 21:49:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A3A546B009E; Thu, 7 Nov 2024 21:49:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 865896B00B5; Thu, 7 Nov 2024 21:49:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 624916B008A for ; Thu, 7 Nov 2024 21:49:26 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 07C041C5B17 for ; Fri, 8 Nov 2024 02:49:26 +0000 (UTC) X-FDA: 82761395094.08.91A9259 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf21.hostedemail.com (Postfix) with ESMTP id CD7471C000A for ; Fri, 8 Nov 2024 02:48:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=eqU58w7p; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=nd1WOgaf; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf21.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731034024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mBYcRFmEb+3b/fM6kn/w4zB9wiSUe2gMK0J5QFB7WVI=; b=TnrNIh9frQ4S1CW9euk68ZDPJ6iGrK0koO77h4ctrY7iPHwh6IdYL4tspXzHL0wHHVl5Lg yS6NWoRCETqL/YtBJJZidymvclgI/Y7HtH1biV6MfJUltlg2kfRTwf/QhJiaY/kOTIskiz PjFjkKtEooZvLeqcNWXrZQMRhoWopPY= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1731034024; a=rsa-sha256; cv=pass; b=2oYBeBGz2qyB0cvcIMqjGBUcBVtuYc2yvUN3X1pYVTR0aLM1cQDhoKKQFOsf7y2BRqA12A ew3Tk/77UAzB4bG2syq1pf0R9IzEp0VYEcxiLF6swYLMNDSJo0xbG0wwpf4JYivGSmHM1N qai+2Lx96/tdy5a/HZMs97sav/f/zVI= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=eqU58w7p; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=nd1WOgaf; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf21.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A81ffOa024026; Fri, 8 Nov 2024 02:49:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=mBYcRFmEb+3b/fM6kn /w4zB9wiSUe2gMK0J5QFB7WVI=; b=eqU58w7pQXZ+Rzs5y6xPaxilcpQFPWUDX4 QbZqwXdrz5qtAFWRD8+dayx45ZZnAwZuNH1n93dIosp0K4mOAA3hwQWa0trT9B+T Smrks+5tMG9F2JC298Q/wgmwDJyV5Y+hk45XRnSpJsb077mBR9/DObgZ5RLW4H4r gfezAnvjdhbCsgfHOU5zhWCins0wFKWMqAJPFq1TBxZ3c+yKRZulXisM2huevUP2 B3AX8mme5xZHiNFs4hrMXEYXx4ERETH75yoNIc7B4zYbAVHh/0yhyM9TvaVOC7dr fZ0vGchDcXVsMtmG9W7/iBuhxwYWkVUt5Y6P6x9wmjIhOG54T8Zg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42s6ggr84w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Nov 2024 02:49:20 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4A80Wcc7008451; Fri, 8 Nov 2024 02:49:19 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2172.outbound.protection.outlook.com [104.47.57.172]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42nahauvhw-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Nov 2024 02:49:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=np9ntr/Tx6BvMdV56tCfaeVzD6uQSi7GVYEjGRqD7IFyE/+v7gtXE+d1tpjlCNDbdjpw8U4ziftAQRG2uXizSeUsuOrabM/t5ePQXLLV4fWdbIgPVLWIcSfsHUh6h2VG8ZCat2NLpYHax2X9nmlVzfdLFBryd0dZen4F22SHibJ3bvbFv0NNwkMIJ2RTIyR/1VmjaGi8Y2tY4WW2t+UQyBhDYfYffxwqTjHj9Pey9c4mkO2cFu2TH3cVk9UoNoGhvbgOJNUPkeC1XePQcwnTrMqRiBhAkcHn0TLeWe8qGoyEpGhR5XLer6Gv2SP1cGFh4vkOToRMB+ELDtOxRUEFDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mBYcRFmEb+3b/fM6kn/w4zB9wiSUe2gMK0J5QFB7WVI=; b=SAS7PFEKTSJfAZiQG5oi/+/pH4hqPwktjluRYtoWgbtPMlQLiwuYcBIchDM41F5tftpMudJGP6IrZRNBriPGxzfhypdXGSK7DCE2jNHhJOBsS2kZg4MXjNlbI094GlWVruQIb/WO39m5UVKbkDVPcN8NbG26CItvR37/K5M4F0/VOX6aouj0MAuj+jXCJk8PU+0BVswQ3wEPN7whoWIdNUwTKZBApVNCSjH/2peG0euQCCPQy/3UvsQ6rqC+yYtvIdEKsf6KGWRFSiSP3fNcc4P89GYlUEel0kUgUQR4ZDQcPoXQKgUBQ+ltxV3kNiZBEJJgifg2ifCyRQEcikN/BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mBYcRFmEb+3b/fM6kn/w4zB9wiSUe2gMK0J5QFB7WVI=; b=nd1WOgafkrKqzw1Sk0SZHWmaIsHu9hivarcdWtiph1U8e97u8Lr1OicCN1c00LLu3aR0i+dHSs4T1Y8fZXqSOX2zkuSqInxkjmJmcopH3AmhECaI5YbKuF60Dtev+DQ35JMwuyqVGE/DxnCiebnVfLwey/AE+jnVlApmXItQvUg= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by IA1PR10MB6711.namprd10.prod.outlook.com (2603:10b6:208:418::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.19; Fri, 8 Nov 2024 02:49:16 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8137.018; Fri, 8 Nov 2024 02:49:16 +0000 Date: Thu, 7 Nov 2024 21:49:14 -0500 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH 1/4] maple_tree: current split may result in deficient node Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes References: <20241020024628.22469-1-richard.weiyang@gmail.com> <20241020024628.22469-2-richard.weiyang@gmail.com> <20241108023050.e7gnkqd7axotujea@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241108023050.e7gnkqd7axotujea@master> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0270.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:109::20) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|IA1PR10MB6711:EE_ X-MS-Office365-Filtering-Correlation-Id: 1aeb485c-b9fc-4b96-792d-08dcff9fefa4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?raS64/HqFmI6gyexMfn9iMBuajb0y/n7VS8m+kHGPtrDLjkKjhle9GESv8tr?= =?us-ascii?Q?qrxPm6tSg3AXFAQCOOcYU3bi97x0N+gJScy92uczjC+f2A3Wc5o1ocro+DcX?= =?us-ascii?Q?5KjEdpcFww3F47c0jkreOwAXt5auNSJanUYa6ey1w21Cpu27e2DWu90q2arr?= =?us-ascii?Q?TxfU2ljcbiLTH2KbFaBfj5j4IjOuegrozU6o1PY8QMvMa6Ik+5/HC+gfopHi?= =?us-ascii?Q?Fqth7MCmsRCwzrj0pYqf1R2J2MHW9XQYvKFqCMfuxXOe1Vww022z1ssC+bpQ?= =?us-ascii?Q?hPyQSqYeaW98WvOxD/5awpATNXGXeXBE8+CRQb/EyDXF80+T1jS/qI+qKgZV?= =?us-ascii?Q?LQn1/5sYF4PHKkKQIS8d4gdtKHIiG1FJd6WqCgTy7IX0yXBZTg/OTWbT50OD?= =?us-ascii?Q?HbBJnuVcZXwUqAx7btzviLo/Ql5AxbixsXUJ/yHj7z9dlqDZdrtEDlb6qtGT?= =?us-ascii?Q?HGYpqSgJMkESJqznub1CK1XPr4tQtPVWf3JCR3GTwx6JHluSEMOZGhDKWGGa?= =?us-ascii?Q?ss4FdDbxr9OHciwQsDws7J1aMx9J9XH4eeTUzbnhv1PiQq4/vxQ/2rxr4337?= =?us-ascii?Q?3ifCWlpwfrlme5lxwfnITIXUKMDvGgpoJJNQwOq/hM3lel7tOOXI70UniZOY?= =?us-ascii?Q?MHUJ0AlJKhWHjkgrtFTv3Q9+ntp/QSeulPpIBtIhoXcqax4hrk/Ymu6E6IYk?= =?us-ascii?Q?yHEZbX1ABybfhb7I5gxfjJYMqA+gjFCYCW0IIdAqDK7fTjHw++UGFpw3b+ua?= =?us-ascii?Q?cV+he8Qc5GGns+lejpssAVTTlu7/kA+kHy9cqe7x5W0kVXAWT34UNBuPFD1e?= =?us-ascii?Q?KdpG7bnUf7wiyS95LbCuqRPQWK0/PWfNbx8GFWFiPo2Yo01S5GhglLUrdr3W?= =?us-ascii?Q?zZ4AsMDXO5DvCXFjw1CDy66OQYOrQkVINcXX2ug0MXSxaDVlUGbji5tPVpXv?= =?us-ascii?Q?/ROEaiuEUU5/+dqhRMhtKvTlA/fQY0A5ONoXDJOECrN2h/GwARjP6rqCTG3h?= =?us-ascii?Q?IXgZ0execFy/r86UnRJna6OTcSAeukYyDWyBguyfPNi/mNFmgAjEmb2KI7a2?= =?us-ascii?Q?JQ63cN5zdtVnP27BAok546meF7Wr+9ImS9olgfG/NwL1W3DsO/VnbNnOlpu8?= =?us-ascii?Q?wGcXaSq2Q6RDJq2xVBZxLuu8uMdUQ6iHTB3LAkaZg7wV1EUPsX37JBu6RXhE?= =?us-ascii?Q?5FSiLGdhd3qCkVaqehaMYXeP9rEz3CIPkUAb/vUy+/fcDlTIA3mYD8qXZZW8?= =?us-ascii?Q?ATo3ochgEMtLXhgzzrn0JfBDSzfz7mHvQa9fC9b+6fhcbwahMoX1wY64PcrX?= =?us-ascii?Q?zaPHK2aIH8wk3x+6+Xa99Rmw?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gk1y4WzZ+NYH2wzobuUk3w1MpB072JcYHAhVuyv3ZdnyEa1lro9IB0rSDDG1?= =?us-ascii?Q?M8P7XJRRVuKXqx5xVj2md2DUx8y5bN1g25mdUlSXrSh3DzRXhumAx/PeDEcU?= =?us-ascii?Q?JMMiv0noAAR3cPLIL57e99uX+zvnzVJA/BtxN922ajzb6a6xGRQA5cQZCNAB?= =?us-ascii?Q?0e2DgXLkbqr8/cs9RKiU6PSVD4/PX8jJEOEvYkzCvUVMSws14Uqcw7FJygLZ?= =?us-ascii?Q?ZIASm++RCK4wOK5qgbnOQzlHknZvzpG1EI8yK7eAXTdQ2cH+9piAQS4h4Sab?= =?us-ascii?Q?c6SjK0sKJnTiQupGGJcvWzDsw0h739QXhi3G8+40Aa7L6HadmyPJ/toyKWBv?= =?us-ascii?Q?snowW7gw2IeIiIaftRnm8l/Vn/xtcQ3i/b9t0EGEbeIgYDHqoqyLFC5CYqDh?= =?us-ascii?Q?9G6rTlh0lcu0+WcSd2VeEarDW3A4CJSxPX8ZHeO61dfHC2Yhlwl/TUg88RL9?= =?us-ascii?Q?WGraVENmNzglEIRt2epMqZs3a9IudvMj7QuF8f7dO5JiCtmJB5X3e7BV4GEG?= =?us-ascii?Q?EKRVBicKlrLhehXNWsKaRR8U55pp8KLxl18Yb8/8YgIFCWY2UUh0B6ZRXfiR?= =?us-ascii?Q?i9GfOC+FoSe3Qg/CwhPGdLh/T1w0FzQ0El71F1k3Gszon7Ezmjh9pHB0uW6g?= =?us-ascii?Q?MHe+Sd3Qe/dUK5krXg6NG7ADi5GWpX6/76jinl6LEy4zjNMzmvrJUoIZQA2q?= =?us-ascii?Q?1Jjh7eHXPgHBKhuc/zZw1an8M14yWDh2I+KKgkbjvyjJVh2aZbPDXtGJTyxM?= =?us-ascii?Q?D15B2VIpop9wd5FldGhkDCo1QWvCFy2qA4rtA8Ld2HouhbjEEvgmIeihv5o5?= =?us-ascii?Q?F0MGAH6+bX+bFA/KT+KVabGi6EpT2aKU4J5pCNjveQRW5knZm7sHtbeDrGDl?= =?us-ascii?Q?4L2wk2iMyJ5J86xm21RikqN0Vx1qODt/j2iMjvjDOJsAN0bgfGbYvAXoQe+9?= =?us-ascii?Q?z4eDEu8SnorRF1BdpuD/679detrBTeXpO4ousk6eYmRIOisU/by/AgiWdDCo?= =?us-ascii?Q?hPKnCc1yXAHvdQeB+l4gCRP7qegxUMIZkVKS03bYq4Aetd/OdUdY1QBLjV8R?= =?us-ascii?Q?MFRbQjOQIlguF3UZquNMbEYPa4brBY7S4hReE3kyI3ud4NvlsF25xC1Xbma0?= =?us-ascii?Q?Pr9tZAbw18gLKn8zMqY8VOmKKdk3b2RSZO5O6BWrm7M3yQi9HpbQAHY00L11?= =?us-ascii?Q?/onh3mi0MzBpLGafFJGKHGksAGcPrLt635x4T84BPcO/SPhSah5pJ+9GkNk4?= =?us-ascii?Q?G8x73Sp4gzzA2RSE7CGuvRs5GYOV6WyToULIjEt15u+xHwT21YHxPF55yKzX?= =?us-ascii?Q?3YbowMMIf3wIJA28bys6e3gMZZimC+QB1nsNWCdX3vQNJEHP0wWi1b9/V2DN?= =?us-ascii?Q?DtsfgvtcbDdwPk4DKjBD1GIUknBOUsNYjstYIBceqxzEdIMHq1L7VcqTEOIu?= =?us-ascii?Q?TzOUNHs2gBsET52gwShWrCEVY8MN274Tgfajao0bXZs56j6R1t9M1m8FuWBQ?= =?us-ascii?Q?79By98ChMbeJ2E+8ZVd7+RHtMXtjSp60QjLjMau8wLGLDSjDpMteyHWv08IB?= =?us-ascii?Q?RUqbFUgpfz+I8fpfrvNRz4GgPLAAU8GdisE/b0Mu?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Hx8+O5Ay13h0jyrp5lecql921JdqQ5oytoxBjSG6BngqcNbOU+1ioolF44T59FVsSDpP11+yGNB1AZQakCZGmfgtaTFrv+ydh4Ijn2lTyDSTVZm/6CzXzwx76cZ+yHmljyOPdzUiWmEbJlAeFuOWh4lMCDuq0pttR/W7LxPvjejJ6rxTPJ6+mo41XljNU2fr7NEGEq9ZMz3+dWjLwAfHLs1uX0ttBkzKSwCzbZOcumA8/BeMxpZunMTFR5KjLP6V6/LkyGLFdzRdD0HjSQKMijmtg3AwT/D5EdKJPHJi49D8CuqV0tiW08MQX8HkMrcPl8sp1p/VeFCT8RQWa6c9+MkQt8xHkSxrDplid62M28pjTv6M2Gn8y509Byyz3h8aE0dko2157PRxtapDy42xakYYuJHDLz89VQmWcoMa0+PH9qCpnsFDBcYfPN4XmVTq0z51wwPeOKwrvwHix0qoP+4+UZOTAawEnyY8SDNoEzgUk1QBShqHBBfBYwvFlBTaIASv4CeIzJ/qBV7/KSTmJ2cuCkEO1PxbgZ7rk5EIkJIaLVZQSvvymifYOW7fA6brpfAYyqvM+MQXAXwua2jpeCPjKeHOL3h0fGkUcvo6SXg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1aeb485c-b9fc-4b96-792d-08dcff9fefa4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2024 02:49:16.6646 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ltmhrQFVqtKT0uPQpP0sGtv/9UjjJi9oKRXOYUnOj8jVkXqCUfsPzFHPuRtotXO1xyS4HG1TMnlZON4iU1GepQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6711 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-08_02,2024-11-07_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411080023 X-Proofpoint-GUID: fxP_0BDrXf6nbOtmJnNaKUv8wxE8y5FA X-Proofpoint-ORIG-GUID: fxP_0BDrXf6nbOtmJnNaKUv8wxE8y5FA X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CD7471C000A X-Stat-Signature: nrakndkn6dye9dwc3ihfeoj6krykfeax X-HE-Tag: 1731034093-69007 X-HE-Meta: U2FsdGVkX18gPxiQTt7YsPtcogfalmYgJtzP7/UkUlmVZn9m1qwMhlaD4+WYFnkCPf+CGEDhRTD0r7Gogrlrpm5Ej4D1zzRwtVptIl4+fOZCwkcq80xAoWMaw20ZgNZTs5JiDQA5XrEUTL11BvpzYN1rHaz5TqxViqeowdEWkw9ZB9vIeMoj6BOzSCQHP/FcG1Fwi+kOnmnNyA9xLo5tbqt/n8JHyv8Jj/P28SLX/gAO/2AsaEqE9xZVKjBZU4JZ928GSkfrT35tPdVWB/ZF6lqo1K3RF14b8uxkF6f+71qMTDXFkr/F0L4DWa/h3NR61fTYOeBwLArWNiQxFbwYRWkUjY41sE2Eh7F2S9fKS56hndVXCr9G3A25wk64+bTP2VIbS3QYmZDAEBq1Wjit7radkLdjef0loGcCEpel6ciSsfnszVs9ZjmUpA26jyViEboZHN1LcenwbjYB//cy+XL/i3vB6f4xNSWXxYsYrUPFflviSYRE7oicQATedt3MLP9hEh77ahtmjkQd4gYmyvtLm7PBS1xhIsQAXMnzO0bIgIDRqc8IEtuKMTsisPGBtKUAKjoaAx3FboJ+C+odbJ/O4gWqzVG73QviOeRO91pF01ceJXoBvZDvSFaWTAOfp3KtcTXoO0kcawErJ7s+BjvJcA9x4gY7h5+/h09crpJXoZMfvFJ8ODfzmTs10ky0ibFKJ8NT3N97X8Ei2mauvWAez64zRt2foD+o2jAI3zSvbQw/2ZjRicu1B9T5FNBKstxx7KHAOJLvtcWxY++KrZT4FCFqGEmzAMvYh08aHXttCqqaOI8Hnb/nU6Mb9nNOYKEbZyPfE/D5skE8mMtI58xRbG/axBzWYqT5UAUA5CTjZnIiaHUjL+tjpPLwmXcEQJ0fkT936RtX6luXgTdEggrxok7+nccvjnBsPPFDGycGwKZxb/CPzYUU3nqxOIOLSTd+3M1rk2Q1sKWyuJp x/DN+QkH xeR1QyX42+Oh9P+C3HK7XQyViNwA3zh4B4aCBeOSrN43zmgGltqKrsWgH0HROlf3spbeuSRBO8biaLlmZS9dKqLyKW41RunQRI1A+/je3WmHGpggKbtWM+82LlfR7umJPCjJttWuYFEAHU8wtu8YERz9pAXDlSlHD82zYt8zupfRXVznhfNOgwEK5G8vbwQgz73FI1QhyfZDG9QlJ+EiiIxUa+QOeaKaNSfrwWvQiUoBik4/pDNMbXSJmwJtdmhLSKsiOvWAtgrzxYQfbxqDUj6+3ayy2RASGBHTpnfd5x60g57Yn5j+/7XqGNe6PYacYtcjZTzeaIS5TqKrJZO5MplzU51hfikLUMtyqUG1wtgaQJCFqY4ZUFdQZT79wBMNFpbq9yi4YtLXD2gEvzkZHqU36pzVfNTHHSq65IAmatkAlqjEMrWPvorQWEVLlYa9p1B2TG7X1t2aLXctxfaNbB7Gb2vPjLV8quK1TOcaXpPbTe1EihyS/EIEChxIzmRiesMyW7bG3FB1/OY0tPkOY9ByuQI6hSK/3d77r4kKvZVl24C3iQVovgeHa+uTjC1MACZhCpUJ4rjJvf8Wv12Qx/V+mv5OdwOBTTbC4Z63huEOv/DIx5A+z72l+upvLYUn09ldNGOzm9fBY0m6IwJ6bmu1O8xe0xZAO5ESINm2ydLJ5UCKh2qT2thpCskEZBPGkI2sSsIO0jPnVWuOCeIsI9bqJsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002469, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241107 21:31]: > On Sun, Oct 20, 2024 at 05:55:10PM -0400, Liam R. Howlett wrote: > >* Wei Yang [241019 22:46]: > [...] > > > >Don't state the code, it's stated below. > > > >I am still concerned about jitter that this patch set may cause. > > > > If my understanding is correct, the change here won't cause worse jitter. > > Below is the dump result when this case happens. > Let's name those nodes: n1, n2, n3. > > maple_tree(0x5611079e1680) flags 9, height 2 root 0x615000001c1e > 0-18446744073709551615: node 0x615000001c00 depth 0 type 3 parent 0x5611079e1681 contents: 0 8 18446744073709551577 0 0 0 0 0 0 0 | 02 02| 0x61500000210c 10 0x615000001f0c 23 0x61500000120c 18446744073709551615 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) > 0-10: node 0x615000002100 depth 1 type 1 parent 0x615000001c06 contents: 0x1 0 0x3 1 0x5 2 0x7 3 0x9 4 0xb 5 0xd 6 0xf 7 0x11 8 0x13 9 0x15 10 (nil) 0 (nil) 0 (nil) 0 (nil) 0 0xa > 0: value 0 (0x0) [0x1] > 1: value 1 (0x1) [0x3] > 2: value 2 (0x2) [0x5] > 3: value 3 (0x3) [0x7] > 4: value 4 (0x4) [0x9] > 5: value 5 (0x5) [0xb] > 6: value 6 (0x6) [0xd] > 7: value 7 (0x7) [0xf] > 8: value 8 (0x8) [0x11] > 9: value 9 (0x9) [0x13] > 10: value 10 (0xa) [0x15] > 11-23: node 0x615000001f00 depth 1 type 1 parent 0x615000001c0e contents: 0x17 11 (nil) 19 0x29 20 0x2b 21 0x2d 22 0x2f 23 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 (nil) 0 0x5 > 11: value 11 (0xb) [0x17] > 12-19: (nil) > 20: value 20 (0x14) [0x29] > 21: value 21 (0x15) [0x2b] > 22: value 22 (0x16) [0x2d] > 23: value 23 (0x17) [0x2f] > 24-18446744073709551615: node 0x615000001200 depth 1 type 1 parent 0x615000001c16 contents: 0x31 24 0x33 25 0x35 26 0x37 27 0x39 28 0x3b 29 0x3d 30 0x3f 31 0x41 32 0x43 33 0x45 34 0x47 35 0x49 36 0x4b 37 0x4d 38 (nil) > 24: value 24 (0x18) [0x31] > 25: value 25 (0x19) [0x33] > 26: value 26 (0x1a) [0x35] > 27: value 27 (0x1b) [0x37] > 28: value 28 (0x1c) [0x39] > 29: value 29 (0x1d) [0x3b] > 30: value 30 (0x1e) [0x3d] > 31: value 31 (0x1f) [0x3f] > 32: value 32 (0x20) [0x41] > 33: value 33 (0x21) [0x43] > 34: value 34 (0x22) [0x45] > 35: value 35 (0x23) [0x47] > 36: value 36 (0x24) [0x49] > 37: value 37 (0x25) [0x4b] > 38: value 38 (0x26) [0x4d] > 39-18446744073709551615: (nil) > > Since n2 is already deficient, removal a data from n2 would need rebalance, > which is a jitter if my understanding is correct. > > After this change, removal a data from n2 would also result in a deficient > node. So this is not worse than current behavior. > > Do you have other cases in concern? My concern comes when we have a node with 16 entries, then add one then delete one, then add one, then delete one, then add one, then delete one... I am not worried that you fixed the insufficient node, I am worried that the splitting and rebalancing target will become too strict and cause us to allocate nodes over and over - this can be even worse if it causes a tree expansion/contraction further up. There are a few benchmarks that do this more than it happens in the real world, but it is still important to handle this case for real world cases. Thanks, Liam