From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE4C1C4345F for ; Sat, 27 Apr 2024 01:18:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CE046B0099; Fri, 26 Apr 2024 21:18:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57F326B009A; Fri, 26 Apr 2024 21:18:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 445D76B009C; Fri, 26 Apr 2024 21:18:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 264E16B0099 for ; Fri, 26 Apr 2024 21:18:20 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D05D81406F0 for ; Sat, 27 Apr 2024 01:18:19 +0000 (UTC) X-FDA: 82053551118.29.3B1354B Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) by imf10.hostedemail.com (Postfix) with ESMTP id F3673C0007 for ; Sat, 27 Apr 2024 01:18:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dgOep0XN; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714180698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1KyQAvNmH8cK+YgrZdteZGkEfU1LsqfdtvT92BFP4zs=; b=bLJcNZA4eDJetHdtjc50/3CAyFIW/N9XnxvpxxlnCImb/tCe4uDUKtOz0isz+0zvK6hnIW z6B65cKAlctHFvXFQ1ADSP0v8ipEYy3Zpxtyu+etARoQ49QEQahAa/DGmQzKu5uozSGsmX SWBo/6ZfX6IFyUFFR65FI51bf8WeBGs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714180698; a=rsa-sha256; cv=none; b=uaMQMqJWcYKNMqc5/TKeNh/YEW4sN7fsh9lbxmfuW/hJ6ZJi3pYTTNQpkqVH4MBqbyJCB8 ySpxx/8/WrblN+i6Wvp4uIOLDE2E8Xo979uZYYHmODLWV0BjaeTVfqLNYo5EK1lnOFWUSx 5rOqEK2dIPzkN483tYzjMRK7fIZV4TI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dgOep0XN; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 26 Apr 2024 18:18:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714180696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1KyQAvNmH8cK+YgrZdteZGkEfU1LsqfdtvT92BFP4zs=; b=dgOep0XNlHGarvM2anPP/ocidn8aiFauFWMVL/4H+jO07miUU7fqfv5JREfQWrhxIbJNch USGIoyNCjOMiZoftkwWiZRd68UzI59DYglctp7HxWO1n4Y/jmFQ/NxOkZ2mD17TqSFe77+ 8GmQ9urU6LOMfEywqhlZXcewZn0q3Ac= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/7] memcg: pr_warn_once for unexpected events and stats Message-ID: References: <20240427003733.3898961-1-shakeel.butt@linux.dev> <20240427003733.3898961-6-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: 1cwkhqogprytrcggrr4ewno77w3cax75 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: F3673C0007 X-HE-Tag: 1714180697-963692 X-HE-Meta: U2FsdGVkX1/Hjbt2zsnfmW8dR3Na+YJRP29cHBeOK5cOlaK3T34MyvinCvz8DVMkwWL9Xs13cJc79+ADBu60Afw8+tbIebew7ePf48apDgZLiI4tB3ibc4AKHXr/4mahXUYaBfpjXHUBcqUmCtxvHknBeHlWTlnLzq7m6Vc/JmMrkO9Ph2CNlsqb/HbTQwNBXR8SBMF5fMHwryFrAD0/5TmO3VC2U7KOTnHbW1bTK+71D97sWh7Lglm9Z5MNFZ/wCmhae8FQkgW/557EgTTg5hP8zs0/wNAQdIEk0HtVVD4G4Tkrljs4qIg+B4Y75AalAbZX0RpxUcRwQWm7LBw4cdaHcvDmw9tWxqMpJlxNGJiUNKcyt9O7uA080bBvuXjHdhZAVslu2iZwI135wI5eZlLcFVS/XIagbmDk5odZVlNfJVy1P7YTgkZz4Bc0wQYLCayz4Ke+vIMvDXyYrxvNKh4txCwi4iwkL8AnLnawggcEUzB970ffAAboZSRs4fxh3+0kB7HuTd4SVF+VTOplwX+DNVB1PfqkIn0oZN7695NcOzKnbB1Isil0cCx6cSE7ra/tZzx+7IEtUNqXzZ24oMEhXavBKFAFKxd8sEDB2Wylu7SilzqJqjiaO29vgjeMSaHaFa/GUYOxh1GUydwvFoPGYRp4jscvz9nZHU/ya10kVva/5DSk1axDZjieO9V5qhkhQ6XEjDlx0RJez2v9XNSNhSfTFarYRlQ7qQ7+dLfew+tO2+Oydznu4bk4rSxN7GEtWQvMwfF3MXp84z9Y64Sf6xiIlmOvAscV9xVcx1MExmQq5TVFe6g6T0S4TWnaokV4saTeFmICBYpJ6FiixedRT9iKKFBuOXPs1MP2V5x1schZom8lYlK2fdQh9lSnjQ3a73urDpFTiz//X5FIb82wRtNML0qkTwOSdp3hGUsHvvRSuKtyVfHiWKuQrXCF9zSbKSIjs76/QiZFNsi fvTpdZ9q rAlQ9aV8s1PMnOYnnQRmqZv7kwORt8kdf8WbSS5RtayUkck2klrySUqxro6JDvztYGyn0t7t5fYrgYyqIkOyK+fAGfgQ/bDcXEchmRbHb4kqFOpZWJpzSzxeI38zTWLTeUzZ5PAmu9fdtZRGVMWB9NzcYEEeYPMLKOj3j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 05:58:16PM -0700, Yosry Ahmed wrote: > On Fri, Apr 26, 2024 at 5:38 PM Shakeel Butt wrote: > > > > To reduce memory usage by the memcg events and stats, the kernel uses > > indirection table and only allocate stats and events which are being > > used by the memcg code. To make this more robust, let's add warnings > > where unexpected stats and events indexes are used. > > > > Signed-off-by: Shakeel Butt > > --- > > mm/memcontrol.c | 43 ++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 34 insertions(+), 9 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 103e0e53e20a..36145089dcf5 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -671,9 +671,11 @@ unsigned long lruvec_page_state(struct lruvec *lruvec, enum node_stat_item idx) > > return node_page_state(lruvec_pgdat(lruvec), idx); > > > > i = memcg_stats_index(idx); > > - if (i >= 0) { > > + if (likely(i >= 0)) { > > pn = container_of(lruvec, struct mem_cgroup_per_node, lruvec); > > x = READ_ONCE(pn->lruvec_stats->state[i]); > > + } else { > > + pr_warn_once("%s: stat item index: %d\n", __func__, idx); > > } > > Can we make these more compact by using WARN_ON_ONCE() instead: > > if (WARN_ON_ONCE(i < 0)) > return 0; > > I guess the advantage of using pr_warn_once() is that we get to print > the exact stat index, but the stack trace from WARN_ON_ONCE() should > make it obvious in most cases AFAICT. > > No strong opinions either way. One reason I used pr_warn_once() over WARN_ON_ONCE() is the syzbot trigger. No need to trip the bot over this error condition.