From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3178DE64006 for ; Thu, 21 Nov 2024 18:25:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 712696B007B; Thu, 21 Nov 2024 13:25:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69A416B0082; Thu, 21 Nov 2024 13:25:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 588C86B0085; Thu, 21 Nov 2024 13:25:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3873B6B007B for ; Thu, 21 Nov 2024 13:25:39 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E06618148B for ; Thu, 21 Nov 2024 18:25:38 +0000 (UTC) X-FDA: 82810928676.21.3082A01 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf30.hostedemail.com (Postfix) with ESMTP id A96CA80019 for ; Thu, 21 Nov 2024 18:23:56 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WJIKJtfx; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732213469; a=rsa-sha256; cv=none; b=K/1Qqim2qjqzlKsCOT0gXaOGkfE2MsbCybaO9lRjjtN2fIwV9v+KO23McXH1wknv4KWyKu j4WTTS9P0BwfJfvtp76qujLPlyEhYTACJGpjELJkkDBV+5QKaJsg96HPVaJLYmj5qJk1hs 92fbVHFBp+yVuqu55AHyciAW4rU9r3o= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WJIKJtfx; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732213469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ihkFpriMDTn2R0Csp6uPIGw12MhtUrO0pmOXiS0fygo=; b=K4ev4RyvIBQ5uF+OkWEYlFjqDpQk8e9UiKAo704mVsyb+F7TxhkdWLw8UxRLm6tWGJgQfm MyEW4VKUbTp3bMjeXHh+F37hcIg92KrPDLR0yPIywNVr/fufTK1BT4mhEf8M5Vq3wjBdux ck40zizDJ9GKPU6x8y60lra0ALxHsW8= Date: Thu, 21 Nov 2024 10:25:19 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1732213534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ihkFpriMDTn2R0Csp6uPIGw12MhtUrO0pmOXiS0fygo=; b=WJIKJtfxJw6Tz2pnpC6xE1Aq42D6R3khV5PxF1ZUKlQPDYIleYJB3h1hCY2dHlvoFOYsDG y0gLxXQJQNjPW9zBdiMbDsrIZxOl7/NbaF26QTv7fZ42XN3jX8olhmfsy/VxlN4X80HJIG Rykl7Xr6u7FUxcdg6x8w+Al7STALnA8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, souravpanda@google.com, pasha.tatashin@soleen.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 2/5] mm: move per-vma lock into vm_area_struct Message-ID: References: <20241120000826.335387-1-surenb@google.com> <20241120000826.335387-3-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: A96CA80019 X-Rspamd-Server: rspam11 X-Stat-Signature: wwgc8cd875fftgrnpffhqp4q86jsurej X-HE-Tag: 1732213436-48524 X-HE-Meta: U2FsdGVkX19g7L47xlwGggqdHHycuqq/ZFjYkUsUhrRwLA0xgs+UOdmY/XOGjQyKUCuuIiV7O5Gyb6c8L6cKC7XtOShNNyjnVZ00tjpoX+Gom0mheJgJah1Y5W8G611kwaza1kkpteglQF5mRWvOW2QDaGzWTqL9zaNb4B/Ck4KviW55UX0D00zLZdULlsyWKH5UbQ0UZiCYEpVtwN+hvJkUJ1LKYN4vo17iEYdI/CB1kUEFytEa72iFUpzLdpRLuWLK4bl5H8FKv/FN8l5Q279LzsxlXiNHnmuJfxt/hlZ1CK4ZF9fM1jxH951gGDAC9rhn6hfgVEoIFrDK9MqhguQ/9w8k7Y65I1M4kAQ9oJTtwxcM5r/+9X8UilOxA1bwhd5DKrgp2GUDdiF96Cgy4R2Qd90eMigH1EZrKu0cb7SC4hi7QFZrgr2g0Vz5aZupzt2EYfPK3BEhFnH8Ap5AwQF9uNHuApgJ/wjjqq6moZZ2c/rwlxu6s+1/1ZNzjQMozb6upUKi7j3bi3uBKwJxovDpMwJzK7vCC4Bh37w3LP4SNshe/L10XiWKBnwZnCqlHjKIJI+pIqM/7kYo9URvj2vASqPmpJu70oUCA80V3UgO3zm3TJYOvDZS6GhjmdQ0NgUklFFR8xHvtQOowBOHUbobbsrcwddp612v7AW+Oa3TZKr7uPfRq0wSU4tnjlW6uzBWddY8NLsd/YU5Fz9O+H8xF+vNtObzhkuesmf3vg6GQVBPpxCIm2eo8lKxbgpkBMt/QvWZ38/EOOAQfUEX3eeiEnqBG+7lO88jcgDUJpzOfeJvaKfGHdZlavYb/uJXZLfXzprPNpcBtjDVnXVTv/xBmXpEWi3TKMaMtq28nI9h1ahVWpuuFU2pHXkRq5tb8lZysEY2G0DCutVTGCsbMjdxymlHpah/CAhhOZLIGGuIKLKuu/lVzpdd9tI0c+HQ2cQmVAmw++/eGO9fgKI 46ipUmMD NWAnkAAvKZJnJxgXGUr3S6dhL2LfaZe0Vv6IYHFJuakuNmTXCXbKyRzpyPZss11B4os0ssThGi5MPWt/ZyMkNR7Rkn0PDajGeGPrqo+39rYXu+ktu60ddy20O5veQIlS3MIWUL1qab8BmtrJI0KC9qLv2yz+I3kXdSdvji6bAenzo39GVUhlo04Bh5y+nbqbcnhwRIzdQrftPxxWvxWQTTMv4iBi/bWf0kKh1ptdJGyA10Ag= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 09:05:21AM -0800, Suren Baghdasaryan wrote: [...] > > Sorry, I should have been more clear. It's ok if some fields which are > rarely accessed in the pagefault path are placed in the same cacheling > with vm_lock. In fact I've done that to pack them better in the > previous version of this patchset here: > https://lore.kernel.org/all/20241111205506.3404479-5-surenb@google.com/ > (removed for now based on the feedback). So, vm_lock being the only > field on the cacheline is not my goal. After this patchset I'm > planning to try packing the members better and save some memory. > Nah, my bad, somehow I thought you want vm_lock to be on a cacheline alone.