From: Yosry Ahmed <yosry.ahmed@linux.dev>
To: Sahil Chandna <chandna.sahil@gmail.com>
Cc: akpm@linux-foundation.org, david@redhat.com,
lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz,
rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org,
shakeel.butt@linux.dev, zhengqi.arch@bytedance.com,
Liam.Howlett@oracle.com, weixugc@google.com,
axelrasmussen@google.com, yuanchu@google.com, nphamcs@gmail.com,
chengming.zhou@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values
Date: Tue, 18 Nov 2025 15:46:26 +0000 [thread overview]
Message-ID: <dqmiid7ep4b7lchv6qwniedftoqzo6qit5py3dwo6whrcljrbr@kydq6avtuypd> (raw)
In-Reply-To: <555cdbea3a51898e4c84fdc0f444dae0c2e20f24.1763227530.git.chandna.sahil@gmail.com>
On Tue, Nov 18, 2025 at 11:38:51AM +0530, Sahil Chandna wrote:
> Use the %pe printk format specifier to report error pointers directly
> instead of printing PTR_ERR() as a long value. This improves clarity,
> produces more readable error messages.
>
> This instance was flagged by the Coccinelle script
> (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe.
>
> Found by: make coccicheck MODE=report M=mm/
> No functional change intended.
>
> Signed-off-by: Sahil Chandna <chandna.sahil@gmail.com>
Acked-by: Yosry Ahmed <yosry.ahmed@linux.dev>
> ---
> mm/zswap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index c1af782e54ec..c35604db32ad 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>
> acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
> if (IS_ERR(acomp)) {
> - pr_err("could not alloc crypto acomp %s : %ld\n",
> - pool->tfm_name, PTR_ERR(acomp));
> + pr_err("could not alloc crypto acomp %s : %pe\n",
> + pool->tfm_name, acomp);
> ret = PTR_ERR(acomp);
> goto fail;
> }
> --
> 2.50.1
>
next prev parent reply other threads:[~2025-11-18 15:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 6:08 [PATCH 0/3] mm: Coccinelle-driven cleanups across memory management code Sahil Chandna
2025-11-18 6:08 ` [PATCH 1/3] mm/pagewalk: use min() macro instead of manual ternary Sahil Chandna
2025-11-18 10:19 ` Markus Elfring
2025-11-18 10:45 ` David Laight
2025-11-18 15:18 ` Matthew Wilcox
2025-11-18 16:56 ` David Laight
2025-11-18 6:08 ` [PATCH 2/3] mm/vmscan: use %pe to print PTR_ERR() values Sahil Chandna
2025-11-18 13:15 ` Markus Elfring
2025-11-19 1:52 ` SeongJae Park
2025-11-18 6:08 ` [PATCH 3/3] mm/zswap: " Sahil Chandna
2025-11-18 13:20 ` Markus Elfring
2025-11-18 15:11 ` Matthew Wilcox
2025-11-18 19:28 ` Markus Elfring
2025-11-18 15:46 ` Yosry Ahmed [this message]
2025-11-19 1:50 ` SeongJae Park
2025-11-19 12:50 ` Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dqmiid7ep4b7lchv6qwniedftoqzo6qit5py3dwo6whrcljrbr@kydq6avtuypd \
--to=yosry.ahmed@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=chandna.sahil@gmail.com \
--cc=chengming.zhou@linux.dev \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox