From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00EFFC5AD49 for ; Mon, 2 Jun 2025 16:53:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 981F66B02FA; Mon, 2 Jun 2025 12:53:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 959DF6B02FC; Mon, 2 Jun 2025 12:53:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 897DE6B02FD; Mon, 2 Jun 2025 12:53:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A02B6B02FA for ; Mon, 2 Jun 2025 12:53:20 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D328B1D6A46 for ; Mon, 2 Jun 2025 16:53:19 +0000 (UTC) X-FDA: 83511056118.02.19D7DD0 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf11.hostedemail.com (Postfix) with ESMTP id D63C740010 for ; Mon, 2 Jun 2025 16:53:17 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EqgEkwBo; spf=pass (imf11.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748883198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5agi1qs9OW78m3JphTzvG7DfpG3RNEiOQUPRyolTd6E=; b=omt3yGesDZiQY5OzQDB4YUCEZbu8pdZJp9ypQ1FLIGgQ3fBM5iGBBLGBx2JP44Kx9g9do9 8hsiJLCqNlYmV+I20iLaduENEpgB4Y5cFYsH0x+fH11tVxWeEtLkn1kNPRDILNYeOYxACo /I1QoaMxybmFMPwG7FeIM3IPRv0venQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EqgEkwBo; spf=pass (imf11.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748883198; a=rsa-sha256; cv=none; b=8Tpf3B7XXuW9TENvybzb4p3I/FQ1x+c3UA7EnGwPU/V/No7dmrF+vWiZ0mL0uGhbz8ckbN ZtCLLfNzSpbb1dK1UdirbUTXkSRC1+muqfMgQBmVLnObNMWx3NxUsnrPE188W1aXe9DBDt c7L7Gp10/081Lb4ZVdvCpRnEYKPeJyw= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso1305282f8f.1 for ; Mon, 02 Jun 2025 09:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1748883196; x=1749487996; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5agi1qs9OW78m3JphTzvG7DfpG3RNEiOQUPRyolTd6E=; b=EqgEkwBoKMpE4Ok1iRj4CaLLlMR5jK7A4EkXmLwPLGYfGbmeZaT2vcZM/ZjJ+0qH8U GP1GaAJyzKhpcp5s+Wp5+Fjyu9v88BxwzrBVC6WjHEzTnocMlRIDkB3M24yvLz0hJ/aC XSlbxzr5fjy5J/URLQQ+WRmfY+1rhxGlLTbiB6gmLkmPu0u+Y/XKKNlEho3GgFvMdCc7 vahTQjvKwD9o0aTh0HkyIDzAQckioAoHJZFUGVGyG9wbu4/QtJKIn0JX1WfIzjyOnd6z xNc7/DTNZBYktnx54XBBamoX/ih4VcUye6RWNOYEAPPbIjyWN0b2ROLupk61/xIlepa+ a5rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748883196; x=1749487996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5agi1qs9OW78m3JphTzvG7DfpG3RNEiOQUPRyolTd6E=; b=r4e7yL0qaW1aN5r24G3x33DlFoJkLuqYrcdvL74u6MYuJUemdtIn171yC4CutFjKNv adXkJ0hYbs71F/rSm/K6XTzJeuIxUiLGUJAvRFocDhS6OAeHy8fcThFocMsXS7amhPGk iLtYntcqmz1Mu5jbj0LlsFdiZGN9TJZdcTl7PJZ7kCNIDOUb3adhQlqS3yRpSGaJEHUN BJljP5yGVXFMmZ7yncgK0hd/Z8xsDCo5tXdc9ohTMBTMzZo3OlIVgt9ELbDuZIW++Oxg xForQPfPtVEuTKIhuP+N3swRhxTGjReK5GykZU8DYHWQMq1i+Ibwk3pkAiM6XUXAveQh 2ArQ== X-Forwarded-Encrypted: i=1; AJvYcCV+L4UNJRQZZSDRdELUGJYIHjbv4yTYBu5JjcfHLUhrCkE9yPGEamefTSm/is0okKP0aInPRNAwDg==@kvack.org X-Gm-Message-State: AOJu0YxFaVx6qJbTovb3/BQBP96gUU7EfY0I0IUYov0Krz87mefr92JB 2ZjTDl3tXfbkiekuINuKOl8bBJ/s4FkgPT/UKQwgv/LZ2MZXD7RCZLobMPUWOn9sx54= X-Gm-Gg: ASbGncuoYmudaFVIm/Kj+tfl10/eOB70J57RRyW9+YfH3xxJCUDA3CKSM0KfyfXVIZ1 AQlHtcgxgR2YQATuVHpMLl5EpcjkgJD1M/8BwDLBaxJlRKRIPke3Vn1MOEwv2Ri+3FK6mQU3C0f 8yYIWp2eMqwFhEQpf7ooxSv97n2iaBd8IF/cUFhp9csHR4281EbQg/KrALS8jW85k8/H2btTNJX L3ZZNgfBiyBr4atI1l3RAcP8CieQbrMCzc10saJUa+a6a1W6QQO9AnHJqXHti5c6+pxCAz7Hfv1 d++gZ/W5HQ2Rp71+MAxdKEfCcqY9KOTX8UObba+7z2fNYehBQ9u3SA== X-Google-Smtp-Source: AGHT+IHIE0h8ks2B24+GvFatYdBhkFfv8FzjJdWIaF0OkvJ4PLpG5qpKqArlSVDjF/Tm2wElewMocA== X-Received: by 2002:a05:6000:40cb:b0:3a3:7987:945e with SMTP id ffacd0b85a97d-3a4f89df65dmr10778901f8f.56.1748883196046; Mon, 02 Jun 2025 09:53:16 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe5b7b0sm15609636f8f.10.2025.06.02.09.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 09:53:15 -0700 (PDT) Date: Mon, 2 Jun 2025 18:53:13 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Shakeel Butt Cc: "Chen, Yu C" , peterz@infradead.org, akpm@linux-foundation.org, mingo@redhat.com, tj@kernel.org, hannes@cmpxchg.org, corbet@lwn.net, mgorman@suse.de, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, tim.c.chen@intel.com, aubrey.li@intel.com, libo.chen@oracle.com, kprateek.nayak@amd.com, vineethr@linux.ibm.com, venkat88@linux.ibm.com, ayushjai@amd.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yu.chen.surf@foxmail.com Subject: Re: [PATCH v5 2/2] sched/numa: add statistics of numa balance task Message-ID: References: <7ef90a88602ed536be46eba7152ed0d33bad5790.1748002400.git.yu.c.chen@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g6yleufkzt7awgj3" Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 6e31ahyox5d5nnh8omfhgermbmxjupr5 X-Rspamd-Queue-Id: D63C740010 X-Rspamd-Server: rspam11 X-HE-Tag: 1748883197-622243 X-HE-Meta: U2FsdGVkX19jrH0qHhNkIT5MN9XwgYCG4JQ1CK/Mcuy6m2OsaHv/TzqTvQrr36Kblnn8qH7b/IhShZEcLqa6UDJxb5WPYhBcKwZkZbOSYMtGxmqx/9Nv5V9gWs8UpvW/G4ug/BpC8ZB/0sIWFT5F4c+8mGVisHARaUj/sAVA0PolM27SmPu1lImCZbpyyTJ5POOoLIHqWlCVenWjZwXXax4sj1v5NFwRIzdF4bFug93XreT9V48upQXWz2lSMgq7oGXYfCTP4Hio3XpY4ClwwTfgUsDiAtc9d+WPAXGrslyRKbCl6vqGYLdHf08yetIj++bwRyx8lJ9MTfXfjV2QjzPqTJY6zZ5lqrLXM1SMUfSKhTrE182SOQk/DdcjEQg58Hi8H6YsV2enstmN6cLLY1BWzUu+nH60IRrF47Yi34M36cdlIoOTZ7w/2fgSCoR/ZlMGQLqddg4BZXyCpGmJUOkuhjlEqQkT81SBK8LLorjfPn00fAo1qC4jR2NnQMnRXRComvA8GBKpm4vQRsLi17BGxiGAic9wUztVGLkZuEyIlFLCtKm+U9AcCM2HFCR8rr+mp7u3ZjvEjNi7M+A0UOkEU6t4dKxDkm2VYYf6iUKZiiF6NS0Y9BeaW96Q/4QoJZtFWJ6gaKjuz2kAcTNaaLP1Uki1xCURG69pycFctynQ6g3U/pVlCkLODSBBSam/6Ppm4rOCDCISIsO+z9A7NGE9Vq2p69eCTIQQ7IE/JynBae+ImeoT2ZQC3AUlfO0kr/xqe1S9U2ApI1rTFMYXuZLzmhFbJPlCLWywyegg9yUYSS2Gh0beBhEwbtG1QWP3B0cVU7C2n89tXF9mBSzHxIL9fmBrzMutehk34ukVFixmvPL0InL6CuqqjWUXneLWSzdNn0bgaUguOFf6CHKt/H26FR29UaWBjY71ruic0VRq1+0lpenK1Kw8hx5u5EcjqsReQMqKtT8gqOs4RVZ yFNwiaaY gt4aTy7TLEWcFPKa+McJKoRmcvuoVzVGIGpHC4hloF9nJDUEzKwDr7+uYrGNNNWEubc7uf/xHK/XulqEsuvqrIdfjf1YlJfvj706AVZYs7kMLR86cLFZk7dAhXXc0q4Z7fa5Qg84WhK3qc+BFwXCqBKeIrGxR2WKPKnWfnRUdrsC8q9T7IsL4XfE3cRPUhCU81YTEwR+azLMQEVCUv3AXGskKk+IgUC5JY/ahXa0iPfVWry+5GTWWK4d8a5qg8wNWQvAGBe9BU1pkSSupwlqYLED1gX7fgGNgVuM8W+SI4r6fS5a7WGk4alzFpmJRPR/Fi96Db2j3084CGWjHfgJX48CNgZ0dlskHaEoNV30PeSxdCdSYJkOWoRCjmeNgfAeAX3XW2mqqgFLwRsKllAdrA7LkCB4VTtoifDJHhY7514bBVs3n4H/5W50/mw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --g6yleufkzt7awgj3 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v5 2/2] sched/numa: add statistics of numa balance task MIME-Version: 1.0 On Tue, May 27, 2025 at 11:15:33AM -0700, Shakeel Butt wrote: > I am now more inclined to keep these new stats in memory.stat as the > current version is doing because: >=20 > 1. Relevant stats are exposed through the same interface and we already > have numa balancing stats in memory.stat. >=20 > 2. There is no single good home for these new stats and exposing them in > cpu.stat would require more code and even if we reuse memcg infra, we > would still need to flush the memcg stats, so why not just expose in > the memory.stat. >=20 > 3. Though a bit far fetched, I think we may add more stats which sit at > the boundary of sched and mm in future. Numa balancing is one > concrete example of such stats. I am envisioning for reliable memory > reclaim or overcommit, there might be some useful events as well. > Anyways it is still unbaked atm. >=20 >=20 > Michal, let me know your thought on this. I reckon users may be little bit more likely to look that info in memory.stat. Which would be OK unless threaded subtrees are considered (e.g. cpuset (NUMA affinity) has thread granularity) and these migration stats are potentially per-thread relevant. I was also pondering why cannot be misplaced container found by existing NUMA stats. Chen has explained task vs page migration in NUMA balancing. I guess mere page migration number (especially when stagnating) may not point to the the misplaced container. OK. Second thing is what is the "misplaced" container. Is it because of wrong set_mempolicy(2) or cpuset configuration? If it's the former (i.e. it requires enabled cpuset controller), it'd justify exposing this info in cpuset.stat, if it's the latter, the cgroup aggregation is not that relevant (hence /proc//sched) is sufficient. Or is there another meaning of a misplaced container? Chen, could you please clarify? Because memory controller doesn't control NUMA, it needn't be enabled to have this statistics and it cannot be enabled in threaded groups, I'm having some doubts whether memory.stat is a good home for this field. Regards, Michal --g6yleufkzt7awgj3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCaD3W9wAKCRAt3Wney77B Sd2uAP99fRZB3zwdhHyZCwIbpZAgx51Hl8FgeZoZxCpyovrMGgEA39M62oE0rmZz mcKZRPReYjxX0Ty4SyIIK75L/yiX4Qs= =IOWj -----END PGP SIGNATURE----- --g6yleufkzt7awgj3--