From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E83C5B543 for ; Fri, 30 May 2025 19:59:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BC786B01F0; Fri, 30 May 2025 15:59:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56CED6B01F1; Fri, 30 May 2025 15:59:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45C056B01F2; Fri, 30 May 2025 15:59:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2336A6B01F0 for ; Fri, 30 May 2025 15:59:44 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 963F48148C for ; Fri, 30 May 2025 19:59:43 +0000 (UTC) X-FDA: 83500639446.13.B48AE4B Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) by imf08.hostedemail.com (Postfix) with ESMTP id C74F6160010 for ; Fri, 30 May 2025 19:59:41 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QcLoznGw; spf=pass (imf08.hostedemail.com: domain of 3LA46aAsKCHkXZhboibvqkddlldib.Zljifkru-jjhsXZh.lod@flex--ackerleytng.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3LA46aAsKCHkXZhboibvqkddlldib.Zljifkru-jjhsXZh.lod@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748635181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XLJX3ZuweedNmIpG0KUncbRpuBe5C8PWGGVckjGFyc8=; b=1mbJSSF9F4/LqJhpF3OaCRmZuEGHW2jKWocsWuCKbgaS0TmVmBtkaFZl6d7Cx5J1HeEiJy UgoCTj6TmSjNoW9k/fYvlS9k85azApI+VgDW2YSkdlI4HtOSlJkxxlp8p++eJTWs2s+kho sF+2yJ8eqkH+9cp/pre7kKr3NUetYps= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QcLoznGw; spf=pass (imf08.hostedemail.com: domain of 3LA46aAsKCHkXZhboibvqkddlldib.Zljifkru-jjhsXZh.lod@flex--ackerleytng.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3LA46aAsKCHkXZhboibvqkddlldib.Zljifkru-jjhsXZh.lod@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748635181; a=rsa-sha256; cv=none; b=deyuL+rE27+GjfhCaBsx8hE6kYBMdtdvtJbHP8XXkDsY4p8rV8enrt3/1SQEie/SeVmVb4 OsSDmiUWgh4BGQcCed/oDoDt/CQb6lGOnVSSgqkGVyvjseJT1r4uIEceUT/42NRBE/msGu a2DqIdRgiNx4z02V7MeV0VXb/NX9I90= Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-7377139d8b1so2051340b3a.0 for ; Fri, 30 May 2025 12:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748635180; x=1749239980; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XLJX3ZuweedNmIpG0KUncbRpuBe5C8PWGGVckjGFyc8=; b=QcLoznGwu2oM/3grX/diGfkKTWIoF5Dfqv0XqRxRwrQTYJqn/Wcguh/iCOedelEmeN YqOrm9xt4/I2d9plYTNJid7dxyg0jVNsHLN0nxhZrVH8tcY+uH5iH+0nDT1YSjcuPHWv P8yooN5fTnap1lnQ+yNS/05ZSj++JFII3ULj/ae6ECmCZDo9PKr9DkoGPkwl7ezeAyzH LSrd1LZKh3i0625r94wf//cmz13pbAy31rO91V/12lOhe1ll376NSH0laFHUa5ZZaCve GucBHwtyixZHIPTC+RL11qCF45YCVV8yxOyjFnOH1wC5+IpsuLUIR6CrJ9eIn2J3UvLa A37A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748635180; x=1749239980; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XLJX3ZuweedNmIpG0KUncbRpuBe5C8PWGGVckjGFyc8=; b=dDLw/ceg0RbyxX7bLNhVe/Z0Vaui8uwD9xFHsFcJLeoXVFncEBSMS3ObFGkRLJ9MPM 8mqU9pc0FIWee2PZIFsZOpKOQ58tlGNBZWJGaQM6Ms+gbbVh0mS4qx6bKzMaex97mHDB bdn9XNk2OPwhhqFz5olmt+kg/VHvOr+9bIQ2JnAFCiFNm3nmNkZchFcZ54SPyRDFTQ17 ruCNgAAM88KlhxUFsfJ034p2KlmJZQmNO3joMVvFgiF7QQCCMnuDwUXBoRtUqyiKMu4t P2BGntuQ5MHL0DYPCuSH7bPZD/GnSb8Siy+mdOuXV6jqiO5E79xOFo8oTd71TrGJ2Lbx T5oQ== X-Forwarded-Encrypted: i=1; AJvYcCUzLqrdI8usZ/XIUip97fUagfDOx/pouwBVxZvB2b1Sc7Fsw6Rh2fb+XMIE5Fj2kaCOjHTSHz53Ww==@kvack.org X-Gm-Message-State: AOJu0Yx8oFgZjRXfkZ79NfJE3RIVm6YaB0sR4A03udVNaiPc6BSDX7ZI GF6iyaz2Z6Tc9gscBxoq7bFRlPFyNv9A9x4xgnT11MNQsDaTIPa6VwM2UZ4HLBR+p/1TLSrcg2T 8bbrBnOA4UuhEm149MKJVDpUslA== X-Google-Smtp-Source: AGHT+IFFhC3hXX+PVrgQzetLdBECprnA1DEgPQOOh2/WyOZiyyWJYJHQsUMyh+zMD4P5Er1nSHhtcou8zoPt2CfFVA== X-Received: from pfoh25.prod.google.com ([2002:aa7:86d9:0:b0:744:671f:ab5c]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2303:b0:742:ae7e:7da8 with SMTP id d2e1a72fcca58-747bd96e16emr6946361b3a.8.1748635180286; Fri, 30 May 2025 12:59:40 -0700 (PDT) Date: Fri, 30 May 2025 12:59:38 -0700 In-Reply-To: <1c5cfc23-3f63-404d-a4bf-030c24412b20@linux.intel.com> Mime-Version: 1.0 References: <65afac3b13851c442c72652904db6d5755299615.1747264138.git.ackerleytng@google.com> <6825f0f3ac8a7_337c392942d@iweiny-mobl.notmuch> <1c5cfc23-3f63-404d-a4bf-030c24412b20@linux.intel.com> Message-ID: Subject: Re: [RFC PATCH v2 03/51] KVM: selftests: Update guest_memfd_test for INIT_PRIVATE flag From: Ackerley Tng To: Binbin Wu , Ira Weiny Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: C74F6160010 X-Rspamd-Server: rspam09 X-Stat-Signature: 4utz7wnwx4hs359rn371t7t5d1qhzsd8 X-HE-Tag: 1748635181-853356 X-HE-Meta: U2FsdGVkX19OFqhG+EAPIvo+bmly2U0nQMpFEGRg8O2M6VES4FGMsYXvcyI3rdFQSROqOZFt0gL3Co3RefpQRC/fgJYHn+wJcMp0KyUs5Xt9i9seDvySO5n1t0ETDAKkkuKS3fmxB0ylQ6AWZpzH+xfv/jicA6Qh5A96x4oxjLyCjZxz/hv14XfyKEWkcAFRjDPu4fBPI/KyXqQbK453SO7hvmyrgM6ARx+aj+eoWGbPP2XDhgDzDVdJqgB2N1it6aKaUgpJvSMRetljYIH8uLW7NSbHrzCHNLSUzCmyT4Taclth1OfJb6rRz91suVobv41rSnhigqZxoovvn1giEVhgbibInkDqKJzlqrJDMSZRu1wkEkC12gVYfU9aBtPGj+Y3E4/uiO23A/T3YZDquJ7+ZzPyXA/Gk2m8J6jIJ2z6rlkgSZ01UHlvUrCFiKbYt91NgdYzYxPTy43Uwl7l1d8s7WoIMMVxsNgw9PBcYQ4PDXFyM/ULcdliJYAip7MMOjyk/OIsOKARjDqqN7jIoclt5ThCRI6/+px1V5O/lfemmFUysMLanQHV2yMobJtikiG2a2s2cyOsp6TqIq2bltPpnGWaI1iF/94EaxMNdVr5byChmtIHCG/I37G1tOPdmNaH/g3ebFA/E2I4kIDsWmciB+g7McXjirwEZwFJ0yAFIzmzvAl+rZivNkiwr2MPrbxvIDYVHoHg0uBRjudg1Sd3oE1HGbMAoHHolo4qSfSUUVDBWjc4i4QVmuKDN4iSKfEoSex1XmPiBV+LZhBVZkT76qB1sIVBQWgEOrJmLkwyn/BTDXbRF++KMajtwzFN4QEV7Pmvri6upzT72u7azW6dBD0v2cthaZJIkZ+N73hoHJcPaRRMKnLtHqD1WpW3VnCAH8pZWgfOyv3G0F30Gtfkkddilqw2O7WJ3ilz9uhcXNzbQQ4FdL3Is68Tg0WbJ+blfzGpgtq57BvysiM UV9gR/B4 ANHiYCsZ3dFNpMgu/8ZNQtCwssTHrzyceQOMXgKTazKrN4GU3RJLDlgSAsDVETB8NpC52A1frBgPmsnS1KgKajbcMuGCREbUqI3uIOQjhPIrW9XbKWehv2FPrvaAUGwDDI5rVyYJ7ajdo7vkbnP85XcTR0bowxawxjVOnNdTQsoNY9MYsCKhy6EyxUiQUEPPQZ3BmlnFq6jtVeXPTL8is2Zs31WtxRbIHXaeV1i64m7fgXgbNIboE/2zOJFPB8DoSLBevSe6eypoDfpYKUTzsHq0DquljNSnDXnMXHmoTcwQPgnSjhmzFgaQ9RmmQ8vS6s+6Kaj+P/SkyNxnBEyAvqG43KxQ4+K/iJzvcxTYL0L07724U3zNpSxQFHvJOs9GIagygRq474Pa0jNiJK8/TnN3RT1ONruA0ZnfF4wQbqH+8DcovA/8AWlVnVJi2Jt56oUV4ovs0YION/aoZXTpV8PSg3q9RvTRYHmQB+9zppC/EMfpVrO/Do9faJCy23nSiL46BGnvtyw6+bZpDRb0sAS+jaipxZ3KlZDXWRisYmijKq83bTzslAVy/LaJATyMELPDD08Z2PVag6ULUh2mO1LfGWpMiwXi0knGvmB3GDqI0pNDB23dXC4+fbHEkMh7/xrQDLiRn5Qtuq9YVdn9lJt4m+FyqrWCLPf9h0/9TScCuB3/uES9I+Dkd6Mxr6JqA6O5w17stzWFdSEU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Binbin Wu writes: > On 5/17/2025 1:42 AM, Ackerley Tng wrote: >> Ira Weiny writes: >> >>> Ackerley Tng wrote: >>>> Test that GUEST_MEMFD_FLAG_INIT_PRIVATE is only valid when >>>> GUEST_MEMFD_FLAG_SUPPORT_SHARED is set. >>>> >>>> Change-Id: I506e236a232047cfaee17bcaed02ee14c8d25bbb >>>> Signed-off-by: Ackerley Tng >>>> --- >>>> .../testing/selftests/kvm/guest_memfd_test.c | 36 ++++++++++++------- >>>> 1 file changed, 24 insertions(+), 12 deletions(-) >>>> >>>> diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c >>>> index 60aaba5808a5..bf2876cbd711 100644 >>>> --- a/tools/testing/selftests/kvm/guest_memfd_test.c >>>> +++ b/tools/testing/selftests/kvm/guest_memfd_test.c >>>> @@ -401,13 +401,31 @@ static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, >>>> kvm_vm_release(vm); >>>> } >>>> >>>> +static void test_vm_with_gmem_flag(struct kvm_vm *vm, uint64_t flag, >>>> + bool expect_valid) >>>> +{ >>>> + size_t page_size = getpagesize(); >>>> + int fd; >>>> + >>>> + fd = __vm_create_guest_memfd(vm, page_size, flag); >>>> + >>>> + if (expect_valid) { >>>> + TEST_ASSERT(fd > 0, >>>> + "guest_memfd() with flag '0x%lx' should be valid", >>>> + flag); >>>> + close(fd); >>>> + } else { >>>> + TEST_ASSERT(fd == -1 && errno == EINVAL, >>>> + "guest_memfd() with flag '0x%lx' should fail with EINVAL", >>>> + flag); >>>> + } >>>> +} >>>> + >>>> static void test_vm_type_gmem_flag_validity(unsigned long vm_type, >>>> uint64_t expected_valid_flags) >>>> { >>>> - size_t page_size = getpagesize(); >>>> struct kvm_vm *vm; >>>> uint64_t flag = 0; >>>> - int fd; >>>> >>>> if (!(kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type))) >>>> return; >>>> @@ -415,17 +433,11 @@ static void test_vm_type_gmem_flag_validity(unsigned long vm_type, >>>> vm = vm_create_barebones_type(vm_type); >>>> >>>> for (flag = BIT(0); flag; flag <<= 1) { >>>> - fd = __vm_create_guest_memfd(vm, page_size, flag); >>>> + test_vm_with_gmem_flag(vm, flag, flag & expected_valid_flags); >>>> >>>> - if (flag & expected_valid_flags) { >>>> - TEST_ASSERT(fd > 0, >>>> - "guest_memfd() with flag '0x%lx' should be valid", >>>> - flag); >>>> - close(fd); >>>> - } else { >>>> - TEST_ASSERT(fd == -1 && errno == EINVAL, >>>> - "guest_memfd() with flag '0x%lx' should fail with EINVAL", >>>> - flag); >>>> + if (flag == GUEST_MEMFD_FLAG_SUPPORT_SHARED) { >>>> + test_vm_with_gmem_flag( >>>> + vm, flag | GUEST_MEMFD_FLAG_INIT_PRIVATE, true); >>> I don't understand the point of this check. In 2/51 we set >>> GUEST_MEMFD_FLAG_INIT_PRIVATE when GUEST_MEMFD_FLAG_SUPPORT_SHARED is set. >>> >>> When can this check ever fail? >>> >>> Ira >> In 02/51, GUEST_MEMFD_FLAG_INIT_PRIVATE is not set by default, >> GUEST_MEMFD_FLAG_INIT_PRIVATE is set as one of the valid_flags. >> >> The intention is that GUEST_MEMFD_FLAG_INIT_PRIVATE is only valid if >> GUEST_MEMFD_FLAG_SUPPORT_SHARED is requested by userspace. >> >> In this test, the earlier part before the if block calls >> test_vm_with_gmem_flag() all valid flags, and that already tests >> GUEST_MEMFD_FLAG_SUPPORT_SHARED individually. >> >> Specifically if GUEST_MEMFD_FLAG_SUPPORT_SHARED is set, this if block >> adds a test for when both GUEST_MEMFD_FLAG_SUPPORT_SHARED and >> GUEST_MEMFD_FLAG_INIT_PRIVATE are set, and sets that expect_valid is >> true. > Maybe it's more clear to move this case out of the loop? > Will try that in the next revision. Thanks! >> >> This second test doesn't fail, it is meant to check that the kernel >> allows the pair of flags to be set. Hope that makes sense.