From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68B18C001B0 for ; Mon, 7 Aug 2023 23:17:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAFDE6B0074; Mon, 7 Aug 2023 19:17:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E60048E0001; Mon, 7 Aug 2023 19:17:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D27348D0002; Mon, 7 Aug 2023 19:17:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C47616B0074 for ; Mon, 7 Aug 2023 19:17:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9489B140644 for ; Mon, 7 Aug 2023 23:17:53 +0000 (UTC) X-FDA: 81098873226.17.231B3E3 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf14.hostedemail.com (Postfix) with ESMTP id DB7BE100005 for ; Mon, 7 Aug 2023 23:17:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rHwQlDZD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3nnvRZAsKCAkjltn0un72wppxxpun.lxvurw36-vvt4jlt.x0p@flex--ackerleytng.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3nnvRZAsKCAkjltn0un72wppxxpun.lxvurw36-vvt4jlt.x0p@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691450271; a=rsa-sha256; cv=none; b=NMUOPK2pPpq2qa1m4xHjW1cPARgaNU4Ez+OD/9TPwJGniCECSIu6vzqsFGVZtc5vzqAxYu gEZYpA957dHFrgHlF6h6iOowfl6sq4h0nRETMpA4td+fAxs9Utuj0/NGDu2koDMY0pIefG o4XkjjNYACwaN4Lgyu9LSMR5msYai24= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rHwQlDZD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3nnvRZAsKCAkjltn0un72wppxxpun.lxvurw36-vvt4jlt.x0p@flex--ackerleytng.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3nnvRZAsKCAkjltn0un72wppxxpun.lxvurw36-vvt4jlt.x0p@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691450271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=O6ADKvrj6NKuTG8K0De5TN5TBG7YUj/XYIH2D8dp568=; b=iJXHCwav9PpezSZ+jYJYwnK2O4B4yps7Cfs2eRw8CGKPxzPYaiVwIiZDdh+vrTbWfP0ydb dJ1mfKl+z13lLjnn/wEBb3A7JIWvT7ec9UkVcEtfVFAyl1qlxNcv27dtVQcOT5QFhaZle3 Ah5a3Qvu9TAQOTvJYir8WnJWjduJQ7c= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5868992ddd4so58920427b3.0 for ; Mon, 07 Aug 2023 16:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691450271; x=1692055071; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=O6ADKvrj6NKuTG8K0De5TN5TBG7YUj/XYIH2D8dp568=; b=rHwQlDZDzym7DX7JPTeHFjVedtFRUtAMiKX2VU1EjC3DDPS+GKehZ420ny5GaoR1ql DJZSgsfTVJl3vHuTgVdsaoMbYWxHvGzjOU0b7lDeewUWBnmHCx4rEyCV+u7mMO4LYlh5 X/eCH8/74nhTzgvQgUg3W7ew8mnRsIapj5OejxlfXYe7B7oIEIOpl62BZW0oI322fnfO 0Voq/X8G0TvKlJzbTSRNfra4zE+z5UETF5mjVUp3srNKrf5MdQ1+J9GDHb9R/7Klrk79 sQ7ciz1qdHaVGW7a/1FblT/tag2WVBkp7Xupx92Rz9XtAvp0t79KGYAXs3GugjDd4DWz Be4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691450271; x=1692055071; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O6ADKvrj6NKuTG8K0De5TN5TBG7YUj/XYIH2D8dp568=; b=RxDEUV3+Dyd1nFkLyLl3l9aD0bhO/t+dIkA78e4m8e6zlLAuR7bnbgZUxXyj0FvVxl j/E9xovg9J6ndASwg7SPOm58LtYw+4xZh+0FGIGdmOnZ9uYvz47+AYxZyMub3OFHPeO3 XuRkuz7Y08Uj3A0xzpDUB7nfbRbdQMuS/YEn/Qsaz538atvjC+Fl5640OLTh93vsb6Ij 6ptZbN8ooMJ4MB27ydJ+DEcPX7cpQodd4dg5+RnxQd+6ChgLRhJ1lbPajNp/+y59/fFj WS9Bb09jvyQuSP4sHP2xcR86ijoLQTY19V3UbLPj55fqW/zzA5ZOAdp/Fp2zR5aoUOFV Qn3Q== X-Gm-Message-State: AOJu0YyTUXdl9/qv0DeIBtY72CdfS7b/0n1Ede8ca4O3J7GxNWmQuoIR fcquDpC4ToyO2OXgf/H50fdflv8XZ7C3iO7WTQ== X-Google-Smtp-Source: AGHT+IGSgl+5gSINX//lCEXF+ifa5KuvDte/Vqkh35HGceplFQQ8fBj/FZjwVUabZs4KoYQYU07HEfGWMf/BZUZt+g== X-Received: from ackerleytng-ctop.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:13f8]) (user=ackerleytng job=sendgmr) by 2002:a25:ce50:0:b0:d4f:d7a5:ba3b with SMTP id x77-20020a25ce50000000b00d4fd7a5ba3bmr34924ybe.8.1691450270921; Mon, 07 Aug 2023 16:17:50 -0700 (PDT) Date: Mon, 07 Aug 2023 23:17:49 +0000 In-Reply-To: <20230718234512.1690985-28-seanjc@google.com> (message from Sean Christopherson on Tue, 18 Jul 2023 16:45:10 -0700) Mime-Version: 1.0 Message-ID: Subject: Re: [RFC PATCH v11 27/29] KVM: selftests: Expand set_memory_region_test to validate guest_memfd() From: Ackerley Tng To: Sean Christopherson Cc: pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, willy@infradead.org, akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, chao.p.peng@linux.intel.com, tabba@google.com, jarkko@kernel.org, yu.c.zhang@linux.intel.com, vannapurve@google.com, mail@maciej.szmigiero.name, vbabka@suse.cz, david@redhat.com, qperret@google.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DB7BE100005 X-Stat-Signature: esws1swo9cmos98bswpbf65ymeedog4k X-HE-Tag: 1691450271-702802 X-HE-Meta: U2FsdGVkX1/dFMk6k6JVcGiR6JmVq2VrYD70PfjChMdU1y5O94W3AiqKXgyUnwqOLbBAxvMOX2cK3cxxzZjEYgYALmXf+AoCSmiRN/qQ34IIijbAD/FPKe42DWTmiWDKg3d+zWuKDG3Bb72LNLiYZBn5dTRmFHBktgB+ftM1bCnm4RGMxwxAaPSmud9j0dxPCyNGiwwIeehFA/SUp5+3sr2l/jAMmoQ3euvWU30RHYF7Tstuo6JiAet3AvAXUkRv+G8Ulr8tpVCDnxZ3gsV52mED1Ixu0QBXCW8xwg/GBC92wc6y+CRl4zYQZYv8Do5dGA77tOoSFwpTshgBgCsCT/BZa1hj0/djuMTi311psA4+yrvP6AmoHYr0q0dFV7kZ3jAeWMvDUyIcYz9pC1Stf5iHYeH/YcIDuGS05XyHKf5+Brz4120s2odQcnDU0virrHXRuYKx5nB4Wo+pB8CvKaFRFNja8OMBfO30RBNg/8D9G6EjJ3yHOe04O+DNJs3o4qndeBoC3bcORGtYgaYZ8M46nUOv87RGPlurM19xWB6XnqRZF5H7SZp3h1tww878PrY2Jfn9aQl4NXjd8llIyC31QJ1djGU7NhBqjyKKW+ns9Y9qrg8ImNdbRTI7Dh+Aqn9zZMjbbVLm0VeEKjYIG6/Q3XQJyP5BSVAZB9EL6vQYIwyuzDho3a8VE3xWp7okxUipR8iTjbdVjMMViIJdMiwnABrzdoMLxmutJL7ek3KU7VD3c3NOHMuCB8X5f+iok1KYDqcxHb/qaJ3QZHZWPzTC6f8ghyvKs5Za9BQZr4BCSwhVhfjFiRDj7J+AEeLR5msAi0dEj0AnbehA0po3S791QIxE+l+c0YDQIGW7lar/j7bL7ftv16cDH2HtiydX4KE2XAN8zEwwvnSF+1fH8S6XQgLYw4vTVKvhWKKzK8KxpfleHXmRF+0sfLb/aVGLCYZ9EcFPjqcq/3brTej U46+V4Yv Vwc+hyq2OsasQ7HkZCE0XKzTUIIuwLZKDmmKQyCXBKO0Vp/uB5cDQssjnUJbOnPN9uou7j29hbYebu9CWzG9uluGyoCNnN1KVCLnIDmaIlOBOsi+I+Bs3Jn1UPNHxh0tsOzltxPyl6hRZ94QvPXrUUC0grdKWedOpd377xr7grd0cvspoHp9Vimltu7AE8D9nQKZ+yvQbh9IDmCFpb+DbtfYwh6JTM1qZoH+22aNkPuYOfYCTe9ysEcVLP4YfRZ1sKu3QIeIKXp2OAtTna8VkAmy8r+H0TsfEtq2w4JV23l2Dd1EnZ2mNumKAi8dFRrK4G1NXvhINW0UL0dO1/oirmlPFU7aMuRN8bagsMTUiQzZ/4WbE4669RmXI8oQZKmfZ1D/iYTxqOyaQAwRLlDZCNLezxmy4a4oCY+PFPBdZJA/ovJUOKH16l1LNhxuE/FfYKbUyQeyGEenTGtdOKPP+l/2SyRQXEP000bxYAjrgSqar8ptiHAdd36Yj5sBPaV2Mu8EbKfC7L1NyPUpz7vcb3FCQlUFNpjrhlqjPfsg0814ZL6s8K+o3sl5NPffpn8Xde8wsZ7HX/Ra9CJRhcj//teEiDCj3l+YRR7pNSSJVDYg5XLeLiDNiTqUqMUhU5jCfH90Hmcjfb4sZ12fZMLLIQQ1qL7X0ZQR4zepSxHpfWXQL3rkZIWiEd9ilfC/1Tu3fXV2DyD/28BBi4TjiWcshqyOc0Npg8Clf7dX+SMzCcvuCW+hSW6Ir2r//D0NmDUM5dmWvbIKt+D4KfZw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000161, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sean Christopherson writes: > From: Chao Peng > > Expand set_memory_region_test to exercise various positive and negative > testcases for private memory. > > - Non-guest_memfd() file descriptor for private memory > - guest_memfd() from different VM > - Overlapping bindings > - Unaligned bindings > > Signed-off-by: Chao Peng > Co-developed-by: Ackerley Tng > Signed-off-by: Ackerley Tng > [sean: trim the testcases to remove duplicate coverage] > Signed-off-by: Sean Christopherson > --- > .../selftests/kvm/include/kvm_util_base.h | 10 ++ > .../selftests/kvm/set_memory_region_test.c | 99 +++++++++++++++++++ > 2 files changed, 109 insertions(+) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h > index 334df27a6f43..39b38c75b99c 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util_base.h > +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h > @@ -789,6 +789,16 @@ static inline struct kvm_vm *vm_create_barebones(void) > return ____vm_create(VM_SHAPE_DEFAULT); > } > > > + > +static void test_add_private_memory_region(void) > +{ > + struct kvm_vm *vm, *vm2; > + int memfd, i; > + > + pr_info("Testing ADD of KVM_MEM_PRIVATE memory regions\n"); > + > + vm = vm_create_barebones_protected_vm(); > + > + test_invalid_guest_memfd(vm, vm->kvm_fd, 0, "KVM fd should fail"); > + test_invalid_guest_memfd(vm, vm->fd, 0, "VM's fd should fail"); > + > + memfd = kvm_memfd_alloc(MEM_REGION_SIZE, false); > + test_invalid_guest_memfd(vm, vm->fd, 0, "Regular memfd() should fail"); This should be test_invalid_guest_memfd(vm, memfd, 0, "Regular memfd() should fail"); > + close(memfd); > + > + vm2 = vm_create_barebones_protected_vm(); > + memfd = vm_create_guest_memfd(vm2, MEM_REGION_SIZE, 0); > + test_invalid_guest_memfd(vm, memfd, 0, "Other VM's guest_memfd() should fail"); > + > + vm_set_user_memory_region2(vm2, MEM_REGION_SLOT, KVM_MEM_PRIVATE, > + MEM_REGION_GPA, MEM_REGION_SIZE, 0, memfd, 0); > + close(memfd); > + kvm_vm_free(vm2); > + > + memfd = vm_create_guest_memfd(vm, MEM_REGION_SIZE, 0); > + for (i = 1; i < PAGE_SIZE; i++) > + test_invalid_guest_memfd(vm, memfd, i, "Unaligned offset should fail"); > + > + vm_set_user_memory_region2(vm, MEM_REGION_SLOT, KVM_MEM_PRIVATE, > + MEM_REGION_GPA, MEM_REGION_SIZE, 0, memfd, 0); > + close(memfd); > + > + kvm_vm_free(vm); > +} > + >