From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A9BEC369CB for ; Wed, 23 Apr 2025 20:25:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B47676B0008; Wed, 23 Apr 2025 16:25:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF47D6B000A; Wed, 23 Apr 2025 16:25:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BB4E6B000C; Wed, 23 Apr 2025 16:25:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7EC896B0008 for ; Wed, 23 Apr 2025 16:25:50 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F1F201A0220 for ; Wed, 23 Apr 2025 20:25:51 +0000 (UTC) X-FDA: 83366439702.10.E90F28E Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) by imf30.hostedemail.com (Postfix) with ESMTP id 3CDD780008 for ; Wed, 23 Apr 2025 20:25:50 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WtTYCOM6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3zUwJaAsKCNIy082F92MHB44CC492.0CA96BIL-AA8Jy08.CF4@flex--ackerleytng.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3zUwJaAsKCNIy082F92MHB44CC492.0CA96BIL-AA8Jy08.CF4@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745439950; a=rsa-sha256; cv=none; b=ZZYEilu0cwk1micbImT3nTztVP9ejL1Q1IxdUQ5ixK9qBMwTfLc7AnOl4uKqtxwIEFvJeg 6Hsxztl4/mKmUgwf1ME76DPaOocCm9YFxW8kQ1KE4Ob7xoEiJRrkFqrKOpv0wO/YkyrpZ4 Dlu77+BMLVVmPU3j+IAmVPq31Q4GEgY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WtTYCOM6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3zUwJaAsKCNIy082F92MHB44CC492.0CA96BIL-AA8Jy08.CF4@flex--ackerleytng.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3zUwJaAsKCNIy082F92MHB44CC492.0CA96BIL-AA8Jy08.CF4@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745439950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CjX2WJaP/+hIZJnKE7ZkAy8ut0H0AnZ+KN3YDGIa+EI=; b=q8NA09j3DrHzW1XGAr8koSAAW5SMXeDcif+BCW3otyJqKgQIWag7fxkyVRI4OkA0nVQrnl 17iO+2U7SGtrKrOSt3LSrK+kNf5nfRRzi3f2spE5ImM+2qGeo3YHF+dvE7hNoSnJwM21TO ihmsKYOdTV1ykFd5yN0TGavVTIZzuDc= Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-736c1ea954fso79748b3a.3 for ; Wed, 23 Apr 2025 13:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745439949; x=1746044749; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=CjX2WJaP/+hIZJnKE7ZkAy8ut0H0AnZ+KN3YDGIa+EI=; b=WtTYCOM6PhR3W9iSttjB8BI9Qq98oHYFrxr5cAcdfqGVvW6X+ZuY1snqi29iUAgqfI FcfEP7Qf5gZtfO4OzThjsuSwYpWy5kk+JholrBuud+ccEdh9V3TV9G0JSfAf+vtRn5w/ IOXUS5DRmecvAbkzG28x6RKEHVLtAcNyMIIfntLb3IXGY+JPR5gUd4rVhi2t9JF+Qzjy JJj+QU7sUNUbVwCaKCBNoWxdlM1ny7kwt/mINoR5Ofv5lxov7wpRip2KPEt1k9dVX3LI WOncAhhp54usAXnyNu5ALTAnLBugB2gjBhvHSJz3e4e1FaI8Cpb9OeOtoBPA565TBTyi pDjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745439949; x=1746044749; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CjX2WJaP/+hIZJnKE7ZkAy8ut0H0AnZ+KN3YDGIa+EI=; b=kXU/uP8rlA+kb1lQayJlfxAoi6UnEiWPs6UT0oMVsHYvHu2DiOZW3GNvghh4gR47BP KJXqKf/GdAl7eW95cNxYGE9aR7Y9VrDwxpfEeJVW9sgCqZrx1z8QbkiZb0gKCHM4k3/0 sTPPr7/t6vqVc4uy7rlkHWmw5JTIgi93w5PDzAL7rV6mGpOLm/kOjJco2JBYOZ3eKYaU nBSVbCJ0U/mFt3VuPrTzQWbee9j+N3x9aKQC+xKbA/ZnyzbvExeagQO8aEOdHZRvnn7l 4tPopAzlp6gjAs5Wnpwo/xjyOyTTz6GZTNjR68OBIru94sSyVsQfhpkcAb02Qr1+pUqz Xw6Q== X-Forwarded-Encrypted: i=1; AJvYcCXAkq65tpXPmc+OIXaFd4ug+klqQUNaTLYtiX3P7Kg8qfi42yOxYeoQ6cJos00exjJo0rzg8vT/VA==@kvack.org X-Gm-Message-State: AOJu0Yw8wbDWAGNxPuf1MRxzOnTo+zK1oU2xW5CiQu8fNK9sU8FyQ4tx tHaY6gsvuE7U1NRnlll6Wm13dSP1GdE8ziYtJQ/cYVFCIbcDsOOYe2BonfMnvNnIhtD0e0gFljX DxFvPOw7sba8Ll8T7cXO/zw== X-Google-Smtp-Source: AGHT+IFLEEtCn1zkdoknKQC40EflQZ5HCAiPFEe4xIPUK0dlv/WJ0C7ai9MKNllw9+iA8ZkUhOs7ih4lNf6hYQC50w== X-Received: from pfam7.prod.google.com ([2002:aa7:8a07:0:b0:736:ae72:7543]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:c889:b0:1ee:a914:1d64 with SMTP id adf61e73a8af0-2044113e9a5mr1184451637.28.1745439949162; Wed, 23 Apr 2025 13:25:49 -0700 (PDT) Date: Wed, 23 Apr 2025 13:25:47 -0700 In-Reply-To: Mime-Version: 1.0 References: <5a05eb947cf7aa21f00b94171ca818cc3d5bdfee.1726009989.git.ackerleytng@google.com> Message-ID: Subject: Re: [RFC PATCH 27/39] KVM: guest_memfd: Allow mmapping guest_memfd files From: Ackerley Tng To: Peter Xu Cc: tabba@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, jgg@nvidia.com, david@redhat.com, rientjes@google.com, fvdl@google.com, jthoughton@google.com, seanjc@google.com, pbonzini@redhat.com, zhiquan1.li@intel.com, fan.du@intel.com, jun.miao@intel.com, isaku.yamahata@intel.com, muchun.song@linux.dev, mike.kravetz@oracle.com, erdemaktas@google.com, vannapurve@google.com, qperret@google.com, jhubbard@nvidia.com, willy@infradead.org, shuah@kernel.org, brauner@kernel.org, bfoster@redhat.com, kent.overstreet@linux.dev, pvorel@suse.cz, rppt@kernel.org, richard.weiyang@gmail.com, anup@brainfault.org, haibo1.xu@intel.com, ajones@ventanamicro.com, vkuznets@redhat.com, maciej.wieczor-retman@intel.com, pgonda@google.com, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-fsdevel@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3CDD780008 X-Stat-Signature: jy7qkacoxcsdh8ptdxaa9dzyniz7j5db X-Rspam-User: X-HE-Tag: 1745439950-78985 X-HE-Meta: U2FsdGVkX18oWqyd1puntlaitE21Fg4MNYEap7CU3dgVxK6bIbp8+Kg6E3eyIqcfJWWLFUeASsqFyezywrzx/FAwKtxwXpkn4fRaTM4PschU+DxWf6C7E8wGc4auWGQ55JNnx6sp2NXaOR5/5xGqHbAXH+v0ZWeafCpGaTdvKYaLc5mNEUnXsBswbvhL8VLXc2IYDe3PVgpQEd52/LYlXq31sSoEKrSTvMD+rU2KABHxvQkAKCju/H97H9ZtRbEwL9X+1FR9CX1TjVgSLRzQAlsO1QefB4bVF2S99lGDVJH3JlxTteGO93oD9bRYw9GQFgbdOBJgAHDR3JDv3SWR7QOTmvVW7+FWwEJ8tTVIUh5cNGJnP7Dkud6PBQsnKFEfGZVNzlW1FjFfPn2pT1Ntz+C4w72psYgb67L4rjjfItS9wOAZrL1s//0Cj3m59yyrZUkyPUUJRgPsHS1Tv4Z6dgvAsDEIl9NKGAmgvUiF489ikdi10i4iLwPRu8C3heMpOUowXcVL0AtD73fNHVobtIentc9W/jDKjS+HCWd2JqamuqgNZbBLiuS3MPawdopWe6UfB5U/UkVsq09/Bbaw3GvsKg14Scp/rzG879FmLahug9hbifJxatLLlyFOvQOYkP6I80qvRckmQPfiXwACIJ6W1pVqcQyRnTKFhl6ss76PFbTL0PeVwMdD6+6M1T7mUwIcjY1BUrwljxCduspQGw4VgUgcHNTRdlJi/Ts8w2ZY2143LU4qGwVmraZhSyqMbNRPw+ZEMcWvrem9t0WcF/EqP61GFOGRrbD59Eh6xbD7Ih8AIsCVpy1XKqYkHPvjN7AyQDqVKJDp+i4eHtm6FIG4AzbmjFbGMG6a11iQu9ZAQoNTAIF6iy/d4jwt5rLeiXH9L3oWTHJYzcAKAD2Eelks9zGLdAUETqz7sMP1VWoJf8CuQ92ldgHrDqtOBiFoBYhJyZE0UktvtQDay1B I8YzFi6/ 77TugIE5YfLc19GPv3qHg3H99ucPav7LZm7YDVmGDosxSbHhAyP6Olz4C3NIZicwHwdkCoGL4KcSFYuHJygugxLxmWfrmLZfYK+JxtQFaWRDPB5bUdjdIxtcgwuQ6auZQQmcxU4RwIkAGQw1ZbkO3Mr/rAfk9XtX3NO/9/hxXXysB3ruoah8f09j6xACXf+Q4mXKFt6/CsYXmiEV+3DFezZD5ZssjWjGKxCTkbEgZ67pDfKMfXPRNtsKiU4RYjW17ueH8o9UhX34GI0HzdKt9temQ/CZLYFSDNXep0HUqHuKc2AhcbK9O22FJMSHNSjvpL/ds53OeZsa0c1giu6ouy3+BRxXCFc7naRhLnr2GtNilT61Vx7Yx3pb4x8u7lF2gTo9SpkFFsgGlGANc6HCIK4TP48DqMfOfzpGNQZv95HQ1xXsww7zonHRYnjQSLyZasS79ni/r0X3t0EgEzXWail35IfzlhwJP3bDJpPiy9Cn+yf/DbFSjRGm9fTHZeHmX+pc8Fxk3Qfh5FujNU6UZBy9iUtSiqVWyXtoJZRTEMpTpdHXF0k3EWWNkc/a6hUBlrPESNDJLFlsH1hAG9Ff0qENO3fjrfhuvReEw8e+dirpZ+koEj8As8FLsh0vx6dHMrxxMPV8MsH6bsJVkgIXeaLrYMXrvof4ujg1cqrFxUi9HLQFrb6amdVc6AQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Peter Xu writes: > On Tue, Sep 10, 2024 at 11:43:58PM +0000, Ackerley Tng wrote: >> @@ -790,6 +791,9 @@ static long kvm_gmem_punch_hole(struct inode *inode, loff_t offset, loff_t len) >> */ >> filemap_invalidate_lock(inode->i_mapping); >> >> + /* TODO: Check if even_cows should be 0 or 1 */ >> + unmap_mapping_range(inode->i_mapping, start, len, 0); >> + >> list_for_each_entry(gmem, gmem_list, entry) >> kvm_gmem_invalidate_begin(gmem, start, end); >> >> @@ -946,6 +950,9 @@ static void kvm_gmem_hugetlb_teardown(struct inode *inode) >> { >> struct kvm_gmem_hugetlb *hgmem; >> >> + /* TODO: Check if even_cows should be 0 or 1 */ >> + unmap_mapping_range(inode->i_mapping, 0, LLONG_MAX, 0); > > Setting to 0 is ok in both places: even_cows only applies to MAP_PRIVATE, > which gmemfd doesn't support. So feel free to drop the two comment lines. > > Thanks, > > -- > Peter Xu Thank you for reviewing and helping me check on this!