From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D287C5AE59 for ; Thu, 5 Jun 2025 19:17:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7DD06B00C0; Thu, 5 Jun 2025 15:17:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2E4A6B00C1; Thu, 5 Jun 2025 15:17:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1D3F6B00C2; Thu, 5 Jun 2025 15:17:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 80DEA6B00C0 for ; Thu, 5 Jun 2025 15:17:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A6985F88C for ; Thu, 5 Jun 2025 19:17:04 +0000 (UTC) X-FDA: 83522304768.27.2315190 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) by imf08.hostedemail.com (Postfix) with ESMTP id 2EA33160015 for ; Thu, 5 Jun 2025 19:17:01 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=i6XWL7xH; spf=pass (imf08.hostedemail.com: domain of 3LO1BaAsKCFcz193GA3NIC55DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--ackerleytng.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3LO1BaAsKCFcz193GA3NIC55DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749151022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qdt+NTF9J8z5h3nw/qHtHa3JaF0BNQRi8vFlUQ8H5zM=; b=dn16rwbO9kuQup7JDGUHsGwAtuc1BWZoAMKmkZ9szlOzhEIkYGr8+3xhD0+ORHv3IQu06F 4d27hl1Xo0dDsgZKpS3aXEGvLvIBmqgVvQUrNHx5Xm2hlTnOTlrcLfOvwNahXTeXBDLzrb YjDcoDuBCeyN7t8Y3MlFeaDh8jDad88= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=i6XWL7xH; spf=pass (imf08.hostedemail.com: domain of 3LO1BaAsKCFcz193GA3NIC55DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--ackerleytng.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3LO1BaAsKCFcz193GA3NIC55DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749151022; a=rsa-sha256; cv=none; b=uMSy20W6+dfjgRrpRXYikUz4tVzNFOD712Q9o3Pt0S5jmwScxnr6IjnUSJjPINNYweOpP8 /GmTcM+bg/1k+Ku2WI3FDLeBAVLl7QZpjcSO5gkraCgBuwmZ/OpJJm+4lPJeJh/KNPqvEA GMZSRQkwPXV5FcLSQil4QIhgpv8ZO6E= Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-74292762324so1394083b3a.0 for ; Thu, 05 Jun 2025 12:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749151021; x=1749755821; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=qdt+NTF9J8z5h3nw/qHtHa3JaF0BNQRi8vFlUQ8H5zM=; b=i6XWL7xHs1cq0LPYS/XtLV0F10V6POgoFj6EmxZJlkH+Nq9KSMjgZrp4F1XNnOKJwr nzU16btTp+5xAZtk+ChO4mqlLJhbtO6aBhn/hg4AQA4kCoF9827iodqN0cBp90RmgUcl 0vMjHxD4aG86cpi24U/hpiNU1+NClF+t7qgbuqu9fWpY3PZ3u8SFazNgtlaPccuR5VAT Lu4m7wWjyaAm3hKMikoVH298soMTEWQFed3QRZYBqw9ZxZvcm0FbjRxXcuvGTFVfSEyT BNVr5EeRk9xEWEEbHUJrS5it/a72HYqcVbnViwKS/MnzvBq4Yx++zMSYQTmxZJb6zDgw Xiag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749151021; x=1749755821; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qdt+NTF9J8z5h3nw/qHtHa3JaF0BNQRi8vFlUQ8H5zM=; b=ni3DyZ0e2ro/yU1bGRX1eJrDK7sdmSqcMtBFwT0FVk1W5l6GptHPGL7g9nBEYoRczE XHh0Bbf6PHTFPIQz7zjOEoSGz0i0OyBAgofyrAVaGV8YpaqzeE0hPBbyrE/CHN+0tJSI r5sE5ZWsva+T9FIPsg7aQKseZTjmeRa95HqS/zj63BTcrs/XH5eaH4o3J60DzSeCu7Tl pdgV/RmVdG+AintTCv8x/ckRrIUpMtshP3qJ0sX2TacRlxd68d7zg79kQNxR+vfh/KzF JMlNhKjL+gnlphTR8CcYeolkWBb7EiaUClraqEn0eM0oq+6rs+BXQscZHP9u4thLsBtI jUGg== X-Forwarded-Encrypted: i=1; AJvYcCVoSbyaFUvoLsK+Xad8eRsoMwD9WVQSac0rBz7sDxzexcw9yzAd/i1zLzeSdFtr6Gygi14DCuf66w==@kvack.org X-Gm-Message-State: AOJu0YwczlEAqzoLsiTORupTLEAtI1PArLkrmRR8Gg9TCIef9NL6gACs 8W2+5OpEhTGmRMfe5rA8heLF2jDSMklFHECZoILDmcjSxT1V/jxzLRNsxWxX0Nd4+M7gVRirk4v jdMDSdBr3UpMoqNMM1qSQ/h1pGA== X-Google-Smtp-Source: AGHT+IH8htB84vea5MhC0iZOF6Zxpq5a9Lmv6Or6O2Uq8VlBTS29CnJcDsUC/JtlL3nBkV61UZOUO9/cw62YUQKDXQ== X-Received: from pfiy14.prod.google.com ([2002:a05:6a00:190e:b0:746:2747:e782]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:cc6:b0:742:a23e:2a68 with SMTP id d2e1a72fcca58-7482806455cmr981739b3a.15.1749151020845; Thu, 05 Jun 2025 12:17:00 -0700 (PDT) Date: Thu, 05 Jun 2025 12:16:59 -0700 In-Reply-To: <558a649d-d419-46e2-adb8-4027e105c1ce@linux.intel.com> Mime-Version: 1.0 References: <7753dc66229663fecea2498cf442a768cb7191ba.1747264138.git.ackerleytng@google.com> <558a649d-d419-46e2-adb8-4027e105c1ce@linux.intel.com> Message-ID: Subject: Re: [RFC PATCH v2 38/51] KVM: guest_memfd: Split allocator pages for guest_memfd use From: Ackerley Tng To: Binbin Wu Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2EA33160015 X-Stat-Signature: 4rcbcr7wfyhh7yw67ir7gy9antsg7zk7 X-Rspam-User: X-HE-Tag: 1749151021-890874 X-HE-Meta: U2FsdGVkX18lBbGCRyT1I8uLQ93b+e+erC8X1sO4pOLBykGmU6RIlQQ/lBl1LGTvg4EGPOwrReYQNsMNbKTseZZPAOuHU6ExHAndHnKScSLnrPufr+LKUHXtneSQjAvb00iaSXPDFQ/zpr0neqeT9usSfFg8iRWJF6djouay2ysFLM707ka4Y4j/ml/XDiNyt9Vd7Dj0BBDWkc0gf6VdQDbYTs/jajIJHsJF7iwkr7mHeY01av38N95RvQUZTru1P5XpJVjDJwt7/1r32eLb0Gowdch+FWa+6bpf1HpMAQogymPhyDqQwY8K3wICb9TRs4PFfU3lCsbqVlyv2hIldwjEdO+5+B3PUK3E6wgPcUiEb3ZbN+tcY1RI+roXm4WepA9TyCV2T7u3/+1A6MJtHTmpJOqIVEIvRI2re12fm5XOnWPvea+bc8fkSRWIF+8yMgJELgd/FeRPX280RVSX5HXErh0JRVbYst5BxvUvmXZ5BsxwcyAu04Yw1dTrBlVJOsVUgH3gzVTO4Tuv6/jEXfSzW/S71UkLWUc3stPpxH/qrPRyAKPQR+Zw3kFl3C3N8+fOgCK0P96bhH9bFxo0UXuimGvgG5eIGLu6+nYYco7hSPTGO4vxJ1DYwHRSP09xnsj8GBDwTaw3R5phQRnMnDueNvHlR0dqq10/hT6wRsJn8Jn1uxHe4UL5InWsMMNp21D725xwPpGDGgURjmUnpEvXCfUzePKy5NJYO23U8yEot/wk07azzTrFlCbNEgirOka3SEhUMnuPJMHjihfeCz0ojnD3dXbfdJJhxPnSzQ5VZ38jJ2vxDxZ+HJf9KpxPouR29uvwWZBvgsxLnjSqn68g6z+u7G9a47877geDJwwyaELImz5asC+/s7dIU2jQBRx8nOkJc8wQ2fFNTvZKzJDlBECPUJpymQ4ttpflzmzlYP9tyV2prMDNW7PqLkiPjCksrFpc/JVEH2sVpIv V3QORmgB DsTwTEzgRWkPp7WnxXUcO895rBfCYMvEAqHcnhpjp8oRyrrN1MvCScmZQt3oVJGkejC3X42xIHEX6wc5j3rudqCjq6wEVM+DZGLVXPtwoNdtl/pTSt94cJGanGFcRwVUQTBAOA5C3+V6CBGwv5cDiKW0dzgBSypitkR7jpXH2D9DUHoc+Re1RmfVB9sBX5LIqPDTbHUk4AGZZlWn3d/UV3aSDHsUj/p7fDYUWDOGo9yWJNqc9DaSxyWWGnmoszlDWUmU1lanF+VAKJ56+KG2K2RrLu5tncKff/N5XH1b/odb1wWcoGQeIVbiqCAW/hX58pGSiv5BPqOgdtf+A0VU0Ljh+PWAId8jVITlwyQK35jBvTaysgzIEz3O+dJ24ZjpboWJ1GVYnSsjeWnIdrdyVfTtMdw2Eiqwjo87fd7z+xG8LSnRXJeUsWd7r8z/XV/K/FkP+xvRJeSrUSKRAP6ZfLMVp8rbvlEFV41B0TCu04NLLYPuLa+nrqkqmjix3mwNfDY0hoLAzLRE9skobCoeShsxytdQqAAUQBaAbFhQTgRErYFgMLKe4XvU+tIBol6qWMwUr5rnHsBuSZNmibvO5bnOlTkC96bo9j25DAKck6xYcBZCmbMXkHHp3Phy0xkw9TUQCQgZsfNNSYLGdb9cL7YJAY0wyChzrSvb8IKamF9On1aR7prLtbwwKXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Binbin Wu writes: > On 5/15/2025 7:42 AM, Ackerley Tng wrote: > [...] >> + >> +static inline int kvm_gmem_try_split_folio_in_filemap(struct inode *inode, >> + struct folio *folio) >> +{ >> + size_t to_nr_pages; >> + void *priv; >> + >> + if (!kvm_gmem_has_custom_allocator(inode)) >> + return 0; >> + >> + priv = kvm_gmem_allocator_private(inode); >> + to_nr_pages = kvm_gmem_allocator_ops(inode)->nr_pages_in_page(priv); >> + >> + if (kvm_gmem_has_some_shared(inode, folio->index, to_nr_pages)) > > What if a huge page whose attribute is shared? > This checks if there are any shared pages in the range [folio->index, folio->index + to_nr_pages), so if the entire huge page is shared this function should also return true. folio->index is the start of the merged huge page, and to_nr_pages is the number of pages in the merged huge page, so this should be querying exactly the entire huge page. Note to self: rename kvm_gmem_has_some_shared() to kvm_gmem_has_any_shared() in the next revision. Hope I answered your question! Let me know if I misunderstood your question. >> + return kvm_gmem_split_folio_in_filemap(inode, folio); >> + >> + return 0; >> +} >> + > [...] >> >> static int kvm_gmem_shareability_setup(struct maple_tree *mt, loff_t size, u64 flags) >> @@ -563,11 +1005,16 @@ static struct folio *kvm_gmem_get_folio(struct inode *inode, pgoff_t index) >> return folio; >> >> if (kvm_gmem_has_custom_allocator(inode)) { >> - void *p = kvm_gmem_allocator_private(inode); >> + size_t nr_pages; >> + void *p; >> >> + p = kvm_gmem_allocator_private(inode); >> folio = kvm_gmem_allocator_ops(inode)->alloc_folio(p); >> if (IS_ERR(folio)) >> return folio; >> + >> + nr_pages = kvm_gmem_allocator_ops(inode)->nr_pages_in_folio(p); >> + index_floor = round_down(index, nr_pages); >> } else { >> gfp_t gfp = mapping_gfp_mask(inode->i_mapping); >> >> @@ -580,10 +1027,11 @@ static struct folio *kvm_gmem_get_folio(struct inode *inode, pgoff_t index) >> folio_put(folio); >> return ERR_PTR(ret); >> } >> + >> + index_floor = index; >> } >> allocated_size = folio_size(folio); >> >> - index_floor = round_down(index, folio_nr_pages(folio)); >> ret = kvm_gmem_filemap_add_folio(inode->i_mapping, folio, index_floor); >> if (ret) { >> folio_put(folio); >> @@ -600,6 +1048,13 @@ static struct folio *kvm_gmem_get_folio(struct inode *inode, pgoff_t index) >> return ERR_PTR(ret); >> } >> >> + /* Leave just filemap's refcounts on folio. */ >> + folio_put(folio); >> + >> + ret = kvm_gmem_try_split_folio_in_filemap(inode, folio); > > When !CONFIG_KVM_GMEM_SHARED_MEM, kvm_gmem_try_split_folio_in_filemap() is > undefined. > Will fix this in the next revision. Thanks! >> + if (ret) >> + goto err; >> + >> spin_lock(&inode->i_lock); >> inode->i_blocks += allocated_size / 512; >> spin_unlock(&inode->i_lock); >> > [...]