From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDDD2C001B0 for ; Mon, 7 Aug 2023 23:25:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 629A86B0074; Mon, 7 Aug 2023 19:25:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D9B98E0001; Mon, 7 Aug 2023 19:25:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47AAE8D0002; Mon, 7 Aug 2023 19:25:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3360C6B0074 for ; Mon, 7 Aug 2023 19:25:07 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 010F1406C5 for ; Mon, 7 Aug 2023 23:25:06 +0000 (UTC) X-FDA: 81098891454.13.E9AD667 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf08.hostedemail.com (Postfix) with ESMTP id 45407160018 for ; Mon, 7 Aug 2023 23:25:05 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=R4PwviCR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of 3UH3RZAsKCL0dfnhuoh1wqjjrrjoh.frpolqx0-ppnydfn.ruj@flex--ackerleytng.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3UH3RZAsKCL0dfnhuoh1wqjjrrjoh.frpolqx0-ppnydfn.ruj@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691450705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=iwb23aAhSO8tTiEFGOvNlQCsoOox6vBjb8gCypJE4mI=; b=7h5q9Wlv/m8nfZ8MtKRWmXyGOpA34hRIBv7dbv0FTEZ0rIDDwHfdczoomjNdWFOoaUn2Ug fAMf4C8RM5znVjog25AWiwV1cvR1VHuERrM+fkmtN4zPerw8pYktMVA2yL1nfMmgl1zq3x N0435JQubg1Uc1OjeghNLH65Mk6Q1Jo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=R4PwviCR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of 3UH3RZAsKCL0dfnhuoh1wqjjrrjoh.frpolqx0-ppnydfn.ruj@flex--ackerleytng.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3UH3RZAsKCL0dfnhuoh1wqjjrrjoh.frpolqx0-ppnydfn.ruj@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691450705; a=rsa-sha256; cv=none; b=z44tDBvtZukpe/T1sqXQ0DIwmT0AYHyfAQmd4u6ytdUfYh13txaNsSS4B65cULuwROnCrz mYp1gVW3i+sBfOZ15yJRHX8QAmFGzCXL1396eDoyEnQExVqISOx9i+xMZ4uQhemV2G1+wj e+EFdTUTAZnEvf6SCHegeYR5NskMw/E= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-583da2ac09fso59231237b3.1 for ; Mon, 07 Aug 2023 16:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691450704; x=1692055504; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=iwb23aAhSO8tTiEFGOvNlQCsoOox6vBjb8gCypJE4mI=; b=R4PwviCR8DjVobdiirsmlaUW+2G2OreWXDR1oudY0WdYIlf/tRBxovHV7VVaY5H2D7 s6z9nsA/hZZOzOlAXwj0GlLszUfPpUcqxoVPBkJopNIVm5p7oN0Kjjk8CNCU0uvTetel 32HvbTwQx+uTw/DQ0hiV2GccLkJL/LCqkzOCOWamh7kng72/soRCwM6up6P8iJdnPSBO x/GLCUjk6m180XrAeVCUYgLoKf2lX03dUyg16yLerbR/XPy1Dd0ljJbOlBwH8tdW8OEH 2D0Guisqm80uErrMhMIOa5wS5t40qQeuRJl0ljw9a+5siKs8Y3hopoVBYIWmqvB1hWx2 ivOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691450704; x=1692055504; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iwb23aAhSO8tTiEFGOvNlQCsoOox6vBjb8gCypJE4mI=; b=RlWcGf+sx+TuCsdJkQtAw8i84rAeTXWIeur+mgl4Kj2diosjNylhwitvZKMXLShuDk cYe6gVb0T+fhXzSJJ62xDN51+jHdPKqhrRKHsVMT3rs3b3FS8W0d5QroQFUdczwd6CD6 a4SBUJ1CPal3+HTM2K0vz1d7my3rR4Ebd0n1z8y5iJ0TDQW3PjCyelnP7XxiBF0JoJwY NybmQHt/2PxgR3pGOqG0lLFm9CH2p7Cpr7Ff2Yzn9+vL/t6l7FOzsD/iF16dcMzZfqv0 mBefUlzONgQzOMbOtrHFqRW/3AnFfCzxJGkdZx7fuekLBGQshzKqCpaDrm+wEgBiPLBo +TxQ== X-Gm-Message-State: AOJu0YzqbgUke2Fsy3he7G4I8oDl1fZAP7R9fED4G+R87WxCK1vmGEZT qjW+wqybFH4vcE4avUBOzSjFGs8wS1KrFrYuDg== X-Google-Smtp-Source: AGHT+IFETd5g4M85TFzvRFwf955/8WReyRF2E8l7BIM0KMZjnxLWho58vfoUb+v3YvXkNVl+0ZtvnZ9xmC/A9UkLTg== X-Received: from ackerleytng-ctop.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:13f8]) (user=ackerleytng job=sendgmr) by 2002:a25:445:0:b0:d4c:2a34:aeab with SMTP id 66-20020a250445000000b00d4c2a34aeabmr47419ybe.11.1691450704306; Mon, 07 Aug 2023 16:25:04 -0700 (PDT) Date: Mon, 07 Aug 2023 23:25:02 +0000 In-Reply-To: <20230718234512.1690985-29-seanjc@google.com> (message from Sean Christopherson on Tue, 18 Jul 2023 16:45:11 -0700) Mime-Version: 1.0 Message-ID: Subject: Re: [RFC PATCH v11 28/29] KVM: selftests: Add basic selftest for guest_memfd() From: Ackerley Tng To: Sean Christopherson Cc: pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, willy@infradead.org, akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, chao.p.peng@linux.intel.com, tabba@google.com, jarkko@kernel.org, yu.c.zhang@linux.intel.com, vannapurve@google.com, mail@maciej.szmigiero.name, vbabka@suse.cz, david@redhat.com, qperret@google.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 45407160018 X-Stat-Signature: xhncnofrisnh6cu773yzaz8jdqnjxiq6 X-HE-Tag: 1691450705-185555 X-HE-Meta: U2FsdGVkX195dpqXKOZOI/gFrAnHKDJBphqBfP7uQJW1R8wHI/rSYC3I5Oeiz012oD9dnGZ8cM7dvkcJjLmvasZ2pDyU/ETOmg62VtZFFkL4n11zK8eHFhYImo7ptB44v11wrgjcxwZTuJh0LA6hzGLSeXWaJIqLI2A4wUh66p8S5EG0XuJLU1NgacFsrcI9af224WgcHzw0Q1HTmnRIWu6mKkWYOMV0lO1oa888VT3j6V72w1jNxyveeObyYClXq543h3d8MlPelQv6kg6EVlEZmzEVJ6i/qXZErpAI/q5WU2IxN8b/8L4sVqhq/e6TmR4xdIq3PES84Qjw43SuMoSsTwZdDNS64x/RLsdB5rENzSm7KZuReQQdRnXK6rII4zx4WqVEzNg9nQBLN4lI4QxgyuiyMGfZbiZkULVRHHhdZdAvHBZYqmkh4wYGfugJQoDzb5KVCG0T4CkiJXpOTtyo2sVSbWXnsxvuKZImWs+Oax2W5gUQTQQJOjB3u0VsDPQVELyHfvZVF1B0dQxDKDysKeSCJ5FUCnUBMCyGAMLp//JgGlszz5PE0h7BZk73OFjD7VlZGLF2F3FvwZu2rrK4Sq1zUzsvRXyCJzgRvPZFTImMl64sn2iGVyOlja0pzvLa3UvIJyFQsCgH6gwzgIWhn/eZSN26+lABMuMJT1JkgN2cQrk7UNcakMsikmYMxSRO2p0sGgRVC9hMl4H/5lY7FeBiNIj1p6l2LwqjBUvo8NdcGOaB6IvWnyF0QKjr5Tml7L7hVf5DrpL8J5J7ELSuWJl7NLSnk/veCPHtLCNiwGL/CsNaR6WLhf+VANdTSWyYpcJFNBxWY4UASC0SF23sxVl0Ec1zYXcSvLzQSYu2iQQwVbB4afx5Lo5PZfXYopfRtaAblHZOFEarfRjkWMvYFCw0U3oxmMxSkmsQBu7X5LYbUZUSdWdH7bbWBBkFbfjazWkAwdEQQ/aaGUR I56Y+rtZ abvSk+iYQ4BYKPfJIoR/GAWRB2TTZAQACFgsEAOWoQdCDnUCvT42p8nvYfIF9hfZi/umiEHXjiHuxBLlnPpfeuWHlMPJQQwhsVUN1VjHs6mLBKnpUUpsqPDwgz8yr5IBdEs39nDDyDECU9eZsd5yxNtPIJX2PHg606zYezOxN2czh31wdU70+ua2VCELsgm7uPYppSHATQuXEsukoTXtMPgIqUzPl8Tx/2/b2I0poMe92nFk3ZwYzs2bpYIeh0u8BGPcYCHk8JO4FFArEJCQslTDKlsXCyanFE8j7LvkXbEAWBAfl8JqJa0grv6cbeON8vL10FbIidF4vP16cbxNzDEMh7uMYw6bihgNVXF2/vdSSbZ5777HjkTiUW12UhPxxly0L0g7HFm2uIq02gR9rVnjAQztRSs8c7k2/0B/254t+P+/ci/SGh/QtEozW/Q+Iqo+rAbmmX1KdZ6E+dcXsVZlUElkYeNYZIaJn/sPkomgAbKSHmLz6WaRUkQD+pbZOInQesJkNB6KgmMQB+n5otNJZfRBbTC6R0Exjkit6Xb15hNqJZW3g2RQWLNljMsuuBoafHC3tHR/LXs0jDoIR2S8G26DG5a/dcJjpfdda7r9MJz9vcI7w9/DrgTDikk8AWGFHaFZG3+tEGw+NFQAO+oolykdj0GShALuUCvnmgPtgWdsG4CkkQesEdcDPVlHqHcd2XQ1tzSopp7T3650PHN/aC27tPchNeShUtptovVgSEkpY+gzOs52kmj8yN9nl6FP0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sean Christopherson writes: > Add a selftest to verify the basic functionality of guest_memfd(): > > Here's one more test: >From 72dc6836f01bdd613d64d4c6a4f2af8f2b777ba2 Mon Sep 17 00:00:00 2001 From: Ackerley Tng Date: Tue, 1 Aug 2023 18:02:50 +0000 Subject: [PATCH] KVM: selftests: Add tests - invalid inputs for KVM_CREATE_GUEST_MEMFD Test that invalid inputs for KVM_CREATE_GUEST_MEMFD, such as non-page-aligned page size and invalid flags, are rejected by the KVM_CREATE_GUEST_MEMFD with EINVAL Signed-off-by: Ackerley Tng --- tools/testing/selftests/kvm/guest_memfd_test.c | 17 +++++++++++++++++ .../selftests/kvm/include/kvm_util_base.h | 11 +++++++++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index eb93c608a7e0..ad20f11b2d2c 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -90,6 +90,21 @@ static void test_fallocate(int fd, size_t page_size, size_t total_size) TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); } +static void test_create_guest_memfd_invalid(struct kvm_vm *vm, size_t page_size) +{ + int fd; + + /* Non-page-aligned page_size */ + fd = __vm_create_guest_memfd(vm, 1, 0); + ASSERT_EQ(fd, -1); + ASSERT_EQ(errno, EINVAL); + + /* Invalid flags */ + fd = __vm_create_guest_memfd(vm, page_size, 99); + ASSERT_EQ(fd, -1); + ASSERT_EQ(errno, EINVAL); +} + int main(int argc, char *argv[]) { @@ -103,6 +118,8 @@ int main(int argc, char *argv[]) vm = vm_create_barebones(); + test_create_guest_memfd_invalid(vm, page_size); + fd = vm_create_guest_memfd(vm, total_size, 0); test_file_read_write(fd); diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h index 39b38c75b99c..8bdfadd72349 100644 --- a/tools/testing/selftests/kvm/include/kvm_util_base.h +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h @@ -474,7 +474,8 @@ static inline uint64_t vm_get_stat(struct kvm_vm *vm, const char *stat_name) } void vm_create_irqchip(struct kvm_vm *vm); -static inline int vm_create_guest_memfd(struct kvm_vm *vm, uint64_t size, + +static inline int __vm_create_guest_memfd(struct kvm_vm *vm, uint64_t size, uint64_t flags) { struct kvm_create_guest_memfd gmem = { @@ -482,7 +483,13 @@ static inline int vm_create_guest_memfd(struct kvm_vm *vm, uint64_t size, .flags = flags, }; - int fd = __vm_ioctl(vm, KVM_CREATE_GUEST_MEMFD, &gmem); + return __vm_ioctl(vm, KVM_CREATE_GUEST_MEMFD, &gmem); +} + +static inline int vm_create_guest_memfd(struct kvm_vm *vm, uint64_t size, + uint64_t flags) +{ + int fd = __vm_create_guest_memfd(vm, size, flags); TEST_ASSERT(fd >= 0, KVM_IOCTL_ERROR(KVM_CREATE_GUEST_MEMFD, fd)); return fd; -- 2.41.0.640.ga95def55d0-goog