From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79828C19776 for ; Wed, 26 Feb 2025 22:29:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A624D280002; Wed, 26 Feb 2025 17:29:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EB96280001; Wed, 26 Feb 2025 17:29:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 864E6280002; Wed, 26 Feb 2025 17:29:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 64F07280001 for ; Wed, 26 Feb 2025 17:29:23 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0DC22C0CAF for ; Wed, 26 Feb 2025 22:29:23 +0000 (UTC) X-FDA: 83163538206.19.F03D28C Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf28.hostedemail.com (Postfix) with ESMTP id 4FCFEC0002 for ; Wed, 26 Feb 2025 22:29:21 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BU60fpiV; spf=pass (imf28.hostedemail.com: domain of 3wJW_ZwsKCC8LNVPcWPjeYRRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--ackerleytng.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3wJW_ZwsKCC8LNVPcWPjeYRRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740608961; a=rsa-sha256; cv=none; b=XwCKvxwEMukTTRy6ozSAuP1OjekYCu93ISMFCcp3xOP8AyhKHLfOmkfMgebsj07IFey7UE xtfkmWRxc2gXqZuLJ/EYs86OGpoZa4uZDqlciK/+RuqTLmwEt23di8hFM7hzbGndxJAMtO lm6nCK1yIp4IUUvDOb1Ekib14Mbwi3c= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BU60fpiV; spf=pass (imf28.hostedemail.com: domain of 3wJW_ZwsKCC8LNVPcWPjeYRRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--ackerleytng.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3wJW_ZwsKCC8LNVPcWPjeYRRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740608961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=oBGRt7WXjkkbaucrCtRFoiyJpp1hbaiF4R/5f+bgEWc=; b=QRqnqh/OZ0WPf3AxdDQPzluCmV4JCoPGyRsHqKcRM+7wpUVAIxAnaT1ymKIaYIKXgDr2oY UyoVbVIED1A9OojAq2M5ToWWkUyE3Qww/B3omDVejt4Sx8Dg7tgjtZJ3+i+Nfe1jRJcqFu bGAH+NUNkM2Sy1Q8UuOM6NOwvf/b5Ms= Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2234bf13b47so4380065ad.0 for ; Wed, 26 Feb 2025 14:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740608960; x=1741213760; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=oBGRt7WXjkkbaucrCtRFoiyJpp1hbaiF4R/5f+bgEWc=; b=BU60fpiVy90OEwYCA4ET7htMF3kj/wah/QzkQvY/s/rnPf4XvH1Idg6hEu9hq458Ui Mn1V/76uZrzINw79wlP9RQcVSsPclge2xXgOO7ijTCL+VSf4EYsvmQ/NNkoK8YNy6Euh TWNZE54RsdykF3LS6sFZo6tqkOhan2STBiDJbL7ABywhqixQOhE7mDgv2Ii9jq1/c6yM lK0wMeWdDIh94ycFB/n8bsK9K2HEfL2daxp1wRgaeOxt/vUSy/G79L7c3kkowBRY8EYv GFnySoxIadUs8zHQcF8GkP8vT7+LJyE9pQ5CG78mRoipEDBgfOed+VYyqO7KGG8/Bank gm/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740608960; x=1741213760; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oBGRt7WXjkkbaucrCtRFoiyJpp1hbaiF4R/5f+bgEWc=; b=aofE968LqSmLWpnHTZY2RrJQhcz8ZExcE/zDNcp7gV8gj29CNcKGwUK4CG5U8Lu3OQ Z/o+BnA20KI+gBWXAkiSxgk0+ZNl5xXDMMhiK8iR9l9cg9+5LR6tAkp4sKg+Ktex9hKk daDazjqd2c11IpH6Nv74YZK0oNIPQvW7Im+VWB4IbsSjgESn6pmp5MbfCGbYxm47hauz VjX+/9d3eLSrBeW56qWhA9aO8Fa19BAAS6haiVK1Xe2PjUwRA4ZBwt5ODvcetL+IjS8s 6oGyi/XTicIDpZ1OEJ29p3+HyE/JZBtMFInoaR5x4v3lL7EIm+s72bCvAdHLEWK3T96v 6aYA== X-Forwarded-Encrypted: i=1; AJvYcCUMnPGJgwT6GFaje7fGhEfI56uUf9ifMWhLU+KLbzT4ar/HOw5tzT+d4BtONtOCQ0+8ok1OovcSPw==@kvack.org X-Gm-Message-State: AOJu0YwZWZrLcpVD0+1AefrSNn7EkZfLXdnOrlslTE2Wi3iSEqFs9PHy VruacpduN1Cpui/CIkNeL0wFD747hvgUnnO8VeK5w3zrnWQMiqhzjpMNgcBqHFNjaDH5qjYOcxc L+sOBN3lpdNrxa5elTIlSww== X-Google-Smtp-Source: AGHT+IEx90GrBY3H6MbzTcyDAQhZ2Ks2wua1pC+ws2C0H9wlTxI+92NL1aBLbDXxy63FmYi74R2O4wQAYik0gcC9+w== X-Received: from pjh15.prod.google.com ([2002:a17:90b:3f8f:b0:2fa:e9b:33b7]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ea0a:b0:216:393b:23d4 with SMTP id d9443c01a7336-221a0ec9a77mr342976695ad.11.1740608960088; Wed, 26 Feb 2025 14:29:20 -0800 (PST) Date: Wed, 26 Feb 2025 22:29:19 +0000 In-Reply-To: (message from Fuad Tabba on Wed, 29 Jan 2025 10:15:23 +0000) Mime-Version: 1.0 Message-ID: Subject: Re: [RFC PATCH v5 04/15] KVM: guest_memfd: Track mappability within a struct kvm_gmem_private From: Ackerley Tng To: Fuad Tabba Cc: gshan@redhat.com, kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4FCFEC0002 X-Stat-Signature: j3t1ntkru9mjsxyie7sczscpu5tryrzm X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740608961-807438 X-HE-Meta: U2FsdGVkX1+R/SXpRykoDBrJF1eJjFXfonfQOAhOn67AV+q8WtviMt+rke4azIXTerlUTicOK1U4tUeqUDh24KAfyb0LQ+hEaxeAf/D6QR7oEKrv8Rp6yc23GVs7jI/NoHOnRnpLktDjQqDP+ZhotKwWKHt8NM8BhQrF3QA0CT3I9kX2tK3yYLxsEUNMwBRa8Jfgix6sZ0ltdA4gQdLQogAoCDl4n1bOIlWoEyQoIu0b4hbnTDIJuxeKw4Zus7uIUTlfuj4XacGctuMYn02/3qFpD3pkCfQMu07gIOYz69zPXxHMWHFXvhOs95f5c2z9oOGJ0JVAyTV+gq/iGosNzi7rK9wFum1lbzjyfP4RZ7qpWNuTR1Xha3Ubq93elO74BAZz/VPSQ5lU//9fjQqJKn3FPIxMjaKKgzJJQ2tJ9KvfQ2wB0XFFxKA+fWuWEb2Ahh7hwqCg/GxsrKcXIFH3TfZHtxs7o6w57pQ7YYU8D1HDgoQMvEGUqsZWgalWaqi7p2Gx13BWGNV2PlLlEQnY7dOLJ5uvvqFPIO2YzYvzzOvnoMn/LdrpKwQJOa8htexfxuLpxvSdWICy1kC6pERyqC/Fq6rcfw4J73KmdLWnIdfCfvbpgN0tS/TZHGDjlrFnuyKF/d4ab0i3X5ZeDKRN13fwRbhIAaO84+fXvvg1Z8LfwH2KtcbCtnhUML69A/PyhiQ3HjffFu/0Glr+pQ5vtV9SmhOzUZH9d2fXhofdyw3Q4KxEYkYQH7w2Q3LtZa5kvL82PjeutdeYTkD/I//qQEgbDbsc8CV6g2K3dKg1hsQ4g00+xWeO5+Fp+wbv3+D177lErV+thdK7mAlP8lmZWK79zVVyz/vd6IRIuCJdA6hmYY27wRw0MLmUoljS4OzJSoLExxU78IZ+RZSh//Q2WiqOwFj6g8L48BDMHkZyQPuRUxWmfwXw8aTC/NbLMm8zvMalriJd9uKHdrRY+Nh V9nVeztQ tD69w6ELbYvzGz5C2KrX6KfvQDuEv1njvlCiGmoKDDqwaSu+2jsAJKHENujl4QLwEXdP8RZinMWTyPMHqGJFQhxPXmHSScTboPjdyR0vXFDauuNG0jp+3Eg3meEXamRelTTSy/1ZzGgYhcCI+WM4/HhmguwIwhK/30Nql0ugezJcV7UmPcoHgKK/tm1CuV8eZ5y1lBG08Y4s6sFCQMSpCQVDsFleWpMxN0k+uI/o14IfCWzZzEhLQVSmMWmBuMB4GQx/QgRM8k3Pbau36pSg7p6rRVJ9570G62Yl1+iQ61fEbJiHsQqRpfEf0Zuc01w0lx9B+wgEcemtktiyoLj0KadMcu3ZBhx9DJxvYoJl4YXYKpGGUJKWTrvXYtsJiTgYbO7/NQinLurEooo+t6uYvxvKZH94RvgccPIl+kAt9iuexJX9bHuuaFDHXLubC93iLX9Vbp+dv0OgtvZAXAGnFQGYyKm1M5EZQrgJpKXbN3wzSag26UOw8kojqG7c8EXYsdoyxl+LxqVQIth+ETg7LyqNqj6yQD5c+7rCV8uT80wEaIwENRrScbkSrNJSudg/c4CW9QJ6Bi1EdlJ4+wPUAeO9ity7VXT4I4R1xWuH9pcK90C2oRmuajh332ZSpk4+mf3VfHPbaNfIAsqd1Q/seSBJbK3dF/9eBqpI5pNb29CQa7Yyt4sl6CFY3zzqBUr69ihKvKfY+aBW2InLgZbaGJoM6x6+/Z+mOgOu+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Fuad Tabba writes: > Hi Gavin, > > On Fri, 24 Jan 2025 at 05:32, Gavin Shan wrote: >> >> Hi Fuad, >> >> On 1/18/25 2:29 AM, Fuad Tabba wrote: >> > From: Ackerley Tng >> > >> > Track whether guest_memfd memory can be mapped within the inode, >> > since it is property of the guest_memfd's memory contents. >> > >> > The guest_memfd PRIVATE memory attribute is not used for two >> > reasons. First because it reflects the userspace expectation for >> > that memory location, and therefore can be toggled by userspace. >> > The second is, although each guest_memfd file has a 1:1 binding >> > with a KVM instance, the plan is to allow multiple files per >> > inode, e.g. to allow intra-host migration to a new KVM instance, >> > without destroying guest_memfd. >> > >> > Signed-off-by: Ackerley Tng >> > Co-developed-by: Vishal Annapurve >> > Signed-off-by: Vishal Annapurve >> > Co-developed-by: Fuad Tabba >> > Signed-off-by: Fuad Tabba >> > --- >> > virt/kvm/guest_memfd.c | 56 ++++++++++++++++++++++++++++++++++++++---- >> > 1 file changed, 51 insertions(+), 5 deletions(-) >> > >> > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c >> > index 6453658d2650..0a7b6cf8bd8f 100644 >> > --- a/virt/kvm/guest_memfd.c >> > +++ b/virt/kvm/guest_memfd.c >> > @@ -18,6 +18,17 @@ struct kvm_gmem { >> > struct list_head entry; >> > }; >> > >> > +struct kvm_gmem_inode_private { >> > +#ifdef CONFIG_KVM_GMEM_MAPPABLE >> > + struct xarray mappable_offsets; >> > +#endif >> > +}; >> > + >> > +static struct kvm_gmem_inode_private *kvm_gmem_private(struct inode *inode) >> > +{ >> > + return inode->i_mapping->i_private_data; >> > +} >> > + >> > /** >> > * folio_file_pfn - like folio_file_page, but return a pfn. >> > * @folio: The folio which contains this index. >> > @@ -312,8 +323,28 @@ static pgoff_t kvm_gmem_get_index(struct kvm_memory_slot *slot, gfn_t gfn) >> > return gfn - slot->base_gfn + slot->gmem.pgoff; >> > } >> > >> > +static void kvm_gmem_evict_inode(struct inode *inode) >> > +{ >> > + struct kvm_gmem_inode_private *private = kvm_gmem_private(inode); >> > + >> > +#ifdef CONFIG_KVM_GMEM_MAPPABLE >> > + /* >> > + * .evict_inode can be called before private data is set up if there are >> > + * issues during inode creation. >> > + */ >> > + if (private) >> > + xa_destroy(&private->mappable_offsets); >> > +#endif >> > + >> > + truncate_inode_pages_final(inode->i_mapping); >> > + >> > + kfree(private); >> > + clear_inode(inode); >> > +} >> > + >> > static const struct super_operations kvm_gmem_super_operations = { >> > - .statfs = simple_statfs, >> > + .statfs = simple_statfs, >> > + .evict_inode = kvm_gmem_evict_inode, >> > }; >> > >> >> As I understood, ->destroy_inode() may be more suitable place where the xarray is >> released. ->evict_inode() usually detach the inode from the existing struct, to make >> it offline. ->destroy_inode() is actually the place where the associated resource >> (memory) is relased. >> >> Another benefit with ->destroy_inode() is we're not concerned to truncate_inode_pages_final() >> and clear_inode(). > > I see. I'll give this a try. > While working on 1G page support (old revision at [1]), I was looking at this. Using .destroy_inode to clean up private->mappable_offsets should work fine, and I agree this should be refactored to use .destroy_inode instead. Thanks for pointing this out! FWIW, for 1G page support, the truncation process has to be overridden to, so the .evict_inode override will have to come back. >> >> > static int kvm_gmem_init_fs_context(struct fs_context *fc) >> > @@ -440,6 +471,7 @@ static struct inode *kvm_gmem_inode_make_secure_inode(const char *name, >> > loff_t size, u64 flags) >> > { >> > const struct qstr qname = QSTR_INIT(name, strlen(name)); >> > + struct kvm_gmem_inode_private *private; >> > struct inode *inode; >> > int err; >> > >> > @@ -448,10 +480,19 @@ static struct inode *kvm_gmem_inode_make_secure_inode(const char *name, >> > return inode; >> > >> > err = security_inode_init_security_anon(inode, &qname, NULL); >> > - if (err) { >> > - iput(inode); >> > - return ERR_PTR(err); >> > - } >> > + if (err) >> > + goto out; >> > + >> > + err = -ENOMEM; >> > + private = kzalloc(sizeof(*private), GFP_KERNEL); >> > + if (!private) >> > + goto out; >> > + >> > +#ifdef CONFIG_KVM_GMEM_MAPPABLE >> > + xa_init(&private->mappable_offsets); >> > +#endif >> > + >> > + inode->i_mapping->i_private_data = private; >> > >> >> The whole block of code needs to be guarded by CONFIG_KVM_GMEM_MAPPABLE because >> kzalloc(sizeof(...)) is translated to kzalloc(0) when CONFIG_KVM_GMEM_MAPPABLE >> is disabled, and kzalloc() will always fail. It will lead to unusable guest-memfd >> if CONFIG_KVM_GMEM_MAPPABLE is disabled. > > Good point, thanks for pointing this out. > > Cheers, > /fuad > >> > inode->i_private = (void *)(unsigned long)flags; >> > inode->i_op = &kvm_gmem_iops; >> > @@ -464,6 +505,11 @@ static struct inode *kvm_gmem_inode_make_secure_inode(const char *name, >> > WARN_ON_ONCE(!mapping_unevictable(inode->i_mapping)); >> > >> > return inode; >> > + >> > +out: >> > + iput(inode); >> > + >> > + return ERR_PTR(err); >> > } >> > >> > static struct file *kvm_gmem_inode_create_getfile(void *priv, loff_t size, >> >> Thanks, >> Gavin >> [1] https://lore.kernel.org/all/cover.1726009989.git.ackerleytng@google.com/T/