From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 271E2C47071 for ; Thu, 16 Nov 2023 21:00:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B06BC6B04A6; Thu, 16 Nov 2023 16:00:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB96D6B04A8; Thu, 16 Nov 2023 16:00:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97EAA6B04A9; Thu, 16 Nov 2023 16:00:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 870696B04A6 for ; Thu, 16 Nov 2023 16:00:27 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 55262120D29 for ; Thu, 16 Nov 2023 21:00:27 +0000 (UTC) X-FDA: 81465035694.27.E6941F2 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf14.hostedemail.com (Postfix) with ESMTP id 98C88100021 for ; Thu, 16 Nov 2023 21:00:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eaI3ErHo; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 36IJWZQsKCHkXZhboibvqkddlldib.Zljifkru-jjhsXZh.lod@flex--ackerleytng.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=36IJWZQsKCHkXZhboibvqkddlldib.Zljifkru-jjhsXZh.lod@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700168425; a=rsa-sha256; cv=none; b=r+68EAQ39E9+k9r4DNz1yn7zrymdFKd9THSVoEi3sZUpI209VDIBvO3M/6DUyucMuS7qlQ fgKgU5lNKRVAsHCmXDr6dYj6qhItBbEgYm08AgZCtIuMc1vtU/r79yTSOwT0+l/5G41ksZ 0CK/85Fj/Xigy3x6aRq5TZt4WUH1CDE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eaI3ErHo; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 36IJWZQsKCHkXZhboibvqkddlldib.Zljifkru-jjhsXZh.lod@flex--ackerleytng.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=36IJWZQsKCHkXZhboibvqkddlldib.Zljifkru-jjhsXZh.lod@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700168425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=pcg1jHOi88FLN7hCqkcZwcR8zkGGhGMDTBufXRqyOok=; b=mSmvqZGaJ1H+SXZjrd/x9uQi9gUguyicocNKQCgLSuySFKbbsH1hLbOYmqCps1IRBCipjT 52byOPpgF0dhDrqoT2JoZIeR8/NZS/w9EwEPHIVTylE3p84egy9gGHq0UEIpRpz4HWu8wd ErP0HilwTSKpj9B4dZ2nv+lBqBwix9k= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-da0737dcb26so1735807276.3 for ; Thu, 16 Nov 2023 13:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700168424; x=1700773224; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=pcg1jHOi88FLN7hCqkcZwcR8zkGGhGMDTBufXRqyOok=; b=eaI3ErHoENVBut9hOrKwgVmeROOQchUNrxIOLA4rQPgrbtwOuitBna8SD2oVWA5zFN 54TcuPPYAclIIL+Sdj3/bEb7v2Qb36pspCAC2cL5WwCGRA1H+CDDz1NXvnfgfOO+3hrl fn22ktu6KkaIShJ2dyZb4HtVeibPTlzB3Zyl+15bi9W8fgrogAZUTpzNb8PYoh2ri47C I6nt3uweb+hyOhoNdjp3zY3DV26gZL6BgfH8FHp4Rg1uaQwI+MIeOgL9YgSzNQWgj6o2 3DIFilsMMR7Cl/kDEHCsf1BinOLUQtc1w4DD61sCgg27P4OVQaueRE091dHbnaMESDwB hy4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700168424; x=1700773224; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pcg1jHOi88FLN7hCqkcZwcR8zkGGhGMDTBufXRqyOok=; b=TiHwKCKhWV9PSr+9uX4l7Q6GwdXVWKopFg61IDlch2dW55i3f3iiwUPWVO+E88l5NY h0+aocM6mu7S2kJimFx6SsGKLg8HwWN8/vfOc5Hrw10bmZkvpSuIVnDqUBxPwIa2zj9y uqQ2W3AtoT75bQmXPWe8EkN6Sqm3z9KBKyG21ODoHjt6bguI+CLMQenyashZxUu4fhaS pSZt1t9MHxo2NKxztj7F1IhO2xTPmG0hU1UHbxL+yuE7AxArlcZEP25PUnanM9cbBRGE 8JafQZMkK4TDLvLgcmawFkAz15z8K2ff/XuCxLQIjpm3R3xETQinCJrwlgRZ9LzSQsXT GzJw== X-Gm-Message-State: AOJu0YyNWki3Ln8lqLb6OYHfD6XcWjMzmKMfjtC0M8tSimBDfM4SmfzT Cb94H+8gjv6fSGuhj2SO3OYpDbK5J75RZbxMuQ== X-Google-Smtp-Source: AGHT+IERExc4D+qrt27go/xYBPrtoAORZdvfQFtSO07pMqMqSuTLQB8wBOPMZT1riqPUGW5/Jxx9EA2kvlBTv30QyA== X-Received: from ackerleytng-ctop.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:13f8]) (user=ackerleytng job=sendgmr) by 2002:a25:7644:0:b0:da3:a4ae:1525 with SMTP id r65-20020a257644000000b00da3a4ae1525mr393167ybc.5.1700168424573; Thu, 16 Nov 2023 13:00:24 -0800 (PST) Date: Thu, 16 Nov 2023 21:00:22 +0000 In-Reply-To: <20231105163040.14904-33-pbonzini@redhat.com> (message from Paolo Bonzini on Sun, 5 Nov 2023 17:30:35 +0100) Mime-Version: 1.0 Message-ID: Subject: Re: [PATCH 32/34] KVM: selftests: Add basic selftest for guest_memfd() From: Ackerley Tng To: Paolo Bonzini Cc: pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, tabba@google.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, mail@maciej.szmigiero.name, david@redhat.com, qperret@google.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 98C88100021 X-Stat-Signature: 4ecedte4q6czuowfqs15h7fg71fpbxb4 X-HE-Tag: 1700168425-291830 X-HE-Meta: U2FsdGVkX19sq1S/CCqePsvsXjL21WUM8J8QfDuYYgFnwlsobpg+zSJrdBc6R8erpqLrFiZqNYDCDCGFjqxVl6en8JQ1u6Pqq3Xz0zYwCGSpAl8lPWPbGhCfHHR7tg8IMIXU82gt/woBZAFzMMYE9GO2KktTg04CfjWzB0pso2RB3vtvevrAaDM5HKq/wN07FcCPcVYB+XGyEhd9LxlZxLgmRWF4c+kJSD5xKyl0ZG9+90x34OWOIHxwQcDL6clCjnuMAMDyJqDxgYkViby91lewySWaIp55fMqE0Qs9zCu4kyr5MyyEGeli9qIdq9uOuv61algBqmS3znJSJIWoLnRwGcFCnk/HQxXh+d+HlauKfXqGsBkbVszSaEGmMJ83hMLnzf1aWaVCvkElg80TEEhKapPAobGBdBhLukpyj/GBztyN9GiobI7a/o9kWEtI3xUjnvkNsjQsm3jZE5DhFVNvHBRTk/g1pgO1/ymOaS7W/L5aTXXBOyJSUhbJ99i3tmcES5DWUVdmZKhAwIGEN7tAU22FxumrS4ymjrFjdCJFhQx6ATq5oyRcyMxLK4KypVfOxyr/9extp7ulwQB7Oia/RefISMGCRHpIXX/fsAie90lkspA/SWG0f+XsNKguN4crYzqSCym73t6xOrbF3JcUK4+vXlF58MzhVNZmdeZ+L93/tx7UexnJ4ZpFirLVJr4WJPEF4PXk3Dnu+jqmIGFWk7w4icxHUT3N1z1+ryKRcsFOTOMjx3AaRYuzfuwra490Xs/tdkez7qy/xRVFSZbOsnlcNVdfGwj83n/SPOd4k6Bzl6Cm0+L4VK2M7AfwSZwdQU0rFv1aMwk7j3cxvE9TIwG7VXMDnrhbY2JuQMzTXLA4EeD8SaibDu+ET+6bnZJeQJyRE0EJaHoaEw+g2l7R0snXv0vEH63jLR9bUKZtPRdrToSB4+ET7gLfRk9mGKqkJYp3+DRGDpEr2q7 mTHvkdQ9 RyYE2rhD9/99a+NF0Vve87aKS3uCGx7Mq5C5qUib7+rQHRuqeWFEP3M/vEZgoptSaSQ0U3LBwzcPwMqpQ0P2YVwvBVvdZ7+jzozIezPmjKX2Za34AnKnYRC+2boWWQh/0gEGuNpQk1f5tPMGeFGJcFK4c6iio0XJSU/oU/4i2SEd+MUiI29y/uq2dW45u/ab00CBJRVEmi3svaSAYWrMJw+RmrJML+3mKyzQFHVaEbzBlv5bkKP/MJU5vf3n7NSRoROJCxttv34s4Xqek6JvM1pVeZfXOjQfLNZU70gPLX//FZ1nuFJIiG3LBpvsYKAgzxF/ZhyXvmfa3GOHaRpx8VFHrULSC/xEzvx2NiPoRWDOirIEdfeYf/5zzUbyaYIOmh+w6fAC2CBe8rOa3a+uZA7LEs4PA5Fib6R919GPcOA7SuL5DOf08P14ANzsyC3Jld5gFLKzf77tN47vatRnDFO3yj0iyUfbZg6VNWMdK/9SuUO5yI+Q0Y6J5EdI99WzySCuD39N6LH4QSqFtWFdlUO1OmX1JrPnVMtbM8um1WFuwizlUmj1u3s3h1O1f88wEtaePv5t/SBH+23cm8zxCts++512M5c45UWz+S7xevMw9WMLnJxqpnGN7sNv7NLBqG+wOU3/L8plqwehD/USbXTdhtzN9001yUy+4LtRwwvEc3VzfjKAbuqw4mPv1J9ojowtTslZNw0P9JQ2WDUoWioC2g2jp4lVYfVfVPCdiqT1Lnjw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000382, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Paolo Bonzini writes: > > > +static void test_create_guest_memfd_invalid(struct kvm_vm *vm) > +{ > + size_t page_size = getpagesize(); > + uint64_t flag; > + size_t size; > + int fd; > + > + for (size = 1; size < page_size; size++) { > + fd = __vm_create_guest_memfd(vm, size, 0); > + TEST_ASSERT(fd == -1 && errno == EINVAL, > + "guest_memfd() with non-page-aligned page size '0x%lx' should fail with EINVAL", > + size); > + } > + > + for (flag = 1; flag; flag <<= 1) { Since transparent hugepage support is no longer officially part of this series, > + uint64_t bit; this declaration of bit can be removed. > + > + fd = __vm_create_guest_memfd(vm, page_size, flag); > + TEST_ASSERT(fd == -1 && errno == EINVAL, > + "guest_memfd() with flag '0x%lx' should fail with EINVAL", > + flag); > + This loop can also be removed, > + for_each_set_bit(bit, &valid_flags, 64) { > + fd = __vm_create_guest_memfd(vm, page_size, flag | BIT_ULL(bit)); > + TEST_ASSERT(fd == -1 && errno == EINVAL, > + "guest_memfd() with flags '0x%llx' should fail with EINVAL", > + flag | BIT_ULL(bit)); > + } otherwise this won't compile because valid_flags is not declared. These lines will have to be added back when adding transparent hugepage support. > + } > +} Tested-by: Ackerley Tng