From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5DCBC7EE22 for ; Mon, 8 May 2023 16:29:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 392FD6B0074; Mon, 8 May 2023 12:29:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 341EC6B0075; Mon, 8 May 2023 12:29:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2310D6B0078; Mon, 8 May 2023 12:29:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 107976B0074 for ; Mon, 8 May 2023 12:29:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C1A5540881 for ; Mon, 8 May 2023 16:29:34 +0000 (UTC) X-FDA: 80767623468.09.BD39928 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf03.hostedemail.com (Postfix) with ESMTP id BE99D20015 for ; Mon, 8 May 2023 16:29:32 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=A+o0rLnA; spf=pass (imf03.hostedemail.com: domain of 3ayNZZAsKCEAcemgtng0vpiiqqing.eqonkpwz-oomxcem.qti@flex--ackerleytng.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3ayNZZAsKCEAcemgtng0vpiiqqing.eqonkpwz-oomxcem.qti@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683563372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=NCAPmpxEboZRCp5DLfCJG8it89iaKWx8exXle5+fDgE=; b=z4NKIjTpSpswhczWB+DloH8S3Cz5L3RZZVChvwV1kplE5+WDuJmR6DJ1ejQP621zBfna8p qAQOsf6Jcx38U6Tr2JozlkkZgmBhKclr8/LtC2EdbUhKn5tfXWwi8xj24Nf54YOCXLtmbm B6RiwsH3y/gkQrS8utJ7XWkMZcQJils= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=A+o0rLnA; spf=pass (imf03.hostedemail.com: domain of 3ayNZZAsKCEAcemgtng0vpiiqqing.eqonkpwz-oomxcem.qti@flex--ackerleytng.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3ayNZZAsKCEAcemgtng0vpiiqqing.eqonkpwz-oomxcem.qti@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683563372; a=rsa-sha256; cv=none; b=4hCn4qQgm+i8kgbaEiy+2Ideq+Ih4lsYp7f4TiTqdAed8u1+NgcdnMLFuzcGCHeJDxd0yO sF3NVH/6+kk1lgsJ7orKJt0L0aGEyuWTZ4wT7E+09yUV5B+bYvsYOj6yQnqjydO7TKgaUC oN4patE5BfATe0TfNxC/+5yTqGfodTM= Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-51f10bda596so2139779a12.1 for ; Mon, 08 May 2023 09:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683563371; x=1686155371; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=NCAPmpxEboZRCp5DLfCJG8it89iaKWx8exXle5+fDgE=; b=A+o0rLnAoFkcu74b0ZTyzM4ELOkmu/fubFOC43V3bUC8SI2ZLvAgDgdLvm7YpNb4iY lkDovKqfkqWHqHpHROm2OpwUiBiwkFH0eq41npWZUl0Auxtvlm9TltesUV5gaGCOdjK6 YZeNqElzkzKVeM4q1kGcoXt0wC6fx/+T09iRE4HSSfLzQrMpX69Es2m2gFqj/lsccwA3 G+IDS9nQAaFgj/uLiCLVwBBL26UiAwRdZ+quQGoVCbC2LZugLCjsv3wveXeRpElvfrSt rbOd8ZsetUR6aYFg8l/NOSvaQOYVs49lC//LrjyPaKtzsYZ8J1y4h8OQcDQgfnmQv9TE Esuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683563371; x=1686155371; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NCAPmpxEboZRCp5DLfCJG8it89iaKWx8exXle5+fDgE=; b=TxlD4ybmrex+i79f5eKGfYFuJuflHnXRxg+uHNieFnnWOH4KrfXG7DLmoymSc2BWN+ 4kY52XOZAc2OFcCGPMqDGdkuq75JbQCUmO7Z+uKSUFtvXP4i2pCGzgprvec6377zsnqd Hve1VNFDsnV/PQ6vyWQ5O9wvQDEE3lMV0Sm7jXhg+eB8eQxYZpDe4g96mGW60BkjLnAm Qj3tQpXUhMnX9GaR7w3pKIm51TE8sn0slsXc1BCGok/nK5aHZwTMSbFP/DMsDw5JLHAY 2YITYjydm+QTsKNqwoPBL71hyx8CBOlxaL7mI3sZrZmvJEOsEwQU2KK9lnjsZ6tc3l3y xXMg== X-Gm-Message-State: AC+VfDzhescVKDBhv1CVQQ3x3SzQ3AvkX8isxmJpImJXpa1MSjkwepgL kEb8diRbzPybwsOd6RXYW49XlY3TF+mXZJNI4g== X-Google-Smtp-Source: ACHHUZ76MdGRZaZii/Tb2tEloQqPEW6qT4wxUIpboq08Bq3SCocGXXbj1z+MFqhm9tKSr2oW8q4lKvAUY4lcbA5McQ== X-Received: from ackerleytng-ctop.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:13f8]) (user=ackerleytng job=sendgmr) by 2002:a63:2b04:0:b0:521:62ef:9b38 with SMTP id r4-20020a632b04000000b0052162ef9b38mr3198022pgr.3.1683563371206; Mon, 08 May 2023 09:29:31 -0700 (PDT) Date: Mon, 08 May 2023 16:29:29 +0000 In-Reply-To: <20230504001409.GA104105@monkey> (message from Mike Kravetz on Wed, 3 May 2023 17:14:09 -0700) Mime-Version: 1.0 Message-ID: Subject: Re: [PATCH 2/2] fs: hugetlbfs: Fix logic to skip allocation on hit in page cache From: Ackerley Tng To: Mike Kravetz Cc: willy@infradead.org, sidhartha.kumar@oracle.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, jhubbard@nvidia.com, vannapurve@google.com, erdemaktas@google.com Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes X-Stat-Signature: ta4ca15k3p7c8gkeg9cj8ooubcbnzp7c X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BE99D20015 X-Rspam-User: X-HE-Tag: 1683563372-367831 X-HE-Meta: U2FsdGVkX18xc2v6pW1TN11PfjK3afpptfmZQnm4w5aqsKXXl7x22NQoZAls3EooJy21G4TgqILMtUddBSjo6cmKRvePiZgTOVRJK4pifUNv1UA+TLEp4hLZqeU65EL58HL3FpGfc8W9XYus1PzuAg3A4fzvmINmPjk1SuaYQadkz7vMxon/TVyzKA+SAoDF1VMQY7rvLvw5kzjUjjvuZcgM3W3FzT2SKh9juuR7U1Y8sTFI85LssId+SEturz7bdPENT7qaz41+n6PEJPmTO4AlN9mUwDntmo1eb0m0oOxON92UWthSfyz/mD0EjBVHUmZ6m7sbx/N1uAymOcYay9WhA6hAvoJNOkHGopTMQ6OLW3uhmm2g74T9cBrO6vVo2sK0nlALUPPWF8NEbYLaCFdYTcfHpuAk5D6Kyf6Nx9bYUw7cUrxLbUeTh7SpTkgyI1UWiDHJDL5i4RvuicQqdusVaKv2FlcpjiR0TQF3MyGEwh/pqAlCFuk6Tg8mYIwWQeAGqZYWPjP8VLkSMONGKmKEcjE8SeWSYEXI8M8Ir3OTbvoTxnwqvaEy+22/HBDlFGyWCTYrCtky3Vij9uxQBiCd3VIt7LgJfNuldKnW1XqU/izRpkfmj22bWV57ap27mobQpXhCxubvVgdQYDIdCA45pzupA7mSOElCitm2Gt7Kf4GYVEAk2GyAiqWqMwlwaK20K9p/Fs3MkVo7/GpExRJwcv8oBXiqmNYgh3KTkv1U3Yh9RNxSlwLucpFn7bBQWzwjsnadwBVWa9ubsqZnTOhmSFrvlBSC6LWqkxaJuG7Ob4uob+YsYqMvFfdnYe78AgGTd/16mUh0WkbPCQ+e2Ps2iFPfaC9bc3zt1JA+3qBDGw3LAn8m87LFuuwBYyK/Jt6ya8Kkq5GOUKa/9J/GQRPUpcxzRVPvK6Tl0qXR/XUGb0HYwniSeX5VIbCCOZZW0DXzqvz9X5FcOSRyL9G T+Wn6Yb7 a/RGJqBMOiaWgYsLg0PWFlGuE1c44yqVIQkLa8SbW6XYp6mgFmNuF2LimH/GUHimjM1zke9VBx4B3F4UtOyEUYZPVqhV9id5M5YonVIIxdq4qUUDHjLnZm8gPb8JOgQDiK6fWtwkSzS1DTQpGr3ijEtL14bgtXNwsyfZ/SYeZhkYT933F/o3oDZeZ9TtEQIjdrZRh9JYyFkR2Un41ok6K64Ll7r703ctdpmvXkypv0abZLLW18kBaRREDq8XcYZiyK7/9VcabwrLMVZ3/5LE8OjwwOvB8+JoWiUomD8M0LXPqP0HyW5qBVB4zf35bY9w3oy/zhEaPo14d5xQxRzUyMZgjMvePUFpm+cDxlRcB2/+8wZE8PuEBwk9KUt0kzDbfRN6uJB9sa+r4zHZsl6dE8wwbsgch26h42BqDPpouMCmwfNlTBay4oHkmQvxoInJiyo7I8Pkl+mSAKBr4yFKijsLpLVlVNt8ZMtfYeGzF7wTHmRPonQxvvq8eEbGOKxAFL8j4kYDbsmttMGNTMMCGMNa6fDhW5G3E+KWwZImsY9E5R8xNaLU+w/OIPcq9QnXDHkxs4TDXE53Lw44zrNhMq0LlIvUaL82qOX2a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000673, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I wrote a selftest to verify the behavior of page_cache_next_miss() and indeed you are right about the special case. I'll continue to look into this to figure out why it isn't hitting in the page cache. Thanks Mike!