From: Ackerley Tng <ackerleytng@google.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: willy@infradead.org, sidhartha.kumar@oracle.com,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
muchun.song@linux.dev, jhubbard@nvidia.com,
vannapurve@google.com, erdemaktas@google.com
Subject: Re: [PATCH 2/2] fs: hugetlbfs: Fix logic to skip allocation on hit in page cache
Date: Mon, 08 May 2023 16:29:29 +0000 [thread overview]
Message-ID: <diqz5y92g51y.fsf@ackerleytng-ctop.c.googlers.com> (raw)
In-Reply-To: <20230504001409.GA104105@monkey> (message from Mike Kravetz on Wed, 3 May 2023 17:14:09 -0700)
I wrote a selftest to verify the behavior of page_cache_next_miss() and
indeed you are right about the special case.
I'll continue to look into this to figure out why it isn't hitting in
the page cache.
Thanks Mike!
next prev parent reply other threads:[~2023-05-08 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 23:56 [PATCH 0/2] Fix fallocate error in hugetlbfs when fallocating again Ackerley Tng
2023-05-02 23:56 ` [PATCH 1/2] mm: filemap: Add filemap_has_folio function Ackerley Tng
2023-05-02 23:56 ` [PATCH 2/2] fs: hugetlbfs: Fix logic to skip allocation on hit in page cache Ackerley Tng
2023-05-03 3:05 ` Mike Kravetz
2023-05-04 0:14 ` Mike Kravetz
2023-05-08 16:29 ` Ackerley Tng [this message]
2023-05-08 20:40 ` Ackerley Tng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=diqz5y92g51y.fsf@ackerleytng-ctop.c.googlers.com \
--to=ackerleytng@google.com \
--cc=akpm@linux-foundation.org \
--cc=erdemaktas@google.com \
--cc=jhubbard@nvidia.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=sidhartha.kumar@oracle.com \
--cc=vannapurve@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox