From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F464C0219D for ; Thu, 13 Feb 2025 09:47:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 924776B0083; Thu, 13 Feb 2025 04:47:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D4896B0085; Thu, 13 Feb 2025 04:47:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79BF76B0088; Thu, 13 Feb 2025 04:47:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5CBB36B0083 for ; Thu, 13 Feb 2025 04:47:38 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 13FE5160AD8 for ; Thu, 13 Feb 2025 09:47:38 +0000 (UTC) X-FDA: 83114444196.29.2901CE4 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf22.hostedemail.com (Postfix) with ESMTP id 6599DC0003 for ; Thu, 13 Feb 2025 09:47:36 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Dp7wnExe; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of 3t7-tZwsKCDIOQYSfZSmhbUUccUZS.QcaZWbil-aaYjOQY.cfU@flex--ackerleytng.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3t7-tZwsKCDIOQYSfZSmhbUUccUZS.QcaZWbil-aaYjOQY.cfU@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739440056; a=rsa-sha256; cv=none; b=4eePnE/LqCpCShoU67Jn6bMwHBbZEpeXWuGLJvG6MMEPbArxErO+z2SlaAMf7CeX6yydO0 TAhWOrnSaI8lhoDycjvP3ylc8xGFLwjfkzDDUd3IgxIXeOmmIC5LGCfnYRv7/5YRu6L+6z m/dnv0Uem/E/b2ZLzrckuyEgUWbhAfU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Dp7wnExe; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of 3t7-tZwsKCDIOQYSfZSmhbUUccUZS.QcaZWbil-aaYjOQY.cfU@flex--ackerleytng.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3t7-tZwsKCDIOQYSfZSmhbUUccUZS.QcaZWbil-aaYjOQY.cfU@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739440056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=PuoEoBk1WxA1QM7rSYL5IAeW1R6CE44HE0t4+Ea+Jjs=; b=5WOAlwnHalcZUxiwZmbFULksol5Fx/xgplw+/3nafVUofBWkD8rGGXfGxr5rfQHHdgmnYk CsApROwLxjK10L7ABGEh+VQCb3HKv757PGjnZ7m41J1MAUbP3w+PrE3LPOk7T1+siyanGx J/3htDKaDY/tQ/N2sqLRrIhrzEEs/dw= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2fa166cf656so1631628a91.2 for ; Thu, 13 Feb 2025 01:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739440055; x=1740044855; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=PuoEoBk1WxA1QM7rSYL5IAeW1R6CE44HE0t4+Ea+Jjs=; b=Dp7wnExe58M+iADo3/tltdb3qgJ8hTcnldOKv91GjibDM3Fx6Ju2iqOQv8NDqrNUlx /1fGAG+ALNAQ6eH8qsxB2o2U0Zg7FpAwHTZV2GERnp7sjP9HlkNC4guXjyVqUR2lR9Hc xng7RMCsl7CmA8emdsIK4XAi26VejzWNtV9sBXf921pPFCTmQ4zQqd1fdue1pciv44Z6 ZM90C8jrqlmBK5MV+lKnGqYYLu4VvLhHJO+9Qd6vr62i7YbBzRQbMIs17Vyqlp/mEPON I/upv+EeYEx0KmomOU7JcnClXey0An1FnZE8fnkwRibXhXOb4kbxowtZNUFLPBw98B74 wpsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739440055; x=1740044855; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PuoEoBk1WxA1QM7rSYL5IAeW1R6CE44HE0t4+Ea+Jjs=; b=fgnJtkcnEMgMI3fBrYgf4UrY+8CgVdBH+KpO2IZopangr9XT/7pkK6f9Lh1IuEjn/e 6LW5sff1GRT/i+qUgU5CAvbLMuNRmRfOho6JlZxLdrN84Lpc0gLZB4ftv+7PFFwW+UlE q8p+Yypha4x6J9LdPAlFHX3k8G7E9nV2LVCp2Juu+jobNlnJurCZIydv6gZRjuHTwBsc wqlaaB2w3+qQQggwZKZKkZMk4uHk1LtDeGRqiTKOspIk/Dz4eiRvNXpxcL/yRc/cPAem RbYp+q/NKhVs8URaVkE1m7sRatkPH5BqUYGawu3yiYIQaxuC554kxGJb49BY+P3J/WNe GgIQ== X-Forwarded-Encrypted: i=1; AJvYcCViP36VoS27JVKps1YdxYdIyKDBgJF0k+Ord2z5m0OxQ66hfUOO2z+Lu/gaCmwTdzL+igFIoBXlCw==@kvack.org X-Gm-Message-State: AOJu0YwDscKytGJqNOK2WYFioZjzbk19NErsUC8wfzGfp9IMJJhB/7vg 2Xp5FBncF6FI30WtdKWLYmO+3olHifzYCi/RAoKh02IOEGwjSUpHTgSphYjQ8tVjBqSFeokCcv7 XOLoav5XgQ/LHFIXwr+XWOQ== X-Google-Smtp-Source: AGHT+IFjo0o7W8BMmhgfzjT1fZjgSjJW+Epialp3pC2emFjR4ZguxthbuHETUF+drifrj4mBdX3+3nB91gHNlOu2NQ== X-Received: from pjbmp3.prod.google.com ([2002:a17:90b:1903:b0:2fa:a101:755]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3a89:b0:2f4:423a:8fb2 with SMTP id 98e67ed59e1d1-2fc0e98dd17mr3572208a91.20.1739440055202; Thu, 13 Feb 2025 01:47:35 -0800 (PST) Date: Thu, 13 Feb 2025 09:47:33 +0000 In-Reply-To: (message from Peter Xu on Sun, 1 Dec 2024 12:59:33 -0500) Mime-Version: 1.0 Message-ID: Subject: Re: [RFC PATCH 14/39] KVM: guest_memfd: hugetlb: initialization and cleanup From: Ackerley Tng To: Peter Xu Cc: tabba@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, jgg@nvidia.com, david@redhat.com, rientjes@google.com, fvdl@google.com, jthoughton@google.com, seanjc@google.com, pbonzini@redhat.com, zhiquan1.li@intel.com, fan.du@intel.com, jun.miao@intel.com, isaku.yamahata@intel.com, muchun.song@linux.dev, mike.kravetz@oracle.com, erdemaktas@google.com, vannapurve@google.com, qperret@google.com, jhubbard@nvidia.com, willy@infradead.org, shuah@kernel.org, brauner@kernel.org, bfoster@redhat.com, kent.overstreet@linux.dev, pvorel@suse.cz, rppt@kernel.org, richard.weiyang@gmail.com, anup@brainfault.org, haibo1.xu@intel.com, ajones@ventanamicro.com, vkuznets@redhat.com, maciej.wieczor-retman@intel.com, pgonda@google.com, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-fsdevel@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6599DC0003 X-Stat-Signature: 1oj3ua1bnurgq3n6wdpeed67zj91t4z1 X-Rspam-User: X-HE-Tag: 1739440056-353725 X-HE-Meta: U2FsdGVkX1+0ns9I0hIp5hTwInAwkTSdhb/De7QuTzzvS+4z/ZjdzQgSOTvlcBIqQSxkQyb0N/x5guhHH/PdpuUyi4kijMgzSq1SovG1mqr0Y0MGMNG+wn11K3lnopTZfQYP6L+HfG70J6V8SVwSyB+t4AR/RtRQJ6YFBIcaWrkTh5jYZyr8M8KDHC8eAdRrRrCMoazdgw3GqgPa2sZcQ8ipjTVq5kWLDn9ORTZbiRTyI6P+ZS0P6VJ8LxhbwWNeoTF5T0H0aXFP0NkmnoKkYSjdeZ1r0RZYuIHT2HfUdkWY8T9DTel3V9nacQ5BuQOJ5y/vp8VPnvtDTOdnBNiVpiWmhZVBlu+G2vP2w2c1+3zIHAJVtEX34WzhWUuDhzSD6L38BuZkJmUXjn1GMwGQGhGtsoezFm+Gmgr0tVHkqe45UccDuLd2r4KHglJhuLxb5MZDVBqCZboku1f4CVH/qDPDyar8vaAyyzLyyMiZcJBm1sqK2zKH5Mb9l3bwYjp1dnM8SexEbBJiQ/SjR0HccCB4JsAaevPaukE4oRO/6D9SA750Y/4qCqeh7duXFp16Va7gjm68xHN+844yOUSqLfhJWyTpzj9aq0rAHxzWQw9cJFG2HJiPvcE4XTyEO17S5eoiVK2P6jxtK94oYgNemd7U0nI9emkJwiQ2qorTkaSj/vZOCrz0NHjCEfhwYTdOjOLdbMUjPz+Q8bqMPlfF9cDpDCmZOPF+1tpmh2pBh5L1Fdl09dAmHoPgBMJZbFDYdcd6Kme9MzmXuzi+ue0FfEL/zBLdmNzSUqWX7i5p+2a9NMh31B5c3zgFlZj3VWtI146Uf3kHeOxw7vOX5z71awErxC2xHA2sOp/YcS1r+CqQ+74Ss5YzSIAHEuwOIZDzYDRHAzg8RuQOthS5SeXRhTJtSkDFryAt+aPyJuVVDu9HhMaSMIMTFgInN3A6n3Bo+P0OpLfxo4zDzjrh2BX K48hTUfA ClntFuSj5974jlJBXxiLNeI14+QZTT9cNZdUE1jR6jyWQzw5NSNzsEmTmyZg0NOzyd2LJDAOY6/2JbdtDjSJLN+w7d4FYNk9GmWEUJZ1NeD5YT7WnHfpPRDCanaOAhRKQAu1MDkL5Lhuq6YtIKh+CkSqvvgd/EQHR8uNR35UNerHyFDOv5OUxa3s7HQsTXfuGDxXTKHwvewNQt34e5/LKy7HVu2ie1GFuTnUJd0gjZyD0X83QWDSDlyQnF7SaRJsg5Ez333UTEB4Ia+kedHDuf30x+qxbGhq2nIW+6YilddK3576uQ2u/glKIjvPrf+YNwSqEUfjfoLnY4XlkfprTlbzB+9FKXseH8tt8U1VoUyBGErm3maWBDm7hdwfU4UmgaPIrXKmFW4Hi2lRwbWsQPXmEcev/2lhJeHfhv+be9RcaLf6GzGpay5c53ce8ob1VoFUUD05iX5NRxNs2fgtj9W1m3S2zcrLUmQJzVYdU6SIs+M2hwQFd+edQsRGdc/f1cg5q/Q3ZoNcLafW8cTp7qNp+uUKhAfHhbjRYCWX0L+UPnOh/h5uSHoVpMkWL8/snGjRiVe6bpzYh0wR6OfhsDZDDdbaR7lCciBs5KSCGkdDbBAL6gw0qhiUzrTSf6YJ/aX4P7aHvp7Fu3vbNMqhnbi29QczV6fyi9JBsqrBQ1ap/3E3QcgQV7WKQ2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.038110, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Peter Xu writes: > On Tue, Sep 10, 2024 at 11:43:45PM +0000, Ackerley Tng wrote: >> +/** >> + * Removes folios in range [@lstart, @lend) from page cache of inode, updates >> + * inode metadata and hugetlb reservations. >> + */ >> +static void kvm_gmem_hugetlb_truncate_folios_range(struct inode *inode, >> + loff_t lstart, loff_t lend) >> +{ >> + struct kvm_gmem_hugetlb *hgmem; >> + struct hstate *h; >> + int gbl_reserve; >> + int num_freed; >> + >> + hgmem = kvm_gmem_hgmem(inode); >> + h = hgmem->h; >> + >> + num_freed = kvm_gmem_hugetlb_filemap_remove_folios(inode->i_mapping, >> + h, lstart, lend); >> + >> + gbl_reserve = hugepage_subpool_put_pages(hgmem->spool, num_freed); >> + hugetlb_acct_memory(h, -gbl_reserve); > > I wonder whether this is needed, and whether hugetlb_acct_memory() needs to > be exported in the other patch. > > IIUC subpools manages the global reservation on its own when min_pages is > set (which should be gmem's case, where both max/min set to gmem size). > That's in hugepage_put_subpool() -> unlock_or_release_subpool(). > Thank you for pointing this out! You are right and I will remove hugetlb_acct_memory() from here. >> + >> + spin_lock(&inode->i_lock); >> + inode->i_blocks -= blocks_per_huge_page(h) * num_freed; >> + spin_unlock(&inode->i_lock); >> +}