From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C7ADC83F1B for ; Wed, 16 Jul 2025 23:06:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C0EC6B0099; Wed, 16 Jul 2025 19:06:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1987F6B009A; Wed, 16 Jul 2025 19:06:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AE8C6B009B; Wed, 16 Jul 2025 19:06:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EBD936B0099 for ; Wed, 16 Jul 2025 19:06:18 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 61222C0571 for ; Wed, 16 Jul 2025 23:06:18 +0000 (UTC) X-FDA: 83671663236.28.5106575 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) by imf18.hostedemail.com (Postfix) with ESMTP id 8F0061C0011 for ; Wed, 16 Jul 2025 23:06:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Z9VOegpo; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of 3ZzB4aAsKCPIUWeYlfYsnhaaiiafY.Wigfchor-ggepUWe.ila@flex--ackerleytng.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3ZzB4aAsKCPIUWeYlfYsnhaaiiafY.Wigfchor-ggepUWe.ila@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752707176; a=rsa-sha256; cv=none; b=0LtLv/EeVGX6ywx40aZJdGmcUHNzENaNudtNH+tD9DVTaPUuxhbIZKHPT4/aNJrDwxDpPe XfhCUuCoUxfBchhY0MPbp8NkK3+1SNgN3xCrg0VxwDgAORXN7Iczgy7EAAmv8miotDhrE4 aC1Chvcb0ZJiXiaVaLdS/7v9qb0Ia3E= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Z9VOegpo; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of 3ZzB4aAsKCPIUWeYlfYsnhaaiiafY.Wigfchor-ggepUWe.ila@flex--ackerleytng.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3ZzB4aAsKCPIUWeYlfYsnhaaiiafY.Wigfchor-ggepUWe.ila@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752707176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=adcqncZXuKWrstQvgpFavoHNK5nsVYpbKX4vNDqmYr8=; b=Ts+1HkAYCEsrCD9xW2m1cTLpInaZtSWY5EJRqIolfh2tM7iFaXOx8vXlJ+Wiqwj2vBSld0 k6fCgMcvaKhWyfl8Ma7Iv7kEugh7kTHotYQnmXW73kUXcEduI2nq51hxG0kwpvaORe3LOM KnhvDHbZgG3NLbh5XgKWKUuktRWCf9A= Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-748fd21468cso333003b3a.1 for ; Wed, 16 Jul 2025 16:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752707175; x=1753311975; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=adcqncZXuKWrstQvgpFavoHNK5nsVYpbKX4vNDqmYr8=; b=Z9VOegpos1P2OkcaG6veztVhNvhIxs3JzNE34q7FnTiX0Cpl8rGEGPxLJtp7b0Gy09 UDc1PT3oenzeQ4Ry5GF11fer/Wf9Y696sMD2m3wztM9A70p4s9rvagtwnCkbtFQPkKV+ 4NyC8n1rEHD2iiu6N20RBMY3jE9OcCfc6F8+slpl/nQlS7aSVE8uaZ/r2HoYSTfltRX1 /rhe/D9FNVTZGDIi8tLeA70Q6SUFQarN8f2NxMbxn+Lcj1kApvPMvxWPqfUvRlU4okUe VlCeYyhdjZqodNgfmE8ZK6CXmkqaUT6RqtRL07QulWkqOxzNpB5/r6my3B6XLQV55JyC tb1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752707175; x=1753311975; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=adcqncZXuKWrstQvgpFavoHNK5nsVYpbKX4vNDqmYr8=; b=D04Cb1qqiRn0JGr6kOqtybXlDtPYViCs2R5qbwm7hCC39HSr1HG62FscZ+XSxNSIjn 1QSeLlprFRYpOA275L+fPmyp/af55Rm5vqDPZEgDLskvtDka+oFnr6iQ74p2SWAPDokL VwoMskaOY1O2um3eoxEysk3MJE9wqj97P+JcdKsQnOh0j5CI1S3PqTlp0PWUny9LsTJJ fOW8vcRdNfjSfN/VoSEcgYERFylMfPiHPZbu6VihWwpztKqEdHW1vlvM/bMXNIuvgLQS QLmg+F15Axe+r7hqX5s3qanD9uuZA8yDt+FcIGMmfBGURW7B9qmMP7nxuvAt8pmiqyyF VEYw== X-Forwarded-Encrypted: i=1; AJvYcCXshrWa6LfNf3VUng6WIHYFautlwbKIxmOxuGGzp3iQnvHtc3uyiHT9WF2GuMtT+Dow2M+sS8bFMw==@kvack.org X-Gm-Message-State: AOJu0Yw6KahW9DjiIgGQnclRTTLhAycutimKwdVCyZzK+HrQjqBZx00m DGFtSQY5wiv0VhhXln4SRTfLCo+skpBEpWLk6YI5y7uLaGNIAP9iIF29wScLGvyyeJ4bcG6tibh MOXvBUcXlaieWN/PDfSueVHMbLg== X-Google-Smtp-Source: AGHT+IEkMWa2Fbym2vWCv7D3Erwky7+KyVGpa/foKNybzbL0WNkaHxozAp9QYAhPJYnoNy6cgJaknHtaJQ+s/tVRNw== X-Received: from pfxa17.prod.google.com ([2002:a05:6a00:1d11:b0:756:c6cf:2462]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:92a7:b0:74d:f997:1b45 with SMTP id d2e1a72fcca58-756e81a0b16mr8759465b3a.8.1752707175027; Wed, 16 Jul 2025 16:06:15 -0700 (PDT) Date: Wed, 16 Jul 2025 16:06:13 -0700 In-Reply-To: Mime-Version: 1.0 References: <006899ccedf93f45082390460620753090c01914.camel@intel.com> Message-ID: Subject: Re: [RFC PATCH v2 00/51] 1G page support for guest_memfd From: Ackerley Tng To: Fuad Tabba , Sean Christopherson Cc: Vishal Annapurve , Rick P Edgecombe , "pvorel@suse.cz" , "kvm@vger.kernel.org" , "catalin.marinas@arm.com" , Jun Miao , Kirill Shutemov , "pdurrant@amazon.co.uk" , "vbabka@suse.cz" , "peterx@redhat.com" , "x86@kernel.org" , "amoorthy@google.com" , "jack@suse.cz" , "quic_svaddagi@quicinc.com" , "keirf@google.com" , "palmer@dabbelt.com" , "vkuznets@redhat.com" , "mail@maciej.szmigiero.name" , "anthony.yznaga@oracle.com" , Wei W Wang , "Wieczor-Retman, Maciej" , Yan Y Zhao , "ajones@ventanamicro.com" , "willy@infradead.org" , "rppt@kernel.org" , "quic_mnalajal@quicinc.com" , "aik@amd.com" , "usama.arif@bytedance.com" , Dave Hansen , "fvdl@google.com" , "paul.walmsley@sifive.com" , "bfoster@redhat.com" , "nsaenz@amazon.es" , "anup@brainfault.org" , "quic_eberman@quicinc.com" , "linux-kernel@vger.kernel.org" , "thomas.lendacky@amd.com" , "mic@digikod.net" , "oliver.upton@linux.dev" , "akpm@linux-foundation.org" , "quic_cvanscha@quicinc.com" , "steven.price@arm.com" , "binbin.wu@linux.intel.com" , "hughd@google.com" , Zhiquan1 Li , "rientjes@google.com" , "mpe@ellerman.id.au" , Erdem Aktas , "david@redhat.com" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , Haibo1 Xu , Fan Du , "maz@kernel.org" , "muchun.song@linux.dev" , Isaku Yamahata , "jthoughton@google.com" , "steven.sistare@oracle.com" , "quic_pheragu@quicinc.com" , "jarkko@kernel.org" , "chenhuacai@kernel.org" , Kai Huang , "shuah@kernel.org" , "dwmw@amazon.co.uk" , Chao P Peng , "pankaj.gupta@amd.com" , Alexander Graf , "nikunj@amd.com" , "viro@zeniv.linux.org.uk" , "pbonzini@redhat.com" , "yuzenghui@huawei.com" , "jroedel@suse.de" , "suzuki.poulose@arm.com" , "jgowans@amazon.com" , Yilun Xu , "liam.merwick@oracle.com" , "michael.roth@amd.com" , "quic_tsoni@quicinc.com" , Xiaoyao Li , "aou@eecs.berkeley.edu" , Ira Weiny , "richard.weiyang@gmail.com" , "kent.overstreet@linux.dev" , "qperret@google.com" , "dmatlack@google.com" , "james.morse@arm.com" , "brauner@kernel.org" , "linux-fsdevel@vger.kernel.org" , "pgonda@google.com" , "quic_pderrin@quicinc.com" , "hch@infradead.org" , "linux-mm@kvack.org" , "will@kernel.org" , "roypat@amazon.co.uk" Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8F0061C0011 X-Stat-Signature: jkm5ptkici13uq5fme33jnroathqceee X-HE-Tag: 1752707176-12891 X-HE-Meta: U2FsdGVkX1/72e7ZdSSm7w3/Oz2vFL8V9HiJ6Ym9uGLNOdpCjQv/08b9vWZNg4yCs5Im9UGKAhmscHtIV9qOAkgOX07letyYcLYRMjXzMxboWxRHeV5tBLGAHoGoE8xovuFoL6ebqlAmemEoKDhT/BVGfrtbgEQQQljKFog+Iyvo13m4lDM23VmzToqMDpBtCD1DURmSQeJzwZElC5mx1zctDFE954r5qYt7D4D6I/eRP9Ro17TUlcCVvIHRHMt/n7bGoSmmk+sknwL4qI2QLI2vdyyeMoo+m/q7tAOa3v4sufXvItl79IdAcmcU0y72kiogrVtsZuSmX21rMk1PADoUt+5MGF1vgYx0lk0nT9paELUVPA1u5hKAm2FznKPmckWAqZKbe0HqJmtszCmKpt1fRR/v0xjX3JWINrtN4k7+QzCNEILWku9R+kFmuKXAooY4rQY+GBCf8BrxzrBeWQP6W31zod6MVa+9KSgIvDdDathF3SDiLjj8iIenu9Y2BZVkig7pYcvU9yW+r12r3pze4qmvZyRGe37toDe27kCf3rbNG5qW12pKEAvRV154Vv+StNJRGs4Qbs41R76PSFIVuI+JeMJq/s/Sm031hp4cqPNvQt/U2gui1K4efpyreIEOXiRlcnWJhUElCVZHtQ9kMeAmbHEYIc0rpwJdTSGxSMaF3NIgoOTdwXWi7N1WMaA3GBFHxp9sZNw+ctOFlej9wYwxsxtbZT80BK4JNtg5Cs7as9mSEybY1YD1kEbLrnOE4GBi4iAwF17R/NYQeYpHrZecUME+2q9pEHpIHzr0X4nwnFQp27C4i7Vlq5Iqib6NnwX5lVRBOei9ujAXQ2yjVTMFAm3mfJxpULH5Uw9o7XtgQ5I59nRy9l8rk2lvn/DKUpWspxzO1cH9VfLHPHJYKQh7oPWZ1ERVBJzXz6biSblAzfaOrLQD9io9oGVOWo31Ovoy6GzPVDfPpW2 bQUqXd5M ZIkudPa8ayTkzVKWDdtq5StPPcBCWaSDHTfuLcP7R/Bf40UUyQId42SlissaQJ0SIrtrv6QG+ijDIqisfONpOpDIlR1q5t4mMWxsWZa0O1YPM+fI5Pe+3WCXBMJg/IKA3YNN40pjVue8uKG9u1agxsXPD5vikttP3CbCqSK4ILA0Phr/eAWpV6ZxCKxU6EXGa778JzPZb5bHqyvFI7kHfUSMYxI/FIdzgBVR0gor9X+Tp0ZfLwQkNVhVdZRzbq/ceeujczfLvpUYPacRSrvLqn9moTsFUK6p9z0//N4GI1mQEr/SLOr798ydgz9Ao/kpEFcM/PubJHoWkGPXQRQnhfnKNnSk43RLfrriIA4ng87KMaA/KgIKJyR0FKc5EGgTiOHawOSzPNFCwDRGpJHRRckdWzlGLK29yRERzNzAlpTNuZ5SWqgwsp54gwJWqvcfkiPkKNu5KCyzEt1WSKEOPy97ClKUVDM4kkcwMBViRi3EFlXyLperjk9Z6S3JtsOQtfKt8X1WXxNwdNDb0u85BmYY0meFEZ9uaVDKLhOfZDRpzuvCdgcAIsPTm5vUAyd6mIbmj6WUqTIHPDqffzB8SYuOh5eLBLpLKnhEpCi1r7PaMBSxHEzejX6Uv4KDCGkvdPjvNwA7u3pkBO52H0kK0pv8q7RfIHJ31Kx+VqN7Qza7zJ0DIpPZUkqQUl74/vfAvly6iJaBSr8GM0FypHrt2onAlfRUCRyu79ia3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Fuad Tabba writes: > On Tue, 8 Jul 2025 at 18:25, Sean Christopherson wrote: >> >> On Tue, Jul 08, 2025, Fuad Tabba wrote: >> > > > I don't think we need a flag to preserve memory as I mentioned in [2]. IIUC, >> > > > 1) Conversions are always content-preserving for pKVM. >> > > >> > > No? Perserving contents on private => shared is a security vulnerability waiting >> > > to happen. >> > >> > Actually it is one of the requirements for pKVM as well as its current >> > behavior. We would like to preserve contents both ways, private <=> >> > shared, since it is required by some of the potential use cases (e.g., >> > guest handling video encoding/decoding). >> > >> > To make it clear, I'm talking about explicit sharing from the guest, >> > not relinquishing memory back to the host. In the case of >> > relinquishing (and guest teardown), relinquished memory is poisoned >> > (zeroed) in pKVM. >> >> I forget, what's the "explicit sharing" flow look like? E.g. how/when does pKVM >> know it's ok to convert memory from private to shared? I think we'd still want >> to make data preservation optional, e.g. to avoid potential leakage with setups >> where memory is private by default, but a flag in KVM's uAPI might not be a good >> fit since whether or not to preserve data is more of a guest decision (or at least >> needs to be ok'd by the guest). > > In pKVM all sharing and unsharing is triggered by the guest via > hypercalls. The host cannot unshare. In pKVM's case, would the conversion ioctl be disabled completely, or would the ioctl be allowed, but conversion always checks with pKVM to see if the guest had previously requested a unshare? > That said, making data > preservation optional works for pKVM and is a good idea, for the > reasons that you've mentioned. > > Cheers, > /fuad