From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62937D3A678 for ; Tue, 29 Oct 2024 17:49:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECA826B0099; Tue, 29 Oct 2024 13:49:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E79666B009A; Tue, 29 Oct 2024 13:49:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCC806B009B; Tue, 29 Oct 2024 13:49:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AC5A16B0099 for ; Tue, 29 Oct 2024 13:49:39 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5CDBA8033B for ; Tue, 29 Oct 2024 17:49:39 +0000 (UTC) X-FDA: 82727376774.16.FA64668 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf24.hostedemail.com (Postfix) with ESMTP id 7C20C180013 for ; Tue, 29 Oct 2024 17:49:32 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=IMQKnDOd; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="C0g/mxhk"; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf24.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1730224058; a=rsa-sha256; cv=pass; b=FfwhpDvSOAeVZtiAUyjlviG52wp9jW9Zgb0Ot0xhlt1mwltL879tcI97ka6sZQewmykg8p fjRZiqsQ6O0llbUz4GPzMgCF9Tlos/fJnXgCciRqEGJKlSd3Y6pV4lKXZN0J13QyveUoeQ Cw87VJZTT20x3xKto8cr55cCDgiKUfA= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=IMQKnDOd; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="C0g/mxhk"; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf24.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730224058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8oz2yB4SvBcMH/KN6R0JyE2aiYLosnmWrHTVMLpD6u8=; b=wrY0zNXAN1AFmZe9PcP2nv/ScZvvDwgtnvtMDxrtVRMLUWQMQWWBmXsIveTWe+KCDnZf/j YP9KzQLyZOWQPvePCwWdQSghtYEhnTTHZY4SzGJ9fsu0eLOaenzGgdwCcygQupynPVPLLO u7dAOM9+UJ5vN2rm2y42CoSmOirZMHc= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49TGfVUi030913; Tue, 29 Oct 2024 17:49:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=8oz2yB4SvBcMH/KN6R 0JyE2aiYLosnmWrHTVMLpD6u8=; b=IMQKnDOd9LDFJl+YPuSU6UANkJViQRwedj QFTtUeI6MgUVQJUcgmsZyQfE+UI+Na2oA9t0MEJWa394JeYuKuaYYwH6rVDrJGOJ cn3h6zNvWfgly92TDV5u/4tGtpY9/VKBzy1z/wYg0cxIhzld685o6yJ3BW40d43G hnhGhw8MZD5yA3M9jX8So49oxZcdPLQVXemUPtgpJNBmvbBJxtKOsSHLI9FGV7EN +o66ZYejCoNsDdaFyN7vW1tVZHSHEWlXkEaWE1+iWU2Wt2iJroegzU1b6Tc/zrYh 7aXF3I5+at/JTTfU+5KaJEFAfOKKsHFcKF+dEpttZsFosbi3IXdQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42grdp662f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Oct 2024 17:49:34 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49TGnnZh040315; Tue, 29 Oct 2024 17:49:33 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2044.outbound.protection.outlook.com [104.47.58.44]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42hnapg8ta-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Oct 2024 17:49:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cJPPFhxxynkHzD0ntXdQNaa8fPN3w7QUlbKk/XAYBnmmRC7yt2P/YUo8d1cI8/nSApHoZVDmuW4+tMmSDLiOTRlY+hkkcL/O1XLP59twHJgr2YI3YG1tSfT8h4sVBBARXr9d1tSu0mYdefncLs3wBz/5sQzdTG4ouAbLoQSpOxuQZ8EUQnAFZ1de3nDn59IHJf2+6x5KsWIavS/cR7sM5XUDOo+igD3KvPmHPLotntwqr0nkAawt8KLd7LtdCSbNd5k44L56lQL5M8vQVzuSUbD8bIXRGBefGme0CLyElCo28sT3/75RdSJ97aMEq9gAxRvuXSt2+r3CVvcUBc+clA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8oz2yB4SvBcMH/KN6R0JyE2aiYLosnmWrHTVMLpD6u8=; b=xPY/JKfsUm3fgt06ZJ+C65AxAoVWLUVS2KAqkvxH3Wot/vLbNPSMu2ndpsYMox+xWGxfFghwq12NjPmlnLvecSf5yvYypv4WjiTU2edLMmGEJGwjV03XNu4pL400CTrnm7kvsXoHIxB+ZQ9ExKkbBAKdOHqIbkVAKOMlXm4TH/PY9q5VjUQbi2Eke+6lFTv7jGc+BFmPl9iem83NfV8J8jRKNWH4yvIx0mwiPGU4kw6CxKFKhJx8Bk5ua8fuHQQRus6smcpkG609Fl0NTMv9zY94XwORGOtzJRJKvoSrBblGiUZXbVoB4U4/avLihlxWY5FTwDbwZSRvwj62YFo8AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8oz2yB4SvBcMH/KN6R0JyE2aiYLosnmWrHTVMLpD6u8=; b=C0g/mxhkwDg3czSGmAKY+VD0XWmnRTg4wGMhQw9q8FGfMKdDR+XGJ8Z//N6MWpSclqHtN/s58KcGq2VCEbxSXWygeXClDJp9nSogoswRb4c6nfonIpcjSuoVpLmG93C1+Ngwu1mvJ4FQ7ab/Zy5qTIKHV+r6kYmgdxx1+Xg8P/8= Received: from LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) by PH7PR10MB6153.namprd10.prod.outlook.com (2603:10b6:510:1f7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.25; Tue, 29 Oct 2024 17:49:30 +0000 Received: from LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d]) by LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d%4]) with mapi id 15.20.8114.015; Tue, 29 Oct 2024 17:49:30 +0000 Date: Tue, 29 Oct 2024 13:49:28 -0400 From: "Liam R. Howlett" To: Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH 3/4] maple_tree: use the correct min to calculate split Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes References: <20241020024628.22469-1-richard.weiyang@gmail.com> <20241020024628.22469-4-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YTBP288CA0005.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:14::18) To LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR10MB7943:EE_|PH7PR10MB6153:EE_ X-MS-Office365-Filtering-Correlation-Id: e5762b6f-3eae-43be-58b0-08dcf8420a23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KCoQduSSr4VHrtVpvhoH4IUPORhyL1uhPpnpY4eV6LeP6q/YtSy/bshNNivr?= =?us-ascii?Q?kxpIi6w+9ZlrvUpEa6iHtoypF1aqQGnCroAK+HldsfMXtJfm0dNA/OdVVtbh?= =?us-ascii?Q?QhTW8bzpgfpg8Fbn2X8An3rZ4PdcxWinexJ+JPwoeNgFbwoUFbaQMIrbHZsi?= =?us-ascii?Q?PbV+KxI4dHPbipjyhfYmWqNr2XHifZM4y9g99D/XBA8xIA8qqizcif3xnd85?= =?us-ascii?Q?FV8d7n8MS4iFx1eOs3ObBrcbEjBD8kiHlSQsrPGh4F+ohc1nQ5I0ew/eniQS?= =?us-ascii?Q?hTW3RSTnoNWOi/icOo8i4hU6cVw+btyKY+ucakMqR0RpvPFlA8B//L2qR4+x?= =?us-ascii?Q?OWU/KTp6GTpJPR0TgxZCHLP9B+XC9UyVIAFep/TdlS+nY8c9mX1VwXFE+ypA?= =?us-ascii?Q?R1BuYefs428WAG+3lRoERK4G5KKYkFS1Ec/dP3pC12POitXq7hGYCWKcsgL8?= =?us-ascii?Q?C2lSwihvmQXORKAHHZL+8HV4Kd+7htw4mDUF8/t1u6XEAgJELfWwP2RWUCtl?= =?us-ascii?Q?eDNTxtHkCv/yj30mSuMYOQL3x20KyyZIW1rezwQrVd1MQdBshwskG5hU0CcV?= =?us-ascii?Q?8Vj7OYSbfkPriuLgJ0wZlO06rRL5am2PzRliBXoZP1BPiv9P7ON17kqlnXDh?= =?us-ascii?Q?J0rHsH6880lHggf38obHkEir1xVjHNYKgAhGG5+cl0s4mf8qQLMMUWbjC5Ea?= =?us-ascii?Q?n4aLQkMSjCpznAr6AA+99/VrUxLSspYPvq1TmomWO0ZwMo69Ad8GWppPmmvW?= =?us-ascii?Q?uYz7sW0zmq295yEWGrDo/2Gte1Ae4bdcEorXyqABhwGgH2c38llRA2yXjjKC?= =?us-ascii?Q?496nOpj1Uk9VCZiqjLBfxKsnt5ppJ9bGWxNhHGomrdthMADzu5+ICVxDlQUd?= =?us-ascii?Q?elwdl+UVEnTCibrtwvuDjP96cn9v52YBLMJ6IB0aWhEoUCOozqZC94sIGq+n?= =?us-ascii?Q?p/Z4dVbM9GUgtJHtZyTjC+GSVxkkErUcPAIlLDEYUc623jjuVL9J6djyA9dG?= =?us-ascii?Q?MsXErSt969pS+KFiNM11OHq0cIscVKPJZt7eKGsx6v+SFtCfEaVxbpzW8NUq?= =?us-ascii?Q?TuEnuuGkLFel5789waE2RUMlE8hutaWHnN7tBCsvUPK6AXuzNRGSx9H03XGu?= =?us-ascii?Q?oycIXBnD4Q6eUfrRP9itDEK/UlZtOsf/fipa3yLucwYWZq30gew8IF9U3FuI?= =?us-ascii?Q?85UrLvBAFPcd2cpVythJksdEamaQyBTZ+oP6nBqATbF2dfEaB0zKz25oX6S0?= =?us-ascii?Q?i/pfMJN6vF3Vbx29gTafzGBeiaUCUSHJBoORurrXzf63guuYYFSbPkBRh11p?= =?us-ascii?Q?mLNHWtvDgYxDZAu0bIm4ErDJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR10MB7943.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VGeUX+J53Cx9BtyKaiugJVzjVGp9rFoyLKLDwCz7+dZfEJuHXzEZRePBsaB1?= =?us-ascii?Q?u83P3njEnU2xLKJc7QxTy+WOLlJ052F9oV+Ithe6w72TgOnwNC9m5IP19FDv?= =?us-ascii?Q?PBaJYYAo1EHE3wAbNcy9iJfgU4uiGBMQpJ8ItONOhoQIjXUu5bjiYdyXUnWm?= =?us-ascii?Q?Ycj7nzHh6qrW2Ta53UzrRVGW4zZRnYsW82Ooe2b4EWLFIaNruCL7JlId/xmk?= =?us-ascii?Q?TnExrv4a/ZMxRRgWdQ58juCHGZBNhqRz8s8H5ar1/rxQXTfq88Pkziz+3F+w?= =?us-ascii?Q?wp0yLvE8ilzYVx+2+GfJ9rPyTKD0wpFAfwujUCTeQRlAI/Efrye4xoGhaZl5?= =?us-ascii?Q?3fKGFuvZ5iEtDkA1bQIdw+2tyNJA+vZ8gq4bcwc4TywG22IEEvskBZhVVkjZ?= =?us-ascii?Q?duXxF1ouWWpLnPZvivOW1iyf1c5rjf2907Zx4IhToPEKvstU/hNhMZiEJgj0?= =?us-ascii?Q?gJwadsf+9ZEaly3yHz4y5osD7c4Tu1mcbgCzZV14DpfhANvaPEFG6Btwpysb?= =?us-ascii?Q?3nch5LSj3f6tr1uwAnLdnQ971037mEl5lFBum1dXkV0uMbtUbxwmrWN0P25F?= =?us-ascii?Q?+SX6arQrvWOrQDd1TC48rztuYxJD8TDskXb6fNNony/gWX/WbsSmCEtRQV0k?= =?us-ascii?Q?Ugji3UxUb6Oo14Y2ZJamOvx/mvsQPwCkLyZJzXiFNXBav3EyxZH7+O+tIyms?= =?us-ascii?Q?avyxtZMvY1YH3L3f5UtR5tx5HUXHMyO7bzhmXDnmen223X8xgGnpfVBPhXxe?= =?us-ascii?Q?ktMT3FfXr0jGwrfavvCaVnSX9396AWOgH8YpGX7eeA9Ofekr3EHFO5d9Q13c?= =?us-ascii?Q?17WLl0PIEBbT2SP7HKpi9dUkkHq38CnOttUr/naLJJqU7lj3jTH1p5n7la1k?= =?us-ascii?Q?Yes7Mnia4kzjDkjcLZTr43ZLsuuwSz7r8tajNC9lnJNR/Uzl3dHqjkAgCxTt?= =?us-ascii?Q?R1+YqGpbAbPDhG/HKU6545pN24L5cz/PGF4ta+gJtBWXvKPXdiF+YlVPpnCO?= =?us-ascii?Q?qwa5hexLRHeVxmm3+N6bVNdvbOC8WOodoq1U+96/JJ4ByxvN1DRjtL1PMg2B?= =?us-ascii?Q?Mt0Ztyt08nUKaypOKJpqAWKKYs3mW5bMdDBEiaWiNKWilUwwp71d2TFKqZW2?= =?us-ascii?Q?zNxeBXLimCT3FejgJVZ0ue7L5cUOqP/aiHrxYDhiw3ulhZv8klDbqwlmwOAk?= =?us-ascii?Q?cBP+uJqpzccoS6g9C7Vm9X/4XVX63QSnSdqhstFb8KjUdWPHkKHYHi+qWgQs?= =?us-ascii?Q?ul7hkntAS58g1PWzaJhn5zyzKOBOpiadgnW7m33qvpLXdNyQtC11JCbqkjjs?= =?us-ascii?Q?Jg8xFA6UWiW+LeAWPGZ9See66mwQWBDi2I4ASGJcXm8+XzLhnUScSkcm1/Ct?= =?us-ascii?Q?TBrvpUXrxiVVDkI7cpMFkY4XL0N2biw4RQqjRUWUwsXfYBSypDqY22RQeheW?= =?us-ascii?Q?ZXfybfqhZq8B93f/OKw7ZReAUk5+dvkRfK44D/rszuiH31+zUkRBSZgga90y?= =?us-ascii?Q?/K8zJFiz0VK7tcM3Gg81k0lNDi/9iGiJzLffHQNZynJuLox3cOSWZ/6OYXRx?= =?us-ascii?Q?dkTY0Qp0QV2FX5QcF2FZJlJREDAY6MKAtoxDxe1ZIgq2Nc4McDABBlce0mhB?= =?us-ascii?Q?/Q=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: brUw5k/PqIBCQx7GF/kg/o7DUXJOAxFUXsrUFbvsVXoDIHjzLlPgwKZwFht1fLieqZoMvAzAnDUGXr2XamBBZQlbIk2RDqVHbJkhW5gpMiIO5QbDyqPtBv1vFhq2Hup+aRZe5rv+R7KvDWssjIFuLd34pwdu8A9ZjP494ck1lAuOtYwZdENqdCBuN81GnH++FT1mIV4fspRuIVd2QdaLTk09nP7CGPv6TItCA+3pCn4ad4SYDFRYNnB4rLmw7OyxIBDCN99jP6+2AcR/ioaauUPA3M8Z1EdxpzRiTO+0v0B8O9MkSRj1QPjEav+WdgJYD24CQWXcB195WVnn6hvOXbj0IlMRRwY5+lAZta+RT51SHiX8ivZykKhaAEPgCFgci/ecrw7YtS/x0Pq15C/QRv0QQeFdxUXDhX2dtTiK7F3pwyygjue1FzBsNpjdWgXKOReQttlnfeVUQ8aqTRWsHgEV5UWAzC0hQ0DsB4QAFnB4c840qbn9rjB/FvemcmyNed5iTznT2bmyPoJDCvqF+j9VenEmncHGl+uZKkvrbnl1gWZ/zps/APlJGg/kyd0Y3EnW1V5dQ8MTM0a6YqNcOIXTbqnfL34Rd9CHUcX3nWk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5762b6f-3eae-43be-58b0-08dcf8420a23 X-MS-Exchange-CrossTenant-AuthSource: LV8PR10MB7943.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2024 17:49:30.3658 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FQ4ZHfeQfRe48TyFcZ9INBdsUfWjBjgrvgE+ntBBFJgUa1uI9TqYM10SABhi1wtHmIIikcIk+TtJbDXikIo37w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6153 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-29_13,2024-10-29_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410290134 X-Proofpoint-ORIG-GUID: ItJ4TajERurFsW0mhWjAFkbQj41E_DKq X-Proofpoint-GUID: ItJ4TajERurFsW0mhWjAFkbQj41E_DKq X-Rspamd-Queue-Id: 7C20C180013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: nuxx514pp68xj7wb5rufyq9dsfa3ew6n X-HE-Tag: 1730224172-716716 X-HE-Meta: U2FsdGVkX19YGwzL4qZaGF+dNE75Ddl0esWejI5Suk3KQ+1jye/m+9LB9aVzMzJI7ccUJ28Vmh0ZuaJcF75JBfk2KNOG1ptSVcaRuFeL/JOqzFvZv0XBGBY9xWmAieRBca/ioI4AMgJ7RSltRUQuYyEkwAZ0gLHj6L8KsFU/jJV7aPezZ/C/saTuCQaxY4sTCsVL+3hDQXIOnCEGBGzO5uCovlF+p+cJSCjC5+8YCUHlpRVdmr3U0MzSvTkGMW7AHJhowj3UIgqUSIx6pPoo2Oe8mngX9SR45nxmK6m0eXTbPpHRfcwJp6OT5ichTDdgiKDFWfF7MnnovCQAGgQpkDJX+AmCYya9ERYfWRK+RJzYbuYJIssq+rFncSuZzku0ym2RW8yvcimaCdEkJq09UJcYK7IRRv1CI6os9yPrYFenqY5pO0P2ZWDSAkcWUiXxSJeCVkPgndQKo5gohDCFcQc5a8dLnZyzodrRb9K/S3wwlN9n020eAsxOxFTX1uUiAqMQUo/rz1Of8fUPfyGO7pyk0plSOpg1Ym04BsLuw+PsZVKq1ck63DbV6xS868/3/w03TY+9M/xmiTsFkU+s1enLDxNpwdtLThaif/eiHHkGIKzUwzXOoVNbSLZe46WGXzYngI7y3UCWJfjCrFnabd4Yp3jj6PrrfXJmlt0I/OVwNQB+sY9zaNrenmu/JAGssBLFtK3W0ZPuXbkCQVvNg0xEHaPJUstSQOKmNTOIsZAcsBqDxgii6ArACRcXGh03BvecpOLqWq2m8zdan/lDl3ayYPaG71WMb6k/fvwzyVwOOkBV5K5SajeMMQnZ59kfpEeS+Nb7VwN5xt2yLSiQooigTLRoB6IYP1Nwo70/25dCRMz0pYzcxtYNIvvUpA22di7PRBhoP/OavKE4x6PJewbBT5Q3MsAe6RcGPa5pEjZGTbqnY0Cne57aYnEnoXrGaEhGY8cYtGuvRpByLUF 4yJZYfWX /cuDIUZRECKuxyy2lx1P21LfF4R8MDxnSYpH7xl+Wyu7ya3CyhUFVfhsoKDsnbSB1/ViG2ZTmyZmzzIb0Xr+pct5Wj6iDMhL8Hw9ofsqz7eFrNmXEGyvDH/tb5Sio5RUzM5C335C4tMptLwZ2S3ScS6jhM1URQL58EumCEeXwaFsqjk9gwTpa7B3bdPhPcPoRiCKE6dbEEY5fNYK8aQjCVShY6cBKB7638uRZNPfkamOINBf184huAHrN4AaBQKWHqVm3mCYYPnYSrSXEkB351gkP32GYxWKD0zt4YEGzuILvvurgVRUm2fhCmXP1iDzAgMALJ4YY2CsKwD1yC47U16/7/hPXpvKhtJDTVtYmQyMwK/vOgQYeiYvqzDVTKiUkXFPJObi3AgEpaHbzlQ+TmhelZvH1AvhAzsiafXclxIUPPmxDJLMlWiXoDb4q530hHSEiqTeMT5FYexqNfJ6vdERMzhTxHVfC8ssXdPDbsWOweAtHysWqOR8/fzkKcKfkPJv3Ety+qjQaf6efTzNt1vYeeOoOJvJaHvrJXdGJONGC37d7mlUe0qtLLP1SnMlltuNvJXKZvL9Jeeojr1h3YIu/ydtuPU+Egnk7WEI2H3QYFbcTU27tF+FP2/XKVXgoovxhKr8D/yNmB+ODGWApNBuZW19K8HRboYLw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Liam R. Howlett [241020 18:00]: > * Wei Yang [241019 22:46]: > > The check in mab_calc_split() is to make sure the gap between > > [0, split] won't be too small. But we don't pass the correct min. > > > > First we may encounter a pivot[split] smaller than min. For example: > > > > mt_init_flags(mt, 0); > > for (count = 0; count <= 240; count++) { > > mas_set(&mas, count); > > mas_store(&mas, xa_mk_value(count)); > > } > > > > On splitting root for storing 240, the pivot[split] is smaller than min. > > This result a huge (pivot[split] - min). > > This is fine. > > There is an open work item to make it more accurate at higher levels, > but it's not a problem as it is. > > Each level upwards needs a better 'minimum span', meaning that the node > should have at least mas.min - mas.min + level * something. > > It works today for leaves, somewhat. > > > > > Second prev_l_mas.min is not initialized for the first iteration. This > > means on splitting leaf node, this value is mostly taking no effect. > > No, it is set to 0. Not initialized would cause random data loss. > > See MA_STATE() in the header. > > > > > Since we are now calculating the split of mas->node, we should use the > > mas->min instead of prev_l_mas.min. > > This sounds reasonable, but considering what this number is used for, I > don't see how it is working as well as it is today. I will need to look > deeper into this. On examination of what is happening here, the only way this makes a difference during the testcases is if we have a node with 16 entries, we'll put 8 in the left today and 9 in the left after this change. This only matters if the range is less than the slot count, so the real world implications of the change will be negligible, if anything. I honestly think I'm trying to be too smart here, especially at the leaves. We should just set mid_split = 0; in that complex statement and drop the min argument all together. It hasn't made a difference besides the number of instructions executed. > > > > > Signed-off-by: Wei Yang > > CC: Liam R. Howlett > > CC: Sidhartha Kumar > > CC: Lorenzo Stoakes > > --- > > lib/maple_tree.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > > index 894dc5e9436e..c2d4b188646c 100644 > > --- a/lib/maple_tree.c > > +++ b/lib/maple_tree.c > > @@ -3357,7 +3357,7 @@ static void mas_split(struct ma_state *mas, struct maple_big_node *b_node) > > if (mas_push_data(mas, height, &mast, false)) > > break; > > > > - split = mab_calc_split(mas, b_node, &mid_split, prev_l_mas.min); > > + split = mab_calc_split(mas, b_node, &mid_split, mas->min); > > mast_split_data(&mast, mas, split); > > /* > > * Usually correct, mab_mas_cp in the above call overwrites > > -- > > 2.34.1 > >