From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 075BAC10DCE for ; Thu, 7 Dec 2023 19:00:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3684D6B0080; Thu, 7 Dec 2023 14:00:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 319476B0081; Thu, 7 Dec 2023 14:00:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E0A86B0082; Thu, 7 Dec 2023 14:00:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0E5576B0080 for ; Thu, 7 Dec 2023 14:00:14 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 79783A0FE6 for ; Thu, 7 Dec 2023 19:00:13 +0000 (UTC) X-FDA: 81540937506.16.115723C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id D4E18160009 for ; Thu, 7 Dec 2023 19:00:10 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701975611; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6C1ygqtfa7m4hQyMilkLFZ8moYILSwh1BxQJbxE/tbM=; b=ap5RDsZoL9Lhe5a+y4sI7nUCOrQH9jqqpcvp7P093pBlXrNIqz+nwgvvz0JpOJuYHV4rVG ChJnx1uNgVZhf/U6QNm9JSNWwOMkh0IZrsNe5s12iWvEev2g2T+Z6bLsEKW+cORlGBQLpi detXEU6hEcTaELuxN7HA7TYiKel+pqU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701975611; a=rsa-sha256; cv=none; b=BDFWdUQFzdUkivwb9AAL5sBVM6dBi12KkTqmTLr1frPNZ1Gii5CSLCcclGJrsr4rlK8HJ4 sI/hFrnztP8LTjMXp3SnAz/fDwSRMCD5TjiN0ZZ1dPnVSYzvQ6Elg1S6RkUDMo8bOqYnZl seKeKqNGUkYSXL2W7G5FhIm03DsAooA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2A49B21DBB; Thu, 7 Dec 2023 19:00:09 +0000 (UTC) Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 090C613907; Thu, 7 Dec 2023 19:00:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id 78qvATkWcmU7eQAAn2gu4w (envelope-from ); Thu, 07 Dec 2023 19:00:09 +0000 Date: Thu, 7 Dec 2023 20:00:07 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Dan Schatzberg Cc: Johannes Weiner , Roman Gushchin , Yosry Ahmed , Huan Yang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Tejun Heo , Zefan Li , Jonathan Corbet , Michal Hocko , Shakeel Butt , Muchun Song , Andrew Morton , David Hildenbrand , Matthew Wilcox , Kefeng Wang , "Vishal Moola (Oracle)" , Yue Zhao , Hugh Dickins Subject: Re: [PATCH 1/1] mm: add swapiness= arg to memory.reclaim Message-ID: References: <20231206162900.1571025-1-schatzberg.dan@gmail.com> <20231206162900.1571025-2-schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k3hzrc2h7is5f6ec" Content-Disposition: inline In-Reply-To: <20231206162900.1571025-2-schatzberg.dan@gmail.com> X-Spamd-Bar: +++++++++++++++ X-Spam: Yes X-Rspamd-Queue-Id: D4E18160009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3s357zyx1xoem9sf7u66z657ouj9fp7d X-HE-Tag: 1701975610-580706 X-HE-Meta: U2FsdGVkX1/eS2wiArjjZgmPCZni0RBKvpRdWZINPFq8xNyX0rTOGf98pzeucsEl4vcZUYNId92l0G2alKZ+2T0r9uq9M39ZWtlX8zJ/jo1KMSMm6pGjZcmOcilIyt11BXi3s7FbzPqY4atciHd7YAaNnzVMElTZZvVNUE5IMTbATyNrkdDvsTna1DPuLuYNX2/qOmd8UwvekxSwYyPvhkR4zmpWTODXwfgAMZM/nX+3S7ZiKg59fXsRcsJTFwa8E05Pj2g8mcbzxR4Hpx+IWLYy1zlse0naCRVWcX8OWGlmti3nW2/b5BgE4fB0dXzGtvV6tjlgefyQC2H95uomkF9WGpTxNkypSpOyCSfAgf1ucR+7Zq/8bNGVqzg9uqbfVppTsLaqf/LBAP6kPzxVYf/eZ+E8q/GZBB57urjU8/fDZj34e2usy/FPM6hR5qgKacJM5baep8fw5f2G3dXvtyDgYFcw6qQ3rg0ViUsTvAAwpDWOvNfwGzw/MTSP+RDtcSKT9Rysw0DeoPzFa10BPAGSfiSllM+R/GNWlIOZhjqRsmh1LGisyCy+ryqNX9V0auOMH2PntyLPPzqRdM0O5dnpxeige7IduqcIkXDY4x/UA37atea80F1CBHs8M91ZhIGTyLdzYATr6HXIQfqwIqeIZWzPgGHD7F5rg29WamfRnYO0Mvla6d1xOeGarcxGKeVQHjlKMK1mobkqRkl/SXTWZF7QW5Vjp4OSXUlFsy0/Xa9Co4GDWbDf+o5rk5CqUwzbGFHIxMUIVWEhP6ro4XyAnJXMatLiz3LnAb30GEuyqP4PdWN+pPt/fZ2Qx9vGe+2a8evyKocakphLBw1/r7Hh12tLEjiTEyNEkRPPrb7DXsfJy6tteDZJBQVNfsMXKNIqbMqsOv3r2DYIIQv6fMOlsd0B4Gcpnl45S7brt7HRp7zrG9GePbmYHY932DjZdxbGtIh3bAtepuRcWH5 WPO3mH7G 3Ns1dqJpAsFFRr0XWRnVYSfx4pONz7Iq/gxxsRYFApUxB3XUukBDR0huY3Msy5O+9MZ4VgkxGs9SzQlJW8DjUNAtEoBRNrj4h3/+vbnyc33jI6+PiWhBWlV1TYaSqQiWKJVBezpBo5qSqi9DpG34qXE8E3x6D1Rze5pJFwJDVKSKAyPDorlqLo0OKpA1h3LikQo39KQk1h9p5KiY6mMxIUzX2+ScQRNgGyDTWQbc78IZv8gRKQaLANvmgXhe/9ZA7/AHnBs1QdA/6jnLji1QMUOTFkz0/gY0yYVtxL8/zrvVVsEM3bxv2rLME2ZNhi9SA4NFnaB4FJtlrt2rH76NBszm1UhefD1Eu1pYyo4lepDWis257k6ipf2G1RwpqFiYqiWhKDO0GBU3ndMLRX6bXVxPlGrx/lx3gqZod X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --k3hzrc2h7is5f6ec Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 06, 2023 at 08:28:56AM -0800, Dan Schatzberg wrote: > @@ -6902,12 +6913,33 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, ... > + int swappiness = -1; Here you use a negative number... > @@ -136,6 +136,9 @@ struct scan_control { ... > + /* Swappiness value for reclaim, if NULL use memcg/global value */ > + int *swappiness; ... and here a NULL to denote the unset value. I'd suggest unifying those. Perhaps the negative to avoid unnecessary dereferences. Thanks, Michal --k3hzrc2h7is5f6ec Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZXIWNQAKCRAGvrMr/1gc jsi/AP4ryoDOY4++Kh04OMP3Cy10vHIZmku9PA7uoVwjJ+hVmwEA5f9bJ5wivkdn FZExa4N388uEYUDV6aoyBsryEujrogs= =A0Xu -----END PGP SIGNATURE----- --k3hzrc2h7is5f6ec--