From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E57C369B1 for ; Wed, 16 Apr 2025 09:39:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 159F1280102; Wed, 16 Apr 2025 05:39:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E2F12800D9; Wed, 16 Apr 2025 05:39:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9C92280102; Wed, 16 Apr 2025 05:39:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C8A482800D9 for ; Wed, 16 Apr 2025 05:39:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 93FF280456 for ; Wed, 16 Apr 2025 09:39:35 +0000 (UTC) X-FDA: 83339409510.09.BBDB2E9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 6033CC0004 for ; Wed, 16 Apr 2025 09:39:33 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YZ7myU4Y; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xZlTVqia; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YZ7myU4Y; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xZlTVqia; spf=pass (imf22.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744796373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gmy4FG3KzpIPRVfXg4Qq7YyPdx3r2noeWmQLQ77iMBQ=; b=jDaqW5NZtgJjiQP2qWwZE7vfMyv5jajZqIfxWr7Ur48sTUWR1SKkgCgDmceX+hkLYz/hYG kjkyCmVFxPLpCKuSqo1PrF7RKH93SwCuzmVs6lQkzXTBIIyXih7Lov7IVLFap76Ca9i1bB Du1xmPXdi89B98ooGJa/VScOHtmh8Jw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YZ7myU4Y; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xZlTVqia; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YZ7myU4Y; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xZlTVqia; spf=pass (imf22.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744796373; a=rsa-sha256; cv=none; b=0KqhA1741w1qUJQ7rC3L5IcFDeeIsdT3hB5kWLhb554+JupWYoi+odgkgpF9qP0XVwVQYr 1odRKVDHk44lvGAGVfyTcKdAB9IthiMxlIfoibuwEuPHQjovzmi50wP/FcMyuO9CATOnFt 0aaJSFFgNfkCNEswVwXNZ4hYvPlXKJs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 11EE0211A0; Wed, 16 Apr 2025 09:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744796372; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gmy4FG3KzpIPRVfXg4Qq7YyPdx3r2noeWmQLQ77iMBQ=; b=YZ7myU4YV4ODEYv+tlKzIABVha2ZsVs4+Q5X+GwU0hfDLp7xN8zFfnCyXnAq86q3r5a4uk d9Bs7FfQOAgdMF+gd+bDADMfEEKTrqtZ1ih0dA4WnyPD3flUElOhMjJpXj96C3IcGxEfaB M8figfLDnbfWel+Y6mnqbkvkyuwF3FU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744796372; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gmy4FG3KzpIPRVfXg4Qq7YyPdx3r2noeWmQLQ77iMBQ=; b=xZlTVqiaUXvk/HWIp1JsgznGJKecZzjw/6OwCJDaWkjcvtx+v9wh+W4UsnK0gkY+n9bmyO geNrRAKM3BlUivBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744796372; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gmy4FG3KzpIPRVfXg4Qq7YyPdx3r2noeWmQLQ77iMBQ=; b=YZ7myU4YV4ODEYv+tlKzIABVha2ZsVs4+Q5X+GwU0hfDLp7xN8zFfnCyXnAq86q3r5a4uk d9Bs7FfQOAgdMF+gd+bDADMfEEKTrqtZ1ih0dA4WnyPD3flUElOhMjJpXj96C3IcGxEfaB M8figfLDnbfWel+Y6mnqbkvkyuwF3FU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744796372; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gmy4FG3KzpIPRVfXg4Qq7YyPdx3r2noeWmQLQ77iMBQ=; b=xZlTVqiaUXvk/HWIp1JsgznGJKecZzjw/6OwCJDaWkjcvtx+v9wh+W4UsnK0gkY+n9bmyO geNrRAKM3BlUivBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0821713976; Wed, 16 Apr 2025 09:39:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VYX5AdR6/2dXdQAAD6G6ig (envelope-from ); Wed, 16 Apr 2025 09:39:32 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id BEA74A0947; Wed, 16 Apr 2025 11:39:27 +0200 (CEST) Date: Wed, 16 Apr 2025 11:39:27 +0200 From: Jan Kara To: Davidlohr Bueso Cc: jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, brauner@kernel.org, mcgrof@kernel.org, willy@infradead.org, hare@suse.de, djwong@kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/7] fs/ext4: use sleeping version of sb_find_get_block() Message-ID: References: <20250415231635.83960-1-dave@stgolabs.net> <20250415231635.83960-7-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415231635.83960-7-dave@stgolabs.net> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6033CC0004 X-Stat-Signature: sgmou8uhxdnpqd58jdpgmtedtgdmqacb X-HE-Tag: 1744796373-2925 X-HE-Meta: U2FsdGVkX1+RGslp5W2Qb0ar/8E5RmLXqu/Cf04aZpFiaLfSvlue5djs2fdgH1hnISIVU2WHqZZ9wlAV5/2OmIPqyxV7Q0CKQ+l9tIPCKPgH0MGHGACP3UbK/TL3gXIhUXwAWYzTZQEjm5rrMLL8BhmbVJ6V2YrP0ncL/d64SnmPdwVeT1LI9cSyorES52qtQa6gOZ+8bjEenP8WbVBaIj37cw8uEPgs8QhanNvyzi808xoy0d3iCq3aCtsnDNxJKQlLW5hYV2761+LnTyr2u6QOwyvGJA/wwoDv7tL2ZnWXspxTJfGxI6MLUW1h8uB6J7yCaHLMCZKITMfcd5gj0qv0H5cNiMpeIeRVqgSdUpBHD/MNmDdnmB7xQdaBK05Hn7KPxRZ4AGRwxX3E653ucUQJ1FosDgNH8r3pjdCg20p8yt8nNqrKsI0/peUGzRDfI2ur4v+WbB/I9tBCUPv5oNjiEm3+i9vqsmyjEM7DzUSDzfNpnCuQUVmJ/oZSVWHc8k2UtxEhgYJEGAcv4Bj4yFChbWkDkCgrc6r9RxgHvrXcFIIAr4uemvAmvX8wHRk7Swcz8LpjVIy5xCXub0VF0Ydb0lGzNh54srZXRp0nRBVN7Sk9snjOB0AbYbYTaRXm5lOE0Ng1iU7eMxTYPPBKOJla10UEfmZEVfCgVh9eFCziUJ8zFCS1BK4H+uHhWffOIbvyp2GPaVpCgKlj82iZXRsS1KOMgunMsSZzo9PNx2lGJbfZxLpWl/RWk9EQE2Ph78y8MR1DcJlXIEnSABPP+/M1d3rAsl+/S9G5qLSWesE3YG2dtv4DwdXF6dTRuu5FX23gaQ9VHNi/RI7aAkPXwe1S7s/uAID5EZJGwk61W5kUB0LwOz0EFfguZCVCoI22lOKR4GuALwgA6mq/NC65h9Yx9JMcdDeXxVEVT+LyZhk7MinghqcEecCcR3HTbTvsX+qgftaJpb8mKGDU1uI +THRzJRg Uf2g8vXUUKaWPYvqg0ZOmWwa7uzF+oHRHdOz/zdn1KxpLAtkP4oKGzROcDVkj/oyTpOT4Crl9iTgCUEqXIIXOdC1l4lVRj86GmkMqd2C5yB1EHBF9pFIPcaOgCZQYDDUz4ivSec4UxAofXg772+sLkZybC7ftt59XbtJsNRxlKAyPWeAZcNagFy8icn0phoZWCBcvzQj27IS09S2UkI/SA+kEVBwS3EB83ArsREkaSmj78lCIr/LvUIzITZnIHkfAqAns7xiMcFvqRXR3KAi4VbF6leboP9qyPxrbOv8pMS2onD7ShWrWc6sNj05aI++qCYLAHcjTlf3vmIzj9gjZZvbL9plrC6YVDHqEkPCTShbMtB9mLaMTR8Vq4MzXjAdZGh3dm9OGDk1zx2mC/XIN3i4Ho7xZ1jlaowAnU3O4bg+9m5QekIMCkt/dJzYyC2XEMrU4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 15-04-25 16:16:34, Davidlohr Bueso wrote: > Enable ext4_free_blocks() to use it, which has a cond_resched to begin > with. Convert to the new nonatomic flavor to benefit from potential > performance benefits and adapt in the future vs migration such that > semantics are kept. > > Suggested-by: Jan Kara > Signed-off-by: Davidlohr Bueso Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/mballoc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index f88424c28194..1e98c5be4e0a 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -6642,7 +6642,8 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode, > for (i = 0; i < count; i++) { > cond_resched(); > if (is_metadata) > - bh = sb_find_get_block(inode->i_sb, block + i); > + bh = sb_find_get_block_nonatomic(inode->i_sb, > + block + i); > ext4_forget(handle, is_metadata, inode, bh, block + i); > } > } > -- > 2.39.5 > -- Jan Kara SUSE Labs, CR