From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C7A0D2FFF9 for ; Fri, 18 Oct 2024 11:54:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41C8F6B0082; Fri, 18 Oct 2024 07:54:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CD1E6B0083; Fri, 18 Oct 2024 07:54:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26D4C6B0085; Fri, 18 Oct 2024 07:54:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0B27C6B0082 for ; Fri, 18 Oct 2024 07:54:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A37F94071C for ; Fri, 18 Oct 2024 11:54:42 +0000 (UTC) X-FDA: 82686566004.12.63A6DFB Received: from flow-a1-smtp.messagingengine.com (flow-a1-smtp.messagingengine.com [103.168.172.136]) by imf21.hostedemail.com (Postfix) with ESMTP id 86EE31C0006 for ; Fri, 18 Oct 2024 11:54:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="f HvrGui"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=af6y248P; spf=pass (imf21.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.136 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729252293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=62nSDetxREUwhFRwOeDWnAUvJJ8O2ro8jjslYBHI46M=; b=TceHobk0/bSFmfbFTeNk/yJuJcPqvbwChCkyjVEmQ/qymLEbwnCFoqY7Bt21aKVaocmLK7 KvPbZD5W/fNoQyaiufgHAW9pu/5wcQv1UcJF8ermJl2EZ0tiOukI5cXt1LrqZQ8hUVdg9v OG+ZvsNlZ+IMtJyMK3rZjAiRa8Ixg8U= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="f HvrGui"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=af6y248P; spf=pass (imf21.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.136 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729252293; a=rsa-sha256; cv=none; b=Z+qOHZLZrQSxm7kCnbqu54op5KgzEuZkwKqAuh/r3NPQ/lYfB6RZHxM3bjHgS4sd9UXaXO SbMoVE0tJxEeiW0lpCUWbP1RApSwtsom9U29pVv8phRCCldsP4CuOJCHodJUZq9U1k32CW YelxsAI0H7q/b2sUYQPmQkC9VZGJs6I= Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailflow.phl.internal (Postfix) with ESMTP id D5F0720088D; Fri, 18 Oct 2024 07:54:46 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Fri, 18 Oct 2024 07:54:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1729252486; x= 1729259686; bh=62nSDetxREUwhFRwOeDWnAUvJJ8O2ro8jjslYBHI46M=; b=f HvrGuinqPO7FSLsMxXbhuacamOu+wnRmsFTsmmO8fHw7/XVL6sFGMFgN64NLXwiy cVKLFmCqS/A+McaGMRI8pTWbCMtSvN7M/qOMvtLAT0kQ1QGVjxXX+C0f8l8l0LpU sum4ol2gQbDtueHXCuyslwIdER5QOjS3mUVEKuDm0UQfTt0aW4Zjj+aIK6evgvrH 7alCf1uy+2T1eZHYOX7H6kmPVS/iAimCC6efzmOrWuSCcXOntURcwjfskxOMK9X/ yzQsjpyDOWINeou66X8ya1JUqinQX2AbKl0M2WWakkvejH7RFqdKJ1rhVq6wNz56 99BoEWMoNTzjhE2oi6R2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1729252486; x=1729259686; bh=62nSDetxREUwhFRwOeDWnAUvJJ8O 2ro8jjslYBHI46M=; b=af6y248P4NufDYVeYnsoeKWrRD/c2i2ticskLruWSSBA 4tS8UXpxQUEAx+zlOpH51cp8q5bxBTGEffbckF5trd1dB4coKoKzQqCT2bZuKtJP hqgZFdf6VEgfx79LZtoTFjdSe8Dz1NxnK2uQfa4olgYPC/Hq+wHM3v3yHm7EvGfO d5UWQBCNT9tIJvDvl6MSuU368DlbVhgZxY0UmOUtgxuTUZUxbVXdiK2OyLSodt9T 6+Wqhl3wDXiD8Nlrmt/kHf0N5yxRUI90WiOciFbbt1imkMU3aZ4JpfkapyieOQ9p FQfDqkyVJlNOsk1B+ZZYL5WOiyvgOhsm2ebbQT9D0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehfedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddtvden ucfhrhhomhepfdfmihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlse hshhhuthgvmhhovhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffvdevueetudfhhfff veelhfetfeevveekleevjeduudevvdduvdelteduvefhkeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhv rdhnrghmvgdpnhgspghrtghpthhtohepvddupdhmohguvgepshhmthhpohhuthdprhgtph htthhopehrohgsvghrthhordhsrghsshhusehhuhgrfigvihgtlhhouhgurdgtohhmpdhr tghpthhtoheplhhorhgvnhiiohdrshhtohgrkhgvshesohhrrggtlhgvrdgtohhmpdhrtg hpthhtohepphgruhhlsehprghulhdqmhhoohhrvgdrtghomhdprhgtphhtthhopegvsghp qhifvghrthihgeejvdduvdefsehgmhgrihhlrdgtohhmpdhrtghpthhtohepkhhirhhilh hlrdhshhhuthgvmhhovheslhhinhhugidrihhnthgvlhdrtghomhdprhgtphhtthhopeii ohhhrghrsehlihhnuhigrdhisghmrdgtohhmpdhrtghpthhtohepughmihhtrhihrdhkrg hsrghtkhhinhesghhmrghilhdrtghomhdprhgtphhtthhopegvrhhitgdrshhnohifsggv rhhgsehorhgrtghlvgdrtghomhdprhgtphhtthhopehjmhhorhhrihhssehnrghmvghird horhhg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Oct 2024 07:54:38 -0400 (EDT) Date: Fri, 18 Oct 2024 14:54:33 +0300 From: "Kirill A. Shutemov" To: Roberto Sassu Cc: Lorenzo Stoakes , Paul Moore , ebpqwerty472123@gmail.com, kirill.shutemov@linux.intel.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, jmorris@namei.org, serge@hallyn.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Roberto Sassu , linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, linux-fsdevel@vger.kernel.org, Liam Howlett , Jann Horn Subject: Re: [PATCH 1/3] ima: Remove inode lock Message-ID: References: <7358f12d852964d9209492e337d33b8880234b74.camel@huaweicloud.com> <593282dbc9f48673c8f3b8e0f28e100f34141115.camel@huaweicloud.com> <15bb94a306d3432de55c0a12f29e7ed2b5fa3ba1.camel@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 86EE31C0006 X-Stat-Signature: tijiczmti4npcgdimzd6mgbmj5fim6mu X-Rspam-User: X-HE-Tag: 1729252466-91104 X-HE-Meta: U2FsdGVkX19kCWc2llVgL7YA5GWcIerN86twWlVBfL8+3qRRlbCVt1oEAWA4swUXHhy8nxDvwRkcb9PSyvscOPf1+FvrKAnfQD6N1HIkT7NzbYnHme7iI/BLAFkvaC+KLn8X5HetZeaFO9c7Fn1VBEU9nvSvtFpEDFO9yw3I7xRwK8WC95JA7Uucs1idOzByEIge9rM/cOgTTYqZRCl2wd9teO47urmZIu3po3P2N4Lp6GN/45Qvw08W8xsLXPk71PTJbBZgDApSc83KKQsYbFnJwhhGRKdyKKfNMZPPXe5nwGjXCuxo6rPLkDdemvOk+HegKLvkEy8TJ4swzdJaS+xJAZuZFoaIkEh2o2ne7bfdaM100GFv/MLmefUWiccIvIkFRaI5oD+59ewtjPUW7yj5PLqGZ/h2r6klRZB584/Rxvw/Do9Pdip3ulTnJ81Efsnf1UC4xVzh81IKR6qOuABP2GrweS/BSDxTcmwazE/TfAT4ZOR0bN5/G5WTo04frBPDg0e5ejsFEPG4MrePr/gjzFqa+j+1KmXGIe5p8n/h5zp3CHdXo3gg3ovA2+z8J29mYoStMLWeOMfuzK9OHSPrWBElUCS2WNSx14wAbIGa/mvZL1TjTaC0FbRPdxqTopcTTjGpu8JjIWY4HLY1D1ZspY9Mb8iFA98qlU8La/QF065KNzFB2eNJqgxx9cd+ikAxlr2PPCgVRiJqXrADrVWxs7cwsiYh15V0xB1kfC+8FgKNC+01Zlb7isbbEdmRAvkYxP+PZ8+04pTit5eVOtVfNqFeLtBLbDQqn6tzavfgcxwHy0Xc6b8ifGGhWw6RRcdfQkb/rvfiMT9o/xxZQh2KjcePQJcs8k2XY/65sVdYkLE9/et4WnA8Bb8OFl6rJq5eFwX1945m7tNR2/ap5l6eSDKfjC64Jzi+FHLt/36xtFvg+1Q6Xejk2X0vp5Z6rAmZKFdhZbsowHGjLkD HqHsIMb8 CoKTOY3BJFXpqQ/ytBHYTnI+H7l2nKwa6PoZJIpQT40RI7LQQIcOVRMiqQ24HaNw56UjYOXvDe0BBPcmyK2LxNK0N9nMy4+N327kzHaexIv3mMmBjZHHr7f8vM4lukplrGXNDpXfSX+VMHy8zNncurXuDqTgrPAt3fmq6WDTYseckCLQSK8hagQ1d/ps/c0+kicLP7Z8c6i4lQs5vXGhcFp965B4/beHdumeDFAhnno3I8vHXgzGcwjfjkdyPT8utKRE5UKPuRjCgR+ODc2bdRTHep+tzLWjAYFLX1hBJFpHsPDY3oQZE+uJ6K1kKRkviSA0RoFgBkfa9bu8DniSetJhAzrd7gtoD7i4mz+DN4wlrJsjhK30PxnGbWwJn6dcYqtQYHBf5jINHQBkYJgdW6LvSkPCrUIUMfDTNx059s43ljaSbU89yrp8KpXbRPLsvL3jFdZJUwyTpkUJHAi29i/DGng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 18, 2024 at 01:22:35PM +0200, Roberto Sassu wrote: > On Fri, 2024-10-18 at 14:05 +0300, Kirill A. Shutemov wrote: > > On Fri, Oct 18, 2024 at 12:00:22PM +0100, Lorenzo Stoakes wrote: > > > + Liam, Jann > > > > > > On Fri, Oct 18, 2024 at 01:49:06PM +0300, Kirill A. Shutemov wrote: > > > > On Fri, Oct 18, 2024 at 11:24:06AM +0200, Roberto Sassu wrote: > > > > > Probably it is hard, @Kirill would there be any way to safely move > > > > > security_mmap_file() out of the mmap_lock lock? > > > > > > > > What about something like this (untested): > > > > > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > > > index dd4b35a25aeb..03473e77d356 100644 > > > > --- a/mm/mmap.c > > > > +++ b/mm/mmap.c > > > > @@ -1646,6 +1646,26 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, > > > > if (pgoff + (size >> PAGE_SHIFT) < pgoff) > > > > return ret; > > > > > > > > + if (mmap_read_lock_killable(mm)) > > > > + return -EINTR; > > > > + > > > > + vma = vma_lookup(mm, start); > > > > + > > > > + if (!vma || !(vma->vm_flags & VM_SHARED)) { > > > > + mmap_read_unlock(mm); > > > > + return -EINVAL; > > > > + } > > > > + > > > > + file = get_file(vma->vm_file); > > > > + > > > > + mmap_read_unlock(mm); > > > > + > > > > + ret = security_mmap_file(vma->vm_file, prot, flags); > > > > > > Accessing VMA fields without any kind of lock is... very much not advised. > > > > > > I'm guessing you meant to say: > > > > > > ret = security_mmap_file(file, prot, flags); > > > > > > Here? :) > > > > Sure. My bad. > > > > Patch with all fixups: > > Thanks a lot! Let's wait a bit until the others have a chance to > comment. Meanwhile, I will test it. > > Do you want me to do the final patch, or will you be proposing it? You can post it if it works: Signed-off-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov