From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D65C001DE for ; Fri, 4 Aug 2023 18:00:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 890D96B0071; Fri, 4 Aug 2023 14:00:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 840E96B0072; Fri, 4 Aug 2023 14:00:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E19B6B0074; Fri, 4 Aug 2023 14:00:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 59A5B6B0071 for ; Fri, 4 Aug 2023 14:00:48 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1A8B7B32D6 for ; Fri, 4 Aug 2023 18:00:48 +0000 (UTC) X-FDA: 81087187776.29.567C690 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 6FF2940029 for ; Fri, 4 Aug 2023 18:00:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fgLGfXn5; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691172035; a=rsa-sha256; cv=none; b=DhJjIRKBiF8haniToloir9UDO5YPBN6YsqThvWmbM5OrP+PCLK50HtQ4cOtm7U2AovHEhU gUybT/veTv5AYv87RLIdWrLe0V3k84AIusy07yL+YNlQ4o7CpAVcf6zky2X0c0ixdfJwFl GMtOsenGlocRdBJHOwhCZpdzb+iYnVs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fgLGfXn5; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691172035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=plknfH3SDQ/AujyL8eWFqeOy7h7VD7A1dUfZFnOOKDM=; b=zbnRpKw+THNHROyRAQHJmBEUBI++c+Qt5zyaIqEEdNpyBQYkxi/N46G2PsvAxj/jkB8xVI d/0F138oT/LP7+FbQIcdFBsWSl98Cz0YGXjZXwYm/2uSLhHkVOgnTM5HcdMzLGKgsZvOH6 bR/WXd6ucSOWffh96VN6DDdut9yoQSY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691172033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=plknfH3SDQ/AujyL8eWFqeOy7h7VD7A1dUfZFnOOKDM=; b=fgLGfXn5vRoqRQsufLarXjD/tbwLmtNM930483/Ecdx3JSU9FUTOAGwE9mUiPnWvUeK4y1 zvZCdS/Owx4r+RBTMMS0kMfevbZ/FXH6sFy8oAYgBievvmTMfvmwKyREnpeHLjoi0SG8Qw rHezhWr0puYeNmm4CLUXakiGf00dnok= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-ugoUh5HNMwKWyZlBtCaZUA-1; Fri, 04 Aug 2023 14:00:29 -0400 X-MC-Unique: ugoUh5HNMwKWyZlBtCaZUA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fe182913c5so14233565e9.0 for ; Fri, 04 Aug 2023 11:00:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691172028; x=1691776828; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=plknfH3SDQ/AujyL8eWFqeOy7h7VD7A1dUfZFnOOKDM=; b=CQQO3/wEYewaR7+O84epfT1BwTFcU2QiJAyihx/GZfKopSOcKogRO25VHzJXct86u7 KOAt6ixpbZiH8BoricOzAkfmGRmNKe9QPBLZR4CshA1T7/EbnhyE7nTXmBddpMFOFF0G 0X1f14EZuMhooo3tiAPio7Av4V1jypj48QMZoeYHM82DT1cnNzTwvTcYcGryOmTImth0 Fp3kBp+gOi/YHeTdyzt0x9aHHAjHVl03O+k/sH920f8ClRmvfpOoH22pE29llSqY+V9i nvSsGuZe8dsPvt3j573Xfzmv06yhRvG6Syv1a8KB63E62CUGPlt4kN1floaNFrZ0xR72 V+fw== X-Gm-Message-State: AOJu0YybxiiOiZNoyBe1lR3OiROH5xco+/Iw3G+jc1K4zoV6y5pQ6MOy raDZIaQyj7rj0rWxBoz1bxT5bi3fOtPZNyw3Ak9u4MlfNOj1wqQYom7RhXTjmRboYEuKTJC5C4A k6OkG2oqiUOs= X-Received: by 2002:adf:e90b:0:b0:314:49e4:b0c4 with SMTP id f11-20020adfe90b000000b0031449e4b0c4mr1906964wrm.70.1691172028375; Fri, 04 Aug 2023 11:00:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxHfzUz1EPw43upa/7C1PthJlkuVCBp6Z+blRveCGIYkYDQyDnvZ5j7WD7RCluzgxUr1F+kA== X-Received: by 2002:adf:e90b:0:b0:314:49e4:b0c4 with SMTP id f11-20020adfe90b000000b0031449e4b0c4mr1906951wrm.70.1691172027948; Fri, 04 Aug 2023 11:00:27 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:8e00:a20e:59bc:3c13:4806? (p200300d82f2d8e00a20e59bc3c134806.dip0.t-ipconnect.de. [2003:d8:2f2d:8e00:a20e:59bc:3c13:4806]) by smtp.gmail.com with ESMTPSA id m15-20020a056000008f00b0031417b0d338sm3082057wrx.87.2023.08.04.11.00.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Aug 2023 11:00:27 -0700 (PDT) Message-ID: Date: Fri, 4 Aug 2023 20:00:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 7/7] selftest/mm: ksm_functional_tests: Add PROT_NONE test To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini References: <20230803143208.383663-1-david@redhat.com> <20230803143208.383663-8-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6FF2940029 X-Stat-Signature: swtjaohmr79zzyafca5izar1zrn9habb X-Rspam-User: X-HE-Tag: 1691172035-118442 X-HE-Meta: U2FsdGVkX1/BP3L3sDjGWBzQXFLdsPeETsKGFQxaNIFT9I+EkzqHVUSLvm4UM/tsp5yf3ICjz74BlKMhg19i+VLnz6GfdQHBbEbWZjKooqvFHwOQ2fdMe7/+QAJi80YUuUx5gfvGE2o3wveBXIP+h8/z/+2ifQjNmqDYSOgeMu+EYFI9QqYTQgn35dBoDAg717XlH4rdjsaaISV+TzxwbGy6TJZjhSuKTzYgQIyknv4wXYx2OdIo4bkz7lfeItrka6O91Omx1nq5oYnWgCkBmk0pv0002g28c8YVOdxpBye4oWlx0gQj9J3dMfn7IHTj9mdqKSe9CEyVBJdDvA+eU+WmpA7SX7I79/DZch5/QxBNlCFyd6oULo41kVu+3/L8r9vsxEWBhW8jGNwwNO7WanSmp5HsB/v1f5rKZouYZqoXEjtAVYaC27WVxL29cJcaoHpIT4sPECEnZH+A0p736DZki0WlCprG2gN64xL5WAiP+0ViPs79TWxmIRVEi4YiP714chenrGZxut+RO501/OUOF6u0ULMmqXhVgIDjGuYqDFSvzvBEPJTp4cwocbqhEkMfVS6yVvkGrzOtXhY2I1YG8SF/Y9qjX1wA0QTvRWkLzUsGRlYqFgMMoT6Psq0O6o3juzqwDf5vDDX+msMo0qYDvzPaMr+dUm2vvrIBQ4Qpk99X+luKOZERP4jrduuKz0cBNtTz70CYbC20lD/D6I3f4aLABoJNtslb1rWOtqF3ivz6sMq6N82JLccCBGnrho8FUcyzXbRGpaqOyv7komxUdr3e9pihbqii8dzQ9m5Qe14FytnmW97HbL2qX/iURDl34KiAzA6uKu1tuHucLQR6b3A92BHM66hksCyS4K+b1RgN/7BttEBSOcJL31yErWn5MSETkGwakObpaVI3vFeuXBYgnKMtPBEAzQb1cMvj8ibzvtyKNhhciFaBTkTwFbhnlLFgFGgCs8dhhIQ Z2U+e8/n 789iYajLJrpreyCkPppBKLiHFmY97nyDMdknnUqUgkS91SK77vswuvpRf97sa4VNwoWLi7i6+rC3pDj6L3LUuYUawRO1PyVyMq1/6JFrG+sLOhdx1j4+W6eV7OI+LS/srilz8pJTO/ThKXdUjF2rAkBaplAR/n+eRuQIGuRo9MhU+JqOEBGxpxESZzllyX7dC1SOC1/tIwEqee4QHe3VCqlnBhYwmWxQClke8RRTxIshwEeyn7MwPk0f9MDR/Uj2y3veBOs/Acse1O8w9FwKRLvU9H0oqMSX8l4XgyRf/tyjdhyioVjaOZgbjHicqwZWn7WGF7V8RUkwyX/iO8Za/6ZDUzVpc9uDDH+YOXTqyGC1Eniui2leOgvUxO/clCWmfap7F9Au9GhCXRV6NCOt2pAKvXTrk29+gGNtdaTPx7PwMNYtzsSWI3E8+8VlGroMInMSe77iVOu2bCOI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.08.23 21:06, Peter Xu wrote: > On Thu, Aug 03, 2023 at 04:32:08PM +0200, David Hildenbrand wrote: >> Let's test whether merging and unmerging in PROT_NONE areas works as >> expected. >> >> Pass a page protection to mmap_and_merge_range(), which will trigger >> an mprotect() after writing to the pages, but before enabling merging. >> >> Make sure that unsharing works as expected, by performing a ptrace write >> (using /proc/self/mem) and by setting MADV_UNMERGEABLE. >> >> Note that this implicitly tests that ptrace writes in an inaccessible >> (PROT_NONE) mapping work as expected. >> >> Signed-off-by: David Hildenbrand > > [...] > >> +static void test_prot_none(void) >> +{ >> + const unsigned int size = 2 * MiB; >> + char *map; >> + int i; >> + >> + ksft_print_msg("[RUN] %s\n", __func__); >> + >> + map = mmap_and_merge_range(0x11, size, PROT_NONE, false); >> + if (map == MAP_FAILED) >> + goto unmap; >> + >> + /* Store a unique value in each page on one half using ptrace */ >> + for (i = 0; i < size / 2; i += pagesize) { >> + lseek(mem_fd, (uintptr_t) map + i, SEEK_SET); >> + if (write(mem_fd, &i, sizeof(size)) != sizeof(size)) { > > sizeof(i)? May not matter a huge lot, though.. Oh, indeed, thanks! > >> + ksft_test_result_fail("ptrace write failed\n"); >> + goto unmap; >> + } >> + } > > Acked-by: Peter Xu > Thanks! -- Cheers, David / dhildenb