From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E88FCC77B75 for ; Tue, 18 Apr 2023 02:36:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37F488E0001; Mon, 17 Apr 2023 22:36:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B9F66B0072; Mon, 17 Apr 2023 22:36:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10CDC8E0001; Mon, 17 Apr 2023 22:36:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE6756B0071 for ; Mon, 17 Apr 2023 22:36:06 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 13D90405F6 for ; Tue, 18 Apr 2023 02:36:06 +0000 (UTC) X-FDA: 80692947132.10.A4CD1B8 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf25.hostedemail.com (Postfix) with ESMTP id DAC59A0005 for ; Tue, 18 Apr 2023 02:36:01 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HFiH8hip; spf=pass (imf25.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681785362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rAR+Qyz4Qbn+18dUi0Xf4sYCGsSnCnJMJj3KbYvPti8=; b=cbxGwt+LDMR5JgLDldI8gXl2fIkkklFlkXijz3kljFMYAoxI2zgJlAQHpz6Z+pDnN2Bjmn gmY8aQXLLFeO3lpfdCXCZRlFrSwk1pGII7vUavenfRZ8Dgu/eAJ50vsslAcjfgJ2V1KSuy HuFMy57rzxe2tC2/SYX/rvpvMXo2XGU= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HFiH8hip; spf=pass (imf25.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1681785362; a=rsa-sha256; cv=fail; b=RnlC/lKzK/2RtKMi2LyswDI6yhuba0fVmwOIEiPJKaE+B2VvaI1yjE5hQd05lOWIE9JcyA TXiEIRpkyD3BgMPYAjjkexr70PDJ9aCL5vUd8vJO3IDAKtKnI89mkXe/8gbIei+3ihz09e OlvfzG0ojdHftHW7Xg7UWanvOJthx6Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681785361; x=1713321361; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=xwMfOfDIIKL4sKt7J3Xa4msAR84tBZNcFbiHgH0fVR8=; b=HFiH8hipsCqY4gCrhgGkZPzIAyI/x5w90r7lLwpi2SfSA6/MEdv9GKyu v10BDhe9DcXtyBl7ygv95PffkauPCrEmDJT6j6AK2jy3VAJwl1ZKaY71Z 7mOLxBXPeY7GuUBpJIX7gM0Ygg8nDHx3P/jil/LLu4nK2DzAbTD5x8dRo Bc6u9R4YPV+nHjfzcjdYSyw1H9DLIsF4necnT0pQfCTxQxaoaBOsz6s8X Awro9LNZ+FSXTnOLHyWheuWOXN58ai+GKz50ufc68iVw7q3ohwqPddfYh puludJuRzIBz7US5eEzj4nVblyUjVnDXgjq/Z5anhXKTD9JvFYCiSbhCC g==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="410275065" X-IronPort-AV: E=Sophos;i="5.99,205,1677571200"; d="scan'208";a="410275065" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 19:35:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="723464280" X-IronPort-AV: E=Sophos;i="5.99,205,1677571200"; d="scan'208";a="723464280" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 17 Apr 2023 19:35:48 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 17 Apr 2023 19:35:48 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 17 Apr 2023 19:35:48 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 17 Apr 2023 19:35:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGap/lOZWC0zjIPzTY6EwtgK/gCQFF7Xh/O/uoI7/Vtz/MvvFpU4rTVrhdKvocgmb9BGEHK8wp6+fSRJyXR9zXyRITybuwS1zhv/qbD2gJXmivSUCS6U6+/nVIvDkdsHcpiqiQivDBY9xQ+LG029usAA7vum6kSU3F0xLuklZmu2RUr6VzJfAPqx6VsLVq7Ob3JnmkWXbs4lZr2cGEX/BmLpyLdBxhMoyJD3uf20UPFiysvKjbt1BSzRYSgU0uTSzB/xDdRN92SoUcTvpqtXr9R3Nz5XYGVXC+3H5G8RnMrgZ8d8O196aLNG/l+RVn1vjwurhKoBLmYf8CnJDvcvWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rAR+Qyz4Qbn+18dUi0Xf4sYCGsSnCnJMJj3KbYvPti8=; b=a1MeTYy6iqtPZm9E/eiIz+FXBefMntjtaXsgUtFEzBtg/e0eb54ofZGp0GMpq7vUKXkFv27HQRZPA9x0fztU8Gaw+3qf6yeq2JG0xN9WAiHBVq2A4OHUxe2Zem4yMcWVElpUuObJrx0m1NCxo/Hr9nQJjuUHVjPhzoxJfnHlU/+gAAx/5tsPjM/Ayh7+qGvMjA8LGvsifadHFALxn+QLWMprAFl9frVaLc+TbjDRaXSchpmONwoXqhhtphL09ypf6t/kFXQGA9wj9lPWeIPxsfRb2kcKN+dG9tejWmukfp9sYFLsihW/fYRnxEMbbRfIMqM2UyQMAVEcEbZ9du7Tig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SA0PR11MB4766.namprd11.prod.outlook.com (2603:10b6:806:92::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 02:35:46 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::f670:cacc:d75f:fcc4]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::f670:cacc:d75f:fcc4%7]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 02:35:46 +0000 Message-ID: Date: Tue, 18 Apr 2023 10:37:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.13.0 Subject: Re: [PATCH 2/2] lru: allow large batched add large folio to lru list Content-Language: en-US From: Yin Fengwei To: Matthew Wilcox , "Huang, Ying" CC: , , , References: <20230417075643.3287513-1-fengwei.yin@intel.com> <20230417075643.3287513-3-fengwei.yin@intel.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0030.apcprd02.prod.outlook.com (2603:1096:3:18::18) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|SA0PR11MB4766:EE_ X-MS-Office365-Filtering-Correlation-Id: d7d507eb-741c-4238-f524-08db3fb59cc1 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3yWRxgPGtorz3aAvCN2f9MOt7Wz9UXGbKGbOjGrm+KPwTAWytSs4rG+ng3kb7NOnbicKOpZipz3uwBGGS5MN0TRCn2lFufi/RWl55jghl2qeV83gqFbzMvIXmTvlV/W7XCyRaQMGpVJB7YI3jkC3FNGI6a8A5xzMAk471j7XfTe7vB89gi7Hcmw6T2d6uveRbg1wrSOaeS0vU2KzoBNDqkBOHx06IV3q7sURK0ndT/7Mkdzo3g0bBioz3BTs3GXHZORdkx/QW9jSKSnAlRCflChwLhE7Iy1LpQ7+U4AczZfEiA6r8mUQMKPLOdcF/TbrHVJmMzuvS1J65lKPXECndnL5UxezIssTrDp+tuDzyM/f++kz0i0EIBfq0YsXG1MFl4bMTSyuIcKHD0I+SFQ/WxCtpqLgniaBBGnmXTmtwg7viywdL6nGNC5JNGhYx+0ECTNFA67vmSlb04S4IdL/iNBtXqCU7BIZxjxvNDsUiwZxjVLAzHNSeE6aP/P6cLkWi4gXBcMtvimzGArEUUiLa1gkEfzZ5i8dUrGko+JUQ+ttNCmwO116ZUO8/rhLRgTCryG1mCa+xC6bwNzYjcQ3wTXKia/EhjBJv2veTEvYvAQ8q7kypJGHFD6+GdpdVWkj2P4+XluPxcIQoUmahlidAQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199021)(5660300002)(86362001)(2616005)(6512007)(31696002)(6636002)(83380400001)(186003)(53546011)(82960400001)(26005)(6506007)(38100700002)(8676002)(8936002)(478600001)(110136005)(6486002)(6666004)(316002)(41300700001)(36756003)(66476007)(66556008)(4326008)(66946007)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mk41TjFPRmhYbGpHUHBaS3dVYTdjWDZqbW9ZbWZNdGVWRTBaYnRRWjhaWEJW?= =?utf-8?B?QStGRFk5VzczdEtyM0E5aFIvUjBMaFZva2JaclE0bXd4WHpLMllWbkk2YXpj?= =?utf-8?B?Uk1HOWV5bFZKV1dpTWg5dEtTa1Q2NlVpMC9FRmhxS2RtL1RTanM5NGlJMzB6?= =?utf-8?B?ckZmS0tDOVd0aVhTWThDS1hBTDN2R0ZnaENXdUpKbVY0RFhUdDdVTlkzc2hi?= =?utf-8?B?Rm02bENrV3ZOZlJ3UWFrTTFDOFNpL0dFSzVzd3Z1LzBINWFVaEc3cTlzUlM4?= =?utf-8?B?VVJ4dU5lMVorQ1RBMHMrV0ZiS2RiMVFqREwrOUpPaVMwemFScjRPbm16ZGV6?= =?utf-8?B?QnhXYjJ0clUyZXd6RnlTNHdaT2RFS2huQlN2SjRFYVdFdjNQa2JPZ3YzQXE0?= =?utf-8?B?MmtwVW52TER5TlMwSitBbzQ3a25MRHkvamNoWm5SLy9TT0Q1RzlWUVptbVJ3?= =?utf-8?B?blJFSGZ2VHpXcURCdlhiMG05UCtIREFvd2s5M0VyQXdkdWgwQXBWaGE2NEVR?= =?utf-8?B?ZVJ0bG1zOTkxbTFzZmRLWnoyakFsSVBNejBwWmh5ejJhSFo4dWFTT0tMV215?= =?utf-8?B?TWZicFFXZ0MyVko3ZHRHK1JoaHBoL2w0OWJMaE43K0V2MjRucFpGdDhFT2hG?= =?utf-8?B?RStURmVBczFGRkpCY0FmOGtEN0czTlhzSENjWktYVHRwUENGUnZHa0FKUkw4?= =?utf-8?B?ZEZIczRBNTZiU3Rsbmc5aTZiN1pxenAzVk8rY2xFcldWaHdPSnNlVjNNaXpi?= =?utf-8?B?MndhTE51MkNMbDFwVGFFQnlMb1ZxUEU5WTZYekdXbVNhQWUxdk9sZkU2V0dP?= =?utf-8?B?bHJEaXRTdVdOZitQQ01EM1dQUDh5bTR6a1dhelE3aEhudFlTMnpDZzk1SmhD?= =?utf-8?B?ejVneVE1V1pIOGU1K0JDbXZZQWFWWVdxR0xUKzk1WVlyOXU5MklLUnJZVFlq?= =?utf-8?B?dWRsWWJXM2tDUEZTaTVqWlRQK2hXMERnMTE2UU1NN3crc3pMQ21VcjQ2NGpj?= =?utf-8?B?UVpqdmMvRU1WNStxZi90ZTZkNkdtNStOS2dpakR3ZXpqdGtvWnBSM0RIWDlJ?= =?utf-8?B?Vk5MRHlpVlorZnV1UklzNXVtT2RGUjNDeGZ2TDJYTzBUVHI0clV0R0lsUUJ3?= =?utf-8?B?VXZmeHZBa3duSXFLVVdpS2xxallkKzFrZThnMEdqcThoaExEczlObTNIdEQr?= =?utf-8?B?Z1RTRzh6VFlQNlhMMlZnam1RTnJ5SnRQVjNHN0hiMmJnQ3crcytKZTFSa05F?= =?utf-8?B?ak5rMitwMlRBTlNSNGhjWXJJOWhyVWZ0NFAzSmpheTVPdWpCenQ4NTJQU2Y0?= =?utf-8?B?ZllSdEM3MjlUbk1CQkNJZEtQS25qZGpaaC9xMjkyRGVIVXpqZGpzUzQ0ZHFM?= =?utf-8?B?M2txT0RjS0xxZDd2dng4Ujh2N2g2ZjFjTDFaUGpkN3diSDJnZGNZd3o0RG1Q?= =?utf-8?B?cStTK2pGZnIzNk9xT0VDWG9WV0pqYnZMblNHRzdPa29vdGlvcE9SdERFd2Vs?= =?utf-8?B?S3BOT2VMRUZUTTMydWxONmZpaHVIbXdHTWN4bzBrcU0yWkg3dXg3L1JDOUl2?= =?utf-8?B?R2o3emVneHA1dGp4eGZvcEZDbnRORDMrS2JHaXppZkpXZU5lQkpyU1ZNZisv?= =?utf-8?B?cU1oQWsvZVdtWWZybnU2NjBKN1ZjOUtXZCtndnU3RUxyZE5Gb1BwSVo0RENU?= =?utf-8?B?UGlSMGZETTJXemVnOG4zZHVNMUxBTGVVUUNZNFFZM3hFNjMrbWRZWUFBN2V3?= =?utf-8?B?b25oenVoMkpYY3VtaEN2bkxnMWhaUVRhQU1ibkEzSWMxZ1Fyamp4TFBiRXZS?= =?utf-8?B?OWtqVjkxaE55bXJjZGN1TzdjVklaUkNzU1BjRzdpWnV6WSszSllxRitKeXFZ?= =?utf-8?B?bmQ0RnAzWkVOL1Z5a3kyNVZ1U1U4dzNCOHdxYy8raHBYUmJTcWlVOCtwTDNa?= =?utf-8?B?VVgwMTFZaTFiUHg1QmtoNHJFby9TYnBOaHRBbXd3SkZyZ2RqT3lOaG45K2hz?= =?utf-8?B?SHNGdSs3ZmV5cnNaeGRFMzRaUTRTWWJ4SkZ0c3IyRHBleWY5TnBzTlZXcEJW?= =?utf-8?B?TUtsWHBNZCt0L2Qvai8zQldGSFNkK1Q2dW50ZFcrUEVPZE0xVklicTUvTHFz?= =?utf-8?Q?ZZmIbdEKnYNLmuZYPt+k2Log2?= X-MS-Exchange-CrossTenant-Network-Message-Id: d7d507eb-741c-4238-f524-08db3fb59cc1 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 02:35:46.0517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2xb2z4Ep03QkyMORgmg0f7k4/BVisBJZ/OnygkJR6aVVAG8MjczZajOzmI0joYMWQvBmCQE/lI6AOHdEqwSNXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4766 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DAC59A0005 X-Stat-Signature: iraf3az9oipudppxgs6iw4dopw1whsrd X-HE-Tag: 1681785361-56389 X-HE-Meta: U2FsdGVkX19jpPXCpDPzJ37yd+ST2BDGjV6Q0fRrIxsIHDE9CAWTkva78bQis+w3JFxT/HltPBuo2UJ6WzbPEWl1YSq0ctdYyQOTPwMQTl+RDtjtGazLJhA68z8csEWe4N3aT1PdBeUOqJknayBfanCIxYCg9jTYzcF9XEM8s77HmnNff0DPm/tJoxnYbqIRZ0lZ3BVOzHw2b0XpmRirvU1287g68G2M+nN0yPzItrFsysHBU/kVes9NTIxIyGyGYdRPVMsOMuywITbtYqen3NdCD/2jZAJ0ZriD1lKaZkgjFKCUrcH50cOMROqqQijTD/GM2VpLWKiEwo3+54Mt4tUpZrMtRObnUCnY2q6bZJRid2wBiF9cMpUr/D+upDCnhX3p4ULTpT16C6fp/nvF+DgO0mG/l6D57ANp24mcBd+ORx7hv2VoCXKa4IzcUIiaOXKH2/JPZLSmcBBig5K22HOZa6zvPEYaQN4Xu+szt3pAP2F/U7U4UbmKGvnyzNUJ4iDsML0FoinyVNyGeG8R66p4lVBQ9rjqVLrWG/xe0nwrtFDm2oegrc3BtSEXcT5nW1GFpRXRPWE9cWUbpGtKfcEWDgGNQzw4RMzqr8c5Lm+2xEtt7kdnJaQGAYyxv5Ezbo6R3J7IxcNU4COH4ZMMO5dc0Pa1Y2gQrE3c5FkzKAKVjA7ajTYi7b6J0b6INDzhHlsyuhsLgUF0cSrAmrk+DT3g2yWbk9hvFX/u8LppY2KE3BBlZhx1NHjKaRblPuRE7UrIoA6JYyNOorRr2aT7pOq7bQUVPIh7HBJWpqy6Pgi7knhvoYoT+K/oVIJ71rpqZATznWqmFP8qcb9bZINHvAGJExHmx0CKVpUFn0m6ViLwlCS7hXNKPzUZAx+t7MSNM2J+C6tZ2MkzDm9X5YVBMY/4KN3Zt3RB7xRzBg2MFAXqv510EFv45KSGYZbANBt60tKGJLE+MGUGzejL3mj 5qFOGXu9 vsVrGDYbWuQ2g0iRMm4C9+hEyB1/WuCxuFKMSyNtZh/gWkuvO/RSQ0nwuprDTqs/56ZQuf7+oLJt+GTfcR36geg/aYAvMLPFrU8iQSNxRSHZAJLHExXMta/La/QekAvFZkvtpPNXv1/lou8m2w6ajqqTqa0fA5ZM0AZifuw/00EfPvr7JKc5puARivOipeP2d5SZ78GZOx5/V7UhtudOqwAeBhGtMDMIcjBbWmtDb04xPGuRQqQqfdCEK3/WeFJHkK1VovMXenNP3X7ljMHhEkFjpivvhk/yc1Am8/kRCwRLTwOQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add Ying who found out the large folio is not batched added to lru. On 4/18/23 09:57, Yin Fengwei wrote: > > > On 4/17/23 20:25, Matthew Wilcox wrote: >> On Mon, Apr 17, 2023 at 03:56:43PM +0800, Yin Fengwei wrote: >>> Currently, large folio is not batched added to lru list. Which >>> cause high lru lock contention after enable large folio for >>> anonymous mappping. >> >> Obviously, I think we should be doing a batched add, but I don't think >> this is right. >> >>> @@ -54,7 +57,12 @@ static inline unsigned pagevec_space(struct pagevec *pvec) >>> static inline unsigned pagevec_add(struct pagevec *pvec, struct page *page) >>> { >>> pvec->pages[pvec->nr++] = page; >>> - return pagevec_space(pvec); >>> + pvec->pages_nr += compound_nr(page); >>> + >>> + if (pvec->pages_nr > PAGEVEC_SIZE) >>> + return 0; >>> + else >>> + return pagevec_space(pvec); >> >> I assume your thinking here is that we should limit the number of pages >> in the batches, but I think we should allow the number of folios to reach >> PAGEVEC_SIZE before we drain the batch onto the LRU list. That will >> reduce the contention on the LRU lock even further. > > Yes. The first thought in my mind was to limit the number of folios also. > > But the concern is that large folio has wider range of size. In the extreme > case, if all batched large folios has 2M size, with PAGEVEC_SIZE as 15, > one batch could have 30M memory. Which could be too large for some usages. > > > Regards > Yin, Fengwei > >>