From: David Hildenbrand <david@redhat.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Michal Hocko <mhocko@suse.com>,
Oscar Salvador <osalvador@suse.de>, Zi Yan <ziy@nvidia.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 0/3] hugetlb: add demote/split page functionality
Date: Tue, 9 Mar 2021 20:01:29 +0100 [thread overview]
Message-ID: <dfd59d83-7916-518d-23ce-a9a4e6781918@redhat.com> (raw)
In-Reply-To: <777d3771-7d2f-8e88-8496-56440e195a43@oracle.com>
> I need to take a close look at Oscar's patches. Too many thing to look
> at/review :)
>
> This series does take into account gigantic pages allocated in CMA.
> Such pages can be demoted, and we need to track that they need to go
> back to CMA. Nothing super special for this, mostly a new hugetlb
> specific flag to track such pages.
Ah, just spotted it - patch #2 :)
Took me a while to figure out that we end up calling
cma_declare_contiguous_nid() with order_per_bit=0 - would have thought
we would be using the actual smallest allocation order we end up using
for huge/gigantic pages via CMA. Well, this way it "simply works".
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-03-09 19:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 0:18 Mike Kravetz
2021-03-09 0:18 ` [RFC PATCH 1/3] hugetlb: add demote hugetlb page sysfs interfaces Mike Kravetz
2021-03-09 0:18 ` [RFC PATCH 2/3] hugetlb: add HPageCma flag and code to free non-gigantic pages in CMA Mike Kravetz
2021-03-09 0:18 ` [RFC PATCH 3/3] hugetlb: add hugetlb demote page support Mike Kravetz
2021-03-09 9:01 ` [RFC PATCH 0/3] hugetlb: add demote/split page functionality David Hildenbrand
2021-03-09 17:11 ` Mike Kravetz
2021-03-09 17:50 ` David Hildenbrand
2021-03-09 18:21 ` Mike Kravetz
2021-03-09 19:01 ` David Hildenbrand [this message]
2021-03-10 15:58 ` Oscar Salvador
2021-03-10 16:23 ` Michal Hocko
2021-03-10 16:46 ` Zi Yan
2021-03-10 17:05 ` Michal Hocko
2021-03-10 17:36 ` Zi Yan
2021-03-10 19:56 ` Mike Kravetz
2021-03-10 19:45 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd59d83-7916-518d-23ce-a9a4e6781918@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox