From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 987B6C83F03 for ; Fri, 4 Jul 2025 14:20:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 354B76B8056; Fri, 4 Jul 2025 10:20:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32B856B803F; Fri, 4 Jul 2025 10:20:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CC536B8056; Fri, 4 Jul 2025 10:20:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F41FD6B803F for ; Fri, 4 Jul 2025 10:20:49 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9FDF759813 for ; Fri, 4 Jul 2025 14:20:49 +0000 (UTC) X-FDA: 83626793418.24.3DE40B8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 2935510000C for ; Fri, 4 Jul 2025 14:20:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B6567hTu; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751638847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FPWR8/6FevG48UmfkMhjqNTe4/LZAWg9DvTsvfd8iaY=; b=68nLsj9RSprN5S8D+ceKnOEiZENsTnhj2QhEJRPNawhG6Zw5KQIJ/w7DJGefqImEkaURNv izCPJ8/9gzyhh4xs74PbvxJ8xGjF5nvRd3mfgkjhn7b82NsJCVnYO1jV9ZP5BEu2uSKRKc saJTBlzC16dUGNf+4Qsmry8tEtGE4q0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751638847; a=rsa-sha256; cv=none; b=GbHNfnd4iQi8TN253wdJZ94vZ7ypgQX/onTSfFIpjyb9QE2BHyiJPAzDfGYzVbpns6PFk/ r7OHLmQkAlLaH7c2cP3GRR9Ov6HS4cU7Zh6U5f8C/n1MpwPS0HWaIUIkOjLV7iUKw28B31 3yI/bXsc57l64fK0pFRjjcIGwguvX0c= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B6567hTu; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751638846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FPWR8/6FevG48UmfkMhjqNTe4/LZAWg9DvTsvfd8iaY=; b=B6567hTuWBRAOI6IQbQDGGwDpG0STZ9NVpasVvL8/S6sUpDADWCP3dwqdo7njZAtE7nUII AHLfzhfcYOHCpqJ9YDASAHC5pmnGAp9pJiPaKs3aNmR004lenltWgREHeO/UR4fAuph4k0 o4CHWGHqjMmkZ9ivddZkNGTvQ7Mow+c= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-iIbIglUIMvq0-yqQ0EPw4Q-1; Fri, 04 Jul 2025 10:20:43 -0400 X-MC-Unique: iIbIglUIMvq0-yqQ0EPw4Q-1 X-Mimecast-MFC-AGG-ID: iIbIglUIMvq0-yqQ0EPw4Q_1751638842 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4fabcafecso494553f8f.0 for ; Fri, 04 Jul 2025 07:20:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751638842; x=1752243642; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FPWR8/6FevG48UmfkMhjqNTe4/LZAWg9DvTsvfd8iaY=; b=deWnRZsOW8V3QonHGYvMIw3J2jhJ/UsM3TNKBx+ESECcVFIpVAznFRU+NmkpEkxhBk 0MQtmhW695YINOOk0z7uOU/JA4fQ5JO1oNJlOc7jlnpfdikwNlo7r6DGVpZa1asT98HT tsN8oFvX9lCirajLOolbZVLGtA3Jqxo9Fll0ehXMMueJdnDnjPv6YMrTaYm92ux4WBeG zrH4HNctSmYCmxMa2WH6thT1cy4fsH+o+EgXXSNH4rTKgoZiGWba9ZUxVbHGg/E8yhDv ui6ilKDHFjNtIQXgRRLVibpDHGZ/QskA2mtS0c0pwgD1KzBq2AQkVUqdW5uDqKC95ZxB Y0mQ== X-Forwarded-Encrypted: i=1; AJvYcCV7ucQ48Cd3NniQT0U5lP6Orih05BLbfnuue52/5MzBy2qUYAcin64uYIPvOP3/VW6wceZwNcg4Qw==@kvack.org X-Gm-Message-State: AOJu0YxPGeI38yoXUAMQEsNuxYNJ2Thwd31iacjt2CSglw8rVVK9r+7v QREBJYW4huRt3pQgiSTzq8F014IpxEr7X6gDlKzw/PiFnp1OPeXZsfQk8Ea1Rjh359YbTil20OH wSbY5p7c0ytobYkAIYeSniufre1fl05FIJKLiU3c+MyeOw30asKrd X-Gm-Gg: ASbGncsh65zTGLwVEjEiXXjdWV1za+zUPDTeA7xiMmtxrrQdQcCiukfoDPa9pQfQzEM Tix54xav1GF8wrOgRtFWS7adE4vgrR57fOX1Uei6R+q3BevXqNueuIKuSTpY1PSDVyHdN1KvKuj uVsKqAOKQxhW2ew32oDnjntXjMYQknWp4pdBPPLNNQiVk5PIWNG+Q2fTG4gJkuIjgXqFTHW90R3 /zfFQpL/LjP9c5WsV7SgMizasfuCc0KN0cNvEl1abmNEP7WDt/2uBquXejW9IWWvCl/SgDbNzZJ W022bKRse19tPZUTK/wJDCljhgWvXPT/rp25Qs8rgwzUGzx7AmWtodBTgl2V45an3Ur6Yo0bZ8I MqQM3dzpHzKnvWZ/2+7pD62pgDX5k52AccOYgbkHRvQAse/U= X-Received: by 2002:a5d:5f8d:0:b0:3a4:f70e:abda with SMTP id ffacd0b85a97d-3b4964eafb0mr2523311f8f.10.1751638841935; Fri, 04 Jul 2025 07:20:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+/kiTWcuui6KC8nKQ4kO8+DE7sHGdoqJ0Z4Ks5m7aF9X96EBl8jRZQtA50Mb5hMtiVeqQ5Q== X-Received: by 2002:a5d:5f8d:0:b0:3a4:f70e:abda with SMTP id ffacd0b85a97d-3b4964eafb0mr2523272f8f.10.1751638841478; Fri, 04 Jul 2025 07:20:41 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b161f351sm28210535e9.4.2025.07.04.07.20.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 07:20:41 -0700 (PDT) Message-ID: Date: Fri, 4 Jul 2025 16:20:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] x86/mm: Disable hugetlb page table sharing on 32-bit To: Jann Horn , Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: Muchun Song , Oscar Salvador , Vitaly Chikunov , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dave Hansen , stable@vger.kernel.org References: <20250702-x86-2level-hugetlb-v2-1-1a98096edf92@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250702-x86-2level-hugetlb-v2-1-1a98096edf92@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FKvclnr-CRnM5vx3D1i2KNYUrUEUU1rAbDzj13Bmgv8_1751638842 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2935510000C X-Stat-Signature: d3ky69fpcqwk9rsejmqnqunrco67m7n8 X-HE-Tag: 1751638846-654147 X-HE-Meta: U2FsdGVkX19JTcwTteYaqytzWqYedi2xnxIPxEnMs9auRKOwA9qdrf0OWqbZ1ToLDUraeRryoWgQa/BfbI7pB2JfJ1KDtK6cjUZx0sSXCiUnERvAcxni7dZ8nnuv+5ipZU0T6ixTa2JAOVZIo7z0mhMN6pTe7Yre6gKFID7k8btXAw9ASSr+DLGd9AUpxdbU8p3mmM/RMDn5FjP91pzOFRHvNAZoqVGK3Xch/KRnmdxkITHLcdm66n99SEtPq0eBrQH/7pPM2wGCXNTo2wwzlTkoqPP59eWX0vTggxMMfsiYZsVkCGvdNAv8P4qvGJ+u4SoaB42NfXsoykohZnHRALLdmkRFY27zPigErel8QRMh2cjzrUe0KDLf3iKpE7O8mVgri8fOD8J2hOVX1bwapOzMOJYnVkr4FlZLLwJMDfLBpYsRz/Q37YOa/zKngmxGBWby+QpJwuKplNEPHtIyc0pvnlTCBBpgoW+FYQyPpJu5XKM2Jp6CGXq8bvWRnZTiT3EJf2e0EZwOUSnf24pXE7nlxzvLZx4nsyqPLH4YnL7YziqtcAQndM9wRkidxzz52OBRCyMy3U4Mj2x3hddZD0k8QzEy3u30E7tuWlVJhL1V+AmWNg4sCXU8/EZ1W7bSsFKzSqIbMqtC+e5sdmB4c9LxTRf9TNOdap5gJ/PzluKF8bTVzFNgMloma1cNKG472x6B9y2BmTq8A/WQh3+bJjgWA2xvItdkihJtTl9i39AqrrWPCimx9jsSg3lqFTk6257rfdYMHxRFhJQGdptNdU/vGXE6LvwXExMv5GahRBgOm5VVsUjRFpemPRbcMP9NH3LaxHkq9u3srIBc6tUDBT2t9TGGnEVaoABLfi8AYYp1jzaE7OoGfqHs4NxEuBKdqgEXq3U8AHRg7hMDVOu7OZXF0UKTKgVi9ZFlMSqTjCQv6Thn3zRuC7J0njmlmMVVoKMzExAJp7fkn3vqZyf R4zKr5H2 DwuTGUQwt2/9fhmxKCWbjqdVhW8x7DMvQbolHplXeRto5KSYXPjxPRSCwkg/g7TcyVPhvN1NgEvIo0ZdUFHYV7R5CqmgtN6kpK6XPamS10MV367v6wsQb/nAnau7OGE/fEvuHu3AMoYywfWLn5eUVKOlWsj6sbFkWhmmfFYAhTk8WqzebhfKtqLy5S3NN1n/aMe81iXELhq6m5qJGa1aflJpREoIvZd2zcKZDe9mBB5/K7+GY/r3YWt9rgzcyuYPEYV2KlUaLGoHo9pf7Y0gt3JUJtPrR7amjVbZwhlznTdjA7QwzXf4/cmLv0EP2nkk6rlF1+vN/m+jweCnb8BPaSgN3u8d76W1Exi829Vi+TnymdxYEsU65KzwHx6hmq9zByEMSANXIePRgLkY8gs9A+tgr9kjIhsOy/YLIyFlbhiYn0TzysmAwKYQlNWqBEeGfjP84RJMeaK/uQvPzG8l+nqOOjHVWTRWgwuB9D0LWhBS+IxqHBH3ptPdSHWjlmPSgPtWdikuB9FhDjkYeV12NMFD5mVcn04J+MEqvT2/zQ4IkLewOu3cMWLBFXJ0o6/BmOD5KBujSvhyUiCQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 10:32, Jann Horn wrote: > Only select ARCH_WANT_HUGE_PMD_SHARE on 64-bit x86. > Page table sharing requires at least three levels because it involves > shared references to PMD tables; 32-bit x86 has either two-level paging > (without PAE) or three-level paging (with PAE), but even with > three-level paging, having a dedicated PGD entry for hugetlb is only > barely possible (because the PGD only has four entries), and it seems > unlikely anyone's actually using PMD sharing on 32-bit. > > Having ARCH_WANT_HUGE_PMD_SHARE enabled on non-PAE 32-bit X86 (which > has 2-level paging) became particularly problematic after commit > 59d9094df3d7 ("mm: hugetlb: independent PMD page table shared count"), > since that changes `struct ptdesc` such that the `pt_mm` (for PGDs) and > the `pt_share_count` (for PMDs) share the same union storage - and with > 2-level paging, PMDs are PGDs. > > (For comparison, arm64 also gates ARCH_WANT_HUGE_PMD_SHARE on the > configuration of page tables such that it is never enabled with 2-level > paging.) > > Reported-by: Vitaly Chikunov > Closes: https://lore.kernel.org/r/srhpjxlqfna67blvma5frmy3aa@altlinux.org > Suggested-by: Dave Hansen > Tested-by: Vitaly Chikunov > Fixes: cfe28c5d63d8 ("x86: mm: Remove x86 version of huge_pmd_share.") > Cc: stable@vger.kernel.org > Signed-off-by: Jann Horn > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb