From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80691C369D3 for ; Fri, 25 Apr 2025 15:58:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B07E6B0008; Fri, 25 Apr 2025 11:58:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4600E6B000A; Fri, 25 Apr 2025 11:58:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DC1E6B000C; Fri, 25 Apr 2025 11:58:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0FF606B0008 for ; Fri, 25 Apr 2025 11:58:27 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6A14D1A1B7B for ; Fri, 25 Apr 2025 15:58:27 +0000 (UTC) X-FDA: 83373023454.02.460D7FC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 1494920015 for ; Fri, 25 Apr 2025 15:58:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iVYbsNEE; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745596705; a=rsa-sha256; cv=none; b=RVAbjefeO2up1H3Gt5OZuqXMg3P9ZUUE2i94XMumxux2CawwAZp4k83mpqcj9ik2D1jIlg Qtoda7AcAI8RSAIiHOBUeRbfDWOrkEJeIv5etylonAS7DaeIL4gW0yYSr6UZ7zqR29sEH1 HugTeIV+FrfgdiZpKrEV5+SiUcdFFdQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iVYbsNEE; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745596705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dlJYDwbFFHt9mjy5FeeoBwjn/d0ty4DWBjurl4PTHGQ=; b=xQrpFO5iN2ZSlz1fjRx1W/rAHJDKA/61mrr2pqsheEdNGItasTN5MyYSrZUqjC1lAwZnpJ GLnlaByi2rv/EhdlAyLeIRGT9JW4UcfPKGQDgHXz7DZrv0K7awsfNE2ycslzYLWU796g/f iNKTFKJVeOXN6bAxWFZR8V5BlTb30Qc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745596704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dlJYDwbFFHt9mjy5FeeoBwjn/d0ty4DWBjurl4PTHGQ=; b=iVYbsNEEnQ0I8t74Wqwi3adBYMNqoxEAyQ+BIlzPc5POL8xtx4v9NqApmTzkvPYoF5bhgP QxNXFFp0SqOayQ0naZPM7WTKbbuFmA0qk7pUr2MlsSb6iB78lrb94CIW9Smzy1rUf66pVm cRc6PUW5YmT7a+zekpQN0QRX2WFOOLI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-iTKo5H9IPP6Fvzby8RNryw-1; Fri, 25 Apr 2025 11:58:22 -0400 X-MC-Unique: iTKo5H9IPP6Fvzby8RNryw-1 X-Mimecast-MFC-AGG-ID: iTKo5H9IPP6Fvzby8RNryw_1745596701 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43ce8f82e66so11962665e9.3 for ; Fri, 25 Apr 2025 08:58:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745596701; x=1746201501; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dlJYDwbFFHt9mjy5FeeoBwjn/d0ty4DWBjurl4PTHGQ=; b=MXmByhI2zsDuhBNEe1nR/9Wt6URbyM/JWthYFmGJd+N+TL3AYpHHFrO/wtvbhLSLr2 nIZD2BnTAF+MmETxD0dnQb9FDbZnXvp7lcK5iP3iBIlNNcsVM/NdzIIHrMKyPt7hcy75 L2SklnUCmpFSsr/Y2aMzaROQMd4bltsXiHlXOyT/+QJz8Tgzdw+AS6d7YP15tfG52SXZ HCRUZ43xDzavxEVtAgMLrcjM5Q8ZXLHV79jFt1gvapCnb9Y9+rOUbNWh2CR0MbTyq81R e0Y2SkEM1svpYSjG5NEPPwkXxOSVvNqR6acHrHCg+jchMZzhTmhgFNCea61jJ4+SZM6B OiRQ== X-Forwarded-Encrypted: i=1; AJvYcCX79TMgvWmvovvwdkGoYjrFrKZeOcgknZMAv/70i14Fbii6Cnkmh0xpsW/HWDmbzZ6FO3RHodRVmw==@kvack.org X-Gm-Message-State: AOJu0YxiV1/IhegS6yrH07qkLlkOez9kS8DOca1Tr/FEOHykEPFz04Wa z3yG1zQxvN+VME0SlCB47iexwHGSeONSlHiyL/Pytxb/zh7FM8vA/KMf1zW+Tq52JZL/7sOKJ7E hAaJOdCoCj0HOQYPll1MxcQr/Lw5sniXxDo5AYQxkzjWx9FCy X-Gm-Gg: ASbGncuBIfxuSNtl3SXLYbYdk3eOPxoHKmXXq4aYLd9yeoUhjcbDxYI6ogipHE8JXto egSzH+dDXf7jD2vjfEEzdSDuJzAql8wzYy3+JhDOtGzhRirkqwfnbplhuui8gJf0WZ8KD15yGDw S9L+V4oEs7H1yBPP4NFN0HqBGMJNquuCs8cG80F5J9TXqwBa07qCl7k3eyfejPygh4LIqeADu0/ aaogFtGNlzhDJUf/xGryJczevu8v0LYBo0IHP/7UeBpKZxqFQh2KiK+98m+A+a2KU3yR5jCZa7n Uu7tQOmi8N8lsICTeEzRNgJdpBR0kyHPK/9wkaDlpAd0Wz1aW7SY8ncQu8EK5JFatYU4VZWDf+g GEL79FLXkL3K98OKbsa1IUndRBOtxaAsINVOa X-Received: by 2002:a05:600c:1c91:b0:43c:f050:fed3 with SMTP id 5b1f17b1804b1-440a65dedfcmr26860435e9.11.1745596701012; Fri, 25 Apr 2025 08:58:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGf/cX7CKiG2B5aqouPDe8G518RQAT+gieqSXtXcKyyNhh6mdgrU9lR51b+m2trr5gamUeeMg== X-Received: by 2002:a05:600c:1c91:b0:43c:f050:fed3 with SMTP id 5b1f17b1804b1-440a65dedfcmr26860255e9.11.1745596700656; Fri, 25 Apr 2025 08:58:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c70f:6900:6c56:80f8:c14:6d2a? (p200300cbc70f69006c5680f80c146d2a.dip0.t-ipconnect.de. [2003:cb:c70f:6900:6c56:80f8:c14:6d2a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2abf73sm61323305e9.20.2025.04.25.08.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 08:58:20 -0700 (PDT) Message-ID: Date: Fri, 25 Apr 2025 17:58:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] mm/userfaultfd: Fix uninitialized output field for -EAGAIN race To: James Houghton , Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Rapoport , Suren Baghdasaryan , Axel Rasmussen , Andrew Morton References: <20250424215729.194656-1-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rZGJ3HSAE-UM-YTMvrJinR2zPuDG9SndJXSrTz1ZmnU_1745596701 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1494920015 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: jci7au83iqqxh7oqcybcec8s446pjcwq X-HE-Tag: 1745596704-723787 X-HE-Meta: U2FsdGVkX18j+yGD/XP7IH9EE7rA1Z7uKpj9EtiesckEi+U+eQWWAom7zM4WGAmNS7rPPqGo8PHMEScHP+c0H7XhIGFPg8TYX/XYKJeyp0R6oy0LmYY+JsK5ZEKD1S8Oa68U+ba8HJVKLkM98IJWU9qXGpzD3RoMeTGY9UeUFkHR01J+a9A4ungOtiPotMLZLCuwY1kU24ZZoGApzVin5wlJPy7v00glSl2c/UnE4m7hixZXeHA/UEPVDD3XO5bJE5KK6b99QOaF54oDOY8cDM4j0hoQU+Omh1uteX0GolWh0DX9dIozanPp6YntAZTx9NFxvxyhGrQGnRDBq7nwiD3aTSo1cupdtMvOdDn1Zqe5iikSGHAUOfETI7rVFJBERdyByfSr6JUlf74l26nN0r64Scn1AUrrnhi1MFi/urPyeUiNRNuJeSvp0StFH7YtER+xjfa0L1dk024fiMoE7mhvIHo+r9kWJ4TeBg6hgRY/OafmNzmfR/Q/ATPs5uTB3y6PvDvPdMZ/yBG/3ADEE/9fggSy0zSbCL5UArYmtK+az6VC5lhafUJUENlbHBzyehlX//vsEHKpIWEnmE9l2LQVNWv/dqmDqgEJq7+FkftncAb97ZRRrMv9IiiA3pGYVZtn3U20PazKtZGqOXA/U4bm8lzmF/ygVNu5Xj8Fa0o+Dz9fKK9Sl6cDntlvS02cB8t85E3YZJjKhD7CGdnAlWeA36VOPxF4NavOg9YAR+2XuJZUSX1U/eSZl1zrhHQz7ZAM0MDZsqw4JZ2pZfxxle3zLghZON62oM4gIV0wJ6poPjFJytVMJ9r9u8ZinMckxdC5pfF/IWyxGzXvrI0Pp3zA28qcSgdmVCNxPSGoWFkQIO1bMjFS8OZW0+AhRUTvrs0WVFLepqBluusUsxCxCdSjIVOqkJ4ltbZj2V8gePOH/zm5r2xZXH/AYLFs3P5m9F7w2ooTlL10MBV2sAM Ck07bU9c +Y04QKW/dQ9gusKQyll3B9wdBxtJYMoPF6w6Yi5fqBRSE77vBaKf0uab/rHIVygtQT3HJHnSEVHEJsqU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.04.25 17:45, James Houghton wrote: > On Thu, Apr 24, 2025 at 5:57 PM Peter Xu wrote: >> >> When discussing some userfaultfd issues with Andrea, Andrea pointed out an >> ABI issue with userfaultfd that existed for years. Luckily the issue >> should only be a very corner case one, and the fix (even if changing the >> kernel ABI) should only be in the good way, IOW there should have no risk >> breaking any userapp but only fixing. > > FWIW, my userspace basically looks like this: > > struct uffdio_continue uffdio_continue; > int64_t target_len = /* whatever */; > int64_t bytes_mapped = 0; > int ioctl_ret; > do { > uffdio_continue.range = /* whatever */; > uffdio_continue.mapped = 0; > ioctl_ret = ioctl(uffd, UFFDIO_CONTINUE, &uffdio_continue); > if (uffdio_continue.mapped < 0) { break; } > bytes_mapped += uffdio_continue.mapped; > } while (bytes_mapped < target_len && errno == EAGAIN); > > I think your patch would indeed break this. (Perhaps I shouldn't be > reading from `mapped` without first checking that errno == EAGAIN.) > > Well, that's what I would say, except in practice I never actually hit > the mmap_changing case while invoking UFFDIO_CONTINUE. :) Hm, but what if mfill_atomic_continue() would already return -EAGAIN when checking mmap_changing etc? Wouldn't code already run into an issue there? -- Cheers, David / dhildenb