From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E571C0218B for ; Thu, 23 Jan 2025 10:28:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5ACC6B007B; Thu, 23 Jan 2025 05:28:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0B0C6B0082; Thu, 23 Jan 2025 05:28:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A84236B0083; Thu, 23 Jan 2025 05:28:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8A2E76B007B for ; Thu, 23 Jan 2025 05:28:10 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CFD6E48316 for ; Thu, 23 Jan 2025 10:28:09 +0000 (UTC) X-FDA: 83038341498.16.7B61964 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 4D26F40015 for ; Thu, 23 Jan 2025 10:28:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IdIy74k1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737628087; a=rsa-sha256; cv=none; b=apFfWNR/RmikW1wrbaHJBSawP2MkdlvX2DU9im52ePTuIpsDmYI4IR5YK+dgnFc9mgcshW hVKB7bq2FPPXrty9yy6yjbNXwdDG17HVBczyOGUVr2dbfoC/YCrScbipKVBU3nsKADdti1 7f60UPMCRP6Dw8vKwVjxH7ary8HA7Qw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IdIy74k1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737628087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FicqxSIae8HOyLpVsGZXZRg0Aah4bpzbFXJtjgPh3WI=; b=u1+Qe7bnyLPLkpeVOoOytWy4RUMZa6fBIB3synNFDl5J4EAcQIuWjqrEL2EK3NoEHK3rP8 8vyO13Ww0cgwCaw8hmTFp6SURJQ/Y+dxBuswgRvZS3NV8zkizCT33ctsJjluXOKrcm5Bu7 W3a4cGuMQJQb14OKdJZ7o+axO8Sg650= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737628086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FicqxSIae8HOyLpVsGZXZRg0Aah4bpzbFXJtjgPh3WI=; b=IdIy74k1aXBZas0AATIBpbTdspRjHYR24dMUKQqhfACpjDEpBhTbKXWPAEz1I6nivTB86a 6acXJTEuGK2k8/AJm0wCsByEnaFJAFNBUxPBBSoKxdVoHn4a+1XBJODyQZtA+VUCiUtVPb qvQ1URRyd4/wW4/D6E+PhN8hBUlR9EA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-wyQx2ulFMHaYa3FmEMBE2A-1; Thu, 23 Jan 2025 05:28:05 -0500 X-MC-Unique: wyQx2ulFMHaYa3FmEMBE2A-1 X-Mimecast-MFC-AGG-ID: wyQx2ulFMHaYa3FmEMBE2A Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-436248d1240so3471425e9.0 for ; Thu, 23 Jan 2025 02:28:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737628084; x=1738232884; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FicqxSIae8HOyLpVsGZXZRg0Aah4bpzbFXJtjgPh3WI=; b=fAY0IBLI5rQn+nmcU/F4ZUXjvUNg1Mxox0wU/CAGWi1YR0bgayUucJs37lCrU0e8qM e2fRmADlPaHsX8hO6yJxwSu9gtd9OqkcraFVMh+RreGkRdxQyrrXNeinYDwFAdXDAPYE DnkX+OlUbRfp6Gr5QueD3Kcs+ZbFSsuD1G6C/QyvatqYgFj0V2/Jk6gyhBhDMMb2Hog3 Xi8c8AFT6pICUFSuq1P9wocapqXDJbFyz3VVmW/sCJ59feRfK49ak7glRd5xWlPFX0os O3FzV8owBUr3xK2LMj/ttNNU7wlj32rioLSoG/J2edcv+9gU+z3sEY85gHXwUbu5GX0b ne/w== X-Forwarded-Encrypted: i=1; AJvYcCXaXrdcexX/kmzgJh/8u3+opTapx6v185q93xDJjXC9sUpeJXhJSHsxqdHjRe6fYiPDUW37nm+Keg==@kvack.org X-Gm-Message-State: AOJu0Yy63dWZwtvflxwPcSbSnc3yaVGpit+A/V1ZewIH316DleB2jAbV K1LXk/P3u9DlrZspFDt4tEsyfEnV7ccXp7c97/JBswtxDYgTwBwOUzOnkKW8NvD3lPHABsFAoPE TeTVmzZ5+alU3BqRZ+okTgXZ25WM880+ccR7KT0Z0f7ivYvHq X-Gm-Gg: ASbGncsNEyX4F3cpSiIankjFFLaTfZY79kWoAKzy08PRBbtvvAqzfuNBGYI355owCS4 jViPAmAbPQzR+J0AqDhAgh3agNSq5pWzFdZQfJuuNp6XLm8j8UCHBhQTLF4eYnHVpJnLVBD97Cs haUrxqmDMcDOZbkFBO/U4y+nsZb9qSb0Q8SZZ6g6zVJ/zYc1kZ8nsL0SpGJigqIkW7OMdnxx3++ Zw4VjVSEpwuEtYHE0YI80Bl3YDfcR1UufjojBHzkEErNkdb+ojzw3AedRVmylca2/vQalqo2VFX X1hgIRHCcdbEoNDR3HChlZxyyP0FBOfVK5u8WkjvuZ+kkss6xnvOlYgiPHHqDjFEEU3QbXAjlTf t7symyufLS2ZO/v7fNdAI5A== X-Received: by 2002:a05:600c:4e89:b0:434:f739:7ce3 with SMTP id 5b1f17b1804b1-438913cb518mr229843505e9.8.1737628083965; Thu, 23 Jan 2025 02:28:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6vbH7yMy45to2djiY2Uojizp16OLhYfpBeVdmBjQkMYn6DUvSgIBC78DLFl1W/RdKbixRfw== X-Received: by 2002:a05:600c:4e89:b0:434:f739:7ce3 with SMTP id 5b1f17b1804b1-438913cb518mr229842915e9.8.1737628083486; Thu, 23 Jan 2025 02:28:03 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:b400:e20a:6d03:7ac8:f97d? (p200300cbc70bb400e20a6d037ac8f97d.dip0.t-ipconnect.de. [2003:cb:c70b:b400:e20a:6d03:7ac8:f97d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b16ff48esm42826635e9.0.2025.01.23.02.28.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 02:28:01 -0800 (PST) Message-ID: Date: Thu, 23 Jan 2025 11:27:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 1/9] KVM: guest_memfd: Allow host to mmap guest_memfd() pages To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com References: <20250122152738.1173160-1-tabba@google.com> <20250122152738.1173160-2-tabba@google.com> <647bbdac-df82-4cdb-a3e9-287d439b4ef7@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SLkbzm8rTOHoVIx5biX-YJC5CpaVWD1vMRMTHTd8iEA_1737628084 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4D26F40015 X-Stat-Signature: 4ymj4rx13rehimssgr8ytdzcoba79p9b X-Rspam-User: X-HE-Tag: 1737628087-699340 X-HE-Meta: U2FsdGVkX1+wxpIqMfAm+mImKAsEQzDs/g6/8Jokx1mRo+ZXSQa2GMM6BG1Gj+YWgFn5sjSD843CumT+Tus7Ycqu5nCPd8119vtWljWAKkqoe7FHD+Z2C0HP/TCqoGfSbjZ6AEZNbf8Kk3cXIaUsXfIbOo7YLmiNyUh81m+rX3EyivyejCPKKoSc3srYvKRN+5aORpJctrnLcriIarb+s5pPWAmaMuPbzFr9phCQaLBxiu99ijev/TT0qYsR2gikUpliUf799Vh9uA3jSJAXTiny4P/tDbpWioq7BDt1kRfHAPNb/VvgkwNXShBNxgVgoY7J0lOIhgQpoR5k5X6fOOKB7jELM9TDLKdnN2ZrqIr8OFhiYRu5aXbI2Sry+i5qZ+xg9lfGTgwxLSiKiRep8VzT+Zlvw2yUIUDeRBz0Qiq1inxIaQ2Lz60QbUWudqWXut+1G4O6s8/qDfHPbJLqQ78Az4RDujuDWrOPFAY5QMGCRKYVSg0KdPiCCk8Wwd3tcg6zLZVVfLfkX+dTHRc/Zz0T8ssITaDo/M3x+K57zQc7IFMJl95MqrwjnhxvHOif3HRBTt3f2RfGh7NhPDRhcCjFNzkkXWUtbH29/BQhLTIREJrG3slUYzt9EgZ4D3UrDA/IXDd+Z/OO9QuywaXHt4oT7zRyjhOw7yOQXdXiMjjqEy/lEsoJdINnwkaw8kb4DelSsP85TiOu5tcRQRO6W39m3XnuqMe4wh1V32s4MTi4se7aaweH/anvsRKTbqlAfCvyr/9L4HIjNDjhLYiMrhaFnZPc3WpuqqyyJBN2grMSrlDknBhm6TaLAvmjbzTefVQgdNtmo1LY+Vxyn7pT13e71OyvSXGoUzoXTpG9Orthy9Qsf10DTDCCjrlHWcm8iE2rl+/7znAUSWDDTbqystpGSHhiszp0E2nFaDYMvzQc8aPO53NqMLY1MIjzva0ZcCmAGXRdB6Zco5EeeII Nr48fNF7 FK4iotWi4zlyseCl0MeCzyUEuemwgpZWhV64YcUOzVC6ThbkBY+tQidL77YxB/ZBIcokvi+H+rDXv2W8Dyr/0gZ9IAK/vHym/kPDcYCfFyFvAFIe48nyK5JtE9dtWHnvyeOLeLGe8xjre1kWxxrlFsBgHupfmcchd8qXB3AUXcIfcmQE2BPIkp6Apf/S//rOjUAeamgfhcqRcCTxoacbCtRYc8y36a/JLKPm3ndJXwmQJGiQugx+5ySmMBgo3HfecoNntOrSmubmSGc2zgz6GDQ+HPcM0BrImwfY+bONuBFY4yAP74b1XgaQcMbgKrbpKOsFZLr0+KYGTvjHxgolE4iwpnnd34jBQ0T/kCLRnX2r3KoqEuPKeSi9uMBpexYrKebobh3cj3rZzEAACd1UhpAFVUSdvMrhBAWw+F+Jte4pepLqa/NNgLWgUtKwfPvx7O4PiRBmwOjaki21frVKcNxz2YUGfrMO6J891bQYA9aSpuioP2efFfY5VjLuJryMh9qGaekXD/0YGUqD7FbQkHPzRBHdxS4bcvcaRFb3rISF0w/j7fLAdSXZvRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> + bool >>> diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c >>> index 47a9f68f7b24..9ee162bf6bde 100644 >>> --- a/virt/kvm/guest_memfd.c >>> +++ b/virt/kvm/guest_memfd.c >>> @@ -307,7 +307,78 @@ static pgoff_t kvm_gmem_get_index(struct kvm_memory_slot *slot, gfn_t gfn) >>> return gfn - slot->base_gfn + slot->gmem.pgoff; >>> } >>> >>> +#ifdef CONFIG_KVM_GMEM_MAPPABLE >>> +static vm_fault_t kvm_gmem_fault(struct vm_fault *vmf) >>> +{ >>> + struct inode *inode = file_inode(vmf->vma->vm_file); >>> + struct folio *folio; >>> + vm_fault_t ret = VM_FAULT_LOCKED; >>> + >>> + filemap_invalidate_lock_shared(inode->i_mapping); >>> + >>> + folio = kvm_gmem_get_folio(inode, vmf->pgoff); >> >> >> Would the idea be later that kvm_gmem_get_folio() would fail on private >> memory, or do you envision other checks in this code here in the future? > > There would be other checks in the future, the idea is that they would > be the ones in: > https://lore.kernel.org/all/20250117163001.2326672-8-tabba@google.com/ > Thanks, so I wonder if this patch should just add necessary callback(s) as well, to make this patch look like it adds most of the infrastructure on the mmap level. kvm_gmem_is_shared() or sth like that, documenting that it must be called after kvm_gmem_get_folio() -- with a raised folio reference / folio lock. Alternatively, provide a kvm_gmem_get_shared_folio() that abstracts that operation. We could also for now ensure that we really only get small folios back, and even get rid of the clearing loop. The "WARN_ON_ONCE(folio_test_guestmem(folio)" would be added separately. In the context of this series, the callback would be a nop and always say "yes". -- Cheers, David / dhildenb