From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E73C001B0 for ; Wed, 28 Jun 2023 01:51:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEA798D0002; Tue, 27 Jun 2023 21:51:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9B248D0001; Tue, 27 Jun 2023 21:51:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8B3B8D0002; Tue, 27 Jun 2023 21:51:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CA1778D0001 for ; Tue, 27 Jun 2023 21:51:40 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9719380B07 for ; Wed, 28 Jun 2023 01:51:40 +0000 (UTC) X-FDA: 80950479960.09.9D3B3EF Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf21.hostedemail.com (Postfix) with ESMTP id 19F7C1C0006 for ; Wed, 28 Jun 2023 01:51:37 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687917098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ruM/V2RJrTlzhCyElrmtvOUwaRO9dEM+zRtr8mgeE/I=; b=Q/rXhZJLTIYfngx3JB3xBMzwIuMlKyII6wxFnHQAJnhmDrxJVrDA6OiUiy/ZI5NK/jOZUH NNqmuE595V5htFJAJG1Bs31NCqQPy1AZkfB4WLChJCmWkR+eHkk643VpEd5izQcsZVySYs 4w/WXlwqzkLVIjC8bfedLpOuOwRjz0s= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687917098; a=rsa-sha256; cv=none; b=GaOt4XhyDsHj4zPUCD7eZlmOI6z3wJ2RUK74qIliUy+2QEKYxqvKD9Yv0TgM7+KA56Aj9r JztwlqeUZkkiOI2PimkfBlbPslBgb0UJp35sleJEVJfCCcCKK+/rtr5uqDflbzXkMZLRQE +4xvdjm5qcdoLmVAqZoYMHBwa4omEuw= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QrPgp2HjGz1HCB4; Wed, 28 Jun 2023 09:51:18 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 28 Jun 2023 09:51:33 +0800 Subject: Re: [PATCH v2] mm: memory-failure: remove unneeded page state check in shake_page() To: , CC: , References: <20230628014604.3432146-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Wed, 28 Jun 2023 09:51:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230628014604.3432146-1-linmiaohe@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 19F7C1C0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7oy449ns583ih7hr9oarf4iiarorjjyn X-HE-Tag: 1687917097-136567 X-HE-Meta: U2FsdGVkX18tRlPoF3tIhxPij8H5IYBqDFpfz7OHqoGro0OOKzBF/KbaD1lxAJJJbxF8Dc+X0aBgPa5Lex57oWtjlaBA2ejvk3lH0x4o3FWuYwHHDEJi/tZ49ynREb1yooTMc1kxn25CdYAmzV6C/zWy3TTUsZDd7hK8k5DlETNX5Ozjin7SLjbBJ/kal/Cz9Z+3JeSCqwEj2Alk1SgNMEPSRjIE6VQsXwawMYNTKSG9a9Q6mEiemiVkfL/3cI7E+u0q6EitDm+SPUsOcecgnnzQqXAKDWevWICfacEu9jEnQRcegiYRCyaDivoVY0lw5/es86pBbDSQ2z8cQmjqAnV1NrrCPLLWh8Oxc2EgbbUJr73fEXaL4IqD3WY0hmb3lrNXgg7RYV6pl7SSVmyR8ZzfKH7dElYs0HNR+7xt4Ck90A4o71j1fP+aHThQEIyeFTnMI2MlhV+uzSpL1JqbWDW00phXwsV0cgkhXJcEiHMWlGwfKzJAh97uPHeYiD4r/rFRg240hZ/EQlRla5m6HWUHszHkLzpM9/5Y+gZxhVNe48BcA0WFwCGtTlQ6hPJ/1oq6/D/7HHgz6oYaBzRgrbpqK2CClf4Zd1IgjYLpgn6y1gnufQC40P2upIgT8OFg7Nu8vW/TyaUwaKfj6ZVX0TiPctYmPWIk8VIzI7gs7wAiUABaLCECGYEhOY/70vWO5cvwrVd4onoB9AdB6IJ1mBHB3FpXwlE/ogiWTDYKGSzWRi5p9nHvpCsTByvOqIwDo97Cr3QNSgS9Ks8zyorWQ7/F2fNtJAhu8aqb4oOFIuGeeeUCrxyh10cM6bSABOSlTSthDJyw41yAhOjYHYFj8JR3IybRXqOcbnNpZKE194FZQpI2PN7af4JyaTBdhwrWJMd/OKyf+KJxiRc9g+9/HTShVeyahViDqd+a1n+aRq0OB3c9m42I+VU6R5SBAIhCDNvIzN9zjbzcSBdMVA1 Nhcl3pVL TcxNe7mCKrg8gupE9Qdj3STOjUupp1WOOb2HBafWi3VcqVwYpctVTaqxR9cYW7QGm81Xut9SVYCIv0VCw7nGWwTYlVxMhl6ypDhuOCbexBU3nnRhy4TIEsBHRCFbl5tS+6yK8iLTofTrpfTRR4q3c9xbUUwqmFyLS9TYlg3i9eNv/EUyjn3+EmPI+8kv/C1UYhT2gN4cdQQJW/1M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/28 9:46, Miaohe Lin wrote: > Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches > are not shrunk now. This check can be added back when a lightweight range > based shrinker is available. > > Signed-off-by: Miaohe Lin Sorry for make noise. Acked-by tag is missing. Will re-post one. > --- > v2: > put TODO comment together with "if (PageSlab)" block per Naoya > collect Acked-by tag per Naoya > --- > mm/memory-failure.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 5b663eca1f29..66e7b3ceaf2d 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -372,17 +372,14 @@ void shake_page(struct page *p) > { > if (PageHuge(p)) > return; > - > - if (!PageSlab(p)) { > - lru_add_drain_all(); > - if (PageLRU(p) || is_free_buddy_page(p)) > - return; > - } > - > /* > * TODO: Could shrink slab caches here if a lightweight range-based > * shrinker will be available. > */ > + if (PageSlab(p)) > + return; > + > + lru_add_drain_all(); > } > EXPORT_SYMBOL_GPL(shake_page); > >